From: "Heng Luo" <heng.luo@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Luo, Heng" <heng.luo@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Chiu, Chasel" <chasel.chiu@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel] [Patch V3 2/2] UpXtreme: Enable Serial Terminal Feature
Date: Wed, 4 Nov 2020 07:36:13 +0000 [thread overview]
Message-ID: <MWHPR11MB1805CCE0680E5736B640A25893EF0@MWHPR11MB1805.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1644373093057A68.12282@groups.io>
Abandon Patch V3 because I missed gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable in other OpenBoardPkgPcd.dsc except UpXtreme's, it will fail to build other platfroms.
I will sent Patch V4.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo
> Sent: Wednesday, November 4, 2020 1:34 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [Patch V3 2/2] UpXtreme: Enable Serial Terminal
> Feature
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3014
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
> | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d
> sc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d
> sc
> index d797ae9d94..e161bf06f4 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d
> sc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d
> s
> +++ c
> @@ -127,6 +127,7 @@
> gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE
> gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE
> gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE+
> gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|TRUE !if
> gMinPlatformPkgTokenSpaceGuid.PcdBootStage >= 1
> gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit|TRUE--
> 2.24.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#66964): https://edk2.groups.io/g/devel/message/66964
> Mute This Topic: https://groups.io/mt/78023563/3906523
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [heng.luo@intel.com] -=-
> =-=-=-=-=
>
prev parent reply other threads:[~2020-11-04 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 5:33 [Patch V3 1/2] MinPlatformPkg: console redirect after the shell is loaded Heng Luo
2020-11-04 5:33 ` [Patch V3 2/2] UpXtreme: Enable Serial Terminal Feature Heng Luo
[not found] ` <1644373093057A68.12282@groups.io>
2020-11-04 7:36 ` Heng Luo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1805CCE0680E5736B640A25893EF0@MWHPR11MB1805.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox