From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.5156.1587695609854926046 for ; Thu, 23 Apr 2020 19:33:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=fJrmdsdf; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: heng.luo@intel.com) IronPort-SDR: GbCAgNhSmXA4/JlQy8fS1v3Ei5Ba9d0A2Hq/xPRJDDbZmBN+GjySKUgq78Y1QdjMhXARaGvNxl vv82P2gDZq0Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 19:33:28 -0700 IronPort-SDR: UmFeKZgAD9OEUsk6VwWlEIcuWOXty4dqqI3T8tmj8CfE7ymtMIZeUDrJiVfqsLEU1409EwuHjC LJeDN2ncqEHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208";a="274449314" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2020 19:33:28 -0700 Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 19:33:28 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX126.amr.corp.intel.com (10.22.240.126) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 19:33:28 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 19:33:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BeEyyxMha1od8D6v30pPSJYDz1Jz4YM28McanKpN2mFwKpcYnh/05tcTs1c+guYboaqrcpXyaJwnoWbiG9r7olFLUNs+VEdS9ApHCQ9WPlZBucxw2rMlTeKtiOHMNpPBWuV9530hoaPoccPh5PW8S44hSEr3tmI+Abjf3h6l07o0cQMjsHqUrpBdBfyWh3+7dXvojfDfGLDCOyFQCLkw+YgNMFZ38jfnVj8O+Prpmw2uDbPagiT/1aByC/z/XR3ZptjYSj+dmaBB2aNufpW9bUG3xU76Rmv/Iu0+L/eI2Ee09ka5BeOItGZ60W8tptqtUuEG458aBd28VQZ9ujcYew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gv+fmYYU3Z1uoRTo5W9MTTY5ILD0nbelAQG52OvptE=; b=MBYK66GPfp6xkPeYYMbwF+odxkUw6BNCcbPn2LkZKyJ78T1M97/W0Lu4DHHme2cK14uLo+7lHvlxJkmLaQlPYWx6Z3O9JoTQOcGF28w4A5oT1gsMUeelXBr/LtRFmbpntq7tS/ux3THJwUfjfHJ16RqS7SXyBgtlPFg619nmzvJy5NDe3UK9uG5hgUgWW+J58dkO0Ptd8zB7PBjzA6raqCfDiyY6EwhuX4bTNCn96muKykoUPI/DWW8pCjceiDfG8JUr+vfi8iPdTSkVveHUaOOLbGVNRAZZ5r+JLl0mRq5abCdA9QAdkBfus65myA33T1YSs9Jf3X+Ju+cbyFD78w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gv+fmYYU3Z1uoRTo5W9MTTY5ILD0nbelAQG52OvptE=; b=fJrmdsdfi8tfiiu2FOxZjfFsolEOWsIqddKQfrRV8XMPs1ixfJGlO9r003aWXx0rkmwWvaXaHwfC6/z2z1UKMUj2v1U/8NTr+x+JYbgyRgr66Z61yXLdtdNg4Q+zVcYKq0oXuy/wumfDop5UqIeNvEI39ziUcb58XqGzg/Ok9dQ= Received: from MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) by MWHPR11MB1374.namprd11.prod.outlook.com (2603:10b6:300:24::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Fri, 24 Apr 2020 02:33:26 +0000 Received: from MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::9cd5:39ad:6a4d:34d3]) by MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::9cd5:39ad:6a4d:34d3%12]) with mapi id 15.20.2921.033; Fri, 24 Apr 2020 02:33:26 +0000 From: "Heng Luo" To: "Dong, Eric" , "devel@edk2.groups.io" CC: Michael Kubacki , "Gao, Liming" , "Ni, Ray" Subject: Re: [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code Thread-Topic: [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code Thread-Index: AQHWGdKIgzwcdKHsbU25iizPVUYIcKiHdVbQ Date: Fri, 24 Apr 2020 02:33:25 +0000 Message-ID: References: <20200423084258.1100-1-heng.luo@intel.com> <20200423084258.1100-3-heng.luo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=heng.luo@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 698bba48-5621-465f-2f37-08d7e7f7ddf5 x-ms-traffictypediagnostic: MWHPR11MB1374: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1805.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(366004)(376002)(396003)(346002)(110136005)(26005)(54906003)(316002)(55016002)(53546011)(5660300002)(7696005)(6506007)(66556008)(966005)(81156014)(52536014)(8936002)(76116006)(66946007)(2906002)(71200400001)(66476007)(8676002)(4326008)(9686003)(186003)(478600001)(66446008)(33656002)(107886003)(64756008)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8n5oikf85PM8VC1SGyKfGKgIc+doNHBs8DDENcLudUStHuwfPomJp/69/Eaa8Ee6S/I6AVF31xqWa00J5DoTCfYYFMqIrhK6+aEWlwtsVWUA15bmjgGAZ5aWVgIc+4MxQjZk9hWU0jm3h1Ol7Ger4v4MX4itcPkxJ9P6iMDPkTrVPRdgXnJVwvXqO1VoeoX+Blaued0VcXTUcTwO2858RBZMmriH6RfCwIoNijWW2qG1VOJLhSEaRyutdqEfhsvA5kls76UkZqkhk2TSQqVQkcj4Mn48rpQHNn22G6+lkwgkHQn+zB9KWS9L/oSYzszVZCMfByXqJsUPOXKimcB+AH26Zctc08VREv3TF84XM8QW9O2o+XRFRy0Vxc/uPmk/DNCknI80RG+6L1P2t7ZvGVgT/eJe4dZaBAXa1eGA5khYVqgb6FMUWyO2FcgUAC5L4piIUzUvz/7GDkqgvhoadpIxd3Sp4xMZ4pbnI8qAYTSsW/Sa8XmeftTkmjm9OOHHIWIXWaOYuIhiWgfaU6KTrA== x-ms-exchange-antispam-messagedata: 3ZifU/zG1jhgwMv+DSHUW316klMCGypQHHOTeP66Nocpziobp/V40pmXU/nhFviqFzKNVAK4IKQOb62ru9U0hL1LyQr/1dWeyvPPfRVxyHW0nFEWu8BYDg0MeJfDWF3XxETqS+cDxUxdTLxyLysl/A== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 698bba48-5621-465f-2f37-08d7e7f7ddf5 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 02:33:25.8388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dvNooP3BK+K5UujyGBflaFWIg9c3d3XATr57rfCcL1r8Wp5zCgddWAyuEYTqAxxN38IGfH7asM1M5Jrli5XscA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1374 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Eric,=20 OK, I will combine them into one patch. Thanks, Heng > -----Original Message----- > From: Dong, Eric > Sent: Friday, April 24, 2020 8:52 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Michael Kubacki ; Gao, Liming > ; Ni, Ray > Subject: RE: [PATCH 2/2] Platform/Intel: Cleanup temporary build > workaround related code >=20 > Hi Heng, >=20 > You can't separate these two patches like this. Because in this case, the= first > patch will cause all platforms which use > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > und.dsc file build error. > Please reorg the patches to make all patches can pass build for all platf= orms. >=20 > Thanks, > Eric > > -----Original Message----- > > From: Luo, Heng > > Sent: Thursday, April 23, 2020 4:43 PM > > To: devel@edk2.groups.io > > Cc: Michael Kubacki ; Gao, Liming > > ; Dong, Eric ; Ni, Ray > > > > Subject: [PATCH 2/2] Platform/Intel: Cleanup temporary build > > workaround related code > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2688 > > > > Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > > und.dsc > > > > Cc: Michael Kubacki > > Cc: Liming Gao > > Cc: Eric Dong > > Cc: Ray Ni > > Signed-off-by: Heng Luo > > --- > > > > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d > > sc | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > > | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > > | 2 +- > > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > > | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > > | 2 +- > > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > > g.dsc | 2 +- > > 6 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git > > > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > > .dsc > > > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > > .dsc > > index 14e82ba34d..8e04ca8a4f 100644 > > --- > > > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > > .dsc > > +++ > > > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg > > .ds > > +++ c > > @@ -39,7 +39,7 @@ > > # # Include PCD configuration for this board. #- !include > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > > und.dsc+ !include > > AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc !include > > OpenBoardPkgPcd.dsc !include > > AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git > > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > > index bf63d53bef..7bb8cd5279 100644 > > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > > +++ > > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > > @@ -38,7 +38,7 @@ > > # # Include PCD configuration for this board. #- !include > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > > und.dsc+ !include > > AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc !include > > OpenBoardPkgPcd.dsc !include > > AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git > > > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > > > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > > index 044688ba4e..ef82f8b716 100644 > > --- > > > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > > +++ > > > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > > @@ -37,7 +37,7 @@ > > # # Include PCD configuration for this board. #- !include > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > > und.dsc+ !include > > AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc !include > > OpenBoardPkgPcd.dsc !include > > AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git > > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > > index 350a75a313..3bafc1ff0a 100644 > > --- > > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > > +++ > > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > > @@ -42,7 +42,7 @@ > > DEFINE NETWORK_ISCSI_ENABLE =3D FALSE DEFINE > > NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE - !include > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > > und.dsc+ !include > > AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc !include > > $(PROJECT)/OpenBoardPkgPcd.dsc !include > > AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > > index 2ab9cb03ea..07cf311210 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > > @@ -39,7 +39,7 @@ > > # # Include PCD configuration for this board. #- !include > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > > und.dsc+ !include > > AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc !include > > OpenBoardPkgPcd.dsc !include > > AdvancedFeaturePkg/Include/AdvancedFeatures.dsc diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > > Pkg.dsc > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > > Pkg.dsc > > index 1a9e608bd6..1dace5ee22 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > > Pkg.dsc > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > > Pk > > +++ g.dsc > > @@ -39,7 +39,7 @@ > > # # Include PCD configuration for this board. #- !include > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > > und.dsc+ !include > > AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc !include > > OpenBoardPkgPcd.dsc !include > > AdvancedFeaturePkg/Include/AdvancedFeatures.dsc -- > > 2.24.0.windows.2 >=20