From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.5002.1612427095141446107 for ; Thu, 04 Feb 2021 00:24:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=aKUQtWyJ; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: heng.luo@intel.com) IronPort-SDR: WA8nDq/7MyHmM9sXBigo1oLvQOzZTB8izgG6m9YFckdxkADdK7MCbZLLNzPqEzHmk42UDQGvqq yP/ruwjdQu8g== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="177690378" X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="177690378" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 00:24:54 -0800 IronPort-SDR: +sYLiAnEhf3vKkwWHvnsSfbkwEMJTmlUxsmV8kGG9yZ37W2gdgRybqv/HvwAlKF7R9jsEpIl7S jfrzy5S/95Hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,400,1602572400"; d="scan'208";a="576212385" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 04 Feb 2021 00:24:54 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Feb 2021 00:24:52 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Feb 2021 00:24:52 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 4 Feb 2021 00:24:52 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 4 Feb 2021 00:24:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PHuzwKb4+7xwscMBEcZC1J3bt+xVyjgWrEnoafmt/ku/CROj+oVwngOz5htCtWZoSc/2ArLkPP324bUMuhiCCVrFJEUDK2ESgytG92kgfJPX0Qx4g56P8tN/1dDEm6a9Mudud0zSiy4TfIswGu10zGuyjJjMa791v2Ibl3V3ao+jDORzEhWmFYcJdAoECi380YGe7CKrwQTy1SdfXfrCOatxRgQ6aaiz2iIzdDYpwR7jXY3ILU8awkWoussC/gALvLD7lGdDxMQkk4iJnuhgYDuqZVOmqwg7ShHZ/xc49J1v49dqjHAfZvvQFVWoERa7dy83on229y8E7axPn0EO6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aCvtlFpjOH11TXKGbGnsx2egfgYrUNTpEgkn8p6PAYA=; b=YZ1L1SQga7mp9mD4PMSaaFv6WQ2iQ7/r4kWzwBHn1d6NdUqvACsdtdZibGS2w+EdaPy3AM9SyFu4nGl0pCXlrrtGLL5e6fyN+teWGGb2t7LrxVMXNeWvrPN6Co2+vOMFzo7JGXWzOomj1q5Dnf6GR++pwJqKnmpccfbho2m6Zu8esSSA2Lr6tcrHjFompYKgLvBrvwLWMZsjBdYU1GngPnxgvx/5OoytPAaqsv1M5hchDb5YbUmAlaecxlL9cL5AUNTRH3q6yGwcNjBLFlGfugIUGvPxHKXBdIfXg8d0OuJ9vGg9+PUsYrIH70ii40B/b2D5emtAXt5TGoTRu6CQMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aCvtlFpjOH11TXKGbGnsx2egfgYrUNTpEgkn8p6PAYA=; b=aKUQtWyJ2zguP1vkX11s3ZkJHhDkHagPsSJ93NMJmkhEuFY06ajjo0hCvX96kU85G5gR1PYgbEvejU/oBY/9USIht7+SkE4zOROLOw2pEes7cjvw2ump4D2GzMK6L5U6pk043UNpOMJNlep5O8IcRlohlXFKa6ydmUL1Cng0jvo= Received: from MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) by CO1PR11MB5028.namprd11.prod.outlook.com (2603:10b6:303:9a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11; Thu, 4 Feb 2021 08:24:50 +0000 Received: from MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::c4cd:d1da:d205:3720]) by MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::c4cd:d1da:d205:3720%7]) with mapi id 15.20.3805.028; Thu, 4 Feb 2021 08:24:50 +0000 From: "Heng Luo" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers Thread-Topic: [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers Thread-Index: AQHW+Drw7kiE8O/OSk+31K6gjjhY4apHXaoggAAx5CA= Date: Thu, 4 Feb 2021 08:24:50 +0000 Message-ID: References: <20210201013657.1833-1-heng.luo@intel.com> <20210201013657.1833-40-heng.luo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 65ee7a1f-4eb6-41f8-efc4-08d8c8e65746 x-ms-traffictypediagnostic: CO1PR11MB5028: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h9ou/JyoeVyx5lc/plGbKWAQDAxdZdDlAe/vMiRD6xEEUAK0Ngvt42MNP/g701WmDNpM4dLv5CwLsPVwn6W0FW3PChw3phrC7eMF0QlqkA+JPxnpquJlwNSvGp0lB4qDfWYzmPq227fee8A2sj2XEIFxNGSAzEn+1V1FnaWERzgGmO4SYchrdIX9pFl7Jqk1Tb5TuL4iOxw6HNE8GkJLWo4ydpWEv9GsoPi1OlwO+8iEMhthw5OBbL8ppnG4XF0Nnp3FGd/WB3dHoOuEZEiSzcGAdTsNVwH0ZxQw8GuyAug5V44mUtyQe6Kb6en1SPjmN2ieWZsAyjFukPhOImN6x/JH4Kvsuxj67+JfqOjJFmG0CCTWOUsgRmf/VS1XPMLB6w3ILK3j5vUpbvlyXeRDU1HZVuos/pB2+aHsGzurj1CgSPGXCF0ZoTkNrXMXzuvxce51erUcO8ZTS6qgIcuj1i0BWwiURLlDPlUxV3PFqEP8Pxk/Bo39XG+xYiCgppyjYKjOYk14a7NWHrdaOFEJsvaxOIgOT5LtBpr6FXD9WV+DJXS/G/636JJkxG4E2PvDbdH1NQ78nJYQko7IZj6lvrcPgV8Z1fS17SdsgmJ8dXs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1805.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39860400002)(396003)(376002)(366004)(107886003)(64756008)(19627235002)(110136005)(52536014)(55016002)(83380400001)(478600001)(9686003)(5660300002)(8676002)(66946007)(966005)(53546011)(66556008)(7696005)(4326008)(76116006)(6506007)(26005)(186003)(71200400001)(33656002)(316002)(66446008)(86362001)(8936002)(2906002)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ua4F23uCzytWBeLemPiPT8JFQAY6bGOFvLzbbaOcrmqFi5jIhiOvBdFEjpdo?= =?us-ascii?Q?PtDB+XLq9sa5sjpV9JFMvmbQqSPfuSnBQhZ31zG9we29Fne6eCQGyU0FBgOs?= =?us-ascii?Q?by3N/qsvgUaLs/SUiVutEayRyaeKgB4M5uLqh5cYS8lxuulbcH2yGDvlVHn8?= =?us-ascii?Q?dXszGmlqR6+GbjO2gkzzpYFvg3vo4O13XEBndkBZt5wCYdw+8U+3T60tdJEM?= =?us-ascii?Q?b0aETjRsDikBFMh3k8l04GTyMsQ/UBHAJEohVQVwZcJq31iirVHuTDl/sXRE?= =?us-ascii?Q?MryqkAbnIhQTQ9vpJ7zGFHh/hMH0wafKTeMJLl6f9r9G7t9qRpK27Ju+JpQy?= =?us-ascii?Q?UrdYMekUprcfyfF7gfESuxPqXKqkt0njVNaLw2jMRfVGeelGIuO/nBU0m8LC?= =?us-ascii?Q?qpYjUU+K2ZVGPH0LTGjGWJHI4nChlUTJNjc8u1ll1EgvV/KhAE+dGfOz5Dc4?= =?us-ascii?Q?7QT6Ry9CBpHVnVt+uUnZxO0tzm4TokX3Kg2bMqXxhEeylq86PHzzOE7vhmP1?= =?us-ascii?Q?VAjzQmCfS3G7Zfs7C2XM/prHIGqyFRXhV7WQC5bnIqLA11r+S+3hvsphnk7y?= =?us-ascii?Q?bhiqF2K8rG4qvJX6uTLCk4U+QRPZk0Woj9yxfKzQME4zhsjN7Osv2bknsRwQ?= =?us-ascii?Q?ckXXbOa7vuk+f9i/PjFRCm4Q46buiyRhoBH8WGPuBDwnDmKMG6tbB+/NVwVC?= =?us-ascii?Q?SClbcY5miOn4rRiWPlRNXa/M8cPLAxZynQgDQmcoLM7mrlOvEiB57RiGwWui?= =?us-ascii?Q?hT7GEkwHN5vR90LXRlcFLAXtvsWb43M7N338FbRzOsF5a7JWwEO1Ygm2VU8L?= =?us-ascii?Q?jp4c67ABrrIrdDQA7+OmBbmXFrRRYBuuMdxf4y9taL+A/zn/yjh5sq5PUqYD?= =?us-ascii?Q?iO8ZfDOHaujrkvdV8pEZA34RAyn7beVAm9lbu+njHUEW0bSB9XhDCl+ZLcCE?= =?us-ascii?Q?u5bi4iuw/kN9AlJnFC42+uu2gaqqR1cIKFlb7aOuCbvnL5DSn+MCUnMaslds?= =?us-ascii?Q?HiPCcediD9TDam8rdNsafhcGBI2g6f4lgcv+XsLhvfLYB2vJCNXkuxno16Br?= =?us-ascii?Q?z/1Wme69?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1805.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65ee7a1f-4eb6-41f8-efc4-08d8c8e65746 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 08:24:50.3885 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gr1jDYuihghCS8GML6ihYG+lwUaDh68fR9hsgRIZkJ9Ms3QDfYKWYjCl/fYH9fo+XYYw9NYnn8e6z0mqdUVnbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5028 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank Nate, I will send out Patch V2 following you comments. > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, February 4, 2021 11:51 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maint= ainers >=20 > Hi Heng, >=20 > Thank you so much for all your work on this! I have a couple of minor com= ments, > however due to the size of this patch series I produced a summary of thes= e > comments here for your convenience: >=20 > [PATCH 01/40] >=20 > #1) CpuPcieConfigGen3.h is only used on Rocket Lake boards for backwards > socket compatibility with Comet Lake. It is not needed for Tiger Lake. Pl= ease > remove it. > #2) CpuPcieConfig.h - CPU_PCIE_CONFIG Is missing the following from its > definition: >=20 > CPU_PCIE_ROOT_PORT_CONFIG2 > RootPort2[CPU_PCIE_MAX_ROOT_PORTS]; > PCIE_COMMON_CONFIG2 PcieCommonConfig2; >=20 > [PATCH 02/40] >=20 > #1) FspmArchConfigPpi.h is a duplicate of a header file in IntelFsp2Pkg, = please > remove this duplicate > #2) SiPolicy.h - Please also remove the #include for CpuPcieConfigGen3.h >=20 > [PATCH 34/40] >=20 > #1) DxeSaPolicyLib.c - There is an old comment that is no longer relevant= , please > delete. > #2) DxeSaPolicyLibrary.h - Please also remove the #include for > CpuPcieConfigGen3.h >=20 > [PATCH 35/40] >=20 > #1) DxeVtdInitFruLib.c - Comment on line 2 has a typo "Flu" should be "FR= U" >=20 > [PATCH 36/40] >=20 > #1) PchSmiHelper.h - Comment on line 2 has a typo: "eSPI SMI Dispatch hea= der" > should be "PCH SMI Helper Header" >=20 > [PATCH 39/40] >=20 > #1) SiPkgCommonLib.dsc - The DEFINE PCH =3D Cnl is unused, please delete= it. >=20 > Thanks, > Nate >=20 > > -----Original Message----- > > From: Luo, Heng > > Sent: Sunday, January 31, 2021 5:37 PM > > To: devel@edk2.groups.io > > Cc: Chaganty, Rangasai V ; Desimone, > > Nathaniel L > > Subject: [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg > > maintainers > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3171 > > > > Cc: Sai Chaganty > > Cc: Nate DeSimone > > Signed-off-by: Heng Luo > > --- > > Maintainers.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > 56e16fc48c..34f0b58581 > > 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -242,6 +242,12 @@ F: Silicon/Intel/KabylakeSiliconPkg/ > > M: Chasel Chiu M: Sai Chaganty > > +Silicon/Intel/TigerlakeSiliconPkg+F: > > Silicon/Intel/TigerlakeSiliconPkg/+M: Sai Chaganty > > +M: Nate DeSimone > > +R: Heng Luo + > > Silicon/Intel/SimicsX58SktPkg F: Silicon/Intel/SimicsX58SktPkg/ M: > > Agyeman Prince -- > > 2.24.0.windows.2