From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02olkn0818.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe46::818]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E04A21A04812 for ; Tue, 4 Apr 2017 20:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9z7okZnhluSz2jxzTWcuFuSL5tLqqvnxudNv5t9CyqE=; b=EreDl14BbZhn5gc04AuV2Slh8fjDdbLD1kEJ/IPVChfdmadf9sWALgvJPiPyRPKLwJGiLyUiDtRQy9VaO3NFBg+udadLyuBY5c3U0k4sP+F9tarbyC4fM5vsjof7zJ+vV8yVXLcE8iTUCbBGhUqeR9r3f3jiD2S+gb0CwWw0cm9REpBbhFmRPkHZxaYWtAFzuvjddK6n2rwOn2EdeD/ogiAjJYDNm0+2Z/+FBavYp9y16yFgFaG10xMLD0R3dRuZt4F0EQ+GiVaREugQt8nPOgG0LTQG/PjkdqhtCp778l6EWdJyFAkoq2wO0+NWMxuKQ+XaK73opYdJ+ATNosjRSw== Received: from BL2NAM02FT052.eop-nam02.prod.protection.outlook.com (10.152.76.51) by BL2NAM02HT049.eop-nam02.prod.protection.outlook.com (10.152.76.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.7; Wed, 5 Apr 2017 03:38:00 +0000 Received: from MWHPR11MB1822.namprd11.prod.outlook.com (10.152.76.58) by BL2NAM02FT052.mail.protection.outlook.com (10.152.77.0) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.5 via Frontend Transport; Wed, 5 Apr 2017 03:38:00 +0000 Received: from MWHPR11MB1822.namprd11.prod.outlook.com ([10.175.53.137]) by MWHPR11MB1822.namprd11.prod.outlook.com ([10.175.53.137]) with mapi id 15.01.1019.014; Wed, 5 Apr 2017 03:38:00 +0000 From: Amit kumar To: "Tian, Feng" , Andrew Fish CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] DisconnectController API not working. Thread-Index: AQHSrJRPrCuINgQvWkWq33X7efokpKG2FewAgAAMrcI= Date: Wed, 5 Apr 2017 03:38:00 +0000 Message-ID: References: <37439A6C-0D5F-45E8-B634-1841B73268CE@apple.com> , <7F1BAD85ADEA444D97065A60D2E97EE5699DD64D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <7F1BAD85ADEA444D97065A60D2E97EE5699DD64D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hotmail.com; x-incomingtopheadermarker: OriginalChecksum:1CC12622AC8F6ABB4835E395020AE5CD623A56756D40D867EEBDEB71EF1F7BAE; UpperCasedChecksum:EE7267BBA4350DDB48A78E7D686F6EAF3C0C7054CAD5CFF728D90323C5C7B59E; SizeAsReceived:8395; Count:43 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [zstPo8ciKVI35ey/QFjV+PO9F3h1CBA0] x-microsoft-exchange-diagnostics: 1; BL2NAM02HT049; 5:sPz0Hj3jX2TkZ/yMh2YpwV22uYpREymQGF6A4FV9tZiRdZJYTDIFdtcZB96f3YRd+PbEAhlj+TyMZBCNNn1DDkJVjM+nPSIuscKDsQ0xqIWTE1aNC0TGH+JbYXEfaMi+RGRSC3DGAtctIOT1viQsTQ==; 24:hiJ0pKZcpgcPmOXzJeo7uPKUrBSE/H5Y57D2QNOlM2ljyOKpIXG1l184xf8GdlYbMVo9qMIMkAvjHqBYmg5T32U+faM453pioGhLnARFqZw=; 7:pFfiRCiWuMc7HeE+tmuiJoW8Eb0oOYTwb4sSNqXSZUa+n2IqayM3Ro9x7ZeZS6i3KhuMkulB0W5/dH2jl7LEGQysksDT6DVRiqdGoTzlekxoNXgkN0F3yXhLFDPzMpxustfE7d9gjOh9Adf3dArlFP78/leyeCznGyjps5a1i6cw4+1KKklD3y44zcqvfWJtwHuYeCFweC+gLcQgDOlgwxYemkaNeFu1r9xXIk4MSQIHNAntXAzpsMrU6PBxA6auiwV6OdcgZV9C+h/bYfI3nbSGs+sFqdYzOtmVFeFtJDd0uHwg0fW5KylnHgIlFW6C x-incomingheadercount: 43 x-eopattributedmessage: 0 x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:BL2NAM02HT049; H:MWHPR11MB1822.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: abfc2cd0-fb5c-4687-8e5c-08d47bd52854 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031322274)(1603101448)(1601125374)(1701031045); SRVR:BL2NAM02HT049; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:BL2NAM02HT049; BCL:0; PCL:0; RULEID:; SRVR:BL2NAM02HT049; x-forefront-prvs: 0268246AE7 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2017 03:38:00.0252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT049 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: DisconnectController API not working. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 03:38:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable No i am not trying to disconnect USB controller in use. ________________________________ From: Tian, Feng Sent: Wednesday, April 5, 2017 8:21:36 AM To: Andrew Fish; Amit kumar Cc: edk2-devel@lists.01.org; Tian, Feng Subject: RE: [edk2] DisconnectController API not working. Kumar, Do "map -r" at first please. PS: for the issue you encounter, are you trying to disconnect the usb contr= oller in use? Please note at this time you are reading the file from usb ke= y. It means the disconnect will never succeed. Thanks Feng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Andr= ew Fish Sent: Tuesday, April 4, 2017 12:07 AM To: Amit kumar Cc: edk2-devel@lists.01.org Subject: Re: [edk2] DisconnectController API not working. > On Apr 3, 2017, at 2:58 AM, Amit kumar wrote: > > Hi Andrew , > > I did some testing and found out, same code works fine on Server boards b= ut it fails on desktop boards. > Servers tend to connect less things as it can take a long time. > I Have double checked the ControllerHandle by printing its handle index u= sing ConvertHandleToHandleIndex(ControllerHandle), the ControllerHandle lo= oks correct. > > > I have one new query; > > i have made a startup.nsh file in which i am issuing load driver.efi , i = am getting file not found. > > i have also tried using load fs0:driver.efi, and again i get file not fo= und. I have been trying to run this script from internal shell as well as = usb shell. > Does that command work if you boot the shell? Thanks, Andrew Fish > > Regards > > Amit Kumar > > ________________________________ > From: afish@apple.com on behalf of Andrew Fish > > Sent: Friday, March 31, 2017 10:42:08 PM > To: Amit kumar > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] DisconnectController API not working. > > > On Mar 31, 2017, at 5:26 AM, Amit kumar > wrote: > > > Hi , > > I am trying to disconnect a controller from the usb mass storage > driver, for which i am using > > Status =3D gBS->DisconnectController ( > ControllerHandle, > NULL, > NULL > ); > > after the call i get Status =3D SUCCESS , but when i run drivers command = in shell, i find it still being manged by the same old driver handle. > Although when i run disconnect command from shell (e.g disconnect 163 > ...output disconnect(163,0,0):Status =3D SUCCESS) it works as expected an= d detaches the controller from the driver. > Can some body point me out what could be the reason. > > Amit, > > It is always good to double check you are using the right ControllerHandl= e. > > Sequence of events matters. There are boot flows and Shell commands that = do ConnectController. > ~/work/src/edk2/ShellPkg(master)>git grep ConnectController > Library/UefiShellDebug1CommandsLib/LoadPciRom.c:402: gBS->ConnectContr= oller (HandleBuffer[Index], NULL, NULL, TRUE); > Library/UefiShellDriver1CommandsLib/Connect.c:54: Status =3D gBS->= ConnectController (Handle, NULL, RemainingDevicePath, FALSE); > Library/UefiShellDriver1CommandsLib/Connect.c:95: gBS->ConnectControll= er (RootBridgeHandleBuffer[RootBridgeIndex], NULL, NULL, FALSE); > Library/UefiShellDriver1CommandsLib/Connect.c:116:ConnectControllers ( > Library/UefiShellDriver1CommandsLib/Connect.c:150: // This is where we c= all the gBS->ConnectController function. > Library/UefiShellDriver1CommandsLib/Connect.c:158: Status =3D gBS->C= onnectController(*HandleWalker, DriverHandleList, NULL, Recursive); > Library/UefiShellDriver1CommandsLib/Connect.c:167: Status =3D gBS->Con= nectController(ControllerHandle, DriverHandleList, NULL, Recursive); > Library/UefiShellDriver1CommandsLib/Connect.c:298: Status = =3D gBS->ConnectController ( > Library/UefiShellDriver1CommandsLib/Connect.c:354:ConvertAndConnectCon > trollers ( > Library/UefiShellDriver1CommandsLib/Connect.c:391: return (ConnectContro= llers(Handle1, Handle2, Recursive, Output, (BOOLEAN)(Handle2 !=3D NULL && H= andle1 !=3D NULL))); > Library/UefiShellDriver1CommandsLib/Connect.c:536: Status =3D Co= nvertAndConnectControllers(Handle1, Handle2, ShellCommandLineGetFlag(Packag= e, L"-r"), (BOOLEAN)(Count!=3D0)); > Library/UefiShellDriver1CommandsLib/DrvCfg.c:492: EFI_HANDLE ConnectCon= trollerContextOverride[2]; > Library/UefiShellDriver1CommandsLib/DrvCfg.c:514: ConnectControllerCon= textOverride[0] =3D DriverImageHandle; > Library/UefiShellDriver1CommandsLib/DrvCfg.c:515: ConnectControllerCon= textOverride[1] =3D NULL; > Library/UefiShellDriver1CommandsLib/DrvCfg.c:516: gBS->ConnectControll= er (ControllerHandle, ConnectControllerContextOverride, NULL, TRUE); > Library/UefiShellLevel2CommandsLib/Load.c:52: Status =3D gBS->ConnectC= ontroller (HandleBuffer[Index], NULL, NULL, TRUE); > > > Thanks, > > Andrew Fish > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel