From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.2198.1588211238452585834 for ; Wed, 29 Apr 2020 18:47:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=aseiFjK7; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: xJ95uMk+naucl0TEarPRVW73w3+aBO371Pikt9ytM/PUglClNxnCw29L1bZN/zjVoHiok9yTOF LNECpBEq+Xsw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 18:47:17 -0700 IronPort-SDR: v94TsJrF5p9CAecHb7nGxrwNtNk6Ddc2uGyAozVNd8+VkDXRIe0GhzlEtU43nSVPx6vqoGDnD3 z5XZ0u4IxfqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="459769098" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga006.fm.intel.com with ESMTP; 29 Apr 2020 18:47:16 -0700 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:47:16 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX159.amr.corp.intel.com (10.22.240.24) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:47:16 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:47:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FBlnF/CG45+iVzDAhjqvg1oqYW3raj6wOwa3Jh8CZQ71pNFXdVCoymsMyUadRloRS8lz1GVLOT3cPoPx4z3Xdg04TWhQY97bgWGCLBzp477JpAAUQVZRJ1cr7+kKNKH3XnqO/nk5IlitH3ZWONSqoqPrq45PXIfSx6WJsPvqR+3m9vJVbNAoNMItHemiO/+ilBxAOntk71hDFb9/pF+ps02b8ZwoVKVhAoaouIwZi2+16xscDR428tljenYRaCOI2b2fbfLevFCFkY/GZx/BusA8ATDLsb70vtiaEHQyKo/+3dDX6VdYGY1D12BtPpEsiH3bs+4NCrtOztlHW3yovQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n4P0E9M2DASlaMlqRCEv5jvKGMi9Fe9iwDtcppBIyGs=; b=DjzWJazZcKRoCkeom63MDOSWyd6hG1NB3qWlcsJCuE0yk2lEicCglv9HInjUsD7kiTlFlnX6MWlbK72v3TsiTQGbq6sVdZDl8m7CHMxm8pbN4wlU9Tt45YU/gmD07qXaP7iZ4TyVBCxUc/rl3qtG2B+m6vgNAzCXd+ScQWHutbHXWBsyHf2sQV9bvYJPrgc/0+qDzYxkBhnjtxtkLVB41IQCumZKD5u2STH60A8x1RIeGUuBCdOZK95Kh2E9TGpdy56QIg+nw1id3tF6KqBtGUbGttSB0URmBxc67auDwF9PRYmmeUl9cHdjdLn9+/04VE2l4EPHV0fnWZqrM0yi1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n4P0E9M2DASlaMlqRCEv5jvKGMi9Fe9iwDtcppBIyGs=; b=aseiFjK7NU5MIadNhjZQvJYvIMrSLvE42pE4GYgUt5fNsA2LFXRYiJ5KVI/G+BWooTFXXYjUnnrgPn5x4KfeuaAG1CHI1nvb6sVASC1u2irGxN270tvPrQNElItcK1mmhef6oOtUgl2xB9C82S2hEehv0IK7dJCMNb4IZp3oA8U= Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR11MB0029.namprd11.prod.outlook.com (2603:10b6:301:67::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 01:47:14 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710%9]) with mapi id 15.20.2937.026; Thu, 30 Apr 2020 01:47:14 +0000 From: "Chaganty, Rangasai V" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWHc57eKa9G3pfiEataSIwzo3wraiQ5tTQ Date: Thu, 30 Apr 2020 01:47:14 +0000 Message-ID: References: <20200429023203.37544-1-miki.shindo@intel.com> <20200429023203.37544-3-miki.shindo@intel.com> In-Reply-To: <20200429023203.37544-3-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.222] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c9a5ede-9f8e-45bf-e469-08d7eca86842 x-ms-traffictypediagnostic: MWHPR11MB0029: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:161; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(39860400002)(396003)(346002)(376002)(6506007)(52536014)(478600001)(110136005)(53546011)(8936002)(54906003)(5660300002)(26005)(8676002)(7696005)(186003)(66946007)(33656002)(66556008)(76116006)(66446008)(66476007)(86362001)(316002)(4326008)(64756008)(107886003)(2906002)(9686003)(55016002)(966005)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wiFzQOshfMegXzJUcPsmpAD17n75xAaxoJOQnKkN2NALfYRpyqWRU0Ga37TzA7LVH9hmfMovDb71MFzpmFtt9SM8WRht4ig+37PUdu7rPJhSUfyJJZ5I56FRlQdz744kLtiWiCSw9qOwzsLGWZyL+ivBwADs6fniFiMbg7lnUVhr8QU0Qx0oa+mmm2N24egj+Q34RlhXzIm9FpgFSqo3upE4waUZQpZWVvOYp+PJD1NorEQfEylVetCPKl0GOB+ZXOGNzJDUgczpZMXCKDajW+7d7vBp8iMNMX4tZxnY2bXuNismTz/fWptWqvDlS+kta5OVBaRY2ZkDmcIOzpcoCZ1Wa+wmt093vNXhkS9lLzjsYk42EYW8YTOCnSzFnIzvreRLaHegw7gDnETBJYsd04wsJ/GhBdK8amftKBzy4RQKzA+vwOVz0C9u/mWqfCxOHra8ONpXKqb2H1GL8JpTp9L5MO+rMxbGpy9XEui+9Wm2ocRkY+K/AM7ML5j3Wr/uYX3K4J8fS1e6dRgGMGXHxQ== x-ms-exchange-antispam-messagedata: ZwUVfw/V/YAw+3fqtEmfjjtECzzwRP47gnbtcwrw9Sk6VxziqRmkNzruunLMtuBIntrESyl9JiuEF1ZVUKK6icYqMUqkFrtON/R/yEadqwwYWo+s6jz82SZY+NLCSVLiN+BbzeBw8cuYjkOKRXkrSYZudwQdqriK9v/brcOVi7XxCezjAvlcXokDjvv6wPDwwgiflQKdc8S0whVc3lLlhBx3+2SADzhQe8io5RvkSmP4rFpwPzi9tTWsRSFevsi5dUCW5L95uxNG/Qjs+p249lQrTKuFFKT0U1T8qCWoX1HMQGnaJkxpZQp4e7D8vNMAWNeEzDnF3pwGw2FQvQju+z8baRl7xcTck9mTc1jH1a3CZtfI8fhpw0ZADLdy4onSbEgbYotkNzTsxApbGi/4PBGvNe04rJm2w4nPvY/m4XiMJ0vo9beOZD5aPCXWRIoasg4o5YE42wljWYOBZJnEdiC9+Rp5a5l5Y9Hp2YEavmgN/d9qVdXeRjNiF1sCZb28FdgcqOpq3WPi1ZUQ9ajLSMld4DNszy+XJLSmr4b1dQVl8Kp4k9dzq5VPIiJNYsWzYwvvYoeLXXzqiCXPKmR7Jd8iundgtJ1Lqa6BYea7CwJvv7I4sYhD8mY8habxWfLf4IzL9BHvhCNcAtBxOR1SNQCVKIkIThkwZ6c4p8zL2nhMnsicNOi9/lwiisiytYW+3G0eQUwZiGYwt9LUF1B+LwKx93zMHB6fM4wE/JMgKrS27mGlaqkpf7eWxpRhmmRalJJarzz7scWqIDaABiwD9qpVGSaTJKYUSxSEmViMPFg= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9a5ede-9f8e-45bf-e469-08d7eca86842 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 01:47:14.3010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g7wNYZnXgUjFXUG5MxI+mg/pLosp8TqgD7I24uyVIiaOwFd5Bsy+V88IqMzHxWzunFFkNN/KXhx8Zu0p6OzAggfJUTCI2Zqspo8lCHLmch4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0029 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Shindo, Miki =20 Sent: Tuesday, April 28, 2020 7:32 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L = ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes= redundant InitializeAslUpdateLib REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 This commit removes redundant InitializeAslUpdateLib call as DxeAslUpdateLi= b itself calls it internally. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman Cc: Ray Ni --- Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 5 = +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/T= btDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtD= xe.c index 13a687576c..d101f4bb75 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDx +++ e.c @@ -1,6 +1,6 @@ /** @file =20 -Copyright (c) 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( UINT16 Length; UINT32 Signature; =20 - Status =3D InitializeAslUpdateLib (); - ASSERT_EFI_ERROR (Status); - Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; Length =3D (UINT16) sizeof (TBT_NVS_AREA); DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x Length= %x\n", Address, Length)); -- 2.16.2.windows.1