From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.2154.1588211599867533158 for ; Wed, 29 Apr 2020 18:53:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=c3kTuBAE; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: +DNVDQ66h9kyCCSPCFoQPso9MZs2qnFzRNRht+j6cTjQt5MZ86rLDzS2hHa4UVOG76awbboUjt HfUIXk6lQJHg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 18:53:18 -0700 IronPort-SDR: S8pBWXsIylNZ6s8Gln3WOxsDnpTMd+CVEWIp1V5JQsQemef8z/jOlbH7rkUrYAe5womKgtcACc G11WFp2VT/3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="405239124" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga004.jf.intel.com with ESMTP; 29 Apr 2020 18:53:18 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:53:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:53:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CpP4XpDHGbiWXv8FEHRNOQKjFlq0EdYZiMAL+Fyzy5l52yNkMR/oa9dJSUbdPqyAbu3EbQ0ld5QhcXkf9LJ/gpGPPH0A5+2jjb6XqXURerHZWCN7plkwUvfJOo+FDlqsnchb5ObomAMP1jn3Lof7+8zKUMjw2uQhqsFkaT7waxurW9oAT3EvxTWyeQKSXcYhXqb/SkUtcYEOK2XxS0i4aQk8pJmgGK44uNHc7D3KJtIfJLf4JCV/xq7EDMO2ixVr9rtcnd+OOUN28B1oFzlXpGqLUXDIAlmYMvkBv6jgkIryvjFwwKLdnvW0TpQ9mKgriGg5jLGdMI5JsbzTJUfTAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tR76lwcCmHlllmniwM6YE4udEiSVZ+YrdhMh/lCTBkE=; b=BE1QERRBnOYY74qYa/2Dw61iUJE9grtp/Y7Neyg+QcrPgRaWTNcavU4EFSzrAuLjj3R5IJhkxid5++fbRPOOaX3mmTkYiYLb5+2uFKI2oOKf52tyVzEvvFEbkgNyCoJJv/Wzq/qgoa3dqnnocU5oU1k2FZV8tgpxBvqekJdpunYkrJrWBtohuHJ0g9V1J3Sv47i4sbNo97cUj3JyyGv6vqupWgfcxQz20MU2OGsEOHxhF6En5fZMVtChBSTFehKoq/kHRuF+Z9Fom1FIw1HZzwTkxCBo7iATh+7Dg/wzmlCADdBNUpHsFUd662GKQZj/yam4mpPmzXc61eSxClI6BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tR76lwcCmHlllmniwM6YE4udEiSVZ+YrdhMh/lCTBkE=; b=c3kTuBAEEDX4gDiVp3DPojEEIqUA46mo7tVjRVjUv4+12LSIdFtVF0aRr/0vtnyZltq1d+ckWi6/3JAbT+PuR0outZ+VdE/xdY2+xO7b+2Y2XCiM0ruwfPfS9EYAqXidjOCm0TB/lnoifF5qBptQ7z4jUB4XvmVzTXKWeAx46PM= Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR11MB0029.namprd11.prod.outlook.com (2603:10b6:301:67::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 01:53:16 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710%9]) with mapi id 15.20.2937.026; Thu, 30 Apr 2020 01:53:16 +0000 From: "Chaganty, Rangasai V" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWHc5+1otgqM9O70WmrNnwggaqt6iQ6FTQ Date: Thu, 30 Apr 2020 01:53:16 +0000 Message-ID: References: <20200429023203.37544-1-miki.shindo@intel.com> <20200429023203.37544-4-miki.shindo@intel.com> In-Reply-To: <20200429023203.37544-4-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.222] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 745722df-b90d-4df3-2aeb-08d7eca93fee x-ms-traffictypediagnostic: MWHPR11MB0029: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:216; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(376002)(346002)(39860400002)(136003)(366004)(86362001)(316002)(4326008)(64756008)(66476007)(33656002)(66946007)(66446008)(66556008)(76116006)(9686003)(55016002)(71200400001)(966005)(2906002)(107886003)(478600001)(110136005)(52536014)(6506007)(26005)(8676002)(186003)(7696005)(8936002)(53546011)(54906003)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iVsgf5L7Qhbn3yC6bjNmEnRRdSvcXcxssfXYyeolHmI0mhfjjX5UTQ64BSUyjmFshckCx7yhhM148Tb2ojHo59WpFvZ6yRysqlaCI16ckFuHuPXbKbie4occQw6T7TbdoP/4pbQV5Wmw66CUmxxHIv3hNMvh5vdpx0CbNtTrQ0Q7Dp2WH+OPqMYaUgjMmsR/qH2JNTl5B4eIB+2o9oXps+jONZvvcjEMQ4+aebNgSyalpVUu3mpGyXOmgnxZ1xNeEfHvmltoNXNzSEWk7qIRZEVGPqNO1dqL0KLDfdzz7JJfHXJrH5gHpR2sz+ycwG5c+FycU3zn2E4r5ub9sPyLnee43wKZ2CN3LgmdV9lMR5Kau2ikJ/kCuyy1LPJEU/x9WjfvC2IMqzwmyfNjFiu7L4OIYWzELUr9F+tifnvh82rMPIR8XvuO78rJyV+n0vv2nfqotKvJNDQHvuUufxYx9m6p8VUrPJwxQKquDZUbuGjQxDQygcOssmoRKe8fCI9dX4NQ1qJoYYDveRz6D7c54g== x-ms-exchange-antispam-messagedata: RXDPf2+HBmy86gq5EeEVA6z+X0qBIg3o/xpiZuv+VMx3rJ+QIo8umNDwH3+b4+o0kKuJH3cdxrS1lz2mkjTfr5oq8TJ4Rqjz0LjnhzFNC4Bm7x38IqN9rkNNkfaiLfjxpFThJGYUzMVLw2iFuNZpGfNjgikHRIBT1iI8d3WMKgSJ3QuiHixsqUEfvevOky5TrW8m79Z4VwHepalllyrArcW9NXe3p1TaVdwMiLUswLAJ8A9AMBAbeNf4wEQ0JE4ysiiDf0ViRYMu7PY/xdMxlsg2Jgu+Sl2g0O4ShFhWbrgcpOkUqHSkAdjpudmlZ34jHbfXg6GhQpRznua8yxb9JEPEkStvfsUMkUjqFpO7tB1hK0kn0fsGhuOQGhywOuvQhzg1DwMXccZv785wAyab7K2wkEqnzU4uHUKT30ukCbUTPhceeVCQjQP17IBqvhDExt684KCkhUntUgvRCcd0UI0Rs/x4rG39yJoclAsIsf/AWokJfN5X8Z0x8Pve0OmR0TNJdSdwRUkNHPiZqHyIWz5N0oLs8o6UYJCm1C+EjDZN96ne93n4ueEnwcqKtjoTw1iF12HsBWOAFlAv+kiFOR85HLHWnjN+ho3Hps4zs/PlHxtdcX5ka0aDjeuaj8y51GZz5wdLw0QveAP0BguQYZ+2LzFQMU4ikrdXdjbov+oLURQD8AwgVn6FIs3AVCZ1YPtiKOf+bjdcInedmzYKRA6QS+A/hdqLS/YoCCFvPo5Wg8FIMsJ0kjaV5xR3E0zhrBQcbL/xnyNq5x1JQh0MFHYnB+FRg/vDrktcCp74aE8= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 745722df-b90d-4df3-2aeb-08d7eca93fee X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 01:53:16.1076 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rCvfh6w305MSyHEvS6/py0+5x1HQuD5BjMuE77kLV0SX/DTsafIzkVLLFN4U6d3W6gop506A3ml5mTp9KxmlQlVuWOvDuLDcYtAirAA1NK4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0029 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Shindo, Miki =20 Sent: Tuesday, April 28, 2020 7:32 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L = ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: Remove= s redundant InitializeAslUpdateLib REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 This commit removes redundant InitializeAslUpdateLib calls as DxeAslUpdateL= ib itself calls it internally. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman Cc: Ray Ni --- Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 3= --- 1 file changed, 3 deletions(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/= TbtDxe.c b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/Tb= tDxe.c index ef6201de94..e43c5c2fa1 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.= c +++ b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtD +++ xe.c @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( UINT16 Length; UINT32 Signature; =20 - Status =3D InitializeAslUpdateLib (); - ASSERT_EFI_ERROR (Status); - Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; Length =3D (UINT16) sizeof (TBT_NVS_AREA); DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x Length= %x\n", Address, Length)); -- 2.16.2.windows.1