From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.2117.1588210846165048992 for ; Wed, 29 Apr 2020 18:40:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=sYaqnf1V; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: fUN9yQVEXVTjQzqzC5oC6SZooXgVTo6d39zWbCNvDRJoPttO7PYeFx2IeHzVCmBgpVColtkgXA fi4WEeCRPUqw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 18:40:44 -0700 IronPort-SDR: XdAeILipYy3IJFVVu4P1SdhaV/iMOWBEbQq2+iHBJ1qsZ6RTEZn11wBLQjZ66mLFzO5lYYSJiD u9UoVfjUep9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="249610365" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga008.fm.intel.com with ESMTP; 29 Apr 2020 18:40:44 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:40:41 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 29 Apr 2020 18:40:40 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 29 Apr 2020 18:40:40 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.55) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 18:40:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=InGNenMFJszzuxyZsS3ZjuhE9KE+4JeHvahtSK6WtNM+5TVxio83JDK+9F+IeBQu/WwuyU39iIXHq30i+YJ3SrHUSSSwIDcduC3QNpj35v+28VwPpHnt2m7NXxIrSb6FHIGgN+ga6busYi9UfrVppObEpMfjNkIDtm01KyBKUodPMwLbgfJRqGsRMrqso/3Zr2UgqZT01h/QODIhyIH/X79K3q4Zk8OS3jRe5rseOVnmmkjHAngvrnZ+cOEN/EltItdFe0cPQuYfP0EPeEsgaU8xrEPGKtHTvVRn5K+af06YMuXKBiNIeHB0DluPqQxRq4qE2CsVrglKfFdhamIGDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rKJ1snPKDdHDMRpxTitAcdakTjOoqiFY6F+RxZEXUHY=; b=J2YidsKmURX+SAPRjYYj/m9BPaCswBJ39gqs1zN2fdwiUGpGmKSUVFoMwnuII6oRi763UvJNlmLdW4unmL/3+3AKFGoE5k7ZrF1Z85QUnaW9bCEV8XmndUsyUnctAGSDViDtIo5jxajJo/aiMmCgf9QjJewfZrIOLw3fVCQlPxYFzPlAFj66cjDNv2eZD3er7QYB+LnVWEiG8hb2cCNOiIh8ZOmFTy4W2HZOHq9Jr2F4M3jRBB6KjnfQFH/vLA8v8E+HkzlstKdKQZLraKUAlVO27z/BgHrzqwn92lNUGsTV7MIeLJyqhASZSuKcw253NNyRoEHPReSAzkA1GUAIyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rKJ1snPKDdHDMRpxTitAcdakTjOoqiFY6F+RxZEXUHY=; b=sYaqnf1VuIq2KvugC5AtYe+pDqlhdcVwze3vMVcKSF6ZMXDMmd7P7UgG+e5H9ob2DW5MwDtdtrlemj/CLD5t6DqexKwKMvkzvhd1RHYCDks9u70B6AknRwRNiVvaJ2oK8ndqrvjXs9ybI1rKeRSQ8t4+zzx9vz5taZuw9MS2lDs= Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR11MB1999.namprd11.prod.outlook.com (2603:10b6:300:20::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 30 Apr 2020 01:40:38 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710%9]) with mapi id 15.20.2937.026; Thu, 30 Apr 2020 01:40:38 +0000 From: "Chaganty, Rangasai V" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWHc57nZd2+hp4Ikug4NX1k8y2+6iQ5P8w Date: Thu, 30 Apr 2020 01:40:38 +0000 Message-ID: References: <20200429023203.37544-1-miki.shindo@intel.com> <20200429023203.37544-2-miki.shindo@intel.com> In-Reply-To: <20200429023203.37544-2-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.222] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d5bb3db-fdd5-4d82-6af5-08d7eca77c5b x-ms-traffictypediagnostic: MWHPR11MB1999: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:161; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(39860400002)(346002)(396003)(376002)(186003)(6506007)(5660300002)(54906003)(107886003)(26005)(76116006)(2906002)(110136005)(7696005)(316002)(53546011)(4326008)(86362001)(33656002)(55016002)(966005)(66446008)(71200400001)(52536014)(66946007)(8676002)(8936002)(66556008)(9686003)(478600001)(66476007)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kCq60IlmojMp/U2D/39Q7UaJ/MSnzUdp5GQKQ8vBNbMSwogkK6oTSBrTKBr6P8A3Wu6LHM4mDDNqS1pNW55UvSFprBXpQzq1RQjlkJQyGD845wtKeuSx8vm236leMvicXeeMR1EdDWfNdHQ0fijpleHgr+SjMiLJFz9ROWRT7e3eMbHW2/yUPuBmZf6T3wev2IPSciME8rbE4jmZAOYKAopImnUJO5bUDl4TbVZt58tUr0qCgBL06eYWQGDOrRtMGLBh9rvtmTgoSwMEw9bi5EMs4zt0P/L4TOZ7UlJZoi6r36nH0LGvSFPDojwbWDhBbLCsAhzrnhob4Qg3lYWZiZEh5GHsrHXNWtJ1hZqSTYVRmNmBB2OmhEv7oTa1QUQnbjRrhf5iVr5ReDE04fS6fyL/vI59e3ulMEi1HQolFsaJPBgIUGaqj9viA0SBB9D0mCxPnd5a5nPmtX9/4THsICU2TnIRDpNCKXEYNnSaJbm/39pk7V0j4dgMLWcK67Wt2M+qtftI251tmApgeVYcqg== x-ms-exchange-antispam-messagedata: s72NvidgmMhZr/sv7YHJKUOX9/t5kXRLjIbQoSV48nFKNHptsbpdSHudNxm8zqOzYewYQEvhZ42L+I3IjMaJ3DcwJBRy+lh2nWLw2xr5rA7ovVT9Y2Awcpa60GK9lF/1t5+ehXDf5l6uGpjul+51ab1FPl7rY/IsfAPK14b80odwDf54lf7xNu+h6x/YwXT+aCmYOT813wBDyr0XjHyEcbRSjF6gwbIn/WAWL64Gv3x4JyMAc1kKQj36waGEuDjxv6t/ohhLb+ZVDcgOHM/yzJbJkqitn27ZdDTMMWWacvoXwZIFBCRGW8R+AuVzg2tsBv3667gOQ18vnhDnEdcu/YuLqin8lxJxWQ9KFJTMeOJPC7Wjfya1A1eRk3vOFGcuHx1QiEKTAeac2uPO2AlrHUliBj6eOZ3j5vYlbcDLHLJ6HQhzvKFd3L4qB+9AKzbObVCZUbwaxjoFq3IaimEb1lTbHecYnvWeG7uqQvjQVKf4UcXZmBkFWyvslIf65YdC8xS3fGLu8ySkT7HFfda7xbD5bKHBbMkPoR+bOlxPHWoqS3DJ8B6qTs5fKhsLKHIR4x5vYqilKO8zeZZn7dL8qUV8GhkVMgyA5sZUuAKILqHad4gtkk/y4W1OVBMZGLSkgupSV23z0ULlPxgd7ripzQSX0NpO/Zj981SOgu36JPX/xNRULeyfKOVMauifQ3y5Gaem2LoNRsMIzQhuVy98ufCCw2cI1KJy/HaQgLH4xp/3fJidVMtUoCD+EOpgTj9cLiLo+9T6Stt7dwM/AN+OVH8D9+RAMinKmzCxvS89pKI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0d5bb3db-fdd5-4d82-6af5-08d7eca77c5b X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 01:40:38.4834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4MkyOKPpgXK0BUg8mtUxDivfS2cIud3hatng32p1lrKNjy4NQTG/31VlUbstGS0yEgMDkeyQcG0O25yl/c1vY8OjH/0kB0XWs2JtOctHIYM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1999 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Shindo, Miki =20 Sent: Tuesday, April 28, 2020 7:32 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L = ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Remo= ves redundant InitializeAslUpdateLib REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 This commit removes redundant InitializeAslUpdateLib call as DxeAslUpdateLi= b itself calls it internally. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman Cc: Ray Ni --- Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c |= 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dx= e/TbtDxe.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dx= e/TbtDxe.c index c670f23320..991edfc2c6 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDx= e.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/Tb +++ tDxe.c @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2019, Intel Corporation. All rights reserved.
+ Copyright (c) 2019 - 2020, Intel Corporation. All rights=20 + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( UINT16 Length; UINT32 Signature; =20 - Status =3D InitializeAslUpdateLib (); - ASSERT_EFI_ERROR (Status); - Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; Length =3D (UINT16) sizeof (TBT_NVS_AREA); DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x Length= %x\n", Address, Length)); -- 2.16.2.windows.1