From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.168.1588801954253832131 for ; Wed, 06 May 2020 14:52:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=blNdwLFn; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: MDXwLG1dXozGPA/sPCDL7k24s+VwQYRjI3OPCSsPDrxGBt+paGgwmgl9E7Vvobcl9uuaqV3WaR pCuPFR2eazPQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 14:52:33 -0700 IronPort-SDR: pWXF+Wa71qOP3GKajuW+1Vr5nbrak5mm3Tql14ZWuedw6kE113MHK/PGx7HFF5EHWBE1NLChJy PU5vAfvNKraQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,360,1583222400"; d="scan'208";a="278379308" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga002.jf.intel.com with ESMTP; 06 May 2020 14:52:33 -0700 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 14:52:33 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX114.amr.corp.intel.com (10.22.240.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 14:52:33 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.54) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 14:52:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=agf1LZ0eZSaYzHjerQrOzZz7YupVic2Ixt/5LJeF6bWQ28aFoV5xFTXLtheCWSVlHmtp5stUl0bgotfa32opaPdoBZrJ1ZuxUfUUq8Adsb9ase5Q7FtR7Pr+aZ1Z8SrsOCL+rrBQV1BazrsDoEZRh3HaxwxDlASvkiefKf2mnFFyBwGfrJoPsYPbPMCYwRZJUMvNh0sqyyn723TFa8ZNW2KHRYujKzkvDPglipU7nZqTfKyiwcNMNvDmmcM1gQb/12eY2+0jBY8ROf8AY2SDYYZVQhZVOrD3rZEhBb0GPiKn+eQchvET5zNcqcAUrnpCuA4opJFX/c6kunTUHdC/Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=23Ah+/Y56j9F4MXHRpcP5xdNL5YNaGVatH90MAsHsAc=; b=GrUclKV3ByKiK8CYMR+8hsQR62R17gsLQ6U41T9Id1VpwlDhr7nJt3GK28+29Cn+rrS07avFsJeYHVdY96mcNQUaGf3SEG4D4g5nIorCrHF3SMS98riZ4GQ62neXOdaReOloB1bLBoFO3ZOiNIaaiTVrb7fdjU50y2YEUhUX/GJWk+csPWv4jDU/ERFwSZFr5djqxqKqKMpQx8BsJUWUMbxuWjunQXb2sKW+HLOJCEk9yWCm5itrKkbMS4kfetZcVtM86mauseulJLz13aUNuaX6NyP61lBhad/6Qxof6DciwlKZ9pqvnsuHCWi8gYInvvjHC3UeMmcXj/m9Ok8nLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=23Ah+/Y56j9F4MXHRpcP5xdNL5YNaGVatH90MAsHsAc=; b=blNdwLFnsGaPxpwaPy0tMAYrwFOrMThQFSuxth+k3r/XadGkMpZBS3R0cmuBB6VIbY92yYMQ3I0qGIPZeRhEOhGE82stJRWGzFEJEIKx0KujNW20qi9r9YIWsDc8ZfxxF2nR9GGvYJ6FlQIIQ1STGzTQFrx8wLAZ+9mZcSNwl20= Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR11MB1504.namprd11.prod.outlook.com (2603:10b6:301:c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Wed, 6 May 2020 21:52:30 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710%9]) with mapi id 15.20.2958.030; Wed, 6 May 2020 21:52:30 +0000 From: "Chaganty, Rangasai V" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v5 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v5 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWI1TpeJjK8R2PyUisisqRmk+UHaibmpAQ Date: Wed, 6 May 2020 21:52:30 +0000 Message-ID: References: <20200506031650.55020-1-miki.shindo@intel.com> <20200506031650.55020-3-miki.shindo@intel.com> In-Reply-To: <20200506031650.55020-3-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10e091e6-b741-44ae-b9a5-08d7f207c6be x-ms-traffictypediagnostic: MWHPR11MB1504: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:161; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ldiKzJEiLQN94sRCHx7956K74yb+rq1CcoZIYCo0JRnxPgh2NrC8rLhivD3+C9q8kftfOeSXa3h2Dt1LmSxp8Qd3Xra5+sHUYnG31WngDfm7Gr2mgWzO2uCLKKCMq1ZI5WMEHjE0h40t3TbT4zOzK2MZUYZpnOIKRyabOEXHdSKgJW37epIcXVFe5K3ck+pIyj1YAf9n2xw0A6UUp8ZBHnWTO3QRgW9/4cMYmxIwL25W55h4J/KTu15CkrSOYmKzX1CFmZSYFULKYbjK1R9R7BcLdVSClSRbz8hxbRP8Agxv3k5WTRHwRUchViYktkE3rmexNy0c2egDn2Mv30tZHF6/gtFhvR3BYNXEx+drwX3e8h3VPmC52b3r9tFDn/i8xk4qK19iEDQan2torWlWYCPoePf1ls60g5cjSQJocu8yED6ba3qpy4/RbWxRizb0PVJwPlJjBw2hn/0T2Xmx3N3UHBjiyELZncRzPEtuLobQ6JbBl+BiJuaDmzBIxzY6fi1pz32cXeeVPX5FRAkplew0yw5hFWryzEOafQ7KtZNdhOeHRKMNvtoP/uhvonebniPMwosq96J79HAYDl1/XJGWz4QA41ksTpObn08nbt0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(396003)(346002)(366004)(376002)(39860400002)(33430700001)(76116006)(5660300002)(53546011)(8936002)(66446008)(66476007)(4326008)(186003)(86362001)(52536014)(66556008)(8676002)(7696005)(64756008)(66946007)(26005)(6506007)(2906002)(33440700001)(55016002)(54906003)(966005)(110136005)(478600001)(107886003)(316002)(33656002)(71200400001)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: cyH8tOrBmyUjyYEVhMK9iazYVJDvBqr5wj2PbQj3TbIoPcwU+UxdPlOkVLtWBi6LMLDzL0rrHwsIG+W+Nj0HaQUcJi/9GczLMzTWuF9NwKqO5ZtRZdlak89FncRoY8ATFpoolStxsN5qRnrs3t+tkKU6o5ramySDjS5xB74hckn308/+PwOe1yvk9XOCAn1thZNvynj/kA+UyFC7GFAUsL/itFG1fpzQzb2Q8/SZjmqGYSgjCKb5P2r6+nIfxIvMPtPV4saDE+h99H5yt0l/4aGzGx3KKxzYhJNka3H046LgEBwixI9ptZquuGVlDIHUh1+GAIJiGATpFpOHd0+2pdLuQOJJtDADtaQqoBjLYtxuXIkzpT3VzO7s6bStWEsbtzpLsRScWrivPoZUtbdX5HVPm0is6Ou3qNqdpHbKu5OO8u9Q/5oUJj/czuxy94SO3gwaTfDfhL2HZLh37cxeoPQF1SWEE1IhLe9JIEnQlwAhkleDqImQlzQG34W0Peu3JA+Kb8TraCjV7xBcMrFwLzGzpLf6ImfnClhmicpkbin1YRceMvmSvWSmKYlfn2ecdM17KnPeEwDRqRPjHAYsbDN2KLRQ3hn5vrhmtp52MTbk8pRvfxX4ZWkwCoMccC2G8csqJna+qq8vpykKudyEhQ0FmHGaLS9jUz7P8PUtMEF25tKzGU0Ttqv7trWqX/Rmxm8u3uz+roxXkVFH7CI7uTByObQ12Hti1J4bz85xJayk/7meql9dmabGs+aIlzW1oGn42m/2pocixO7XbZWkK31ueHHALMAwP6hLQvGqRys= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 10e091e6-b741-44ae-b9a5-08d7f207c6be X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 21:52:30.7936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ezc+w8dZ9uWuGESPp7MnEOjyxfZhyCyI5BwsYY7NVT4nPcnkhPxAgjHPe47oxsU5zSFc+sgwqmM/tM80a9R0FBXNZHWBp/WwTJZXvCONkLo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1504 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Shindo, Miki =20 Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L = ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes= redundant InitializeAslUpdateLib REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 This commit removes redundant InitializeAslUpdateLib call as DxeAslUpdateLi= b itself calls it internally. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman Cc: Ray Ni Acked-by: Nate DeSimone Reviewed-by: Ray Ni Reviewed-by: Sai Chaganty Reviewed-by: Chasel Chiu --- Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 5 = +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/T= btDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtD= xe.c index 13a687576c..d101f4bb75 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDx +++ e.c @@ -1,6 +1,6 @@ /** @file =20 -Copyright (c) 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( UINT16 Length; UINT32 Signature; =20 - Status =3D InitializeAslUpdateLib (); - ASSERT_EFI_ERROR (Status); - Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; Length =3D (UINT16) sizeof (TBT_NVS_AREA); DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x Length= %x\n", Address, Length)); -- 2.16.2.windows.1