public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
To: "Esakkithevar, Kathappan" <kathappan.esakkithevar@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Kethi Reddy, Deepika" <deepika.kethi.reddy@intel.com>
Subject: Re: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit
Date: Wed, 13 May 2020 00:11:22 +0000	[thread overview]
Message-ID: <MWHPR11MB1886D250098823728BEC0D80B6BF0@MWHPR11MB1886.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200512172555.56680-1-kathappan.esakkithevar@intel.com>

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com> 
Sent: Tuesday, May 12, 2020 10:26 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika <deepika.kethi.reddy@intel.com>
Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit

The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1.
FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit from CometLake1 FSP at CometlakeOpenBoardPkg.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714

Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
---
 .../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
index 45d76ad5e4..53f26d824f 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
+++ b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli
+++ cyInitLib/PeiFspSaPolicyInitLib.c
@@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem (
     FspmUpd->FspmConfig.GdxcIotSize           = MemConfig->GdxcIotSize;
     FspmUpd->FspmConfig.GdxcMotSize           = MemConfig->GdxcMotSize;
     FspmUpd->FspmConfig.DualDimmPerChannelBoardType =(UINT8) MemConfig->DualDimmPerChannelBoardType;
-    FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit     =(UINT8) MemConfig->Ddr4MixedUDimm2DpcLimit;
+    FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit    =(UINT8) MemConfig->Ddr4MixedUDimm2DpcLimit;
     //
     // Update UPD:CaVrefConfig
     //
--
2.16.2.windows.1


  parent reply	other threads:[~2020-05-13  0:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 17:25 [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Kathappan Esakkithevar
2020-05-12 23:58 ` Chiu, Chasel
2020-05-13  0:11 ` Chaganty, Rangasai V [this message]
2020-05-14  1:24   ` [edk2-devel] " Dong, Eric
2020-05-14  3:16     ` Kathappan Esakkithevar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1886D250098823728BEC0D80B6BF0@MWHPR11MB1886.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox