From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.195.1588801970469058810 for ; Wed, 06 May 2020 14:52:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=DkoCPRUe; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: v5kWvf48NIzO3dAlcg9/6c3c6Rh8xq4EPHDWds0CyyfDc5Y77wU46B0fryOFG/CSzud+Z85CR5 qgzEYe2p431g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 14:52:49 -0700 IronPort-SDR: tUdjYomWRaMF9Gyor83Pw7gySyzjr3GaNKHWRFNLznVeHLjujD4Q9Yb2OKVUTT+GW/qPPTBbNt 1fPw/nWt+/xQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,360,1583222400"; d="scan'208";a="284776106" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 06 May 2020 14:52:49 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 14:52:49 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 14:52:48 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 14:52:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRFbWWui4L4FEdkNGSaU3mTpYqOljgmIRIqi6D0wJhGQVwBz5UIcniVUk/ysoRjIz1T0/qchGSQRt/XEn4UtdqGeT2NAQJxqt12VzghNPF93DYJuZJ2gQcR/RxordTbd2S2BgERTTElGwWERmpD0QiUqeHVlo/6p8LH7+dNE4gq/Fktf7nDXsr5A3pyELe99TFznaGTiqLalg2u1XL226M0DwstllZaOMA9j+9MLA5Cf96z5W5BmL4rpAUpRKQnPS1hG68XchFR62kYPjE4OX6GQiSeHwEG/c0ZZk9FUx3dlqjVoJqS9pr6v+/5FagLfdFEQpna4Qhzv/JdCHtc+Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IVk7cgteKqs3830srMkivr2FO3OAsEKuHzjp0dA0caY=; b=K/46zHiyTcLtQB+uuLNgoKwhonuE0DPfpoJlSOGYrIpl+noHVoLBbbVJpSnjbEDOyl55iJWj4BQ5A01gy9c32Z794uFOV7CKdx7TyDjrIUgJbqewyB/4lfG/llEluYBm+T6cx0F4UapBYRzNSkHkkGDwvcUQTOrzshTkwUl3uVeXv+EWhp+FznObuQAvbJtxVQ4jhY7ga/ylkgbBpcjN6fnVKvNZOBKNtr5sKbJhrw1kuwp8VlF2nS7tx8x4ZIHuG2AKOwH3efzbJuc/EDnGGthqF7mX9MxvRBHR3ZaaQ+dY8njuLtuQ9PyG9w7Yo/t2Lc+hGB7bZjylJIL22JaWzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IVk7cgteKqs3830srMkivr2FO3OAsEKuHzjp0dA0caY=; b=DkoCPRUeNfF5gXaZf+bfKv7RIWIsXp60w1mjCeTTGuZqrmDuw38HYsLwS5YZx5FAFo0ysKv8EI+lR9jx+a2IL2ks/gnxJ6tmIBw+SCeJEEqv8ww5KLVqHVJ85TYfZAyKcLtir5IwIvWjpBgyr7u9QkxK0tMjqTjZqcVpXNYq72Q= Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MWHPR11MB1504.namprd11.prod.outlook.com (2603:10b6:301:c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Wed, 6 May 2020 21:52:46 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::64d0:a918:94e9:d710%9]) with mapi id 15.20.2958.030; Wed, 6 May 2020 21:52:46 +0000 From: "Chaganty, Rangasai V" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v5 3/7] CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v5 3/7] CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWI1TsStOcnNc0YUGfbLdWV4JfHaibmqRA Date: Wed, 6 May 2020 21:52:46 +0000 Message-ID: References: <20200506031650.55020-1-miki.shindo@intel.com> <20200506031650.55020-4-miki.shindo@intel.com> In-Reply-To: <20200506031650.55020-4-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0a186ae-4196-4e57-176d-08d7f207d00f x-ms-traffictypediagnostic: MWHPR11MB1504: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:216; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cXTAOczDY6fZJeyhgZLw5mjYol2s/p1d9VQLWSh+oeqMefFPnPy26Xrw42mIRvDejqrbbDR9EbDNQAYg+d94MHHe7BoXxM6/AAsImqAEdNiFZpWrbOXLgcRZUB0pyqg15NcdjatqiyYs17KD1W4YDNX0TPVuq0wmWtgVBI6CLewN4rWXY8njZbeiZWpiIp7ehBdT5YO3Phhd+DRi40S/7qw/ZWH6MLENzHgDLn8EmlVyr7v29QvTfEEkmQuaZHpEgfa0fWg+GBlFwgILXdtr9RdQtiu4k9UQFxV0zJqNwv+5FtHafqGvnE1cf0bXCUBNwA6AMR/cFNx8E4p8VoZYaFWK61kll8YS/AjM0D9YP15PKkTGkQFO5wT5pfPXwWM06uS6eWTpRgp5uRE5Bl7f9drVUamiCfZEf93+M5XypGL3yK6rJ7IoZVVJ2TM9NTR3qc67gvauBkk7Af2M4Fk5GRmg563rvc2Xn5UsRBte5BbWtbWZF1cI68m/oyQsbyhYg1JqYhjeiysC7QqdxAM5L53HV3sO7B+snJtUa4j68L+z8SJJICbCKgBzH0uDGj1HpuNj6Bngjugr4sxiDCzfQc/1AMP4yZ/9iTXIiaJO+VY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1886.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(396003)(346002)(366004)(376002)(39860400002)(33430700001)(76116006)(5660300002)(53546011)(8936002)(66446008)(66476007)(4326008)(186003)(86362001)(52536014)(66556008)(8676002)(7696005)(64756008)(66946007)(26005)(6506007)(2906002)(33440700001)(55016002)(54906003)(966005)(110136005)(478600001)(107886003)(316002)(33656002)(71200400001)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Jh5dKR5Nieqrs3DoxOfUWHJhWDlBPIm9MRMVUj+WMkUMGt5gzXWx33MjU0PSNW/wbLMqwghHSOdoEtkhe7le6wBUuB1LAllNUi4WFwfp/6EpHwXyL0DLjjKJ0FwjzrSa+RHDuKcMWoybPVDZPBU3jtxAsDvH/wKVS9NogrMH/IaS8RtAU/4xl/IrD/c2ZpkYlyz4S43M872VFTjUFK6OfZ2JELYQ+CJt8aGNnh1rDalwW91XSfgvWDqTPCR0+0wC4R2Q+SY5XttO1Cz6l1jWEA0ybf4seEyl2lOR1DXJssTFecHZDQHE4YjpdM68CxCCJEqYG4afMGQESwS1MyYtPSYzXLX64rLUkIOYlLr4ZkAYfPmLZyrlhtfjp5GPJNqk0rCfwg6RLArOG60Fk3R8izvPn58w0o5o33bFePckD7o/z85znkDzPHuNfIhil3A+OmE3RnhSr14rVG9HTm4rzmt8PUBFChpHs9sed5cv0L8vnMMx0oN5Nl/7DXQVckWRpjcxcgFWuTVPJlW9ogd+Q9QxxWBNOEOUn/OdVBUZOIVZhUgyJWfivN4bKQa8GDk8udXxUu/mgj3r5DnmC7v1cyRTom0QByF7z/gKv/lHHxr02RPvwVDPTuklfKHTguW5EUwQEAEyRXGU0tvaIDYvzCBF2QJynNifPIrX5cBFfI0X83RJMvQBO80Q11Ed1d9bmS6TorTAsxTV/phHuSzKKVSCJTs6CQRm2XnNvcdFvkSgLabEJ4O86og6Dj1qe86hdxb6CxU0HtjwepZKpJ4OS7ZISvd/SgjZ9JVQdf9m1rU= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e0a186ae-4196-4e57-176d-08d7f207d00f X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 21:52:46.4987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3lxkV+PHQWMhmQUdSqS74tCK/c9Hh7Q866yfEp7whYzehTUMGG/0UMPAGC5f2S8O7qYeFqo3/sGWUdPXqrVsLuviSEMJp0vOVMJugMNEejw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1504 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Shindo, Miki =20 Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L = ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 3/7] CometlakeOpenBoardPkg/TbtDxe: Remove= s redundant InitializeAslUpdateLib REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 This commit removes redundant InitializeAslUpdateLib calls as DxeAslUpdateL= ib itself calls it internally. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman Cc: Ray Ni Acked-by: Nate DeSimone Reviewed-by: Ray Ni Reviewed-by: Sai Chaganty Reviewed-by: Chasel Chiu --- Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 3= --- 1 file changed, 3 deletions(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/= TbtDxe.c b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/Tb= tDxe.c index ef6201de94..e43c5c2fa1 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.= c +++ b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtD +++ xe.c @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( UINT16 Length; UINT32 Signature; =20 - Status =3D InitializeAslUpdateLib (); - ASSERT_EFI_ERROR (Status); - Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; Length =3D (UINT16) sizeof (TBT_NVS_AREA); DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x Length= %x\n", Address, Length)); -- 2.16.2.windows.1