From: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>,
Michael Kubacki <Michael.Kubacki@microsoft.com>
Subject: Re: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver
Date: Thu, 23 Apr 2020 08:29:14 +0000 [thread overview]
Message-ID: <MWHPR11MB1886E7CC01116FB7C779601BB6D30@MWHPR11MB1886.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200421204028.10410-3-nathaniel.l.desimone@intel.com>
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Tuesday, April 21, 2020 1:40 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>; Michael Kubacki <Michael.Kubacki@microsoft.com>
Subject: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events
What was done:
* Included an instance of BdsHookLib and BoardBootManagerLib from BoardModulePkg
* Included BdsHookDxe to register the callbacks implemented in BdsHookLib
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
---
.../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 4 ++++
.../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf | 1 +
2 files changed, 5 insertions(+)
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index 2ab9cb03ea..536ed7fb09 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -224,6 +224,8 @@
#######################################
DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpdateLib/DxePolicyUpdateLib.inf
DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPolicyLib/DxeTbtPolicyLib.inf
+
+ BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib
+ .inf
+ BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBo
+ otManagerLib.inf
#######################################
# Board-specific
@@ -446,3 +448,5 @@
$(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
!endif
BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+ BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
+
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
index 199e3876bf..0d99114961 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
@@ -345,6 +345,7 @@ INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
#
# eMMC/SD Card
--
2.26.0.windows.1
next prev parent reply other threads:[~2020-04-23 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 20:40 [edk2-platforms] [PATCH V1 0/2] Integrate BDS Hook Points into New Platforms Nate DeSimone
2020-04-21 20:40 ` [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Nate DeSimone
2020-04-22 18:14 ` [edk2-devel] " Michael Kubacki
2020-04-23 8:26 ` Chaganty, Rangasai V
2020-04-24 6:44 ` Chiu, Chasel
2020-04-24 7:09 ` Kathappan Esakkithevar
2020-04-24 7:33 ` Chiu, Chasel
2020-04-21 20:40 ` [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: " Nate DeSimone
2020-04-22 18:15 ` [edk2-devel] " Michael Kubacki
2020-04-23 8:29 ` Chaganty, Rangasai V [this message]
2020-04-24 6:44 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1886E7CC01116FB7C779601BB6D30@MWHPR11MB1886.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox