From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.6235.1618822043896156335 for ; Mon, 19 Apr 2021 01:47:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Gf27jsGf; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: steven.shi@intel.com) IronPort-SDR: XlcfUWq/y3TcTIinMR6Ho6S4F0Ks5HXRhrWMGbBmhhofR2VzQaRSgN3S5u7QHf6DLOcEo0VEbp g1QopdpfVZvQ== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="259248933" X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="259248933" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 01:47:22 -0700 IronPort-SDR: 6vvt4Tet9pSNz7u2iAMxToNprqUTMxZ0clCmhZJdPvkD3JsKMGjU1ovin85LABUzWO0kH4dMOH fLBTjspPEIBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="616530800" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 19 Apr 2021 01:47:21 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 01:47:21 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 01:47:21 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 19 Apr 2021 01:47:21 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 19 Apr 2021 01:47:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=koUOeKhPP4tAr8S6eWbIkIvKFRY+XPtJyIqParSYjAVgTSy2jFEDETyg7oThcBrXKG89sUCanXGIzI9ywR0dk9DKJzWt46Z3Raz4vtLACxaQfJJgkGJpZnSk772Ez3hVMtVKtvoUOJqDRS+g/Evv5j3ciPRVvk24rm7yDiG/I/F0oCgINDTBQYvMqYUCLGqsKbLF71JVt8fY/ie2zD78seKKOF1XHQfFOhYysgDGv7BVXLbVMbL8wECLl76i+ikxGsCwOrbm7QZ9O6sjnoElhdlxdApkEk/Wk1oZMn8ttj/0nWFDVm1B2qnLLerQPMAndKQVKy2Rjdvwubc6zarCNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tt53v70xOJA0UjuAIg6DoUIOgLkza3cZwjing3nJL2c=; b=ZB3GzzNyFROOPnjy0KLI2g6LZCqzewPzuXmV1fCljlkdesgXFhYC2yX2Lt/MmeKGFIzht3s7reixj2rgnALb0DB3B4kX1/uOZInOSGdyWT2q/FoyXBu5F5dhYGG76g77wIf43HAblhILsx9FnjJb+Ne1Z2pDYc94YmTWQpi2fGYNn4/QBzusyGMmpAcLEAiDQ2H5cQpqwV1itXmrNrnh8gAT5EEi6Vw4ADoeg4GUQ0kO/WbeqQ+6+iuUXZCWS78JyFEP+P/4FqtdUvK9LAC0dkfSvdpWSdoqcz7GfF8dQxuIJXSctlteYmCaS8N/3J5AavOWeFFOpdPSo+IXx9CNXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tt53v70xOJA0UjuAIg6DoUIOgLkza3cZwjing3nJL2c=; b=Gf27jsGfQT64xa4ZJoyjJVNt3MO0czqxiNkCN4a+ppRwIyZDuxGJvXLOF5FZxYheAb7OeGUReSajK38Eq0oY/mO6YmcEfjG0U3o7yvD3sFv5WqPapk1Ev5ENA/78PuoZDx8NDGilSA47HqdpTQ02BRJUgDxtvN6G1Xx0jQENG9M= Received: from MWHPR11MB1950.namprd11.prod.outlook.com (2603:10b6:300:112::16) by CO1PR11MB4803.namprd11.prod.outlook.com (2603:10b6:303:90::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Mon, 19 Apr 2021 08:47:17 +0000 Received: from MWHPR11MB1950.namprd11.prod.outlook.com ([fe80::d8b0:fa76:b9a6:e2d8]) by MWHPR11MB1950.namprd11.prod.outlook.com ([fe80::d8b0:fa76:b9a6:e2d8%8]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 08:47:17 +0000 From: "Steven Shi" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" Subject: Re: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Topic: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Index: AQHXM4RSPO6hagabr0+C2D0ESJz0LKq7hoSAgAABjCA= Date: Mon, 19 Apr 2021 08:47:17 +0000 Message-ID: References: <20210417122133.1879-1-steven.shi@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.222] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d17a2b6-991d-466b-3624-08d9030fbcd7 x-ms-traffictypediagnostic: CO1PR11MB4803: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A+e//rTG2k21SXzSgggv2IY3lujeHht68ud01wDiUYX4wp5KnewLavEpi47fYL0VXQsAdEovWmjVN4tCW40nMjKi9F1qOEu7r2rMs+Fc4WvT6VOnjJfhgFkRZ74PcGGhO1Q+gAti6vV3o6AmlHOo+crq5I95ZOfkzUtRaUyLD0jopOhf9MC4DJjx9FzhyeDRzaDcJbJzC2RjNhGsdIDJjHh0u3k8ydTgHcu0wx1Z4sKKmAVuzoC0pKQKuSXU7vHj9sgq987uDJfqws5BeI4zpu1+DpkD6Ap7TZHP/aNSIv/0N2yNJ30SP3K7Sfe7QwFJbhU8cOW8cDahSieKHPCCtkcxwI3SroO/Xo59CEsLgs1mS1lGI6mvp9S0E857/yXuIKctXUQIa1/u1+aboEGK8SpFO6aFBFBYtb2kWiklOtHTh63fSOVxFWFNb0GAGf55DiOg+ixoRwZdBmH2anpB2wR+kNhpBkshlMTJ8YaUci3pPF7rmCg3sze3uuL25qWPtXariJfR81dfHefnAL4ZG8cizBfBmuMhQmoHvoUtnQGSVOOVdGCT7GrVn2HR11M+8kZm8HVNlgz4dRIlmSy/jaUpvqq5210fBuyCT0SDEB6igPJzU3g/gvwUCecTimBJH85kjjUjh1Rn2yhOTh2zeHediuKw2fKjK3esPZHIXFTGc5jHiBoqT3ocsFpt2PDHiodozOy+Vi0Jfyh5L3vOa9W+e8L6Gfa8rkG4FTAWr4I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1950.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(366004)(39860400002)(346002)(376002)(122000001)(316002)(26005)(110136005)(5660300002)(38100700002)(2906002)(71200400001)(66556008)(9686003)(66446008)(55016002)(64756008)(86362001)(4326008)(186003)(83380400001)(8676002)(52536014)(66476007)(6506007)(966005)(7696005)(76116006)(66946007)(478600001)(33656002)(53546011)(8936002)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?+GWFTWFpavtd7zu5up6lIhra5dcFWH37vLt9Gw3YNve0sh1Qh2aVBb8Ng9TC?= =?us-ascii?Q?CIES8cjrlU9I/2Wvxt/kHXMT4r2Z2A0eOULetg+Hfh51Cc5Mkrk2Ct+HZR9/?= =?us-ascii?Q?AOh8TL51bBB7F6jbg4s69Y/8S4sekMxWt95PLDp4qd++ZLisnbyXt2zUfeRM?= =?us-ascii?Q?u2t8AtNJHVvuBKIsArF0HKrtb6xzu/461+aAbtSNer7nHO08POyf7/+dS2IK?= =?us-ascii?Q?UtXd1EIh/8kA72Q+q6ki9SNqhgV4QqWcyU8pIyKBzjXZ0MsRrL6TUKqeWkL/?= =?us-ascii?Q?aN9MCIiDrUa38/SBRn72in3FE1dUoYPqIHErvx4m0JGHc3+sOQVF0TyYNp9L?= =?us-ascii?Q?Sm/ZE+4793t3kY2zHcdq7YyYMJQ/431RZY1dEERReN/xyEAWGdQbehI/84iU?= =?us-ascii?Q?dVu0/FXeJXxElQFE97ZY2H6VUde/YkfIwZHOKRIhWeSUOCi1He3dUbevVGYu?= =?us-ascii?Q?cAfiSwPVxO5KSBywqJCfurzvBSvIdKk8CJchvDJ/5Nqd8/GNCNDmeurGzkDd?= =?us-ascii?Q?x3zYVnzRzr0dG/oVEAMB80SFyLUBiciARp0kD078ePkPr1Q3RhQThp3Q6QKm?= =?us-ascii?Q?OrAZllso1nLiqQlUVgVCjIwll3OwzGolz7/88cuclTF9T1gWCt/+2WMv7U3x?= =?us-ascii?Q?a2Wm5o7/1y6AO9MfVk09G0pAIhcoecArdBSC0P6S4sHMpMd5LoIJSWG+k9hc?= =?us-ascii?Q?qHeujLpc0A1o0ynvXx+y+a0BxhrfX+rxkvT0ZupKSCSwcklgMnXmAEIlpYHY?= =?us-ascii?Q?nfdms6k64sdDzz/7Lbyj/qebwQe+lVi6VmesBcRT15Q8ilgetM/waRy78sXP?= =?us-ascii?Q?sruiG+t2gsiYyqzQiKit0uBPf6dVuFM1Jo8LapqDeipMh1W+KI5aP73K1hFF?= =?us-ascii?Q?lsFdKNXSKAGZ0geL8xsN9H1HMNUglhxffGFDN1PaoQCM2IG/la9ltHtnwCIf?= =?us-ascii?Q?U3SbqiD3VH4MvxX/6xK6NJ51EliQdfk10LdQVieOzAq2LimmekvKplwxKCyg?= =?us-ascii?Q?jUiW19bIqmqJDk23NJeN/UTx/shqxMFGtKLghEbFd8nGk6808H1nSKwpaNqW?= =?us-ascii?Q?U9Yju5ezR0SzJQWejhRaTimGhw2bJBojGUtrkBVpgXiw1NfncEVJl3o1X86K?= =?us-ascii?Q?P0B48ZlTGp80AGBTVbu5hhwC+myVaPXWdPWdERFqR2zEP8fB+2I2ScnzXYh6?= =?us-ascii?Q?O5WAch1gccSDCTvKlbwdw4IiAhVSIKKuaF0IL4YS5h/t4nnafKXhoSkPu9O6?= =?us-ascii?Q?3cPcXRWJqPjzypUddx5T7bbxF/konynQFaLxg/lt6Yjaryiz5IH47zoZEshw?= =?us-ascii?Q?6I25yY6VTIdfwYPIogGhAs6+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1950.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d17a2b6-991d-466b-3624-08d9030fbcd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 08:47:17.1771 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3O9Iqrezu8JcFwrcnt1puD1ngmUza5BdGGqsuVom4DSud3o7oAN0DsP1or7nNfNOQjwemEoUoBF1wTLdeuy0pQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4803 Return-Path: steven.shi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bob, I tried @set CLANG_BIN=3D"c:\Program Files\LLVM\bin\", but it cannot work w= ith my CI build service. Only the @set "CLANG_BIN=3DC:\Program Files\LLVM\b= in\" can works. So, it is necessary to use double quote around the whole se= tting string, which includes both "=3D" left name and right value parts. =20 Thanks Steven Shi Intel\IAGS\SFP\FIA (Firmware Infrastructure Automation) > -----Original Message----- > From: Feng, Bob C > Sent: Monday, April 19, 2021 4:34 PM > To: Shi, Steven ; devel@edk2.groups.io > Cc: gaoliming@byosoft.com.cn > Subject: RE: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN > path string >=20 > Steven, >=20 > Would you do a little change as >=20 > @set CLANG_BIN=3D"c:\Program Files\LLVM\bin\" >=20 > I think the double quote should be only round the path. >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Shi, Steven > Sent: Saturday, April 17, 2021 8:22 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; gaoliming@byosoft.com.cn; Shi, > Steven > Subject: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path > string >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3341 >=20 > Current CLANG_BIN env variable is set without double quote around the > LLVM default installation path string in windows, which causes some CI bu= ild > service cannot find the LLVM path in windows. > This patch enhance it to add double quote around it. >=20 > Signed-off-by: Steven Shi > Cc: Bob Feng > Cc: Liming Gao > --- > edksetup.bat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/edksetup.bat b/edksetup.bat index 7b9377aaa5c2..7ad137bb3e9b > 100755 > --- a/edksetup.bat > +++ b/edksetup.bat > @@ -120,7 +120,7 @@ if not defined CLANG_BIN ( > @echo. @echo !!! WARNING !!! CLANG_BIN environment variable is n= ot > set @if exist "C:\Program Files\LLVM\bin\clang.exe" (- @set > CLANG_BIN=3DC:\Program Files\LLVM\bin\+ @set > "CLANG_BIN=3DC:\Program Files\LLVM\bin\" @echo Found LLVM, sett= ing > CLANG_BIN environment variable to C:\Program Files\LLVM\bin\ ) )-- > 2.28.0.windows.1