From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.92.41.95]) by mx.groups.io with SMTP id smtpd.web11.34300.1599209037102219386 for ; Fri, 04 Sep 2020 01:43:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hotmail.com header.s=selector1 header.b=QHP8/C8s; spf=pass (domain: hotmail.com, ip: 40.92.41.95, mailfrom: vanjeff_919@hotmail.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SUpv4jFxdQKvUhw/skRK+MgaPKSY4Xed1wfjvyOSpebhNfkkHAh4FWpDWHW9w3Tzq9Td/G1bM7fEKOkxgsferY9L3svUuCRaNMXf3Dbmojb0Rb2rSU5g9N/YbUp+e+XLgTmTmF6pnyMk9lwU39C1v2LXJ2PI+v2YYLe1jtisr4qSaiIKqtugSmkGP11bpBL7WjwiDPQFZkOSmHwDzWex0lGDfgFF1tYa/wZzX7biNkDKSFm6StMQPyTIf2Rgf39yyKIphouwM2wnKmF0h9p313K4e/kadoYjSel3p3kR/12rDu4IjKJXIK5EKATCdSgvKJKkS7AQxva6Z1ZDLLYq7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sYN5NYu0l8HUI9aiO3dKPta7pFdSeDHqWJpKoFBsySY=; b=diqGjAw7OKD8kNc2fPI82x5XbCj1WNFg852rYcBrcibsqzoTYG/uLCAaKZV8JKJD9G+qbnjZOcimvqzN2ZvqppGzQreanvcIQ7JFOUeIyFRrg/hfA6m4T+iuXMfNztjlio6mEROU+E59elVh8qdu/2MtJGtIhYgRqjinOVt3e3eZEc3VozH+hhf9S32RDTL14SDDHO8RsgJQ0cjonjwZTAKWYHsPkuGnA38dIi1YNpgNaEk7rygXT6t6EsWKyY4WAKuGnHeYAGOmC2U1s9NCNOvg9xPqXybuJEy8GBwzmhYLjmGiySsjR6xW+y538Hxp3Ohu7k58XJtQzTSc3lI6RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sYN5NYu0l8HUI9aiO3dKPta7pFdSeDHqWJpKoFBsySY=; b=QHP8/C8sqU0/FmrOsUw8kEeJUVwr3hofTe7psvyDHnZ6u2plqNSSpLWBqkZ8I76csbGG9b2Ikjg0XZrFH4guWIAeFbzM2D38RYbHmzO/4P/hhhXUwnvgd82w0xwnxc//jE0895FrjeO0Jn7Sd2m0WbWRn82clo95vBer+QXLCqtX8VnYHEhOwUNTmhgWQh3aXY9XNMRZqUKQV2DvnzfmyRUqSUv1omn6q/vsx6AP3xjJVuUS8mKu620mBgLuee16I4MGgtIfflZ5DVe3XSA2EpUQ0i2JFA/DjZpk4SJRe31unbiPzC+6vPsZePuNix4vJ/Ri2XAsmeR/HSVstrsKTQ== Received: from DM6PR02CA0094.namprd02.prod.outlook.com (2603:10b6:5:1f4::35) by BYAPR21MB1239.namprd21.prod.outlook.com (2603:10b6:a03:102::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.0; Fri, 4 Sep 2020 08:43:54 +0000 Received: from DM6NAM10FT051.eop-nam10.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::b0) by DM6PR02CA0094.outlook.office365.com (2603:10b6:5:1f4::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16 via Frontend Transport; Fri, 4 Sep 2020 08:43:41 +0000 Received: from MWHPR19MB0030.namprd19.prod.outlook.com (2a01:111:e400:7e86::44) by DM6NAM10FT051.mail.protection.outlook.com (2a01:111:e400:7e86::88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16 via Frontend Transport; Fri, 4 Sep 2020 08:43:41 +0000 Received: from MWHPR19MB0030.namprd19.prod.outlook.com ([fe80::293e:af2:19ca:8470]) by MWHPR19MB0030.namprd19.prod.outlook.com ([fe80::293e:af2:19ca:8470%4]) with mapi id 15.20.3348.017; Fri, 4 Sep 2020 08:43:41 +0000 From: "Fan Jeff" To: "Yao, Jiewen" , "devel@edk2.groups.io" , Laszlo Ersek , "Dong, Eric" , "Ni, Ray" CC: "Lou, Yun" Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBbUEFUQ0ggdjJdIFVlZmlDcHVQa2cvTXBJbml0TGliOiBBZGQgY2hlY2sgZm9yIENSMy9HRFQvSURULg==?= Thread-Topic: =?gb2312?B?u9i4tDogW2VkazItZGV2ZWxdIFtQQVRDSCB2Ml0gVWVmaUNwdVBrZy9NcElu?= =?gb2312?Q?itLib:_Add_check_for_CR3/GDT/IDT.?= Thread-Index: AQHWggSPsVD1Ufr/O0iBw4kxtzfAtalXRPGAgAAPdICAAF6HgIAAB16AgAADd8+AAE+1AIAAAWOrgAARzwCAAAYRIg== Date: Fri, 4 Sep 2020 08:43:41 +0000 Message-ID: References: <20200903151147.1196-1-eric.dong@intel.com> <9c9d8289-4f8e-75d8-2816-750195a54842@redhat.com> , , In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:C46CD376622E9F17467B269039A44707C72CB3EFC9288C15499FCF7AECF69352;UpperCasedChecksum:4C0BDAEF15F0940536C7EAB6EC5615C1DFCBE90C6AAC5480FE58489E3050814A;SizeAsReceived:7841;Count:45 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [1peGq8M0wvtNkkKUxnJonrt+fzMGh/ef] x-ms-publictraffictype: Email x-incomingheadercount: 45 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 776ccb9f-21fb-46ab-08b1-08d850aea037 x-ms-traffictypediagnostic: BYAPR21MB1239: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: svgeAav2tW+QMMQY1rCYXoIJIvLcyEoYl0EEG6rpdFJB9XL5UT/+nqfT1xxMQACq6x29TaNqwRmxgeIv+sgPqin3ek2UcEqXAVdW10AZmszIkMnc7v4tUn65N2WLhw+BsQ/nUC4Jjpi0HgbnMYGgNd9DofvLgUkFv+jraaW//OWkV0dXLhydtA2lSy5Ib6VtmmDTthNmPL+TyMrWHimKoiKZXET5/JyTW9Ok4t3xk4JX/ihlRx7JI+o1pVbdP2xE x-ms-exchange-antispam-messagedata: o1niFgu0IqAFySSzJuT/yb7ukg7otJGOnv2f+q52lZN3Mu+xJ5Baw1oA+GecTbbn0dBy4EiCdVK+IIVueh82/NsiCjx8BzrWPs5vxXU8l915QY5bFm4vaTVYan++T895l8RK8ENVtXBbSowx0upayg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-3174-0-msonline-outlook-fb0b2.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT051.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 776ccb9f-21fb-46ab-08b1-08d850aea037 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2020 08:43:41.4548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR21MB1239 X-Groupsio-MsgNum: 65047 Content-Language: zh-CN Content-Type: multipart/related; boundary="_004_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_"; type="multipart/alternative" --_004_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_ Content-Type: multipart/alternative; boundary="_000_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_" --_000_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Smlld2VuLA0KDQpJIGRvbqGvdCB0aGluayBBUCBuZWVkIHRvIHZhbGlkYXRlIGV2ZXJ5dGluZy4g QlNQIHNob3VsZCBtYWtlIHN1cmUgQ1IzL0dEVC9JRFQgY29ycmVudGx5IGZpcnN0bHkuICBPdGhl cnNpemUsIGV2ZXJ5dGhpbmcgZG9lcyBub3QgbWFrZSBzZW5zZS4NCg0KRm9yIENSMyBjYXNlLCBp ZiB3ZSBhc3N1bWUgQ1IzIGFib3ZlIDRHQiBzcGFjZSBpcyBsZWdhbCBmb3IgQlNQIChJZiB0aGVy ZSBhcmUgYW55IGxpbWl0YXRpb24gb24gaXQsIHBsZWFzZSBjb3JyZW50IG1lKSBidXQgdGhlIGN1 cnJlbnQgQ1BVIEFQIHdha2V1cCBtZXRob2QgZG9lcyBub3QgYWxsb3cgQ1IzIGFib3ZlIDRHQiBz cGFjZSwgdGhpcyBtYXliZSB0aGUgQ1BVIGRyaXZlcqGvcyBidWcgb3IgaW1wbGVtZW50YXRpb24g bGltaXRhdGlvbi4NCg0KVGhlIGtleSBpcyB0aGF0IENSMyBhYm92ZSA0R0IgaXMgbGVnYWwgb3Ig bm90Lg0KSWYgd2UgdGhpbmsgdGhpcyBpcyBidWcsIHdlIG5lZWQgdG8gZW5oYW5jZSBDUFUgZHJp dmVyIHRvIGZpeCBpdC4NCklmIHdlIHRoaW5rIHRoaXMgaXMgb25lIGxpbWlhdGlvbiwgd2UgbmVl ZCB0byB2YWxpZGF0ZSB0aGUgQ1IzIHZhbHVlIGFuZCB0ZWxsIHRoZSBjYWxsZXIuDQoNCkplZmYN Cg0Kt6K8/sjLOiBZYW8sIEppZXdlbjxtYWlsdG86amlld2VuLnlhb0BpbnRlbC5jb20+DQq3osvN yrG85DogMjAyMMTqOdTCNMjVIDE2OjA3DQrK1bz+yMs6IGRldmVsQGVkazIuZ3JvdXBzLmlvPG1h aWx0bzpkZXZlbEBlZGsyLmdyb3Vwcy5pbz47IHZhbmplZmZfOTE5QGhvdG1haWwuY29tPG1haWx0 bzp2YW5qZWZmXzkxOUBob3RtYWlsLmNvbT47IExhc3psbyBFcnNlazxtYWlsdG86bGVyc2VrQHJl ZGhhdC5jb20+OyBEb25nLCBFcmljPG1haWx0bzplcmljLmRvbmdAaW50ZWwuY29tPjsgTmksIFJh eTxtYWlsdG86cmF5Lm5pQGludGVsLmNvbT4NCrOty806IExvdSwgWXVuPG1haWx0bzp5dW4ubG91 QGludGVsLmNvbT4NCtb3zOI6IFJFOiC72Li0OiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyXSBVZWZp Q3B1UGtnL01wSW5pdExpYjogQWRkIGNoZWNrIGZvciBDUjMvR0RUL0lEVC4NCg0KV2hlbiB3ZSBz YXkgobB2YWxpZGF0ZaGxLCB3ZSBuZWVkIGdldCBjbGVhciBvbiB3aGF0IGlzIHRoZSBjb250cmFj dCBiZXR3ZWVuIGNhbGxlciBhbmQgY2FsbGVlLCBhbmQgd2hhdCBpcyB0aGUgZXhwZWN0YXRpb24g b2YgdGhlIHZhbGlkYXRpb24uDQoNCkZvciBleGFtcGxlLCBpbiB0aGlzIGNhc2UsIHRoZSB2YWxp ZGF0aW9uIGlzIGxpbWl0ZWQgdG8gNEcgb3Igbm90IDRHLiBXaHk/DQpUaGlzIGZ1bmN0aW9uIGRv ZXMgbm90IHZlcmlmeSBmb2xsb3dpbmcsIHdoeT8NCg0KICAxLiAgaWYgdGhlIEdEVCB0YWJsZSBp cyB2YWxpZC4NCiAgMi4gIGlmIHRoZSBJRFQgdGFibGUgaXMgdmFsaWQNCiAgMy4gIGlmIHRoZSBl eGNlcHRpb24gaGFuZGxlciBpcyB2YWxpZA0KICA0LiAgaWYgdGhlIHRpbWVyIGhhbmRsZXIgc3Rp bGwgd29ya3MNCiAgNS4gIGlmIHRoZSBwYWdlIHRhYmxlIGlzIHZhbGlkDQogIDYuICBpZiB0aGUg cGFnZSB0YWJsZSBpcyAxOjEgbWFwcGluZw0KICA3LiAgaWYgdGhlIHBhZ2UgdGFibGUgc3RpbGwg ZW5mb3JjZSB0aGUgZXhwZWN0ZWQgcHJvdGVjdGlvbiwgc3VjaCBhcyBSTywgTlgNCiAgOC4gIKGt oa0NCg0KSWYgYW4gYXBwbGljYXRpb24gY3JlYXRlcyBhIGNyYXp5IHN0YXRlLCBDcHVEeGUgbWF5 IHBhc3MgdGhlIHZhbGlkYXRpb24gd2l0aCBiZWxvdyA0RyBwYWdlIHRhYmxlLCBidXQgc3RpbGwg ZmFpbCB0byB3YWtlIHVwIEFQcy4NCg0KSWYgaXQgaXMgdGhlIGFwcKGvcyByZXNwb25zaWJpbGl0 eSB0byBlbnN1cmUgdGhlIHN5c3RlbSBpbiBnb29kIHN0YXRlLCB0aGUgdmFsaWRhdGlvbiBpcyB1 bm5lY2Vzc2FyeS4NCklmIGl0IGlzIHRoZSBDcHVEeGWhr3MgcmVzcG9uc2liaWxpdHkgdG8gZW5z dXJlIHRoZSBzeXN0ZW0gaW4gZ29vZCBzdGF0ZSwgdGhlIHZhbGlkYXRpb24gaXMgaW5zdWZmaWNp ZW50Lg0KDQpJIHRoaW5rIHdlIHNob3VsZCB3YWl0LiBJIGFtIHdvcmtpbmcgd2l0aCBFcmljIHRv IGNvbGxlY3QgdGhlIHJlcXVpcmVtZW50IG9uIHdoeSB0ZXN0IGNhc2UgaXMgZGVzaWduZWQgaW4g dGhpcyB3YXkuDQoNCkRlYnVnQWdlbnREeGUgaXMgYSBnb29kIGNhc2UuIEl0IGlzIGZvciBkZWJ1 ZyBwdXJwb3NlLg0KSSBiZWxpZXZlIHRoZXJlIG11c3QgYmUgY29udHJhY3QgYmV0d2VlbiBDUFUg ZHJpdmVyIGFuZCBEZWJ1Z0FnZW50RHhlIHRoYXQgd2hpY2ggc3RhdHVzIERlYnVnQWdlbnREeGUg bWF5IG1vZGlmeSBhbmQgd2hpY2ggc3RhdGUgRGVidWdBZ2VudER4ZSBtYXkgbm90Lg0KSXQgaXMg RGVidWdBZ2VudER4ZaGvcyByZXNwb25zaWJpbGl0eSB0byBlbnN1cmUgdGhlIG5ldyBzeXN0ZW0g c3RhdGUgaXMgY29ycmVjdCBhbmQgY29tcGF0aWJsZSB3aXRoIHRoZSBDUFUgZHJpdmVyLg0KV2l0 aCB0aGUgY29udHJhY3QsIEkgZG9uoa90IHRoaW5rIENQVSBkcml2ZXIgbmVlZCB2YWxpZGF0ZSB0 aGUgc3lzdGVtIHN0YXRlIGNoYW5nZWQgYnkgRGVidWdBZ2VudER4ZS4NCklmIERlYnVnQWdlbnRE eGUgcHV0IHN5c3RlbSBpbiBhIHdyb25nIHN0YXRlLCBDUFVEcml2ZXIgaGFzIG5vIGNoYW5jZSB0 byBydW4uDQoNCg0KDQoNCkZyb206IGRldmVsQGVkazIuZ3JvdXBzLmlvIDxkZXZlbEBlZGsyLmdy b3Vwcy5pbz4gT24gQmVoYWxmIE9mIEZhbiBKZWZmDQpTZW50OiBGcmlkYXksIFNlcHRlbWJlciA0 LCAyMDIwIDM6MzIgUE0NClRvOiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPjsgZGV2 ZWxAZWRrMi5ncm91cHMuaW87IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRlbC5jb20+OyBOaSwg UmF5IDxyYXkubmlAaW50ZWwuY29tPg0KQ2M6IExvdSwgWXVuIDx5dW4ubG91QGludGVsLmNvbT4N ClN1YmplY3Q6ILvYuLQ6ILvYuLQ6IFtlZGsyLWRldmVsXSBbUEFUQ0ggdjJdIFVlZmlDcHVQa2cv TXBJbml0TGliOiBBZGQgY2hlY2sgZm9yIENSMy9HRFQvSURULg0KDQpMYXN6bG8sDQoNCldoeSBz eW5jIHRoZSBCU1Chr3MgQ1IzL0dEVC9JRFQgdmFsdWVzIGZvciBBUCB3aGVuIEFQIHdha2VzIHVw IGluc3RlYWQgb2YgdXNpbmcgb2xkIGNhY2hlZCBCU1Chr3MgQ1IzL0dEVC9JRFQgdmFsdWVzIHdo ZW4gQ1BVIGRyaXZlciBpbml0aWFsbGx5IGRpc3BhdGNoZWQgaXMgdGhhdCB3ZSBDQU5OT1QgYXNz dW1lIG9yaWdpbmFsIHZhbHVlcyBhcmUgc3RpbGwgdmFsaWQgZHVyaW5nIFBPU1QgcGhhc2UuDQoN Ck9uIHRoaXMgc2VuYXJpbywgQlNQoa9zIENSMy9HRFQvSURUIGFyZSBqdXN0IGxpa2UgaW5wdXQg cGFyYW1ldGVycyBmb3Igb25lIGZ1bmN0aW9uLiBWYWxpZGF0aW5nIHRoZW0gYXJlIG5lY2Vzc2Fy eS4NCg0KRm9yIGV4YW1wbGUsIERlYnVnQWdlbnREeGUgZHJpdmVyIG1heSBiZSBsb2FkZWQgaW4g VUVGSSBzaGVsbCB0byBzZXR1cCBzb3VyY2UgbGV2ZWwgZGVidWdnaW5nIGVudmlyb21lbnQgb2Yg RURLSUkgZGVidWdnZXIgdG9vbHMuICBJdCBtYXkgc2V0dXAgbmV3IElEVCBzcGFjZS4NCg0KSmVm Zg0KDQq3orz+yMs6IExhc3psbyBFcnNlazxtYWlsdG86bGVyc2VrQHJlZGhhdC5jb20+DQq3osvN yrG85DogMjAyMMTqOdTCNMjVIDE0OjU4DQrK1bz+yMs6IEZhbiBKZWZmPG1haWx0bzp2YW5qZWZm XzkxOUBob3RtYWlsLmNvbT47IGRldmVsQGVkazIuZ3JvdXBzLmlvPG1haWx0bzpkZXZlbEBlZGsy Lmdyb3Vwcy5pbz47IGVyaWMuZG9uZ0BpbnRlbC5jb208bWFpbHRvOmVyaWMuZG9uZ0BpbnRlbC5j b20+OyBOaSwgUmF5PG1haWx0bzpyYXkubmlAaW50ZWwuY29tPg0Ks63LzTogTG91LCBZdW48bWFp bHRvOnl1bi5sb3VAaW50ZWwuY29tPg0K1vfM4jogUmU6ILvYuLQ6IFtlZGsyLWRldmVsXSBbUEFU Q0ggdjJdIFVlZmlDcHVQa2cvTXBJbml0TGliOiBBZGQgY2hlY2sgZm9yIENSMy9HRFQvSURULg0K DQpPbiAwOS8wNC8yMCAwNDoxOCwgRmFuIEplZmYgd3JvdGU6DQo+IExhc3psbyAmIEVyaWMsDQo+ DQo+IEludHJvZHVjaW5nIG9uZSBuZXcgUENEIHRvIGhhbmRsZSBzdWNoIHJhcmUgdGVzdCBjYXNl IGlzIHRvbyBoZWF2eS4gSSB0aGluayBXZSBjb3VsZCBkbyB2YWxpZGF0aW5nIENSMy9HRFQvSURU IHNwYWNlIDwgNEdCIGFkZHJlc3MgYWx3YXlzIGluIE1wSW5pdExpYi4NCg0KSSBkaXNhZ3JlZS4N Cg0KV2hhdCB0aGUgVUVGSSBhcHBsaWNhdGlvbiBkb2VzIChpbnRlcmZlcmUgd2l0aCBHRFQgLyBJ RFQgLyBDUjMNCnBsYWNlbWVudCkgaXMgaW52YWxpZC4gSXQgY2hhbmdlcyBzeXN0ZW0gcHJvcGVy dGllcyB1bmRlciB0aGUgZmVldCBvZg0KcGxhdGZvcm0gRFhFIGRyaXZlcnMuIFVFRkkgYXBwbGlj YXRpb25zIGFyZSBzdXBwb3NlZCB0byBiZSB3cml0dGVuDQphZ2FpbnN0IHB1YmxpYyBwcm90b2Nv bHMgYW5kIHNlcnZpY2VzIGluIHRoZSBVRUZJIHNwZWMgKGFuZCBtYXliZSBpbiB0aGUNClBJIHNw ZWMpLg0KDQpJZiB0aGlzIGFwcGxpY2F0aW9uIGlzIGEgdGVzdCBhcHBsaWNhdGlvbiB0aGF0IHB1 cnBvc2VseSBtYXNzYWdlcw0KbG93LWxldmVsIHN5c3RlbSBwcm9wZXJ0aWVzLCB0aGF0J3MgZmlu ZTsgYnV0IHRoZW4sIGlmIHdlIGNoYW5nZSBjb3JlDQplZGsyIGNvbXBvbmVudHMgdG8gYmUgc29t ZXdoYXQgY29tcGF0aWJsZSB3aXRoIHRoaXMgYXBwbGljYXRpb24sIHRoZW4gd2UNCnNob3VsZCBt YWtlIHN1cmUgdGhhdCBwbGF0Zm9ybXMgdGhhdCBkbyBub3QgY2FyZSBhYm91dCB0aGlzIHNwZWNp ZmljIHVzZQ0KY2FzZSBkbyBub3Qgc3VmZmVyIGEgcGVyZm9ybWFuY2UgaGl0IG9yIGEgY29kZSBj b21wbGV4aXR5IGhpdC4NCg0KV2hhdCBJIGNvdWxkIGFjY2VwdCwgdW5kZXIgeW91ciBwcm9wb3Nh bCwgaXMgdGhlIGZvbGxvd2luZzogYWRkIHRocmVlDQpBU1NFUlQoKXMgdG8gRmlsbEV4Y2hhbmdl SW5mb0RhdGEoKSwgd2hlcmUgd2UgZmV0Y2ggdGhlIElEVFIgLyBHRFRSIC8NCkNSMyBhbnl3YXku IFRoaXMgd291bGQgYmUgZmluZSBiZWNhdXNlIGl0IG9ubHkgZXhwcmVzc2VzIGV4aXN0aW5nDQph c3N1bXB0aW9ucyAvIHJlcXVpcmVtZW50cy4NCg0KSG93ZXZlciwgbXkgdW5kZXJzdGFuZGluZyBp cyB0aGF0IHRoaXMgd291bGQgbm90IHNvbHZlIEVyaWMncyBwcm9ibGVtLg0KVGhlIHN5c3RlbSB3 b3VsZCBoYW5nIC0tIGluIERFQlVHIC8gTk9PUFQgYnVpbGRzIC0tIG9yIGNyYXNoIC0tIGluIGEN ClJFTEVBU0UgYnVpbGQgLS0ganVzdCB0aGUgc2FtZSBhcyBiZWZvcmUuDQoNCk5vdywgKmlmKiBG aWxsRXhjaGFuZ2VJbmZvRGF0YSgpIGlzIGN1cnJlbnRseSAqd3JvbmcqIHRvIGhhdmUgdGhlc2UN CjMyLWJpdCBhc3N1bXB0aW9ucywgYmVjYXVzZSBlZGsyIG1vZHVsZXMgdGhlbXNlbHZlcyBjYW4g YnJlYWsgdGhvc2UNCmFzc3VtcHRpb25zICh3aXRob3V0IHRoZSBjdXN0b20gVUVGSSBhcHBsaWNh dGlvbiksIHRoZW4gd2UgaGF2ZSBhIG1vcmUNCnNlcmlvdXMgcHJvYmxlbS4gQnV0IGZvciB0aGF0 IHByb2JsZW0sIGp1c3QgImNoZWNraW5nIGFuZCByZWplY3RpbmciIGlzDQpub3QgYSBzdWZmaWNp ZW50IHNvbHV0aW9uLCByZWdhcmRsZXNzIG9mIGhvdyBhbmQgd2hlcmUgd2UgY2hlY2sgYW5kIHJl amVjdC4NCg0KVGhhbmtzDQpMYXN6bG8NCg0KDQoNCg0KPg0KPiBKZWZmDQo+DQo+ILeivP7Iyzog RG9uZywgRXJpYzxtYWlsdG86ZXJpYy5kb25nQGludGVsLmNvbT4NCj4gt6LLzcqxvOQ6IDIwMjDE 6jnUwjTI1SAxMDowMQ0KPiDK1bz+yMs6IE5pLCBSYXk8bWFpbHRvOnJheS5uaUBpbnRlbC5jb20+ OyBkZXZlbEBlZGsyLmdyb3Vwcy5pbzxtYWlsdG86ZGV2ZWxAZWRrMi5ncm91cHMuaW88bWFpbHRv OmRldmVsQGVkazIuZ3JvdXBzLmlvJTNjbWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvPj47IGxl cnNla0ByZWRoYXQuY29tPG1haWx0bzpsZXJzZWtAcmVkaGF0LmNvbT4NCj4gs63LzTogTG91LCBZ dW48bWFpbHRvOnl1bi5sb3VAaW50ZWwuY29tPg0KPiDW98ziOiBSZTogW2VkazItZGV2ZWxdIFtQ QVRDSCB2Ml0gVWVmaUNwdVBrZy9NcEluaXRMaWI6IEFkZCBjaGVjayBmb3IgQ1IzL0dEVC9JRFQu DQo+DQo+IEkgZ3Vlc3MgTGFzemxvIHRoaW5rIHRoaXMgY2hlY2sgaXMgbm90IGFsd2F5cyBuZWVk ZWQsIGp1c3QgdXNlZCBmb3IgdGhpcyBzcGVjaWFsIHNoZWxsIGFwcGxpY2F0aW9uIGNhc2UuIEhl IHdhbnRzIHRvIHVzZSBkZWZhdWx0IEZBTFNFIHRvIGFsd2F5cyBpZ25vcmUgdGhpcyBjaGVjayBh bmQgbWFrZSBjb2RlIGxvZ2ljIGNsZWFyLg0KPg0KPiBUaGFua3MsDQo+IEVyaWMNCj4NCj4gRnJv bTogTmksIFJheSA8cmF5Lm5pQGludGVsLmNvbTxtYWlsdG86cmF5Lm5pQGludGVsLmNvbT4+DQo+ IFNlbnQ6IEZyaWRheSwgU2VwdGVtYmVyIDQsIDIwMjAgOTozNCBBTQ0KPiBUbzogZGV2ZWxAZWRr Mi5ncm91cHMuaW88bWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvPjsgbGVyc2VrQHJlZGhhdC5j b208bWFpbHRvOmxlcnNla0ByZWRoYXQuY29tPjsgRG9uZywgRXJpYyA8ZXJpYy5kb25nQGludGVs LmNvbTxtYWlsdG86ZXJpYy5kb25nQGludGVsLmNvbT4+DQo+IENjOiBMb3UsIFl1biA8eXVuLmxv dUBpbnRlbC5jb208bWFpbHRvOnl1bi5sb3VAaW50ZWwuY29tPj4NCj4gU3ViamVjdDogUmU6IFtl ZGsyLWRldmVsXSBbUEFUQ0ggdjJdIFVlZmlDcHVQa2cvTXBJbml0TGliOiBBZGQgY2hlY2sgZm9y IENSMy9HRFQvSURULg0KPg0KPiBXaHkgZG8gd2UgbmVlZCBhIG5ldyBQQ0QgdG8gY29udHJvbCBz dWNoIGNoZWNrPyBVbmRlciB3aGF0IGNpcmN1bXN0YW5jZSB0aGUgUENEIGlzIGZhbHNlPw0KPiBX ZSBtYXkgbmVlZCB0byBtb3ZlIHN1Y2ggY2hlY2sgb3V0IG9mIE1wTGliLmMuIEJlY2F1c2Ugd2hl biBicHMgcnVucyBhdCAzMmJpdCBtb2RlLCBBUCBkb2VzbqGvdCBuZWVkIHRvIHN3aXRjaCB0byBs b25nIG1vZGUsIHN1Y2ggY2hlY2sgaXMgbm90IG5lZWRlZCBhbmQgYWxzbyBhbHdheXMgcGFzc2Vz Lg0KPg0KPiBXZSBzaG91bGQgbm90IGFzc3VtZSBQRUkgcnVucyBhdCAzMiBiaXQgbW9kZS4NCj4N Cj4NCj4gt6K8/sjLOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbzxtYWlsdG86ZGV2ZWxAZWRrMi5ncm91 cHMuaW88bWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvJTNjbWFpbHRvOmRldmVsQGVkazIuZ3Jv dXBzLmlvPj4gPGRldmVsQGVkazIuZ3JvdXBzLmlvPG1haWx0bzpkZXZlbEBlZGsyLmdyb3Vwcy5p bzxtYWlsdG86ZGV2ZWxAZWRrMi5ncm91cHMuaW8lM2NtYWlsdG86ZGV2ZWxAZWRrMi5ncm91cHMu aW8+Pj4gtPqx7SBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPG1haWx0bzpsZXJzZWtA cmVkaGF0LmNvbTxtYWlsdG86bGVyc2VrQHJlZGhhdC5jb20lM2NtYWlsdG86bGVyc2VrQHJlZGhh dC5jb20+Pj4NCj4gt6LLzcqxvOQ6IEZyaWRheSwgU2VwdGVtYmVyIDQsIDIwMjAgMzo1NTo0NyBB TQ0KPiDK1bz+yMs6IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRlbC5jb208bWFpbHRvOmVyaWMu ZG9uZ0BpbnRlbC5jb208bWFpbHRvOmVyaWMuZG9uZ0BpbnRlbC5jb20lM2NtYWlsdG86ZXJpYy5k b25nQGludGVsLmNvbT4+PjsgZGV2ZWxAZWRrMi5ncm91cHMuaW88bWFpbHRvOmRldmVsQGVkazIu Z3JvdXBzLmlvPG1haWx0bzpkZXZlbEBlZGsyLmdyb3Vwcy5pbyUzY21haWx0bzpkZXZlbEBlZGsy Lmdyb3Vwcy5pbz4+IDxkZXZlbEBlZGsyLmdyb3Vwcy5pbzxtYWlsdG86ZGV2ZWxAZWRrMi5ncm91 cHMuaW88bWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvJTNjbWFpbHRvOmRldmVsQGVkazIuZ3Jv dXBzLmlvPj4+DQo+ILOty806IE5pLCBSYXkgPHJheS5uaUBpbnRlbC5jb208bWFpbHRvOnJheS5u aUBpbnRlbC5jb208bWFpbHRvOnJheS5uaUBpbnRlbC5jb20lM2NtYWlsdG86cmF5Lm5pQGludGVs LmNvbT4+Pg0KPiDW98ziOiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSCB2Ml0gVWVmaUNwdVBrZy9N cEluaXRMaWI6IEFkZCBjaGVjayBmb3IgQ1IzL0dEVC9JRFQuDQo+DQo+IE9uIDA5LzAzLzIwIDIx OjAwLCBMYXN6bG8gRXJzZWsgd3JvdGU6DQo+DQo+PiAoMTApIE1vcmUgaW1wb3J0YW50bHksIFZh bGlkQ1IzR2R0SWR0Q2hlY2soKSBzaG91bGQgbm90IGJlIGNhbGxlZCBpbiB0aGUNCj4+IFdvcmtl ciBmdW5jdGlvbnMgZm9yIFN0YXJ0dXBBbGxBUHMsIFN0YXJ0dXBUaGlzQVAsIFN3aXRjaEJTUCwg YW5kDQo+PiBFbmFibGVEaXNhYmxlQVAsIGluICJVZWZpQ3B1UGtnL0xpYnJhcnkvTXBJbml0TGli L01wTGliLmMiLg0KPj4NCj4+IEluc3RlYWQsIHRoZSBjYWxscyBzaG91bGQgYmUgbWFkZSBpbiB0 aGUgRFhFIGluc3RhbmNlIG9mIHRoZSBsaWJyYXJ5DQo+PiAoIlVlZmlDcHVQa2cvTGlicmFyeS9N cEluaXRMaWIvRHhlTXBMaWIuYyIpLCBhdCB0aGUgdmVyeSB0b3Agb2YgdGhlDQo+PiBmdW5jdGlv bnM6DQo+Pg0KPj4gLSBNcEluaXRMaWJTdGFydHVwQWxsQVBzDQo+PiAtIE1wSW5pdExpYlN0YXJ0 dXBUaGlzQVANCj4+IC0gTXBJbml0TGliU3dpdGNoQlNQDQo+PiAtIE1wSW5pdExpYkVuYWJsZURp c2FibGVBUA0KPj4NCj4+IEhlcmUncyB3aHk6DQo+Pg0KPj4gKGEpIFRoZSBzeW1wdG9tIGRvZXMg bm90IGFmZmVjdCB0aGUgUEVJIHBoYXNlIC0tIGJ5IHRoZSB0aW1lIHRoZSBVRUZJDQo+PiBhcHBs aWNhdGlvbiBpcyBleGVjdXRlZCwgdGhlIFBFSSBwaGFzZSBoYXMgZW5kZWQ7IHRoZXJlJ3Mgbm8g bmVlZCB0bw0KPj4gbW9kaWZ5IHRoZSBQRUkgaW5zdGFuY2Ugb2YgdGhlIGxpYnJhcnkuDQo+Pg0K Pj4gKGIpIFRoZSBjdXJyZW50bHkgcHJvcG9zZWQgZmFpbHVyZSBleGl0cyBhcmUgdG9vIGxhdGUu IEZvciBleGFtcGxlLCBpbg0KPj4gdGhlIFN3aXRjaEJTUFdvcmtlcigpIGZ1bmN0aW9uLCBieSB0 aGUgdGltZSB3ZSBleGl0LCB3ZSBoYXZlIGNhbGxlZA0KPj4gRGlzYWJsZUFwaWNUaW1lckludGVy cnVwdCgpLCBTYXZlQW5kRGlzYWJsZUludGVycnVwdHMoKSwgYW5kDQo+PiBEaXNhYmxlTHZ0SW50 ZXJydXB0cygpIC0tIGFuZCB0aGUgZXJyb3IgcGF0aCBkb2VzIG5vdCByZXN0b3JlIHRoZQ0KPj4g b3JpZ2luYWwgZW52aXJvbm1lbnQuDQo+Pg0KPj4gKGMpIEFjY29yZGluZyB0byB0aGUgUEkgc3Bl YyAodjEuNyksIHRoZSBTdGFydHVwQWxsQVBzKCksDQo+PiBTdGFydHVwVGhpc0FQKCksIFN3aXRj aEJTUCgpLCBFbmFibGVEaXNhYmxlQVAoKSBtZW1iZXIgZnVuY3Rpb25zIG9mDQo+PiBFRklfTVBf U0VSVklDRVNfUFJPVE9DT0wgbWF5IG9ubHkgYmUgY2FsbGVkIG9uIHRoZSAoY3VycmVudCkgQlNQ Lg0KPj4gQmVjYXVzZSBvZiB0aGlzLCBpdCBpcyBPSyB0byBjYWxsIFZhbGlkQ1IzR2R0SWR0Q2hl Y2soKSBhcyB0aGUgdmVyeQ0KPj4gZmlyc3QgYWN0aW9uIGluIHRoZSBhYm92ZS1saXN0ZWQgRHhl TXBMaWIgZnVuY3Rpb25zLg0KPj4NCj4+IChBc3N1bWluZyB0aGUgcHJvdG9jb2wgbWVtYmVycyBh cmUgY2FsbGVkIGZyb20gYW4gQVAsIGFuZCBjb25zZXF1ZW50bHkNCj4+IHdlIGNoZWNrIENSMyAv IEdEVFIgLyBJRFRSIG9uIHRoZSBBUCAoYW5kIG5vdCBvbiB0aGUgQlNQKSwgdGhhdCdzIHRoZQ0K Pj4gKmNhbGxlcidzKiBmYXVsdCwgcGVyIHNwZWMhKQ0KPg0KPiBUaGlzIG1lYW5zIHdlIGNhbiBt b3ZlIHRoZSBWYWxpZENyM0dkdElkdENoZWNrKCkgZnVuY3Rpb24gdG8NCj4gIkR4ZU1wTGliLmMi LCBhbmQgaXQgaXMgbm90IG5lY2Vzc2FyeSB0byBtb2RpZnkgIk1wTGliLmgiLg0KPg0KPiBUaGFu a3MNCj4gTGFzemxvDQo+ID4NCg0KDQoNCg== --_000_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Jiewen,

 

I don=A1=AFt think AP need to = validate everyting. BSP should make sure CR3/GDT/IDT corrently firstly.&nbs= p; Othersize, everything does not make sense.

 

For CR3 case, if we assume CR3= above 4GB space is legal for BSP (If there are any limitation on it, pleas= e corrent me) but the current CPU AP wakeup method does not allow CR3 above= 4GB space, this maybe the CPU driver=A1=AFs bug or implementation limitation.

 

The key is that CR3 above 4GB = is legal or not.

If we think this is bug, we ne= ed to enhance CPU driver to fix it.

If we think this is one limiat= ion, we need to validate the CR3 value and tell the caller.

 

Jeff

 

=B7=A2=BC=FE= =C8=CB: Yao, Jiew= en
=B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA9=D4=C24=C8=D5 16:07
=CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; vanjeff_919@hotmail.com; Laszlo Ersek; Dong, Eric; <= a href=3D"mailto:ray.ni@intel.com"> Ni, Ray
=B3=AD=CB=CD: Lou, Yun
=D6=F7=CC=E2: RE: =BB=D8=B8=B4: [edk2-devel] [PATCH v2] Ue= fiCpuPkg/MpInitLib: Add check for CR3/GDT/IDT.

 

When we say =A1=B0validate=A1=B1, w= e need get clear on what is the contract between caller and callee, and wha= t is the expectation of the validation.

 

For example, in this case, the vali= dation is limited to 4G or not 4G. Why?

This function does not verify follo= wing, why?

  1. if the GDT table is valid.
  2. if the IDT table is valid
  3. if the exception handler is valid<= o:p>
  4. if the timer handler still work= s
  5. if the page table is valid
  6. if the page table is 1:1 mapping<= o:p>
  7. if the page table still enforce= the expected protection, such as RO, NX
  8. =A1=AD=A1=AD

 

If an application creates a crazy s= tate, CpuDxe may pass the validation with below 4G page table, but still fa= il to wake up APs.

 

If it is the app=A1=AFs responsibil= ity to ensure the system in good state, the validation is unnecessary.=

If it is the CpuDxe=A1=AFs responsi= bility to ensure the system in good state, the validation is insufficient.<= o:p>

 

I think we should wait. I am workin= g with Eric to collect the requirement on why test case is designed in this= way.

 

DebugAgentDxe is a good case. It is= for debug purpose.

I believe there must be contract be= tween CPU driver and DebugAgentDxe that which status DebugAgentDxe may modi= fy and which state DebugAgentDxe may not.

It is DebugAgentDxe=A1=AFs responsi= bility to ensure the new system state is correct and compatible with the CP= U driver.

With the contract, I don=A1=AFt thi= nk CPU driver need validate the system state changed by DebugAgentDxe.=

If DebugAgentDxe put system in a wr= ong state, CPUDriver has no chance to run.

 

 

 

 

From: devel@edk2.groups.io <devel@ed= k2.groups.io> On Behalf Of Fan Jeff
Sent: Friday, September 4, 2020 3:32 PM
To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; D= ong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
Cc: Lou, Yun <yun.lou@intel.com>
Subject: =BB=D8=B8=B4: =BB=D8=B8=B4: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Add che= ck for CR3/GDT/IDT.

 

Laszlo,

 

Why sync the BSP=A1=AF<= span lang=3D"EN-US">s CR3/GDT/IDT values for AP when AP wakes up instead of= using old cached BSP=A1=AFs CR3/GDT/IDT values= when CPU driver initiallly dispatched is that we CANNOT assume original values are still valid during POST phase.

 

On this senario, BSP=A1= = =AFs CR3/GDT/IDT are just like input parameters for o= ne function. Validating them are necessary.

 

For example, DebugAgentDxe dri= ver may be loaded in UEFI shell to setup source level debugging enviroment = of EDKII debugger tools.  It may setup new IDT space.

 

Jeff

 

=B7=A2=BC=FE=C8=CB: = Laszlo Ersek<= /a>
=B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA9=D4=C24=C8=D5 14:58
=CA=D5=BC=FE=C8=CB: Fan Jeff; devel@edk2.groups.io; eric.dong@intel.com; Ni, Ray =B3=AD=CB=CD: Lou, Yun
=D6=F7=CC=E2: Re: =BB=D8=B8=B4: [edk2-devel] [PATCH v2] Ue= fiCpuPkg/MpInitLib: Add check for CR3/GDT/IDT.

 

On 09/04/20 04:18, Fan Jeff wrote:
> Laszlo & Eric,
>
> Introducing one new PCD to handle such rare test case is too heavy. I= think We could do validating CR3/GDT/IDT space < 4GB address always in = MpInitLib.

I disagree.

What the UEFI application does (interfere with GDT / IDT / CR3
placement) is invalid. It changes system properties under the feet of
platform DXE drivers. UEFI applications are supposed to be written
against public protocols and services in the UEFI spec (and maybe in the PI spec).

If this application is a test application that purposely massages
low-level system properties, that's fine; but then, if we change core
edk2 components to be somewhat compatible with this application, then we should make sure that platforms that do not care about this specific use case do not suffer a performance hit or a code complexity hit.

What I could accept, under your proposal, is the following: add three
ASSERT()s to FillExchangeInfoData(), where we fetch the IDTR / GDTR /
CR3 anyway. This would be fine because it only expresses existing
assumptions / requirements.

However, my understanding is that this would not solve Eric's problem.
The system would hang -- in DEBUG / NOOPT builds -- or crash -- in a
RELEASE build -- just the same as before.

Now, *if* FillExchangeInfoData() is currently *wrong* to have these
32-bit assumptions, because edk2 modules themselves can break those
assumptions (without the custom UEFI application), then we have a more
serious problem. But for that problem, just "checking and rejecting&q= uot; is
not a sufficient solution, regardless of how and where we check and reject= .

Thanks
Laszlo




>
> Jeff
>
> =B7=A2=BC=FE=C8=CB: Dong, Eric<mailto:eric.don= g@intel.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA9=D4=C24=C8=D5 10:01
> =CA=D5=BC=FE=C8=CB: Ni, Ray<mailto:ray.ni@intel.com>; deve= l@edk2.groups.io<mailto:devel@edk2.groups.io>; lersek@redhat.com&= lt;mailto:lersek@redhat.com>
> =B3=AD=CB=CD: Lou, Yun<mailto:yun.lou@intel.com>
> =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Add check for CR3/G= DT/IDT.
>
> I guess Laszlo think this check is not always needed, just used for t= his special shell application case. He wants to use default FALSE to always= ignore this check and make code logic clear.
>
> Thanks,
> Eric
>
> From: Ni, Ray <ray.ni@intel.co= m>
> Sent: Friday, September 4, 2020 9:34 AM
> To: devel@edk2.groups.io;= lersek@redhat.com; Dong, Eric <eric.dong@intel.com>
> Cc: Lou, Yun <yun.lou@intel.c= om>
> Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Add check = for CR3/GDT/IDT.
>
> Why do we need a new PCD to control such check? Under what circumstan= ce the PCD is false?
> We may need to move such check out of MpLib.c. Because when bps runs = at 32bit mode, AP doesn=A1=AFt need to switch t= o long mode, such check is not needed and also always passes.
>
> We should not assume PEI runs at 32 bit mode.
>
>
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.grou= ps.io<mailto:devel@edk2.groups.io>> =B4=FA=B1=ED Laszlo Ersek <lersek@redhat.com<mailto= :lersek@redhat.com>>
> =B7=A2=CB=CD=CA=B1=BC=E4: Friday, Septemb= er 4, 2020 3:55:47 AM
> =CA=D5=BC=FE=C8=CB: Dong, Eric <eric.dong@int= el.com<mailto:eric.dong@intel.com>>; deve= l@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io= <mailto:devel@edk2.groups.io>>
> =B3=AD=CB=CD: Ni, Ray <ray.ni@intel.com<mailto:r= ay.ni@intel.com>>
> =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v2]= UefiCpuPkg/MpInitLib: Add check for CR3/GDT/IDT.
>
> On 09/03/20 21:00, Laszlo Ersek wrote:
>
>> (10) More importantly, ValidCR3GdtIdtCheck() should not be called= in the
>> Worker functions for StartupAllAPs, StartupThisAP, SwitchBSP, and=
>> EnableDisableAP, in "UefiCpuPkg/Library/MpInitLib/MpLib.c&qu= ot;.
>>
>> Instead, the calls should be made in the DXE instance of the libr= ary
>> ("UefiCpuPkg/Library/MpInitLib/DxeMpLib.c"), at the ver= y top of the
>> functions:
>>
>> - MpInitLibStartupAllAPs
>> - MpInitLibStartupThisAP
>> - MpInitLibSwitchBSP
>> - MpInitLibEnableDisableAP
>>
>> Here's why:
>>
>> (a) The symptom does not affect the PEI phase -- by the time the = UEFI
>> application is executed, the PEI phase has ended; there's no need= to
>> modify the PEI instance of the library.
>>
>> (b) The currently proposed failure exits are too late. For exampl= e, in
>> the SwitchBSPWorker() function, by the time we exit, we have call= ed
>> DisableApicTimerInterrupt(), SaveAndDisableInterrupts(), and
>> DisableLvtInterrupts() -- and the error path does not restore the=
>> original environment.
>>
>> (c) According to the PI spec (v1.7), the StartupAllAPs(),
>> StartupThisAP(), SwitchBSP(), EnableDisableAP() member functions = of
>> EFI_MP_SERVICES_PROTOCOL may only be called on the (current) BSP.=
>> Because of this, it is OK to call ValidCR3GdtIdtCheck() as the ve= ry
>> first action in the above-listed DxeMpLib functions.
>>
>> (Assuming the protocol members are called from an AP, and consequ= ently
>> we check CR3 / GDTR / IDTR on the AP (and not on the BSP), that's= the
>> *caller's* fault, per spec!)
>
> This means we can move the ValidCr3GdtIdtCheck() function to
> "DxeMpLib.c", and it is not necessary to modify "MpLib= .h".
>
> Thanks
> Laszlo
> >

 

 

--_000_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_-- --_004_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_ Content-Type: image/png; name="154E6E9E578E47869D1F0A70DF84BCF0.png" Content-Description: 154E6E9E578E47869D1F0A70DF84BCF0.png Content-Disposition: inline; filename="154E6E9E578E47869D1F0A70DF84BCF0.png"; size=144; creation-date="Fri, 04 Sep 2020 08:43:40 GMT"; modification-date="Fri, 04 Sep 2020 08:43:40 GMT" Content-ID: Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAsQAAAACCAYAAABfe8oDAAAAAXNSR0IArs4c6QAAAARnQU1BAACx jwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAAAlSURBVFhH7cMBDQAACAMg+5cygQkeRoMIGwUA AK/1ZFVV9efsAW0/ZqCCeHKlAAAAAElFTkSuQmCC --_004_MWHPR19MB003023A788ADAEAE2D616D29D72D0MWHPR19MB0030namp_--