From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.42.139; helo=nam03-by2-obe.outbound.protection.outlook.com; envelope-from=jerecox@microsoft.com; receiver=edk2-devel@lists.01.org Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0139.outbound.protection.outlook.com [104.47.42.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 52A5F2116373F for ; Fri, 19 Oct 2018 09:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n6+2QRQFAmnrFkhMPGX5EjeIg8wk0fCw5yF+bosF0OY=; b=RFjgEkU5U61O1JXD7lJUiEjkDi4gE4aPb8rtkHqP9Xp/+GV7DvaenQ3IdwsnWdHqu6OA6oGfejNnqLXQl4ObnReYygoZ8B+wiIk5aY0tQTlSgB1cPl4l23gp262BooljZrlXpYwOSNTv3l922kzZQSLIoy3j5Wj6SzwAcnYihQw= Received: from MWHPR21MB0176.namprd21.prod.outlook.com (10.173.52.22) by MWHPR21MB0128.namprd21.prod.outlook.com (10.173.52.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.5; Fri, 19 Oct 2018 16:21:23 +0000 Received: from MWHPR21MB0176.namprd21.prod.outlook.com ([fe80::8817:5ea6:f97f:aa10]) by MWHPR21MB0176.namprd21.prod.outlook.com ([fe80::8817:5ea6:f97f:aa10%2]) with mapi id 15.20.1250.004; Fri, 19 Oct 2018 16:21:23 +0000 From: Jeremiah Cox To: "Kinney, Michael D" , stephano , Andrew Fish CC: "Carsey, Jaben" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] Community Discussion: General Code and Commit message standards Thread-Index: AQHUZsLGMYbE7wUBN0+GNViqgMBN56UlDncAgAAYY4CAAA8LAIAAB7EAgAAC1QCAAF8BAIABIXzw Date: Fri, 19 Oct 2018 16:21:23 +0000 Message-ID: References: <8dd58f85-3836-4951-3efe-f4c0aef7a1a1@linux.intel.com> <3ADBB72A-4190-4D58-A359-E493BB1A65CB@apple.com> <18984317-b515-9788-0495-af2b0b698ba9@linux.intel.com> <7D30FC28-2AE8-48F9-8942-8D5593E009DA@apple.com> <5bfbdb37-54c4-b8a0-9281-ef56d9327ae9@linux.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [50.35.76.74] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR21MB0128; 6:fQ74xESM4rOOo0g6u9tc74WG+IdZ1359xJ3sxkIm2ttRLq6mKwBwJ30IDdZMPMPWsWKWVKHoMqX+ZQcgSiLvAqo+PdYuYw6MoPjnzk7jnJScgRCYUi7Qz9YSSE38jjMXPQ9yArWM2ki7wZNfi9rO3XQe1GpOsV91RLGuUTyJOQrUjLPtEHydEldZMBaObakf+EWz4Z4xjKzE8L6fVr0g6Xr884S9+LYZPFMDLkCG9OUeg8RbS8JNrYpYFkw1dwyWYrlQRiXNGsg14bG2ksN3ZnyqL/n4JUFr6gGV6G709La9a7tsFeVQEzmKGCE89H5fs3qcNFYv7taiaAoKQC8ryCx4UrMjKLNBeLzvfQWZhNzRhLcsogR0/EeDyF4E1zpetWLjr2hPpBchuJyNJK0qLjl50mgtxbQhJ33Aeg+PXrOfB5wNzwrA8GKStSjP9rVuuG1ezROsY6IZ4/vgIyZo7g==; 5:Cer9vl5Ntd9PbaFucgJCRTBFco0qvvTlCyPG2CcGcCfV2TmvNTJ2MQx67rFbyIbX1atGAwpXqS8/f46ayHMVG1bCdkiOxKumPSFvi1Fj8t9uN55F221bw8Zc0yhWbzmLeL8wxu3Xn5PYm5XkfWRLfD/8Wc/NO2Bxe8/O78uN1z8=; 7:h0ybfjPb0gpBlGqLD+3RQlWUuzkvZZtlEp6fx5JW/cNmPbMNTseRNQzoZ0xUkfMLn3QhodoSE2qHGNT7pbuAIDI9kdKjegfAy6LZQiYWkvILDl2v9IC0C8yiSnzz8K3JfueXR/zDU38MxAdEmh72DA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: ab61114d-0bbb-43f7-444c-08d635dee958 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:MWHPR21MB0128; x-ms-traffictypediagnostic: MWHPR21MB0128: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(169983927008552)(166708455590820)(162533806227266)(219752817060721)(189930954265078)(228905959029699)(31960201722614)(80524489315369); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(8220027)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231355)(944501410)(52105095)(2018427008)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:MWHPR21MB0128; BCL:0; PCL:0; RULEID:; SRVR:MWHPR21MB0128; x-forefront-prvs: 0830866D19 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(376002)(346002)(366004)(136003)(13464003)(189003)(199004)(97736004)(5250100002)(316002)(55016002)(9686003)(6436002)(478600001)(186003)(26005)(71200400001)(71190400001)(93886005)(81156014)(81166006)(68736007)(8676002)(229853002)(7736002)(8990500004)(6306002)(74316002)(86612001)(10290500003)(486006)(14444005)(256004)(476003)(446003)(6246003)(11346002)(6346003)(66066001)(14454004)(15650500001)(966005)(102836004)(25786009)(4326008)(2906002)(54906003)(110136005)(2900100001)(99286004)(7696005)(76176011)(105586002)(106356001)(10090500001)(8936002)(22452003)(33656002)(53546011)(575784001)(5660300001)(6506007)(53936002)(6116002)(3846002)(86362001)(305945005); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR21MB0128; H:MWHPR21MB0176.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jerecox@microsoft.com; x-microsoft-antispam-message-info: GRJgRiki+44rF6iN5o4onKNe7Wa1G368qHJpyyiyWZIFK4vAyFNqUXqLFmsZDMelvJ24rVD82XUNMGKtQT18CDLh28XNlnkd/Jku3Wa5hEyqnOYlKE8b36mc0CR4+mLBmyVTwJx9cH+me8cN6KLfXKL3w2UN57/MpU8KZSCyqh7hLm7+nmSRKmIkhvaqwPbCTcy7vCREBSj88OcF6dw6ehdJKG54A59Bz3SI9PRhjHwFyq//gjXpcwxf/Vj2M8ulX6tb9F06UJzAgOUBNAhRWzSFweKR77EjEls+ZYbIvjTKRJCiU+uWFGJvKVn68X/l+Q0GmWJ17yRICwUHQ4SlHllqED0ZZp+2fxe4hF/YwP8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab61114d-0bbb-43f7-444c-08d635dee958 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2018 16:21:23.1985 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0128 Subject: Re: Community Discussion: General Code and Commit message standards X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2018 16:21:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In GitHub, adding a link from a PR to an Issue is extremely easy: https://help.github.com/articles/closing-issues-using-keywords/=20 Use any of the following strings, followed by a number, in a PR description= ... close closes closed fix fixes fixed resolve resolves resolved For example: "Closes #123" -----Original Message----- From: edk2-devel On Behalf Of Kinney, Mic= hael D Sent: Thursday, October 18, 2018 4:01 PM To: stephano ; Andrew Fish ; Kinney, Michael D Cc: Carsey, Jaben ; edk2-devel@lists.01.org Subject: Re: [edk2] Community Discussion: General Code and Commit message s= tandards I would also hope that most (if not all) patches do have an associated BZ. = For either a feature request or a bug fix. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] > On Behalf Of stephano > Sent: Thursday, October 18, 2018 10:21 AM > To: Andrew Fish > Cc: Carsey, Jaben ; edk2- devel@lists.01.org > Subject: Re: [edk2] Community Discussion: General Code and Commit=20 > message standards >=20 > On 10/18/2018 6:11 PM, Andrew Fish wrote:> What I've done in the past=20 > on a branch based github PR flow is have a naming convention for the=20 > branch. For example eng/PR--. > Then we have a > git hook that looks at the branch name and if it sees a Bugzilla=20 > number it inserts the Bugzilla reference in the bottom of every commit=20 > message for that branch. The CI also played tricks with the branch=20 > names and could update the bug tracker with CI results, and the=20 > process status of the bug. > Interesting. This will make a good point for coming discussions. I'll=20 > make a note of it. >=20 > I would hope that most modern workflows have a way to accomplish this=20 > in some automated way. Seems like a pretty standard ask. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists > .01.org%2Fmailman%2Flistinfo%2Fedk2-devel&data=3D02%7C01%7Cjerecox%4 > 0microsoft.com%7C9a1bd80da4cd497ff85308d6354d9e4a%7C72f988bf86f141af91 > ab2d7cd011db47%7C1%7C0%7C636755004889706325&sdata=3Dub18%2BhCBJNCpmL > x3gh11Aqo59UAZFn0yOczb%2BW2UzvU%3D&reserved=3D0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists.01= .org%2Fmailman%2Flistinfo%2Fedk2-devel&data=3D02%7C01%7Cjerecox%40micro= soft.com%7C9a1bd80da4cd497ff85308d6354d9e4a%7C72f988bf86f141af91ab2d7cd011d= b47%7C1%7C0%7C636755004889706325&sdata=3Dub18%2BhCBJNCpmLx3gh11Aqo59UAZ= Fn0yOczb%2BW2UzvU%3D&reserved=3D0