Re: [edk2-announce] Research Request

[Jeremiah Cox <jerecox@microsoft.com>]

Test PR submitted

-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com> 
Sent: Wednesday, November 28, 2018 3:07 AM
To: Brian J. Johnson <brian.johnson@hpe.com>; Jeremiah Cox <jerecox@microsoft.com>; stephano <stephano.cetola@linux.intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [edk2-announce] Research Request

On 11/27/18 22:55, Brian J. Johnson wrote:
> On 11/27/18 6:53 AM, Laszlo Ersek wrote:
>> On 11/26/18 22:43, Jeremiah Cox via edk2-devel wrote:
>>> Feedback on GitHub as follows…
>>>
>>>
>>>> 1. No Lock-In - What automated data export is available?
>>>> We want to be able to leave and take all our data with us. "Data" 
>>>> here
>>>> includes: review comments, pull requests / patches (including 
>>>> metadata), old (rejected) pull requests and metadata, issue tracker 
>>>> entries and comments (if issue tracker included). This archiving 
>>>> should be automated, not something we do by hand.
>>> Untested, but might these all be easily satisfied by subscribing a 
>>> mailing list to GitHub notifications?
>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhel
>>> p.github.com%2Farticles%2Fabout-notifications%2F%23watching-notifica
>>> tions&amp;data=02%7C01%7Cjerecox%40microsoft.com%7C86474d2516054fd63
>>> 42708d65521acec%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6367900
>>> 00471363695&amp;sdata=19UcXzXaxWSI9Dwvj7Nb2p1TRa78H8nxgFznkLKYeOg%3D
>>> &amp;reserved=0
>>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhel
>>> p.github.com%2Farticles%2Fabout-email-notifications%2F&amp;data=02%7
>>> C01%7Cjerecox%40microsoft.com%7C86474d2516054fd6342708d65521acec%7C7
>>> 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636790000471363695&amp;sda
>>> ta=ICXNdWhlzBzVfjKk5t5aBsMC6hY8onKZS1T3WqobERk%3D&amp;reserved=0
>> No, they are insufficient.
>>
>> Following the last link above ("about-email-notifications"), one 
>> finds several other links; and one of those is:
>>
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp
>> .github.com%2Farticles%2Fabout-notifications%2F&amp;data=02%7C01%7Cje
>> recox%40microsoft.com%7C86474d2516054fd6342708d65521acec%7C72f988bf86
>> f141af91ab2d7cd011db47%7C1%7C0%7C636790000471363695&amp;sdata=C%2Fy1v
>> gLJC5cpL9fNQOqw1V28Omzazbu%2BeZC2m13wRLs%3D&amp;reserved=0
>>
>> This article says,
>>
>>      GitHub sends participating notifications when you're directly
>>      involved in activities or conversations within a repository or a
>>      team you're a member of. You'll receive a notification when:
>>
>>      [...]
>>
>>      - You open, comment on, or close an issue or pull request.
>>
>>      [...]
>>
>> This is demonstrably false. I'm a member of the TianoCore 
>> organization, I have commented on, and closed (rejected):
>>
>>    
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
>> ub.com%2Ftianocore%2Fedk2%2Fpull%2F133&amp;data=02%7C01%7Cjerecox%40m
>> icrosoft.com%7C86474d2516054fd6342708d65521acec%7C72f988bf86f141af91a
>> b2d7cd011db47%7C1%7C0%7C636790000471363695&amp;sdata=BT0dw8IxXGiopl3%
>> 2FHfJl7w%2BGG8VSlEb2rvIetin5T2o%3D&amp;reserved=0
>>
>> and I *never*  received an email notification about my *own*  comment 
>> / action. I only received the initial email, about the pull request 
>> being opened (attached for reference).
> 
> Try going to the "Settings" item under the menu in the top-right 
> corner, and clicking on the "Notifications" tab on the left.  Under 
> "Email notification preferences" there should be a checkbox for 
> "Include your own updates".  That may do what you need.

That did the trick. I checked the box and then went on to close PR#134.
I got two separate emails shortly after (attached), one about the closure and another about the comment.

In my opinion, the default value for the setting in question is broken (it should be "on" by default). However, to me anyway, it's a big plus for GitHub that it actually supports this feature. If we are going to adopt GitHub, then we can highlight the knob in our docs.

Regarding GitHub, what remains to be seen (for me) is if & how it preserves old (unmerged) topic branches, and review comments made for them, after the pull requestor rebases or deletes those branches in his/her repo.

Can someone please send an artificial/test PR against my personal repo, at <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flersek%2Fedk2&amp;data=02%7C01%7Cjerecox%40microsoft.com%7C86474d2516054fd6342708d65521acec%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636790000471363695&amp;sdata=ipRDM9x1QQnMSv7PF%2BE7yf3oGg7sBE3mjeqHw9vmyDA%3D&amp;reserved=0>? Just change some lines in OvmfPkg/README or something like that.

Thank you!
Laszlo