Hi Guomin,

Could you please point me to the proposed change?

Thanks,
Kun

From: Jiang, Guomin <guomin.jiang@intel.com>
Sent: Wednesday, April 8, 2020 6:30 PM
To: Sean Brogan <sean.brogan@microsoft.com>; devel@edk2.groups.io
Cc: Kun Qin <Kun.Qin@microsoft.com>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Sean,

I think it meet the original code logic more closely.

According to the LoadUnitTestCache(), it need pointer to pointer, the defect is resulted by pointer to local pointer and I think the original logical just want use the local variable as pointer to pointer.

I have reviewed the suggested change and think both are the same logic.

Hi Qin,

Can you give some comment?

Best Regards
guomin
From: sean.brogan via [] <sean.brogan=microsoft.com@[]<mailto:sean.brogan=microsoft.com@[]>>
Sent: Wednesday, April 8, 2020 2:00 PM
To: Jiang, Guomin <guomin.jiang@intel.com<mailto:guomin.jiang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Guomin,

Can you speak to why you implemented differently than the suggested and validated patch?  Seems you created a local whereas ours just used the internal data member.

Thanks
sean