From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.116]) by mx.groups.io with SMTP id smtpd.web11.6.1590531088388306539 for ; Tue, 26 May 2020 15:11:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=h/+Ic0gp; spf=pass (domain: microsoft.com, ip: 40.107.92.116, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LAHARPUm12qOZhkmtXmX/rnsBtJZcrkBD1UZRhe3JTpEkMGTeaJdBHyfjHpbUifLYNAF/SZX15K8gZW0aBFBofBCFoACP5otva07ATxLEDTb07hyKPBDzcplQIo/WQlvC2JQy/V8+EoEkKbDkcc7MachsxKUyQ/pYg5iswBN6fcgP1Hr51Mqao+EUAEKPn9BZznTWxhgIwfilx+SELIWSKFvaeH9jk2PsVqybFx3EN0uZD0iUYxDkeFXIdFq5FX9vXlwSDBQ+ie96FTO2G/n1GOKlnlqHAfWZIdPQ2J1rlfai11eezaRPm/39ev0nH4wmpTWGOX23ljtl20N8fIwGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4okPR5ngjEomQyBc+LzmlbypOA1F2Wkv5+2OzcklV2c=; b=KLZaqDPaclfPV9vVuSuE/KMmNXc4QHTdPPlR+mm9VWWqOfKhpqYzDMC9iQAbqDNwx5KSpUwyIpSpQkVhC2wTNBu7j1ZQfm+d6BMmsOE6w6x3y78hjt9wxGHiF8U61o8sirGEG0tTimvuxmdnns4MXJq4tNQuB76mcp3mM1EXmg7yvB3lPi3/ut9xxvqHleESgs+s/RYLhdTubF0fWw4cdXXI4BWpyaC8bGwFuWhjj+rX1kHVlFoeirqNOo3wQFfsNDqTERcv9XpQ0phVn0I4XNFLXHp134gDk2nItQuBKKCrRSxDHZe7L+FxXg1FqeE4UN2lMvvTl+xtBhPg1zXCig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4okPR5ngjEomQyBc+LzmlbypOA1F2Wkv5+2OzcklV2c=; b=h/+Ic0gpVlz4EwnCWeoDZPIMIpwpveBk65FyE2k+YDi0Sq6zwzlnkkmT1k4Sq3Q41lRLw1gUFMu0Y1OO+cu1VIAUrXKU2qkzPtIy0pU70oxA20poL8QcNyIqd6uP1qSlQxcVar80h54f+RGdDnNKG3mjWSf2CeV6f8As5NO/oM8= Received: from MWHPR21MB0750.namprd21.prod.outlook.com (2603:10b6:300:76::12) by MWHPR21MB0511.namprd21.prod.outlook.com (2603:10b6:300:df::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.4; Tue, 26 May 2020 22:11:26 +0000 Received: from MWHPR21MB0750.namprd21.prod.outlook.com ([fe80::7857:2692:c7af:84ca]) by MWHPR21MB0750.namprd21.prod.outlook.com ([fe80::7857:2692:c7af:84ca%4]) with mapi id 15.20.3066.005; Tue, 26 May 2020 22:11:25 +0000 From: "Bret Barkelew" To: Laszlo Ersek , "devel@edk2.groups.io" , liming.gao , "announce@edk2.groups.io" CC: Leif Lindholm , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005 Thread-Topic: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005 Thread-Index: AdYwDsAM+Wc9O3rBRZWSBqxvcc7LywAPBHqSAJxm8IAAO3SBYA== Date: Tue, 26 May 2020 22:11:25 +0000 Message-ID: References: ,<6cdfa14b-b45f-1c19-0dc3-653ef06c40c4@redhat.com> In-Reply-To: <6cdfa14b-b45f-1c19-0dc3-653ef06c40c4@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-05-26T22:11:26.171Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.144.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: abe36db2-34c4-47d5-eba0-08d801c1bb8e x-ms-traffictypediagnostic: MWHPR21MB0511: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 041517DFAB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uXH3RktFR6F5V1/Wt1ovckO4XSa3TE+l96Jn6aYQhVSfmQjWPqu108fKG8f+ePktLpG1PkTnQInQGdQ/GiDELJCdoKCsMpcVlh1hqQWMl2SEOyVp1X1uoj4DO8fnIfeYZ1gr6rEGDQ9YXhwNKy9s4Woc3OzmQj/mDS7VMkkhxwNYe2fu2CJr04ETUM0fdyVjp4OOoRf9YhcdHy4Vim2LWlgDMLgWDin36gZ3ilqbUOZ/GInQk4Nw8DpB0cf59XPgU9mAh59F85VA5/PUqobKZH7TO+OC1NRczF6MxjYE04WKfzkezJnAi1wBS3ceMUNeLdSmcWcBIVq+AmueU2oTCOXRAncYN/r8pfqkYweh3L5d2vl+t9EiD3PvH2SCz5lYmtOOwsDrIhgTWS6N7UwKZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB0750.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(366004)(396003)(346002)(376002)(966005)(33656002)(82960400001)(10290500003)(64756008)(52536014)(316002)(19627405001)(66946007)(478600001)(82950400001)(76116006)(66556008)(66446008)(66476007)(9686003)(8990500004)(8936002)(110136005)(55016002)(4326008)(5660300002)(2906002)(6506007)(186003)(71200400001)(54906003)(7696005)(26005)(86362001)(8676002)(166002)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 0Dd+cuiz2qOymqqG6kuLvUhDuTz9AgCBNdh4ympdSyM/+EzjB/nW6sC8bUpEQfJEsy8X0+3OqDxlweYZL+y+u/+hgQUoc9TvJ9wA3IzpgDFGBorh4pWA89QlkeYoIuFKh9QUYZX0852wpUxuuIrI9/O0LS4e9eb7E16VoVuFBGQqhLAUOCeB/yoGexjKPzMttrm5zGNkPT6HjM+KR6b5udN2opYMxsyEG1KRBiQ9UxTwNNa/edeLvhlLROE8f8P6JbknVzn+czT0MWThUrCV84pc+k9ydE1yCoSA131KljNR5heEYZ01Vg2dL0YaITgFRZjKAiXlHSg22g8o7UezSwIm2eRuMaTn2fag/aMhL2xJxkTBDEYVunwsN2E/M0NzzHfus2YEMxuHdUyj+Cu9oy9dENXLbJ46m5vqcUucEH71H7x0WV9QTAitl50HJxaV9+zF0jVAjl0ewjOVYDbMhIcMAl9iNoS/IjDDjlL0VSM= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: abe36db2-34c4-47d5-eba0-08d801c1bb8e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2020 22:11:25.7917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bLjKvflnT3SlbO/Qbu/GR109W3w5D9nK615hZV05qxQ59AeD3JTA2EHszKjQ6iPXOVb2tm+IXu/01NcW4FcfyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0511 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR21MB075042B77573074341D0FD38EFB00MWHPR21MB0750namp_" --_000_MWHPR21MB075042B77573074341D0FD38EFB00MWHPR21MB0750namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable I just looked into it, and I think that AsciiStrCpyS() was the wrong functi= on to call in this loop anyway. AsciiStrCpyS() will fail without copying an= y characters. AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop= seems to expect. The bug stands and we should try to get that bug fix into the stable tag. = Thanks! - Bret ________________________________ From: Laszlo Ersek Sent: Monday, May 25, 2020 10:46 AM To: Bret Barkelew ; devel@edk2.groups.io ; liming.gao ; announce@edk2.groups= .io Cc: Leif Lindholm ; afish@apple.com ; = Kinney, Michael D Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable2020= 05 Hi Bret, On 05/22/20 17:11, Bret Barkelew wrote: > We=92d like to ask that this patch be considered for the stable tag: > [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiSt= rnCpyS() > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz= illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&data=3D02%7C01%7Cbret.bar= kelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141af= 91ab2d7cd011db47%7C1%7C0%7C637260256091133309&sdata=3DMDKQ1CKq9%2B9AfPM= L0JxcND47UIcQUAibUSAVlfW5iZc%3D&reserved=3D0 > > The patch was reviewed prior to the hard freeze date, and is a small cha= nge that affects new(ish) code that is not heavily utilized yet. does the original issue (reported in TianoCore#2721) persist with TianoCore#2054 fixed? My understanding (from TianoCore#2721) is that the original AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error condition in AsciiStrCpyS(). Previously, that would indeed trip an ASSERT(), but AIUI that issue has been resolved generally with TianoCore#2054. If the AsciiStrCpyS() call remains an issue with the ASSERT() removed, then replacing the call with AsciiStrnCpyS() still seems like a bugfix to me, not a "feature", so I think the patch is eligible for merging during the HFF. Mike, can you please merge the patch (if it's still needed)? Thanks Laszlo > > - Bret > > From: Liming Gao via groups.io > Sent: Friday, May 22, 2020 1:01 AM > To: devel@edk2.groups.io; announce@edk2.gro= ups.io > Cc: Laszlo Ersek; Leif Lindholm; afish@apple.com; Kinney, Michael D > Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for edk2= -stable202005 > > Hi, all > Today, we enter into Hard Feature Freeze phase until edk2-stable202005= tag is created at 2020-05-29. In this phase, there is no feature to be pus= hed. The critical bug fix is still allowed. > > If the patch is sent after Hard Feature Freeze, and plans to catch thi= s stable tag, please add edk2-stable202005 key words in the patch title and= BZ, and also cc to Tianocore Stewards, then Stewards can give the comments= . > > Below is edk2-stable202005 tag planning. > Date (00:00:00 UTC-8) Description > 2020-03-04 Beginning of development > 2020-05-08 Feature Planning Freeze > 2020-05-15 Soft Feature Freeze > 2020-05-22 Hard Feature Freeze > 2020-05-29 Release > > Thanks > Liming > >=20 > > --_000_MWHPR21MB075042B77573074341D0FD38EFB00MWHPR21MB0750namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
I just looked into it, and I think that AsciiStrCpyS() was the wrong function to call in this loop anyway. AsciiStrCpyS() will fail without copying any characters.
AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the= loop seems to expect.

The bug stands and we should try to get that bug fix into the stable tag. Tha= nks!

- Bret


From: Laszlo Ersek <ler= sek@redhat.com>
Sent: Monday, May 25, 2020 10:46 AM
To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.g= roups.io <devel@edk2.groups.io>; liming.gao <liming.gao@intel.com&= gt;; announce@edk2.groups.io <announce@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com <af= ish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-sta= ble202005
 
Hi Bret,

On 05/22/20 17:11, Bret Barkelew wrote:
> We=92d like to ask that this patch be considered for the stable tag:<= br> > [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use Asci= iStrnCpyS()
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&amp;data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637260256091133309&amp;sdata=3DMDKQ1CKq9%2= B9AfPML0JxcND47UIcQUAibUSAVlfW5iZc%3D&amp;reserved=3D0
>
> The patch was reviewed prior to the hard freeze date, and is a small = change that affects new(ish) code that is not heavily utilized yet.

does the original issue (reported in TianoCore#2721) persist with
TianoCore#2054 fixed?

My understanding (from TianoCore#2721) is that the original
AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error
condition in AsciiStrCpyS(). Previously, that would indeed trip an
ASSERT(), but AIUI that issue has been resolved generally with
TianoCore#2054.

If the AsciiStrCpyS() call remains an issue with the ASSERT() removed,
then replacing the call with AsciiStrnCpyS() still seems like a bugfix
to me, not a "feature", so I think the patch is eligible for mer= ging
during the HFF.

Mike, can you please merge the patch (if it's still needed)?

Thanks
Laszlo


>
> - Bret
>
> From: Liming Gao via groups.io<mailto:liming.gao=3Dintel.com@groups.io>
> Sent: Friday, May 22, 2020 1:01 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; announce= @edk2.groups.io<mailto:announce@edk2.groups.io>
> Cc: Laszlo Ersek<mailto:lerse= k@redhat.com>; Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinne= y@intel.com>
> Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for e= dk2-stable202005
>
> Hi, all
>   Today, we enter into Hard Feature Freeze phase until edk2= -stable202005 tag is created at 2020-05-29. In this phase, there is no feat= ure to be pushed. The critical bug fix is still allowed.
>
>   If the patch is sent after Hard Feature Freeze, and plans= to catch this stable tag, please add edk2-stable202005 key words in the pa= tch title and BZ, and also cc to Tianocore Stewards, then Stewards can give= the comments.
>
> Below is edk2-stable202005 tag planning.
> Date (00:00:00 UTC-8) Description
> 2020-03-04      Beginning of development
> 2020-05-08      Feature Planning Freeze
> 2020-05-15      Soft Feature Freeze
> 2020-05-22      Hard Feature Freeze
> 2020-05-29      Release
>
> Thanks
> Liming
>=20 >
>

--_000_MWHPR21MB075042B77573074341D0FD38EFB00MWHPR21MB0750namp_--