From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.77.122]) by mx.groups.io with SMTP id smtpd.web11.3245.1590546311761115200 for ; Tue, 26 May 2020 19:25:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=NXfSDk/Y; spf=pass (domain: microsoft.com, ip: 40.107.77.122, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AD1y5JnVEO/9W4/Hcm++2H//b1o5Vvu1MJRbi7M2kZgYU5pBrz1GqYNcGjebVAsw00+tuPuMEBvy+wmmPNJJYBhDA6lHyWAQ/OYqZBFbqe8/sV1xBREOSxKS6ODP0VYJUNO9is3MegT5RtElmbyQF3DseMYtlN4VGFItDew87pWzWPb+MVFfzRkTWhaZHBCx9ul1QExPxD2fo6h08d1GgbG86qHPmAs9yvRUD2fMm/ngOPt5/SzSmrIRRFnfEuommaPp2104oqFIqSmN2OaNLMZ0Tb/H41RtFj0xWcXfX9tSmIubi+5jAyqkJIWjBvNiNNNvURuAcrZTTXe4+USCDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bz/bgFdTpS4QUVNTxiZuT6RR7OVXkSkJAPcCTKaGIcg=; b=Y6rO7FRlZH4yy2AfF5bR5HiMVTXJSYZctz0VohSDWgFoleXZXgxLEnWGXvn1ec0NjpXt110xcxx5rcEC7dJybv2X9sx/usy4Hj9qgcH1snrWsRmPOzu0GiJ0DClDya3vmo9Q0aDGFaQ7injnzpWhZmnipYzwPzFMdlKuQr+p/YFoTfQ8V1aiqy7VGQdL7y/rA8JV2hY8ZGDCM6Mt7YgKWTqp7upMMyj1sx5WxKknGvn9+MZ65ftyQqiR5iV+ReXg4CsnbbmZKBEA4npl7mN0Kis9jg/Q0UuofuLQdrEMXjJKXF6QadBLjf3GK9j8coiv+b/BduaxyaqR8sCB0La7KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bz/bgFdTpS4QUVNTxiZuT6RR7OVXkSkJAPcCTKaGIcg=; b=NXfSDk/YBUjX4+NttbZVBk7f2bKELR3ujzRT16k52HjVJ2zEMVJVQzmYA6/NSqgeGzL126D3+eBmTuOXUZW/Hi4bIRCcxAVokQjosaFWAgHuHpjutZ8OseJ3zWjJo7ReeeiY/YfpojYrs4ylyW75OtVcKOMN4vC6x5CKljjhzXc= Received: from MWHPR21MB0750.namprd21.prod.outlook.com (2603:10b6:300:76::12) by MWHPR21MB0704.namprd21.prod.outlook.com (2603:10b6:300:128::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.15; Wed, 27 May 2020 02:25:09 +0000 Received: from MWHPR21MB0750.namprd21.prod.outlook.com ([fe80::7857:2692:c7af:84ca]) by MWHPR21MB0750.namprd21.prod.outlook.com ([fe80::7857:2692:c7af:84ca%4]) with mapi id 15.20.3066.005; Wed, 27 May 2020 02:25:09 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , liming.gao , Laszlo Ersek , "announce@edk2.groups.io" CC: Leif Lindholm , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005 Thread-Topic: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005 Thread-Index: AdYwDsAM+Wc9O3rBRZWSBqxvcc7LywAPBHqSAJxm8IAAO3SBYAAIzaQAAAAkeak= Date: Wed, 27 May 2020 02:25:09 +0000 Message-ID: References: ,<6cdfa14b-b45f-1c19-0dc3-653ef06c40c4@redhat.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-05-26T22:11:26.1710000Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.144.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 55c563ae-6129-4232-8cda-08d801e52d73 x-ms-traffictypediagnostic: MWHPR21MB0704: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04163EF38A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iAV52ewoc1ehImxeiWrSP0vmz16DDI0t9W72LhbL4EQmxyn08XlpxUpCNmuioop7iiReqqV96+egY+e35UqKmnOYsYokc8h9kr9H/nNDcJRqMS6/k5KwPFiA7ohbufkdXnvbXmQrUFP97jZPQ07Tzvw8fmsQT5ZyStiJs729gQQ9mMR990nADS3nVDGvb01DIyVzHI6EPQ6E/oHvnkDZmGcEO3UfeZvnVCW4CDn6z/LL60PJe0NSu1najfwlUilRDhxtbCKH0DSSOWWWgDRnBhTKjnpBKzszsHtsyDD5ReXJ9vrWe/n1lufcxHDrTu6UeWiaQ+2diYb3IHzyRDgrpEldn4wTecHcHYfj0dGkU7NBrJcpUI5RQcYHpw2bk0dx10sFNdOfUKIOEvvWpIh8ww== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB0750.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(186003)(86362001)(82960400001)(64756008)(82950400001)(110136005)(8936002)(52536014)(71200400001)(478600001)(2906002)(10290500003)(4326008)(316002)(5660300002)(7696005)(166002)(54906003)(55016002)(9686003)(966005)(19627235002)(66556008)(66946007)(66446008)(8676002)(66476007)(8990500004)(26005)(76236002)(53546011)(76116006)(6506007)(83380400001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Up4VuXR9+e/R8OCFdAqA28hTTXr99cbbtwPxM4R9B4nRLvOzPa3msVYQwpN8DvWX/VsAj64eiZfJR6AjNKyUyB5sFZETcLw0QAoa7Sr7KMUdCN+ry0waWC615iJMwRYyy8h1AlvFbaJdsF8/Q74QB83zeWEi5tPWpGBg0QCmEOoMrUFqLLWPgldhl6hy3OzDmuwte1cCZSU9knw2GPdwHSk9sf1QBgbolDiOsiyd3stixatqCdanzLbQRE1RMlbX2AhZbOm3ZEN9a6VAyUKjoS22F3ZggaJqlMO2aAbDcFyhLXmiRDFcgJy964pwD7ihCUBkHVb1lRbiAlZxfW4nCMoHIyfa9mETDehgaOdsRsme4Sk18S/CwBU5s5BtgylHeJ5qsxZm31nQSlHZZ6yqlYn5sOTTqTYyleLWiCDmTqOJsI+hqGDXHo/9b+itAH9ccMUzNNXym/tEoQAO7e1lIQSF8j3l7qt3eLIXypYaNsReeUWdo++UTFyHbkrZSOj8 x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55c563ae-6129-4232-8cda-08d801e52d73 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2020 02:25:09.3081 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R0gNjCvNWcoU4KwF85fZnI8p8tIz7C6HETHZoL3UBe/Ou3eKF56Ahb6L6WEHO18mdJmDaHBa0n+Z5EnMhOTHtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0704 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR21MB0750DB8F96698A977D488091EFB10MWHPR21MB0750namp_" --_000_MWHPR21MB0750DB8F96698A977D488091EFB10MWHPR21MB0750namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Thanks! - Bret ________________________________ From: devel@edk2.groups.io on behalf of Liming Gao = via groups.io Sent: Tuesday, May 26, 2020 7:21:00 PM To: Bret Barkelew ; Laszlo Ersek ; devel@edk2.groups.io ; announce@edk2.groups.= io Cc: Leif Lindholm ; afish@apple.com ; = Kinney, Michael D Subject: Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts now fo= r edk2-stable202005 I create PR https://github.com/tianocore/edk2/pull/644 for this patch. Thanks Liming From: Bret Barkelew Sent: Wednesday, May 27, 2020 6:11 AM To: Laszlo Ersek ; devel@edk2.groups.io; Gao, Liming ; announce@edk2.groups.io Cc: Leif Lindholm ; afish@apple.com; Kinney, Michael D = Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable= 202005 I just looked into it, and I think that AsciiStrCpyS() was the wrong funct= ion to call in this loop anyway. AsciiStrCpyS() will fail without copying a= ny characters. AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop= seems to expect. The bug stands and we should try to get that bug fix into the stable tag. = Thanks! - Bret ________________________________ From: Laszlo Ersek > Sent: Monday, May 25, 2020 10:46 AM To: Bret Barkelew >; devel@edk2.groups.io >; liming.gao >; announce@edk2.groups.io > Cc: Leif Lindholm >; afish@app= le.com >; K= inney, Michael D > Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable2020= 05 Hi Bret, On 05/22/20 17:11, Bret Barkelew wrote: > We=92d like to ask that this patch be considered for the stable tag: > [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiSt= rnCpyS() > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz= illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&data=3D02%7C01%7Cbret.bar= kelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141af= 91ab2d7cd011db47%7C1%7C0%7C637260256091133309&sdata=3DMDKQ1CKq9%2B9AfPM= L0JxcND47UIcQUAibUSAVlfW5iZc%3D&reserved=3D0 > > The patch was reviewed prior to the hard freeze date, and is a small cha= nge that affects new(ish) code that is not heavily utilized yet. does the original issue (reported in TianoCore#2721) persist with TianoCore#2054 fixed? My understanding (from TianoCore#2721) is that the original AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error condition in AsciiStrCpyS(). Previously, that would indeed trip an ASSERT(), but AIUI that issue has been resolved generally with TianoCore#2054. If the AsciiStrCpyS() call remains an issue with the ASSERT() removed, then replacing the call with AsciiStrnCpyS() still seems like a bugfix to me, not a "feature", so I think the patch is eligible for merging during the HFF. Mike, can you please merge the patch (if it's still needed)? Thanks Laszlo > > - Bret > > From: Liming Gao via groups.io > Sent: Friday, May 22, 2020 1:01 AM > To: devel@edk2.groups.io>; announce@edk2.groups.io> > Cc: Laszlo Ersek; Leif Lindholm; afish@apple.com; Kinney, Michael D > Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for edk2= -stable202005 > > Hi, all > Today, we enter into Hard Feature Freeze phase until edk2-stable202005= tag is created at 2020-05-29. In this phase, there is no feature to be pus= hed. The critical bug fix is still allowed. > > If the patch is sent after Hard Feature Freeze, and plans to catch thi= s stable tag, please add edk2-stable202005 key words in the patch title and= BZ, and also cc to Tianocore Stewards, then Stewards can give the comments= . > > Below is edk2-stable202005 tag planning. > Date (00:00:00 UTC-8) Description > 2020-03-04 Beginning of development > 2020-05-08 Feature Planning Freeze > 2020-05-15 Soft Feature Freeze > 2020-05-22 Hard Feature Freeze > 2020-05-29 Release > > Thanks > Liming > > > --_000_MWHPR21MB0750DB8F96698A977D488091EFB10MWHPR21MB0750namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Thanks!

 

- Bret

 

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Liming Gao via groups.io <lim= ing.gao=3Dintel.com@groups.io>
Sent: Tuesday, May 26, 2020 7:21:00 PM
To: Bret Barkelew <Bret.Barkelew@microsoft.com>; Laszlo Ersek= <lersek@redhat.com>; devel@edk2.groups.io <devel@edk2.groups.io&g= t;; announce@edk2.groups.io <announce@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com <af= ish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [EXTERNAL] Re: Hard Feature Freeze starts= now for edk2-stable202005
 

I create PR https://github.com/tianocore/edk2/pull/644 for this patch.

 

Thanks

Liming

From: Bret Barkelew <Bret.Barkelew@micr= osoft.com>
Sent: Wednesday, May 27, 2020 6:11 AM
To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; G= ao, Liming <liming.gao@intel.com>; announce@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinne= y, Michael D <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2= -stable202005

 

I j= ust looked into it, and I think that AsciiStr= CpyS() was the wrong function to call in this loop anyway. AsciiStrCpy= S() will fail without copying any characters.

AsciiStrnCpyS() will perform th= e string "slicing"/"chunking" that the loop seems to ex= pect.

&nb= sp;

The bug stands and we should tr= y to get that bug fix into the stable tag. Thanks!

&nb= sp;

- Bret

&nb= sp;

From: Laszlo Ersek <lersek@redhat.com>
Sent: Monday, May 25, 2020 10:46 AM
To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io <devel@edk2.groups.io>; liming.gao= <liming.gao@intel.com>; announce@edk2.groups.io <= ;announce@edk2.groups.io>=
Cc: Leif Lindholm <leif@nuv= iainc.com>; afish@apple.com <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com><= br> Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-sta= ble202005

 

Hi Bret,

On 05/22/20 17:11, Bret Barkelew wrote:
> We=92d like to ask that this patch be considered for the stable tag:<= br> > [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use Asci= iStrnCpyS()
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&amp;data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637260256091133309&amp;sdata=3DMDKQ1CKq9%2= B9AfPML0JxcND47UIcQUAibUSAVlfW5iZc%3D&amp;reserved=3D0
>
> The patch was reviewed prior to the hard freeze date, and is a small = change that affects new(ish) code that is not heavily utilized yet.

does the original issue (reported in TianoCore#2721) persist with
TianoCore#2054 fixed?

My understanding (from TianoCore#2721) is that the original
AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error
condition in AsciiStrCpyS(). Previously, that would indeed trip an
ASSERT(), but AIUI that issue has been resolved generally with
TianoCore#2054.

If the AsciiStrCpyS() call remains an issue with the ASSERT() removed,
then replacing the call with AsciiStrnCpyS() still seems like a bugfix
to me, not a "feature", so I think the patch is eligible for mer= ging
during the HFF.

Mike, can you please merge the patch (if it's still needed)?

Thanks
Laszlo


>
> - Bret
>
> From: Liming Gao via groups.io<mailto:liming.gao=3Dintel.com@groups.io>
> Sent: Friday, May 22, 2020 1:01 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; announce@edk2.groups.io<mailto:announce@edk2.groups.io>
> Cc: Laszlo Ersek<mailto:lerse= k@redhat.com>; Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinne= y@intel.com>
> Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for e= dk2-stable202005
>
> Hi, all
>   Today, we enter into Hard Feature Freeze phase until edk2= -stable202005 tag is created at 2020-05-29. In this phase, there is no feat= ure to be pushed. The critical bug fix is still allowed.
>
>   If the patch is sent after Hard Feature Freeze, and plans= to catch this stable tag, please add edk2-stable202005 key words in the pa= tch title and BZ, and also cc to Tianocore Stewards, then Stewards can give= the comments.
>
> Below is edk2-stable202005 tag planning.
> Date (00:00:00 UTC-8) Description
> 2020-03-04      Beginning of development
> 2020-05-08      Feature Planning Freeze
> 2020-05-15      Soft Feature Freeze
> 2020-05-22      Hard Feature Freeze
> 2020-05-29      Release
>
> Thanks
> Liming
> >
>

--_000_MWHPR21MB0750DB8F96698A977D488091EFB10MWHPR21MB0750namp_--