From: Bret Barkelew <Bret.Barkelew@microsoft.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
Date: Tue, 27 Feb 2018 19:00:28 +0000 [thread overview]
Message-ID: <MWHPR21MB0784BB4F0A1D7BFEC06814D3EFC00@MWHPR21MB0784.namprd21.prod.outlook.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B895BF7A@ORSMSX113.amr.corp.intel.com>
Reviewed-By: Bret Barkelew Bret.Barkelew@microsoft.com
- Bret
From: Kinney, Michael D<mailto:michael.d.kinney@intel.com>
Sent: Wednesday, January 31, 2018 11:29 AM
To: Gao, Liming<mailto:liming.gao@intel.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>
Subject: Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org]
> On Behalf Of Liming Gao
> Sent: Wednesday, January 31, 2018 4:27 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] MdePkg SafeIntLib: Update API
> definition to use the same output name
>
> In SafeUintnToChar8(), update its output parameter name.
> Update pui8Result --> Result to match its library
> implementation
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
> MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/MdePkg/Include/Library/SafeIntLib.h
> b/MdePkg/Include/Library/SafeIntLib.h
> index 5839301..8c5003f 100644
> --- a/MdePkg/Include/Library/SafeIntLib.h
> +++ b/MdePkg/Include/Library/SafeIntLib.h
> @@ -375,7 +375,7 @@ RETURN_STATUS
> EFIAPI
> SafeInt16ToUint8 (
> IN INT16 Operand,
> - OUT UINT8 *pui8Result
> + OUT UINT8 *Result
> );
>
> /**
> @@ -564,7 +564,7 @@ RETURN_STATUS
> EFIAPI
> SafeUint16ToUint8 (
> IN UINT16 Operand,
> - OUT UINT8 *pui8Result
> + OUT UINT8 *Result
> );
>
> /**
> @@ -672,7 +672,7 @@ RETURN_STATUS
> EFIAPI
> SafeInt32ToUint8 (
> IN INT32 Operand,
> - OUT UINT8 *pui8Result
> + OUT UINT8 *Result
> );
>
> /**
> @@ -889,7 +889,7 @@ RETURN_STATUS
> EFIAPI
> SafeUint32ToUint8 (
> IN UINT32 Operand,
> - OUT UINT8 *pui8Result
> + OUT UINT8 *Result
> );
>
> /**
> @@ -1078,7 +1078,7 @@ RETURN_STATUS
> EFIAPI
> SafeIntnToUint8 (
> IN INTN Operand,
> - OUT UINT8 *pui8Result
> + OUT UINT8 *Result
> );
>
> /**
> @@ -1321,7 +1321,7 @@ RETURN_STATUS
> EFIAPI
> SafeUintnToUint8 (
> IN UINTN Operand,
> - OUT UINT8 *pui8Result
> + OUT UINT8 *Result
> );
>
> /**
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fmailman%2Flistinfo%2Fedk2-devel&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C5b2fcf3c266945233cd708d568e0ed61%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636530237637093084&sdata=tJVkaZk%2BKBaoBhkfYmPwL9YgId2FniXqd8l7v0ApjUs%3D&reserved=0
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fmailman%2Flistinfo%2Fedk2-devel&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C5b2fcf3c266945233cd708d568e0ed61%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636530237637093084&sdata=tJVkaZk%2BKBaoBhkfYmPwL9YgId2FniXqd8l7v0ApjUs%3D&reserved=0
prev parent reply other threads:[~2018-02-27 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 12:27 [Patch] MdePkg SafeIntLib: Update API definition to use the same output name Liming Gao
2018-01-31 13:17 ` Laszlo Ersek
2018-01-31 19:29 ` Kinney, Michael D
2018-02-27 19:00 ` Bret Barkelew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR21MB0784BB4F0A1D7BFEC06814D3EFC00@MWHPR21MB0784.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox