public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "pawel.karczewski via groups.io" <pawel.karczewski=solidigm.com@groups.io>
To: devel@edk2.groups.io
Subject: [edk2-devel] Using ekd2-libc with C++20
Date: Fri, 16 Feb 2024 02:00:23 -0800	[thread overview]
Message-ID: <NBog.1708077623991648166.Saej@groups.io> (raw)

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

Hi,

I'm successfully building C++20 project with edk2 under the GCC compiler.
Currently I'm trying to add edk2-libc to this project, but encountered issue with <string.h> header.

```
edk2/StdLib/Include/string.h:487:19: error: ISO C++17 does not allow ‘register’ storage class specifier [-Werror=register] register char **stringp
```

Why `strsep(register char **stringp, register const char *delim)` parameters has register storage class-class specifier?
C standard states the `register` keyword is only hint for the compiler and the extent to which such
suggestions are effective is implementation-defined. Do you see any real performance improvements thanks to this?

As I can see FreeBSD libc and musl do not have `register` keyword in signature of this function.

How do you think, may we remove `register` keyword from headers in Include directory?

Second option I see is to add
```
#ifdef __cplusplus
#define register
#endif
```

Of course I may submit patch for this change.

Paweł


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115541): https://edk2.groups.io/g/devel/message/115541
Mute This Topic: https://groups.io/mt/104393456/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2162 bytes --]

             reply	other threads:[~2024-02-16 14:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 10:00 pawel.karczewski via groups.io [this message]
2024-02-16 17:26 ` [edk2-devel] Using ekd2-libc with C++20 Michael D Kinney
2024-02-16 20:02   ` Pedro Falcato
2024-02-16 20:06 ` Pedro Falcato
2024-02-16 20:48   ` Michael D Kinney
2024-02-16 21:29     ` Michael D Kinney
2024-02-17  2:09   ` Pedro Falcato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=NBog.1708077623991648166.Saej@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox