From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 94AAD9416B3 for ; Mon, 20 Nov 2023 10:25:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=v0exjvkQtxPUq0HNjH9FXG1ajWXjyuIBrMlJQ5B/GgU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1700475930; v=1; b=HaYeWtH7GsN79lAdMRIH++h/uD0SXyvD0a3pdWfEX/gb4uGfbvA1mmt2jEVPNkosAXwLE7p6 oH837l+eVoS1+mbN2tf2oBpBpwysdaN7c4A2KsEK5t/rNpFgNoyusnw0nt07YITQEZJicru7hBw VLXrW7ZJ+cc7frfJgXbJ7Vx8= X-Received: by 127.0.0.2 with SMTP id cvvsYY7687511xwPCe5tr8UH; Mon, 20 Nov 2023 02:25:30 -0800 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.92.89.60]) by mx.groups.io with SMTP id smtpd.web11.47490.1700475929106162945 for ; Mon, 20 Nov 2023 02:25:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7aREZwiKEyvdVduhzm8zrJCYs0RmJ3mKNz6jzuiDD50sLuLD7vFjRJ9t2qCWOvYZCQKNzagBH7wIpiTe2G/SveJyTLAovJWb2M6ox4Y/ysd5pcPH9YQcFMgT4cPMtXp9bnBJ4fxyETlPizUD4cNM7uX91IdyFzhH8TYCLXkidw1JWh7nfnIqRoGkxetUvskCPooNJ2IuRNJiLOqDHg3Y1M6H5k0cJrcOxqKx01o6VCXk1WcorhHNH+SQnCTcCuiovGPAV8FjlyX35XRFbwqCmdt/mYEfH1RgfR6kIRI96t9W/Rnhbc8c6lpS248f2HxlaYY3+n2HBBNL8DYeNi5oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CjSn5UZccAZsIKfOFNuQrJVmZusZHjDQEPV8dYmFgYc=; b=XlE50ZWGRkZvWf1OuYJir14bcCn+Ka7r5N1+OKu0rWNkdJN2r+uyrnzh4rL7qWphwpLnWzKxzw048R7gUT215/b45fZ+SuYlewT+h5BHTaMA6+eONLo7A33t5CHMF9i1VhD9qPDaPpTUrdPW1aurAq1E3LaivUNHQqIRZ8m84CPI2V6+ppSy6+u3WxnO3BL/esTsk48ZOPB8cicUbe0Z6R2ub4CbgPCuB/BS6iRJuyoxkGgvQE3W+lzb2EXL9wCr8ILkmFCCRyo7jAAZqTIpmo6V8xiqbEiYBWkdTPqnkklVtTDtoZ+nuY0IqNlISQBcrKiwvjoTH6JKgf8uOf0q0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none X-Received: from PAXPR02MB7933.eurprd02.prod.outlook.com (2603:10a6:102:280::14) by DBAPR02MB6120.eurprd02.prod.outlook.com (2603:10a6:10:18e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Mon, 20 Nov 2023 10:25:26 +0000 X-Received: from PAXPR02MB7933.eurprd02.prod.outlook.com ([fe80::4fc:ed46:a86a:d81c]) by PAXPR02MB7933.eurprd02.prod.outlook.com ([fe80::4fc:ed46:a86a:d81c%4]) with mapi id 15.20.7002.026; Mon, 20 Nov 2023 10:25:26 +0000 From: "CrossedCarpet" To: Laszlo Ersek , "devel@edk2.groups.io" CC: "Liming Gao (Byosoft address)" Subject: Re: [edk2-devel] [Bug] Building NetworkPkg fails due to missing SynchronizationLib dependency of BaseCryptLib Thread-Topic: [edk2-devel] [Bug] Building NetworkPkg fails due to missing SynchronizationLib dependency of BaseCryptLib Thread-Index: AQHaGXAdCDQH2gVX5E6pBaNWeWp7B7CDAjW6 Date: Mon, 20 Nov 2023 10:25:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-tmn: [vRS+rDHFTBBbfSPzzEu56k3i49fYlmfM] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR02MB7933:EE_|DBAPR02MB6120:EE_ x-ms-office365-filtering-correlation-id: 823b0140-0116-4832-0af2-08dbe9b30340 x-microsoft-antispam-message-info: bm1wzOFzYImHv/fwKiPsi1h/aRuThDXt4CVgn3GvcaTU9eXjC3JWpTX83542uzaGiz1UvpkGx/BQJEmJr9VRcbaisjcN4RLDcAI+9xjK8GHnPVfZd34aWaarpn7hF//egUTKRVQgP5e59MZOJ5sbC4vC/xOK9u1V0KnWZvL13jAAUGAPRr/r46K5sniltJOXpITOjPjJrja2sqnHdfqR+Sn7JlhV3UuchkimpbjiSC0+vKjjMkQyB6wRb//1+Ry1xZK4cpOL6scfzFh+sVuVlVTBK5DwvaUoBym0VZ8k4xpIiJVEhCwqPPv9ukC3Q4boilc/7TAlcCstHBUQs1ZG//sktnVSbxlH3c/UTWg/lYBjk5VLcZxONa8EkrAjnA9o6Bxnfp4fKVe/OJlHIh6V72v7tECl0WViVwWvWxFdWmhgibjRZ/ELUiX0p83N23UvDyeeu9+UwEmUV+8ksjjxvCwqTUqWEDwfNQyiIyxLellboBzpfwRb1W78cg+t2O6NFptlBz0TTjEGERKPBPyXZ8Gu7PV+MYh7bpsrOT3sKIpwLzxmK2HIDAhOej7YshpQH8o8uyk7ExE6xkOV6X2lnvTecnqk/znzwY062yyQIouTYE6xyifo98LKKyKrfER+ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zhAgtDzKpYt8RTs3WNrEv8NHC4ZKc7Zyg15E1L2wB+sX6Q7sBSJxOtza3k+6?= =?us-ascii?Q?kGMLHFD4qKcFRl8He2kR4lyrLR2nHtlfo7LpPQPMdjrUyUwmO5IhXtzTC9yG?= =?us-ascii?Q?FqghB9BfvuSOlTOthc9j7oNkRKNjPE2OGQ/nsXIq0ZXuvOYJecKlcBiT7YnR?= =?us-ascii?Q?1JMKN2IpYuxapf+9ZE0vInHwnKDIC+87SIGGuuOyMqN4cCr1C8bxyV7kNzAj?= =?us-ascii?Q?5fpLQS8FkT0WK4wll3HduOjXBQvmCyGtIq2BWEoy0HNhSGbpICDSP6ZFIYNk?= =?us-ascii?Q?j+FzgQrNv73toWi1z+Fa616FxdbU0lstu2uw+fSO3b+iKvdwe5pBbo+g9eoH?= =?us-ascii?Q?/vpRYUALMyd6LkPre+IG+ez3vGBzux2ZLgSpvDrNGqQj5WGnmUBcmajTnAzC?= =?us-ascii?Q?s4CbNbSXhAQ5YoRcBwyZ49jzDxw1qrmhxd4p2XZRVJKmzHYUB8pEjxscZSz1?= =?us-ascii?Q?6aMn2c7taF6mROPMv5I7HEfPjygFR9Jc9RTPtUEGC5Y/8gA6sUDZyS2gFmM6?= =?us-ascii?Q?gvPE/nN89Qm9nMH6zLYHPa2bXkEvwiM4XuHgpJh6CVFca7vQyxhuHg4D/RMU?= =?us-ascii?Q?xN52yxr8VdMEpPuxrnvDC8CY/6CV3v4tY2mpzIidz78HVZA/B+JsSR9490Re?= =?us-ascii?Q?prSPmwUPPkHMA22u0Pg7qbJulvVsrMKzvtQ1tdxQtTLZ2qSJoIFyDDPQGiAF?= =?us-ascii?Q?5mM69CL5lIh9SXrJD4vOgfyswx6LJae1C/iWSG+lg/U4Hr83p9fj6LdFKX0/?= =?us-ascii?Q?6qLOcG16WuJBLpn1Rpzw9kg+IjGgNAXPM/IkWNkyxbel5nyTysR37aExXUxq?= =?us-ascii?Q?LKfB/2EXTNwtCA95MJWN97OvNGvh3IytfDbutB7xaaBSn54gFD2dwzJdD77S?= =?us-ascii?Q?eQbUV4Xy/QgIjOGlVdw7E+/XEUBQolBROmA1KnWk8kuQhY9z4uLUt/G8aaSU?= =?us-ascii?Q?MkcM3CVywNGnSLPidBh0CM6O5vyVUJO8Utbz26b7dfVfRLReWeuGp02JmlYK?= =?us-ascii?Q?MP6yK9KKs9CY4WNhw07nusxiH7ZAEo9cDsr2ZhZrUGeUbij34JSJNcAGgmB5?= =?us-ascii?Q?gN6R58hlkvDukzbUOGVx+ZP6xmJBUMB1n2ywzf33fkq2H/6n6ega2fr7Zy5t?= =?us-ascii?Q?7Rci2sjSFcDoIzMquurmFyTmfwK9+DxaZVK7jy4vckIdG+UZEtwSY3AairGi?= =?us-ascii?Q?d/8A2U+TU/sOyPCq/qZjNS1nbhFLaa3ZH7zv9w=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-ab7de.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR02MB7933.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 823b0140-0116-4832-0af2-08dbe9b30340 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2023 10:25:26.5999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR02MB6120 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,crossedcarpet@hotmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 073bDKStHTdw54oeExEgsEkCx7686176AA= Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_PAXPR02MB7933CED996F966F2E302A97FA1B4APAXPR02MB7933eurp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HaYeWtH7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=hotmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_PAXPR02MB7933CED996F966F2E302A97FA1B4APAXPR02MB7933eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good morning Laszlo, Thank you for your reply. I feared this was intentional due to believing th= at it would have been caught with automated testing. Doesn't the Azure Pipeline try to build all packages to make sure no depend= ency broke? Also Liming, would you do me the honour of creating a Bugzilla account for = this email? Best regards, CC ________________________________ From: Laszlo Ersek Sent: 17 November 2023 16:06 To: devel@edk2.groups.io ; crossedcarpet@hotmail.com = Cc: Liming Gao (Byosoft address) Subject: Re: [edk2-devel] [Bug] Building NetworkPkg fails due to missing Sy= nchronizationLib dependency of BaseCryptLib On 11/17/23 13:49, CrossedCarpet wrote: > Steps to reproduce: > - download and setup edk2 > - run: > build -a X64 -b DEBUG -t GCC -p NetworkPkg/NetworkPkg.dsc > > Get the error: > build.py... > /.../edk2/NetworkPkg/NetworkPkg.dsc(...): error 4000: Instance of > library class [SynchronizationLib] is not found > in [/.../edk2/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf] [X64] > consumed by module [/.../edk2/NetworkPkg/TlsDxe/TlsDxe.inf] > > Adding this LibClass to NetworkPkg.dsc solves it: > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizat= ionLib.inf This is a regression from commit 5d5be45bd111 ("CryptPkg: Enable CryptoPkg = BaseCryptLib ParallelHash for PEI and DXE", 2022-12-02), which was made for= . It added a new lib class dependency to "BaseCryptLib.inf", but it didn't en= sure that all DSC files in the tree that employed the "BaseCryptLib.inf" in= stance had a resolution for the new lib class. Indeed it is not just NetworkPkg.dsc but also FmpDevicePkg.dsc that's affec= ted: $ git grep -l -F CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf -- '**dsc*= ' \ | xargs -- grep --files-without-match -w SynchronizationLib -- FmpDevicePkg/FmpDevicePkg.dsc NetworkPkg/NetworkPkg.dsc It also *seems* to affect at least one platform in edk2-platforms: Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc (although I realize this last DSC file is an "include" DSC, so the missing = dependency could be resolved in the DSC file that includes this one.) Either way, thanks for catching this; the edk2 issue should be fixed prefer= ably during the current hard feature freeze (for NetworkPkg and FmpDevicePk= g). > I tried to open a bug in bugzilla but I wasn't able to log in or create > an account. How should I do it next time? I think the bugzilla account creation was disabled due to spammer accounts. The way to request an account is described here (linked from the bugzilla.t= ianocore.org landing page under link "Reporting issues"): https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues (I've added Liming to the CC list of this email.) Laszlo >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111466): https://edk2.groups.io/g/devel/message/111466 Mute This Topic: https://groups.io/mt/102646401/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_PAXPR02MB7933CED996F966F2E302A97FA1B4APAXPR02MB7933eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Good morning Laszlo,
Thank you for your reply. I feared this was intentional due to believing th= at it would have been caught with automated testing. 
Doesn't the Azure Pipeline try to build all packages to make sure no depend= ency broke?

Also Liming, would you do me the honour of creating a Bugzilla account for = this email?
Best regards,
CC
From: Laszlo Ersek <lers= ek@redhat.com>
Sent: 17 November 2023 16:06
To: devel@edk2.groups.io <devel@edk2.groups.io>; crossedcarpet= @hotmail.com <crossedcarpet@hotmail.com>
Cc: Liming Gao (Byosoft address) <gaoliming@byosoft.com.cn> Subject: Re: [edk2-devel] [Bug] Building NetworkPkg fails due to mis= sing SynchronizationLib dependency of BaseCryptLib
 
On 11/17/23 13:49, CrossedCarpet wrote:
> Steps to reproduce:
> - download and setup edk2
> - run:
> build -a X64 -b DEBUG -t GCC -p NetworkPkg/NetworkPkg.dsc
>
> Get the error:
> build.py...
> /.../edk2/NetworkPkg/NetworkPkg.dsc(...): error 4000: Instance of
> library class [SynchronizationLib] is not found
> in [/.../edk2/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf] [X64] > consumed by module [/.../edk2/NetworkPkg/TlsDxe/TlsDxe.inf]
>
> Adding this LibClass to NetworkPkg.dsc solves it:
>  
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroni= zationLib.inf

This is a regression from commit 5d5be45bd111 ("CryptPkg: Enable Crypt= oPkg BaseCryptLib ParallelHash for PEI and DXE", 2022-12-02), which wa= s made for <https://bugzilla.tianocore.org/show_bug.cgi?id=3D4097>.

It added a new lib class dependency to "BaseCryptLib.inf", but it= didn't ensure that all DSC files in the tree that employed the "BaseC= ryptLib.inf" instance had a resolution for the new lib class.

Indeed it is not just NetworkPkg.dsc but also FmpDevicePkg.dsc that's affec= ted:

$ git grep -l -F CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf -- '**dsc*= ' \
  | xargs -- grep --files-without-match -w SynchronizationLib --

FmpDevicePkg/FmpDevicePkg.dsc
NetworkPkg/NetworkPkg.dsc

It also *seems* to affect at least one platform in edk2-platforms:

Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

(although I realize this last DSC file is an "include" DSC, so th= e missing dependency could be resolved in the DSC file that includes this o= ne.)

Either way, thanks for catching this; the edk2 issue should be fixed prefer= ably during the current hard feature freeze (for NetworkPkg and FmpDevicePk= g).

> I tried to open a bug in bugzilla but I wasn't able to log in or creat= e
> an account. How should I do it next time?

I think the bugzilla account creation was disabled due to spammer accounts.=

The way to request an account is described here (linked from the bugzilla.t= ianocore.org landing page under link "Reporting issues"):

  https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues<= br>
(I've added Liming to the CC list of this email.)

Laszlo


_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#111466) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_PAXPR02MB7933CED996F966F2E302A97FA1B4APAXPR02MB7933eurp_--