From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.49]) by mx.groups.io with SMTP id smtpd.web11.21718.1621854428505948003 for ; Mon, 24 May 2021 04:07:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ItrZIAEm; spf=pass (domain: arm.com, ip: 40.107.8.49, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uONUIMu58PALrNPsOC6Rw1dxQzN6DxZi3g6f7o5UrJU=; b=ItrZIAEmfu2Nj0n1XPwwnRBAJTpk8JCymm5MUprVfy1BdGF50a3wOHF7bCoeFkb9GD5fFvA0Urf6ZsL5ImvsqYhcUNLIGLnmn6A0vTy+0a0n5ol7DLkDfzerucFt8sNwpi3LlZpF+Ohlxi4dwiF7GghCoe8WuwLMksJWVg8OHd4= Received: from MR2P264CA0027.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::15) by HE1PR0802MB2218.eurprd08.prod.outlook.com (2603:10a6:3:c7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Mon, 24 May 2021 11:07:04 +0000 Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:0:cafe::4b) by MR2P264CA0027.outlook.office365.com (2603:10a6:500::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 11:07:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 24 May 2021 11:07:03 +0000 Received: ("Tessian outbound ea2c9a942a09:v92"); Mon, 24 May 2021 11:07:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3eb37718eaa0bb1e X-CR-MTA-TID: 64aa7808 Received: from 97a54936caed.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 378032E8-90B8-435B-AF70-177DABBA9964.1; Mon, 24 May 2021 11:06:49 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 97a54936caed.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 May 2021 11:06:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HbtnwMPRt2WL4QewsapVnUvx4Bp1vUOsxI9Pivo0R+tLfZXILajmx3b9cOE6uzYehCxettdgvMT5QKANH0UnqU3keJJAGdC2Gc33o74radYFWZ48c0VFrAkeVhhvkbGvWSCGn7Ng2eJwWayMoWLLRoxHxzgTWPjgk2HdKKf+aOXJobAjnjr72d2uFqHmS1pY2iAoGM4ymNlYRHtILb9ITlHX+Bp0b7zql6rh/QVBSGOeEUWfAaKr27J0sJWQhxnkjatZPwvbxUXe1UDkQEnPZOlgaruui+frp/o/Lx6VK1h+k2tP5qF/1KBqzQsvkJGQpp2+iwA7J7yTqjIMTND+og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uONUIMu58PALrNPsOC6Rw1dxQzN6DxZi3g6f7o5UrJU=; b=WJDhbpFil2IGUP5XLX0kNdHE0oOQfnpd7EV6nJLeAYM9PzYLytF8sr4W7Bt0KaxAJlm5j+LwjnkJkMOVe3J5L3BwntngKy628vM4sbJWlJVnsVF2Nvq0Z87aaGyU0LLWPnPKR9j9Waau48ye8LX4dw/gbyqUmLbuloVbMa+kGdLA9doQUx+eoAAO08scyn0q6MT/BEH/Ce1S9Pgp/wxPbAha4HkhiB1pSQCffFvONRTzqeI1GGV9bT6yZDA+9utCvXb4FqKF+TQiCWw4Vv8VcgCV//WAWu4fRxpouKIym2YWc2XTrk5H8+yafV4koDweIassH/wCFyFuUamEVd30fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uONUIMu58PALrNPsOC6Rw1dxQzN6DxZi3g6f7o5UrJU=; b=ItrZIAEmfu2Nj0n1XPwwnRBAJTpk8JCymm5MUprVfy1BdGF50a3wOHF7bCoeFkb9GD5fFvA0Urf6ZsL5ImvsqYhcUNLIGLnmn6A0vTy+0a0n5ol7DLkDfzerucFt8sNwpi3LlZpF+Ohlxi4dwiF7GghCoe8WuwLMksJWVg8OHd4= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PAXPR08MB6464.eurprd08.prod.outlook.com (2603:10a6:102:df::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Mon, 24 May 2021 11:06:48 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 11:06:48 +0000 From: "Samer El-Haj-Mahmoud" To: Marcin Wojtas , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Sunny Wang , "gjb@semihalf.com" , "upstream@semihalf.com" , Samer El-Haj-Mahmoud Subject: Re: [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1 Thread-Topic: [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1 Thread-Index: AQHXUF3UHDShPEKgXk+Wk6lz8ChntqryeAaQ Date: Mon, 24 May 2021 11:06:48 +0000 Message-ID: References: <20210524052919.2496579-1-mw@semihalf.com> <20210524052919.2496579-4-mw@semihalf.com> In-Reply-To: <20210524052919.2496579-4-mw@semihalf.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 51736b14-2663-4a29-f732-08d91ea40fec x-ms-traffictypediagnostic: PAXPR08MB6464:|HE1PR0802MB2218: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: n1agvyO1QWvwfMTBwCJgk7hMKuPo0kFe0wB/CPA7QJ1m/O7eX46vpIUg2fW99YvA3l02a2zh7cIQl9RqyBvIPYNe4W3dgCJK2uMFF88DOQeD/kXQlyff6PQNtRycUVV51tx7lo4DyuP7ij4KNSWcl1W+dDC+s38g+GGGQc7SOnrqLX1SbyUwqGfTl/Rq2hJ6RWqHU3uAfiMl2JPP8gJepH7E+fJYcxIXMdVA5xbeZqmFedqhHDO0kUNipBUuBIjYePdYPhNXSlNMJwziiVOth30FAwvG5gemcl+qx+h9/QxwIiTfOEj9gKFZ6f2yTMuL672FNHA6r4+ZPNs+uY0nuts6EU7gVtJu8sReE2GU8oiYmg0549qTa1Wv2BR2Qvf00c/UPyziVrHenexR4bpoYKH2WfSkdAt/naycAWsrTnSwM8z6vKx5EmneAn7IXtykGYzfrFzKDlqklOFX+n5j/wdfq1Y3EyR09zJ6mzMmlBRyKIS4OJp1tZIrG2NrY1vqO8K1Qs/wgKe02Bi5KsqjmkV6WdQbGWi7aUwSgENf1yTfoYkKKdYp3jiEMVdns3ZR9DKwUOiw6d9wVrXvgTQj7wlqG5hLApeTSdjNws/TNzjQPt2izCl4Yhlerkyr+6ZVN++vLha20QuKVwqbssWpN5C1vaLqmjJ8vvIpf3YDmwh0TRFOj7wzuBO8iqHFDhgpbFMPQaR0x1zMJldmnKuWKKPbTzGWYuEwvK06apgv6yU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(71200400001)(52536014)(110136005)(38100700002)(86362001)(478600001)(5660300002)(316002)(7696005)(4326008)(66556008)(26005)(66476007)(33656002)(9686003)(66446008)(55016002)(2906002)(8936002)(8676002)(6506007)(76116006)(83380400001)(54906003)(53546011)(966005)(186003)(66946007)(64756008)(19627235002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Vv+iUtMzLFW0dUGlm7UR3eM3EbWClA9j7AEV6W0WLr8jy6NqNn0z4T4InRpH?= =?us-ascii?Q?kwSIDOdzkHdXvZi4ydgQT2+yJrQqCiJy1ZDvQXeGYiHVB+Q2ncH/VHY5kNC/?= =?us-ascii?Q?bjBkmpxlzOdyc1SKL/bguClCNWdElTTzgLbWXLVeKZNiMYr41KEZNn63beQ+?= =?us-ascii?Q?ZrM5bagG8hTF6Ji3tsWACfUWLMSQnJXuxHyUOHT9qdrmSaTD0vXUEmT/Bjj6?= =?us-ascii?Q?OfLNozANSVkkUJv5ER/9Osz2p99zYnBtQ3xNyfss6FPR2yUKqQGEZdEwptIS?= =?us-ascii?Q?QXezX7hnQCBkgHwtwvy5vVu1AJcOaG3gYALl1TAwYPOdSL+RhRyxedgV4A3D?= =?us-ascii?Q?aqPpDD6tbATUyRFjQwGuUEthTMnMrE8bVior4Ixv4m0VWgMD3T+ARPnx0rzG?= =?us-ascii?Q?k3BKK/9fp4X1jOnxVUx67OGxPhX8TLWOY1y33GSmRnF4qvcwm8kSm9Iiq4Dl?= =?us-ascii?Q?cwyqy2NgStHtPSuHqFy8FdtNt/udcKcW8A73zFF9nKOYIEjBkS7TcBhwaAqD?= =?us-ascii?Q?/W36QmCdo2KyCQvfP8+tX8rPDMuTnqgEapKMuO6GG+ya+1mict83UuXregT/?= =?us-ascii?Q?FoFzPZ6JkM/zYH2lLk/deNre5A0BEDi7PD/VpdmsUFlB3BWZUSi2zT78fHPF?= =?us-ascii?Q?yDGnsdTdnFZRNb/CTX/YpmtE02reDNgGJ34BcfKnnrmNEulWbO1gMNsPRa4X?= =?us-ascii?Q?XTQpfnIyRfVvcgTCVnhSogez/KL3YoeVdeZbyLeyBm3YbC17dozi+KeqjVxb?= =?us-ascii?Q?arJ3TTCBzHLg4tqBidJ2iDhUoOoDWJDRfJolMWjI9DUZ+ARTsKBVT79vZ4z2?= =?us-ascii?Q?+l+2nW7BK0J1E91B22SWxqwdJ1ZS3VFcA4cMQS0A5Iqdxuaqcoud2RR7TIuv?= =?us-ascii?Q?jIWRBpOFSWtOZAIeXCc6s+IHKqNA5y5mTwfhSbMcpMKxuWoy9+bb0NKLgozh?= =?us-ascii?Q?4aj9L2naQrRnbRttdu6FxRxOSjcNHmrO6fMuyyIGaiT6cKuMLwC3enpUpf47?= =?us-ascii?Q?7MkFkFPihgdImVnMko70mYVS6PWX5LquEBNCjEdttSuQjQjdRVtdHlwLQfq0?= =?us-ascii?Q?MeuoCRZaTnSNuAy5j3Bw3scUdnEUDKMfXOqm4eUnwWLMqyJMBtzEVc5bkkxP?= =?us-ascii?Q?QIK2LJ43iEGow1H7ZPAvz1i11eGvHtR/vSjPeteVvWggxnky+vk2MIqtnhEN?= =?us-ascii?Q?6g1NUyF7EjJVJR/BsHBbEUN2r3L+I50e0ZINSKNa7BSN9vjsV2MPkelkbyP8?= =?us-ascii?Q?AVnL51WuljalISy7tMqrJ2TNkIbNDj/1y7ffkH9qfuVhtNDzrgCfpt0udkEs?= =?us-ascii?Q?XqFgZfP5wT28fywOoxqe/AJ0?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6464 Original-Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 911786ae-759d-49c5-fe4c-08d91ea406b8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ruSgduGXoTtOklOUYZNPUGCP6gDdm5E0aIjpYAjIf8UO8KD7CvTYdCEsoHaMrgiGM+lq24WNnZrvOwuber96+SL6wEpSO3ep8I/n8bDzZhOlKmLhkXVuoUdFlov3KamjnbZX5khebXg3WthHmpBtRU++dGMP9sA3/K/U3ZqZ5cT8eW3h2CONoVH0CkqT1+C/lpHyPsF1kCMDcUUmNPcoIoYIqvLXGsY4JY+bD74tcwk8yQkKCQJaJT9jQ50dxfId4UAuzOu72XaFo6R5JwcQxV3sTGW+Sc2mAE5RrryQau/bm309s+d009R90x1ZQDRQV+TM65VQQFr75evt7DfdmcpllCuzv4a4oPIj0pHL0VQZkuhMsH1bmcmXDZEd1Aj/eOeoBPaU68ikx047598tWy0DuoOAZTg0A1McSMlhY8jzCLizn7ctmL2ykAvahaXuFXR/espOrAd9YYck8ZfPzAfJCWo0tbztCKy1c0Wzkw68jeotl35b18WNZv9sdBiCGOt12fYcBtfH6kB3LXz3Uz23rE2bhpNLE1zb9o7X7IGXYlwogCysL1Fo3RcSiIkBl58eUqg6LVrXLuezOYhdAwS/j6OzkmJALDVDtf8T5fprRuBmPg1lJ5Fq4Ligl2SXEgMRUk2FUbd9soR2Cg/KbEUGgCEzuIRNhG0oG5ZJG7mGbRahJsYfOlIbOQ8v7xAYy2TBrmOl14sMuPW5R4C9Geasb1HSIrvQYXA9F2IvHnml6kdfOGNMndrstMKOiehUMwZrt1yDsEGOnukb9IspEg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(46966006)(36840700001)(82310400003)(52536014)(9686003)(26005)(47076005)(4326008)(19627235002)(5660300002)(36860700001)(53546011)(478600001)(7696005)(6506007)(86362001)(966005)(70586007)(2906002)(54906003)(110136005)(83380400001)(356005)(336012)(8936002)(316002)(70206006)(186003)(33656002)(81166007)(55016002)(8676002)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 11:07:03.9014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51736b14-2663-4a29-f732-08d91ea40fec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2218 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the patch. Not an issue with this patch specifically, but it seems this #define EFI_AC= PI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16450 should probab= ly be renamed to reflect the latest spec (at https://docs.microsoft.com/en-= us/windows-hardware/drivers/bringup/acpi-debug-port-table), which says: 0x0001 : 16550 subset compatible with DBGP Revision 1 Maybe you could send another patch to do this in SerialPortConsoleRedirecti= onTable.h ? Hopefully before this value is used by other platforms (this pa= tch introduces the first usage of this value in edk2 and edk2-platforms) > -----Original Message----- > From: Marcin Wojtas > Sent: Monday, May 24, 2021 1:29 AM > To: devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang > ; gjb@semihalf.com; upstream@semihalf.com; > Marcin Wojtas > Subject: [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch > SPCR UART subtype to 0x1 > > DBG2 ACPI table description [1] specifies three subtypes > related to 16550 UART: > 0x0 - 16550 compatible > 0x1 - 16550 subset > 0x12 - 16550 compatible with parameters defined in > Generic Address Structure (GAS) > > It turned out however, that the Windows OS treats 0x0 subtype as > legacy x86 UART with 8-bit access. ARM SoCs can use types 0x1 (16550 with > fixed mmio32 access) or 0x12 (16550 with fully respected GAS contents). > > Switch Marvell SoCs ACPI UART subtype to 0x1 - thanks to that the > same firmware can run properly with UART output in Windows 10, Linux > and ESXI hypervisor. > > [1] https://docs.microsoft.com/en-us/windows- > hardware/drivers/bringup/acpi-debug-port-table > > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc | 2 +- > Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > b/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > index 438cf7880e..6efc175bdf 100644 > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > @@ -22,7 +22,7 @@ > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE, > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION > > ), > > - > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > 16550, // InterfaceType > > + > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > 16450, // InterfaceType > > { EFI_ACPI_RESERVED_BYTE, > > EFI_ACPI_RESERVED_BYTE, > > EFI_ACPI_RESERVED_BYTE }, = // Reserved1[3] > > diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > index f663d8ade8..2a3415f0a6 100644 > --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > @@ -22,7 +22,7 @@ > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE, > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION > > ), > > - > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > 16550, // InterfaceType > > + > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > 16450, // InterfaceType > > { EFI_ACPI_RESERVED_BYTE, > > EFI_ACPI_RESERVED_BYTE, > > EFI_ACPI_RESERVED_BYTE }, = // Reserved1[3] > > -- > 2.29.0 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.