From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.56]) by mx.groups.io with SMTP id smtpd.web12.24356.1621868680018017306 for ; Mon, 24 May 2021 08:04:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=jo6EcrpR; spf=pass (domain: arm.com, ip: 40.107.21.56, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aT5C3WGVWsNF9OF/HYwWfLt2EvGAJtbsTUx09KtAyxk=; b=jo6EcrpRIpzC0KxD3MEcLmnpX4otEP0pPFn2fmonpkrKTNyBpf6u39eurV0UbFo+w0rJ3yns0adqZw2zW2eVYR1r8k6yvsnz7/GOoyzSa2CS7nuAEBSZ62yoE5uHSPKLMxqcrM2STZXDDybzvprD7CuhcWp1KHCSN7GK2ydwn1Y= Received: from AM6PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:20b:6e::16) by AM5PR0801MB1747.eurprd08.prod.outlook.com (2603:10a6:203:36::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Mon, 24 May 2021 15:04:32 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::b9) by AM6PR02CA0003.outlook.office365.com (2603:10a6:20b:6e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 15:04:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 24 May 2021 15:04:32 +0000 Received: ("Tessian outbound 3c5232d12880:v92"); Mon, 24 May 2021 15:04:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a2cace0da00c4265 X-CR-MTA-TID: 64aa7808 Received: from 0db3f7cd04b3.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 85B8C1F1-1196-40D9-9BC1-A3A09C27B7AF.1; Mon, 24 May 2021 15:04:25 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0db3f7cd04b3.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 May 2021 15:04:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMxDlGGHdpSHGMoXZxgAirU4+84hktMdo4BYi5Yd2Bz3QIpS0PY4SmasfHL89xcz5dTKCwscG5WszKNR4KF0kYftt2Ii9OPm/dzqi20v3YFa58EB/JQE9+ms9eT2Xw3fdX8m3tIQQHb6/nK7f3X5esl3vbb0WT2DgPVeWjNabRHUGTFy/RZ9x4R4zL93V575BTNrls3FIXOs6BFUF7Cz1q2B9Dg1Sn9sRdMSkzP6fKdAvR697XQ0/wc6O4WLNqR/MsLetZrensZYCGtX63U+VNOPV7z3h42a/xeBRYuR3ZS8OzU8wt0F3tyCjAZHyPvV4dcP7Jz8Y6yWenGrCugBVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aT5C3WGVWsNF9OF/HYwWfLt2EvGAJtbsTUx09KtAyxk=; b=SUAjOHWhM0COg8cuT3iPp99Z0qd6THlRCT/twWXJ7+id+Cmkoy/MdLf8/iE5TL9gsD0GWJUbNhu2EP49vl3wNQUU/TmLPR37w0A30QByx7RleDr/lBEXNgueFsfkDbMyZya7PC1WZjoel07Ov6A1ZgOsDLZBPz1Mg4pLEfd4gB3z2DtyPmoKK9z+hDtwX+9+JxF+yjbbjnG0qb162LYgBtmBYO5iFEj3WbGRvwH2RZLqiBlMVsG/tWhF4VfpTseB7yTsov1c172oaPPgI5v48igZwZjZfeeUwkMPgrgihQdPvpRKGPSLcTiy103zOB2+JPmkB28kjNPAQLpv9ux+oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aT5C3WGVWsNF9OF/HYwWfLt2EvGAJtbsTUx09KtAyxk=; b=jo6EcrpRIpzC0KxD3MEcLmnpX4otEP0pPFn2fmonpkrKTNyBpf6u39eurV0UbFo+w0rJ3yns0adqZw2zW2eVYR1r8k6yvsnz7/GOoyzSa2CS7nuAEBSZ62yoE5uHSPKLMxqcrM2STZXDDybzvprD7CuhcWp1KHCSN7GK2ydwn1Y= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PA4PR08MB6032.eurprd08.prod.outlook.com (2603:10a6:102:e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Mon, 24 May 2021 15:04:23 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 15:04:23 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , Marcin Wojtas CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Sunny Wang , "gjb@semihalf.com" , "upstream@semihalf.com" , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1 Thread-Topic: [edk2-devel] [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1 Thread-Index: AQHXUF3UHDShPEKgXk+Wk6lz8ChntqryeAaQgABDTDA= Date: Mon, 24 May 2021 15:04:23 +0000 Message-ID: References: <20210524052919.2496579-1-mw@semihalf.com> <20210524052919.2496579-4-mw@semihalf.com> <1681FC02AF1B6E10.27195@groups.io> In-Reply-To: <1681FC02AF1B6E10.27195@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 189154e4-f84d-4a69-f5ac-08d91ec53ca1 x-ms-traffictypediagnostic: PA4PR08MB6032:|AM5PR0801MB1747: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9l7O9fzlr4P56Hg3WYKFTog3/RfLRh9FGdMc78Y/TOCwYFYIuehOxNyraoFaqqNOcMm3ItoHtSBNFzjkCSORdKw+E7mPusIuG5t/OZDpGuYLysrDqkgaPulB6y+x8d+FjAK7KwIgLIaIuDfzUivRm1TumlFlvNJOyO3qUr8N57wcdyyEqI43Jtlv61i+tK+iWJRiE3i384tsFdd3WT4NV7guuvnkLfGuZ+Pt4sbKP5/migUi6FkvXWRHJ/jppX9VdX7F53KuGohXLleLhHzKh5CIHdPIEypJDe28kswR0OXrHLa6zKGggNLTuYrPzlBAAY+PkZtAfkl+u3xdQqJcJQOY4ynwX+l4Fn2HI/ddqB2HGHsJfPUWpcTjksjw1r1HBnUGDKgictko8jK3vvYQLNrk517iZfTScJaPrifchxSm8u6rYZNZfcEAsxBHFsbOa4k+IQO5ae0zy/1yi2dN8HW0jr+VGlPYDt8b+6QumT5Au0+a2fB26qmGGCnZL/U+r2Q3EkQA+uzhsvCns+Z7MIZBgY5N7/5Y1NvrOiHm1BWkrV5OqHQKr7LWLH+TxZ15RNu3hT35T1oKjkcEJNjn/uKtNyz2i1/NERDCGJz3uheXHIHOyV8AnlKjj+aIPqL9+LgLkXtvTFRNvS6dsnzWIl4TBp4JGfNFvvkV5bjAarx2T9Y55l9XwUoZkNg3bSrQoYnzM7bhBBuMyoY7EGzFwH4Pdj0WUlwuBkMSdJycodk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(39860400002)(396003)(366004)(186003)(316002)(478600001)(26005)(54906003)(86362001)(55016002)(52536014)(122000001)(110136005)(7696005)(19627235002)(966005)(6506007)(53546011)(33656002)(38100700002)(5660300002)(4326008)(8676002)(2906002)(9686003)(66556008)(66476007)(64756008)(66446008)(83380400001)(71200400001)(66946007)(76116006)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/P0HktJWcRBJFcbj53hgTLAjvig9wGKI5s3GuV9DqoczriXIhwQAcSBkaiFS?= =?us-ascii?Q?QO2eWhKN7X4SzV+85hPBGJP+e8ykoVRINdHHdfzUhGUr5XpWhZWuKjkeDi74?= =?us-ascii?Q?73gAt8OSIqfs4nyfvZqAEr1e8SGhGd36E9KTl7xTHUMBEPyRuwHkOddma9/G?= =?us-ascii?Q?5uonSF8lRZYRBNbQJHOFsxifmCjCyLSRpB8vpycxYXZrlAW2k0fvQHNASHfV?= =?us-ascii?Q?i5I1dtoSjW5XqCTEHBrHYInHV13HKRQnTtLSFyxIPc55KCrJ2SIey5vA8RIv?= =?us-ascii?Q?3vAlPo9GE+10ejJ3vS6w413STc42qtSf/xQHGVnsYmxWE4l2t9iDwSxnpScm?= =?us-ascii?Q?tSOyPVHIp0yRCeas5iVFOVlUoBzWQ9qVYZsYg6srYcJjIMZZljHVunmX7Boc?= =?us-ascii?Q?6zXb14wKvwr5I/OHtIVbAqgUlf+vBABKbrFGW6GCF4yoRuUFA6lt0e0uOLyI?= =?us-ascii?Q?EvjNB1zjeN16ljBC6AOaM686k0dy+7cNXJHhIeLY3q4rlxGtSZenzjJ7Y11v?= =?us-ascii?Q?f7SzkoYJDsRM/39wdKCeYXUl5yTa+IW6EnlSWIIFrYgVeaQ88R1Tq1p6YsyN?= =?us-ascii?Q?jsfm1RXddi5I6xztzXCP1+2l7zcNN0QRoN2Oth3xXrPvic0Oeh/cK6nk9U/4?= =?us-ascii?Q?Mhdus10H0ctiEDHc09Vl/XJ8356tflHNgrWeiToDbFPOjzoMXzwZD7ZHnAcs?= =?us-ascii?Q?HFNqhr+B+G4fLCarFuPVqR2x2efOZ0inJNt1BWFRX0mgqnkh8v6FdWeROtP0?= =?us-ascii?Q?mEab4JeGGw0go9jMl0+9FNUA5zP//JHKrkpvtRz1x04KPT3upDKUDO+k64VQ?= =?us-ascii?Q?wOnjORmqlcrBt1iyT/ZUkfVy2+Le6av4h3RmG53vXalZdhH1rD9V+nomtkWU?= =?us-ascii?Q?ry+ytdJ2u8Kk4nAZXVdQgjy1OouOULA85DXFTPhhuy9C6eqd3iNhZyPzg9gf?= =?us-ascii?Q?3zwFgfAEHFCUsDFcltEWLHNUD0p7hcXKj8II+Hgti+EOE3mjp1nnwWvsVFAB?= =?us-ascii?Q?gUoTL/GqYiHrCuC+ulrwAN3HaFHzI6dQGIVSgYOLA4CNWlGy1G/Deq4mP7Cz?= =?us-ascii?Q?sRi08Cx5UJ1LzQcDMYm5njOAPo2FfpM8D+3DHMK5E8Sfeykn4isfLAn0akn2?= =?us-ascii?Q?kjcWm4JNQmM8tzwlDbG+m76NgPltxGD47hT445cqFicmzLCauUwpnIMmIN5U?= =?us-ascii?Q?TGYDOV1pq3k9rBtWo7xiwDmkMwWNgipOqpoZIk1RLgSV6OX6X5cmFe+7lbZQ?= =?us-ascii?Q?f3BwuLC55OITTKyPGyh+Ll2mpG4YauHKejskOj+J9no6vcLQtGTN76Vy3zKX?= =?us-ascii?Q?DUoXZB1Q8BfFExAzEp3Kl9Hw?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6032 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a9d0669b-3ed4-4a82-3018-08d91ec5375d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8gr1vNLeEHV6JBFdKJiZpPYbFSosrPTb11qQTn8sH+y2UZMwxQGjO9V6gT7JLWaOsoKBo6CVaJ/920VbzvGihrM1q/CFwGYYH4QD/MBpYhYJ9TgCPbrUULJTeJ8pZc39ciGAppVY5+2yMDhqsc6OEuvehqkApIwmmD39anOxgFE1SWs+G/VAevjkSulvH9J4XXnj5QkyA8/fZWX0RT9USRahi62yp8avL9CYi32A7BA4FIgZTTJwW34tf9AMd7NpaMhLkDSRA3NCZv9Ox/Tr6LaG9UVpZ4pyBnRqQ3HhZB3NjvSob5qJEXA6zXvstUtWKr6QyuBflLtYZQuX8h65eGnSIIEfp2wgXQu66EOCzZsgmBkYuZukcW8dM8YecSKpZpuy+Mmi9bNCdGymQhznuhEEh1ny28JN6m+safvrfzfcG5p2avNbiVhMZ/PxomgeznoeFmkiTQxfdjI0/H7B5Ojw+ePNU/q7mGXcLMicmELdy8KHFXelrD+f6Tm8RZCdHK0qazNrGr4hdup/flbUCU0PpLJM1Zzy2wVyhkzalhdAVqHoveighz5YVP8VmW/9+edXCEqFB1FGLNXA4S7DbVE98M/cvMk2TDyzTjA3UsWW9eUR+rbW317seYD6cRQg13Nac7nteGf1ei7OGR6ojC03nGowTTBpUUnl8Ol3inboUmpLNZuOzHAbPkf0gqRSK26r3U8OhWLysGXdWu0kHF5Ain/Y6ggVS7qjDfQUNw88/+HiziXyx63mDfr958qLtWKQxXigZ2nHyk+wQv4bFA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(46966006)(36840700001)(26005)(33656002)(52536014)(70586007)(70206006)(9686003)(36860700001)(19627235002)(55016002)(2906002)(966005)(4326008)(53546011)(6506007)(186003)(7696005)(316002)(8936002)(5660300002)(336012)(82740400003)(54906003)(110136005)(86362001)(8676002)(82310400003)(356005)(81166007)(83380400001)(478600001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 15:04:32.2955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 189154e4-f84d-4a69-f5ac-08d91ec53ca1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1747 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That being said, for this particular patch Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Samer > El-Haj-Mahmoud via groups.io > Sent: Monday, May 24, 2021 7:07 AM > To: Marcin Wojtas ; devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Sunny Wang > ; gjb@semihalf.com; upstream@semihalf.com; > Samer El-Haj-Mahmoud > Subject: Re: [edk2-devel] [edk2-platforms PATCH 3/6] Marvell: > Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1 > > Thanks for the patch. > > Not an issue with this patch specifically, but it seems this #define > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > 16450 should probably be renamed to reflect the latest spec (at > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi- > debug-port-table), which says: > > 0x0001 : 16550 subset compatible with DBGP Revision 1 > > Maybe you could send another patch to do this in > SerialPortConsoleRedirectionTable.h ? Hopefully before this value is use= d by > other platforms (this patch introduces the first usage of this value in = edk2 > and edk2-platforms) > > > > > -----Original Message----- > > From: Marcin Wojtas > > Sent: Monday, May 24, 2021 1:29 AM > > To: devel@edk2.groups.io > > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj- > Mahmoud > > ; Sunny Wang > > ; gjb@semihalf.com; upstream@semihalf.com; > > Marcin Wojtas > > Subject: [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: > Switch > > SPCR UART subtype to 0x1 > > > > DBG2 ACPI table description [1] specifies three subtypes > > related to 16550 UART: > > 0x0 - 16550 compatible > > 0x1 - 16550 subset > > 0x12 - 16550 compatible with parameters defined in > > Generic Address Structure (GAS) > > > > It turned out however, that the Windows OS treats 0x0 subtype as > > legacy x86 UART with 8-bit access. ARM SoCs can use types 0x1 (16550 w= ith > > fixed mmio32 access) or 0x12 (16550 with fully respected GAS contents)= . > > > > Switch Marvell SoCs ACPI UART subtype to 0x1 - thanks to that the > > same firmware can run properly with UART output in Windows 10, Linux > > and ESXI hypervisor. > > > > [1] https://docs.microsoft.com/en-us/windows- > > hardware/drivers/bringup/acpi-debug-port-table > > > > Signed-off-by: Marcin Wojtas > > --- > > Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc | 2 +- > > Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > > b/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > > index 438cf7880e..6efc175bdf 100644 > > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Spcr.aslc > > @@ -22,7 +22,7 @@ > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE, > > > > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION > > > > ), > > > > - > > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > > 16550, // InterfaceType > > > > + > > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > > 16450, // InterfaceType > > > > { EFI_ACPI_RESERVED_BYTE, > > > > EFI_ACPI_RESERVED_BYTE, > > > > EFI_ACPI_RESERVED_BYTE }, = // Reserved1[3] > > > > diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > > b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > > index f663d8ade8..2a3415f0a6 100644 > > --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > > +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Spcr.aslc > > @@ -22,7 +22,7 @@ > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr =3D { > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE, > > > > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION > > > > ), > > > > - > > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > > 16550, // InterfaceType > > > > + > > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > > 16450, // InterfaceType > > > > { EFI_ACPI_RESERVED_BYTE, > > > > EFI_ACPI_RESERVED_BYTE, > > > > EFI_ACPI_RESERVED_BYTE }, = // Reserved1[3] > > > > -- > > 2.29.0 > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended rec= ipient, > please notify the sender immediately and do not disclose the contents to= any > other person, use it for any purpose, or store or copy the information i= n any > medium. Thank you. > > >=20 > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.