From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.43]) by mx.groups.io with SMTP id smtpd.web08.34492.1620664925724280533 for ; Mon, 10 May 2021 09:42:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=u0r/ejqw; spf=pass (domain: arm.com, ip: 40.107.8.43, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10xHvjXz6dMpV8TE+kr9cZYgBgMm928kmoW9YrwRaiA=; b=u0r/ejqw6cfHRFPyqwm6lCz2GD630a/UYJ93VRlZnqCfZenezfUqVTYMCsRuVne6+XpYDam5LPuB6416I06rWiO7BNhkRfVwP9JJKwgp9lL4CYqgalK2pR4H5tBWwRzYUQXBm/o3L1rEEOZQhZpSJC4dE4QnhwKtheB1LbKk1T8= Received: from DU2PR04CA0269.eurprd04.prod.outlook.com (2603:10a6:10:28e::34) by HE1PR0802MB2490.eurprd08.prod.outlook.com (2603:10a6:3:d9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.31; Mon, 10 May 2021 16:42:02 +0000 Received: from DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::e5) by DU2PR04CA0269.outlook.office365.com (2603:10a6:10:28e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Mon, 10 May 2021 16:42:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT039.mail.protection.outlook.com (10.152.21.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:42:02 +0000 Received: ("Tessian outbound 6c4b4bc1cefb:v91"); Mon, 10 May 2021 16:42:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2fe9e6253c9ddbcd X-CR-MTA-TID: 64aa7808 Received: from 9badf8d177f1.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 78E9E2CA-E9DF-4B6F-8B4A-A422B18E0BD1.1; Mon, 10 May 2021 16:41:50 +0000 Received: from FRA01-MR2-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9badf8d177f1.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 10 May 2021 16:41:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hEDqmoKSacSEwSDDU4hxKXDn7aW9SY/P0rXwIn1txJczAjIxKqZuMzrl4VlgCWEF87E00y83dC7MGaKMroaafM4/oTfS+uHh7NIAtAJypCDgQXzhJYW105Cn0ILZMEFFXXJOToAWk2PGIR7+HVPyMDuA5AzAsG0gxPgstuGB4BPGwhIu4MXYtkE+ezIDI0tpIrSOO+okGy8HPtdjzQPCUqnf+JrHN8dQB1c4376HQ38kRs0NeGddxqRTkPr0emH+5ObhmgsECXaR0VEUhmrq+x8C0UMMR6QvqRFAxxDWgJOC/LA7CL1KCMvFrYsj8iNO/+IPYZHnbiYFUe7iHOajFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10xHvjXz6dMpV8TE+kr9cZYgBgMm928kmoW9YrwRaiA=; b=j1P840kC6Zd82w0CdxpV/FfTJHHryMU6v+Ex/aksfbU1EaJspkWjUpogRime6SbKU1Cfo4x9n/8Af7C3BWISmgZG3SbMAUWqeG/Zzb2K4+sRYRbqRkYVZuC+rve9dD3Gw58R6KJfjNbUDyhUnnc5sHJG7h/SNj3mfdzwCZX9f+kDb+keKuOqFyLyCr8o6E9p6SR7aLm6mPuKjEd0wgzukI8JQbuV9QUAb456WX+18gk4p5N9wyLwARyd03vSquwH6q4PNR0BQysvaZuwafV+UTFrf0NfxhcjkCfMPYJhq+0q+2HqI5pEu3oDhL7uj+5Pd94rrmO5x4Lt25NhjJA+Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10xHvjXz6dMpV8TE+kr9cZYgBgMm928kmoW9YrwRaiA=; b=u0r/ejqw6cfHRFPyqwm6lCz2GD630a/UYJ93VRlZnqCfZenezfUqVTYMCsRuVne6+XpYDam5LPuB6416I06rWiO7BNhkRfVwP9JJKwgp9lL4CYqgalK2pR4H5tBWwRzYUQXBm/o3L1rEEOZQhZpSJC4dE4QnhwKtheB1LbKk1T8= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PR2PR08MB4906.eurprd08.prod.outlook.com (2603:10a6:101:26::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.27; Mon, 10 May 2021 16:41:49 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad%7]) with mapi id 15.20.4108.031; Mon, 10 May 2021 16:41:49 +0000 From: "Samer El-Haj-Mahmoud" To: Jeremy Linton , "devel@edk2.groups.io" CC: Ard Biesheuvel , "leif@nuviainc.com" , "pete@akeo.ie" , "Andrei Warkentin (awarkentin@vmware.com)" , Jeremy Linton Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Thread-Topic: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Thread-Index: AQHXLDxM/kt8HQGBLEeo9k1B33/A2qrdHjyA Date: Mon, 10 May 2021 16:41:48 +0000 Message-ID: References: <20210408055843.2883563-1-jeremy.linton@arm.com> <20210408055843.2883563-3-jeremy.linton@arm.com> In-Reply-To: <20210408055843.2883563-3-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: dd42ab5d-585e-436a-a606-08d913d2898f x-ms-traffictypediagnostic: PR2PR08MB4906:|HE1PR0802MB2490: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3276;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KTWBFSSmoaiZPrFaQou/tlO1ROll3cKbevKlE6b7lT5d/xfZHLuQvdZ9pSWiU9tARqX7LOE0NqG5cmU14w0QnMSBOpOiBLcEeqdXGx6OXFuJxWxZM4MxUOLivC1i8MGagkVFpGIEuqiUy4Z62FfPIgC+MiUL34skboV8gS5PL0pVFUMF2wQNA50UvoxxoEkE/jOrvnltsbL49vu/F5W9dMQxJ6ksq3pHequBubHSGet1fku57BaG5TRngg51KXbTzZ1xBXL58tOjpXsumeX5nD0e4ivk/uo+2r4AtaAiD1WYJhCrG8xTMJjd8LJmfYo5h3O9VmSbWnchJcrryPyKpjzszBjMnQJg0FUg5iGSjrIK0yEMH8p24T/jyDMgRKH1ePfD/U4cQyr5gnkwjS49VcBPvuWCi/Hgey5tJkXaqaT6bWUiynPcHIiUXUhm+YLy6Wkty7dwt/Vn4RbfXeMRApvmuVtS7Xm0R5QF63P8H3T5HX/c/bD9jjHr8jI2P+hdNEz3F3z0+DuKIy5ilSZcF6zN52Nmn+3VFMU3jlqxy6Thl8ueqHGsGuM2b9JgG1mbMRETd5H1MbDXWCN1j+KxOGibMxjEjAj6qmlEb1CbzCw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(346002)(376002)(39830400003)(110136005)(66556008)(52536014)(83380400001)(122000001)(66446008)(66946007)(316002)(38100700002)(66476007)(6506007)(64756008)(76116006)(8676002)(54906003)(186003)(478600001)(53546011)(26005)(4326008)(55016002)(71200400001)(86362001)(2906002)(33656002)(9686003)(7696005)(8936002)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8fnuIF/S+C2q4BlySbzSHPszFh3IE07Dhn2/YBBLqNoVlH0gk+8QNQ+5ITpw?= =?us-ascii?Q?lGXoWCUnDpHMIBoiIqdcDKNV4FbUzSjFLnIUbA7Kf0ucoQqlBRhGtUnEd6ig?= =?us-ascii?Q?roBRGaEVo48KgpgwELZe4NvpI+wrJXjE0xo35UoiVTy7P9DdvW6OfqHSxecl?= =?us-ascii?Q?j02jR+140CNjdzLZSeWIJetWJMy1RrNxQ5VGfVzo4v1LjABAtcDPlAZanckc?= =?us-ascii?Q?+5XeG3NacwL6n5mztgE6g36Ak3njLlj1TzQ5edD5iEgefSBVitsUjqQPmhRY?= =?us-ascii?Q?E4vEP3uaigL8Svf3mJkW0mnPsnVSs0foG0lAmQ6MCaOX0uq/Me3LWyO/FT/U?= =?us-ascii?Q?kEu/Fovn7qo01XNaS5rPZ4FhHMW1Mhgp3g7sQrGXlJQWMqwLX1y50k49xDyL?= =?us-ascii?Q?dorD1g2BVH4rFps7zUkeIXnZeFPZlV0CQr2CjdBMRD6ibLNUuRXQRjde470Z?= =?us-ascii?Q?f+snNuYNTL8p4qi7gxkKrW+MbgPFsFoE4E+LU5dnEYdH7ALTzP6sUI2DTFI9?= =?us-ascii?Q?5NSVpw8NROnYwlLVsUEO3MOA10RSF7OR++BG3pWFJeOsWkoXX0BZVm4dWY/9?= =?us-ascii?Q?YQpK7E+5OsC95M5w+loGxEyLeOwg+5pyBwEkf8zc9umZnTGZwAOnNLbgQknZ?= =?us-ascii?Q?oUzrnaQ3Tpb1IvbCdsJFVt5JNtIEeI5yxu6rF/dmUQBbfV0MwOY5L3X4mUwO?= =?us-ascii?Q?K235cMb/SWC5D3R5CggPwhTyZrEI6s5zXw3MZfjKSTf80GCgJJVa0iFDwl7J?= =?us-ascii?Q?Khmagdiwmp7JZyrgor7E3zi9clno6OIaFscWPgQEN/cx/Anl8/U60plHlIG7?= =?us-ascii?Q?Ovas4qMCKnpX36kxd9iR/oaKkOISNILEcY95qpE3xXgU+3qXojumr2hccCkW?= =?us-ascii?Q?6iSmURxVb2H6MQ45l49M+nhegr1nkBu/Ztj7F3uB9PeDFQCQnXV52HDB+mDP?= =?us-ascii?Q?+7kVcj2XV0RK7C4nCh47+yE10zz7JBr182K4g2TutSJKbMMgp+Iwgytmn8D+?= =?us-ascii?Q?itqaXfmeIFS0gWvFv5KQpKrfzoQH7gAiPUbQLzfX+IDHGe05qto8VJHlZIGH?= =?us-ascii?Q?opGVk/OQHnW5j0ZFf0FQG+07/bzenOIOm5Lvoak3TfQskjXwXXA2qUS3OoeB?= =?us-ascii?Q?cJZXJBQ4YnJjWWFpvm+eQZGxSOGC4GwB+w0vSjfleOMeZq0qXk01tgmS2u90?= =?us-ascii?Q?gzAF7cZhTmkwpPLkYm9CkCF5Hdr1/FGWegbz4wPJ4iZA2G6M/mKZnf9F3whk?= =?us-ascii?Q?gq3AqA5oyHjjAej9qBR4+mJtVw/UUP1yr+2nqXBG8sV4b1R4XRwgTYngb2x2?= =?us-ascii?Q?JaOB3tXd3YBWwC0yqWB0VMdD?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4906 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9105acc5-fd9b-41c8-fd70-08d913d281c8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7zoSawHIZ3GAtTifXNdnQv4slHALiVbRzHr2S8f2C/vtAIX5rnP+Xw18CMYE1KudbibH1iTku24eMWsz33vej+JnwFps27gWEffDsgQ9tcZY39wn7go8hT92IkxJ6AWxSWnxO7Q/dy7GfW88cGdG1+qrmqUdiKTLxYTbAwL472LTMRpGaw6DPMsYrmC+BvQu9cR8rw6IjQGmVnNVk/0hNb90gvd9WJCZj4UUFDqfcOJpjAbnRLLPVjw7Cgqsg02o5DbRkzV9cuu45jPm1i1YoDOX9nUjoHI+JAfswl8yZLOd+4+hZ0rKbX6Sjoe261EqkPdZLr51/4pSuoyILmlEoVk65hEnI5nYaCSIStAxNeMgvoDzQRnckNC8+OLsyHxmqk6P0906mhW3aVq+iZpeg3EfrH0g68P7KJoyFl5pOZAxeilE5Ik41GfHsX2f4iGSi/P0ooi5LCE/fkDadZarRITWRx2lCxdcljw6hEaaudMLyeH+36kF6hvmoVIUUmmhuChL0JwD5DkAKklG0iVwiUWqh8ZnopaaKnp3jGD/U38Fo2FPmBAuLFY/aZxHybReO2l42ee32a/j0uQ/5AZkOdORxLhZNwe5gJmk2yKCJYCUDbjlBlPIV1Lb72EG9QMjI7N1U4ZqJuQF2yamnsFfr+1tevR6htnzmflfdZrWDdQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(346002)(39860400002)(46966006)(36840700001)(7696005)(5660300002)(6506007)(26005)(86362001)(53546011)(36860700001)(8936002)(8676002)(70586007)(186003)(478600001)(47076005)(316002)(54906003)(110136005)(52536014)(9686003)(55016002)(33656002)(83380400001)(336012)(82310400003)(2906002)(82740400003)(4326008)(81166007)(70206006)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:42:02.1518 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd42ab5d-585e-436a-a606-08d913d2898f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2490 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + Ard's new e-mail address > -----Original Message----- > From: Jeremy Linton > Sent: Thursday, April 8, 2021 1:59 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; leif@nuviainc.com; > pete@akeo.ie; Samer El-Haj-Mahmoud Mahmoud@arm.com>; Andrei Warkentin (awarkentin@vmware.com) > ; Jeremy Linton > Subject: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named > components > > Add some additional IORT nodes for the USB & EMMC devices, realistically > we probably only need to have a single node with the lowest > AddressSizeLimit > but this is conceptually "cleaner" should anyone actually try and use the= se > values rather than the _DMA provided ones. > > Signed-off-by: Jeremy Linton > --- > Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 > ++++++++++++++++++++++++++++++- > 1 file changed, 43 insertions(+), 1 deletion(-) > > diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc > b/Platform/RaspberryPi/AcpiTables/Iort.aslc > index 00720194bb..810307ae37 100644 > --- a/Platform/RaspberryPi/AcpiTables/Iort.aslc > +++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc > @@ -20,6 +20,8 @@ typedef struct { > typedef struct { > > EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort; > > RPI4_NC_NODE NamedCompNode; > > + RPI4_NC_NODE NamedCompNode2; > > + RPI4_NC_NODE NamedCompNode3; > > } RPI4_IO_REMAPPING_STRUCTURE; > > > > STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { > > @@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { > ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE, > > RPI4_IO_REMAPPING_STRUCTURE, > > EFI_ACPI_IO_REMAPPING_TABLE_REVISION), > > - 1, // NumNodes > > + 3, // NumNodes > > sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset > > 0 // Reserved > > }, { > > @@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { > }, { > > "\\_SB_.SCB0.XHC0" // ObjectName > > } > > + }, { > > + // gpu/dwc usb named component node > > + { > > + { > > + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type > > + sizeof (RPI4_NC_NODE), // Length > > + 0x0, // Revision > > + 0x0, // Reserved > > + 0x0, // NumIdMappings > > + 0x0, // IdReference > > + }, > > + 0x0, // Flags > > + 0x0, // CacheCoherent > > + 0x0, // AllocationHints > > + 0x0, // Reserved > > + 0x0, // MemoryAccessFlags > > + 30, // AddressSizeLimit > > + }, { > > + "\\_SB_.GDV0.USB0" // ObjectName > > + } > > + }, { > > + // emmc2 named component node > > + { > > + { > > + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type > > + sizeof (RPI4_NC_NODE), // Length > > + 0x0, // Revision > > + 0x0, // Reserved > > + 0x0, // NumIdMappings > > + 0x0, // IdReference > > + }, > > + 0x0, // Flags > > + 0x0, // CacheCoherent > > + 0x0, // AllocationHints > > + 0x0, // Reserved > > + 0x0, // MemoryAccessFlags > > + 30, // AddressSizeLimit > > + }, { > > + "\\_SB_.GDV1.SDC3" // ObjectName > > + } > > } > > }; > > > > -- > 2.13.7 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.