From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.57]) by mx.groups.io with SMTP id smtpd.web10.3322.1629491898700017578 for ; Fri, 20 Aug 2021 13:38:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=0Sj6qwzr; spf=pass (domain: arm.com, ip: 40.107.20.57, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ADCu6iYfxkanAVgyATB586Wgyx3kTqTDPdiYCYupVhA=; b=0Sj6qwzrwHHMre8qzf4mRwkHDl8n+pnC499Ze5rxi55wz9AjK+Q9YWvTFg/uD8f4U1lEZwR5nDPgjZDTfw0Fpf03fPCoOquQtFIgwhEDV/6FI3gF+B3dGz9z4z8KoNJpp8xnt+/CXwvNmofTMgoGkRb1uELSIGJRxVBkPln4B3M= Received: from AM5PR0101CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::40) by HE1PR0802MB2521.eurprd08.prod.outlook.com (2603:10a6:3:df::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Fri, 20 Aug 2021 20:38:04 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::2e) by AM5PR0101CA0027.outlook.office365.com (2603:10a6:206:16::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.18 via Frontend Transport; Fri, 20 Aug 2021 20:38:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Fri, 20 Aug 2021 20:38:04 +0000 Received: ("Tessian outbound 32695b2df2f8:v103"); Fri, 20 Aug 2021 20:38:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f75a716570afff67 X-CR-MTA-TID: 64aa7808 Received: from ca5cd4ff1546.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F8CD58B7-56BF-44AA-AB44-B2CF464A6B28.1; Fri, 20 Aug 2021 20:37:53 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca5cd4ff1546.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 20 Aug 2021 20:37:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dh66ngzFOcYlPKqjGCP3BcHNHGv//EdjJxUw0QGlwBfTYFvhwWSxkgvgfJBrEoYhZFqVJfum/ENxbbMaFc+h1lrbSEYyanjQbn5rkBqo6aFUGTxZwJ7BAuGIUa68tayeBaMocdxvjYcw2N9qtzIkjjTn0x43ym4CHnfGFIRGMjfWOXJ2vTQXn2Pdub+KG2at9p83k/b1DyP/x6pGSFehU5l7F0G2CPM3CZSiVdhdvupz/wemWgHv/oHuX9t9i0e1VsbNwUJ768PDU9HkwfrBc0M1t4HQoLVGqSYUQu38FYnI88LVJ6rSShfsVfXfvpitjFyo2IVSs9uMxyy7RjMqkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ADCu6iYfxkanAVgyATB586Wgyx3kTqTDPdiYCYupVhA=; b=VutKgzKijrOg07LG4nxb7Vozzn8EA4wYvntbCxDZ9q6taxxK7payv9n+/Sh1qNVreYKSN7Sy+VxVKVGU/P6gPkrmpLgj/avg6iK9HkejsDQ4FxvSeRLIJH1D3Y3/4lsQnRlLulNPJ5ksgzAmCAzGp6izw6GUF+5KPOttV7Hjq/DxpskBThsL6qN1pWBefiuwQGv+AxqmOqH2lh0jghCyOkcmt/xSwBxnNQNdygv/K/4pKmMAkLPBmQuK0H709lj6NIqws2WaI3/zL9iP1S2wqf/LSBk38jMf4fWzniALYkdc25dVe+w+D9wnsb6Zsr+VpIzvT49aXVZ/T0crN/vOTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ADCu6iYfxkanAVgyATB586Wgyx3kTqTDPdiYCYupVhA=; b=0Sj6qwzrwHHMre8qzf4mRwkHDl8n+pnC499Ze5rxi55wz9AjK+Q9YWvTFg/uD8f4U1lEZwR5nDPgjZDTfw0Fpf03fPCoOquQtFIgwhEDV/6FI3gF+B3dGz9z4z8KoNJpp8xnt+/CXwvNmofTMgoGkRb1uELSIGJRxVBkPln4B3M= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PAXPR08MB6351.eurprd08.prod.outlook.com (2603:10a6:102:15b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Fri, 20 Aug 2021 20:37:50 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::8888:874d:364:7237]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::8888:874d:364:7237%6]) with mapi id 15.20.4436.019; Fri, 20 Aug 2021 20:37:50 +0000 From: "Samer El-Haj-Mahmoud" To: Jeremy Linton , "devel@edk2.groups.io" CC: "pete@akeo.ie" , "ardb+tianocore@kernel.org" , "Andrei Warkentin (awarkentin@vmware.com)" , Sunny Wang , Jeremy Linton , Samer El-Haj-Mahmoud Subject: Re: [PATCH v3 6/7] Platform/RaspberryPi: Enable NVMe boot on CM4 Thread-Topic: [PATCH v3 6/7] Platform/RaspberryPi: Enable NVMe boot on CM4 Thread-Index: AQHXlXoqtBR+7Nw5F02FSJp6/NxpD6t822YQ Date: Fri, 20 Aug 2021 20:37:49 +0000 Message-ID: References: <20210820041619.87248-1-jeremy.linton@arm.com> <20210820041619.87248-7-jeremy.linton@arm.com> In-Reply-To: <20210820041619.87248-7-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c7ab11b9-d37c-4a7f-c667-08d9641a6909 x-ms-traffictypediagnostic: PAXPR08MB6351:|HE1PR0802MB2521: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1443;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Z5KwcHTRIkqMXxEeESPSUYVocGHvPdoMN9Z1JFNmrNH1sURvvQ2Ss7KGQjrGaMSZ6wLr9qe8x3WcHuXiao1giwTjHHLLsB3etZWVEuVYUoxtoddiGxsoch2+1oLIooorMa3x4gAdEhSFfj8VCUQWTf34s2GjeQbeccwc7uuQDGTYkE3C7Mn4ME5MFpWRqPNlE5Wo8xGvpAmesP+M/l7KRt+YQYK1c0o3beYmW9IBHhszD3OfqmM4RTGmVHNduMTQqLj35aE9iUgGoxQN1XGpqK4bFJJCYb916Nato4m9e9IIDex4zW/ozBytkmz5dKOPcUd4GZV6IPiY+JgdJddx8K620hF8ntPzV9tuKn21GFG0IEEtjYbwqoiSA/OcalsX419A9ec1mGAgW3dwPEbMW6b4PIYzjxGZNO/KO3a0p2EeqMNl4PFqEQd0/89sasKqBhDfEHhjZF1BZUWHeIooy5talodPkXe2ynSnkOfLHDT7dvUPNWLEz0EikPZ4zOQJvcvtpnNzfadWJN2RjFepUtNzwA9MrXu6+B1HdhnmSmZ3IpI1oSwernoKRfIXN1jXUOpMLW+voH1ou7FiHjju8XrpcukrKytdBaN0Grctx6a7ddrDIM1iSdXjodmjO/Sf5Mt4s40lfPfTr1T+xyyYUBXBKPYi4XH06fbN9gmbFpb1DReeoqNoI8km+KeTqIgrOQg17tQtOArYXC1RKGOPKA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(136003)(376002)(396003)(346002)(366004)(83380400001)(316002)(64756008)(19627235002)(9686003)(54906003)(33656002)(8676002)(26005)(6506007)(2906002)(86362001)(55016002)(122000001)(110136005)(38070700005)(478600001)(71200400001)(76116006)(53546011)(38100700002)(186003)(66556008)(4326008)(66476007)(52536014)(5660300002)(66946007)(8936002)(7696005)(66446008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NKbXmDNkd9F9w5+E2YZMIdylkAouW8KIphUfqglcMkABSvNanB+YMVwSXOSq?= =?us-ascii?Q?xyyL4RJItheHWnPzvhP7ENkYJCowvD2WWSs1+yCDTs/X9rDNMAqUN6liRRm5?= =?us-ascii?Q?pxE8e9LG2g9rvnIfQ9Sn/KbgnMSmEuDYQf9bHoQ27+parWssPpA3cJ5caqM/?= =?us-ascii?Q?L6rLODqk+vGlA6oYM5BiETRTI/PYGycYXPvoFi/6+QjSw1/glwSboOQzlED+?= =?us-ascii?Q?y/rfeiQJke0u93fn1fKA1rNBt4tp11jaAYdFwpHtgN8rFJyU0boxmzEKUU34?= =?us-ascii?Q?fZ6fy8cQg/qO3etbuixMw2cxPsXWELTXDf41Oy6sU9ftRC4Sn9WGTUSJGvbk?= =?us-ascii?Q?MEdMr9chz0Mbk2lMjmU/3xMiTcjOXOYs3aelQLqgcYKrvKK234yq2tQpQbo3?= =?us-ascii?Q?biE+irrlI54CsPt7loMyQWF155IJFPVpfpIRsUBQg3o0pWQ7sJyjrWXMtb4n?= =?us-ascii?Q?VLQALFuJTX1Re913Z89eYjQvdsJQCYII45OyrDknvqlro0p4NZXPMgnDIJdi?= =?us-ascii?Q?LX/iRXuwJHPiA4QWcoyjDqqQDcXlFuaNalIsz3FYALUqc8zcEVugWg5rbVuO?= =?us-ascii?Q?mRYU4vnjv4Fo8dpoi6HpTtxoW0E9zu8ye13+2Tt/OdgWAH+L23rI6nJvS6R1?= =?us-ascii?Q?hMmImJxLD1DMg/7RgEO5Yc3Ya3/mwCiV2OTwqgsQgWCjGw94h2Ij+vlgZG2X?= =?us-ascii?Q?YKedJXfyOCgsHvntcKrD19/NoDLzBGz5w5FMRMC/VslTr4mOZIhrJA4rqghr?= =?us-ascii?Q?iUxnF16PgDoDyb96kpGI6zEfeotoW/a8rMA5W5x0MZ/C0MWPypgibz1XvLP0?= =?us-ascii?Q?4/5yDzSdFHqYTQpBSQfzWyOI6/OIXm/C4vRvfOibSlG4bKrmcxLLu8sDTs6V?= =?us-ascii?Q?KQiB/DjmluGMtpB3HOVlJ+OvTKENV//JTNllqKe5E1Ag4SpSwTltnIwi99jJ?= =?us-ascii?Q?+mZAG/DpYS6eKeEeI6PYUhb7rr8U876lVrZiAmr/dg+tmmUrmVnZVQQ6qKCC?= =?us-ascii?Q?Lae3B65qMYePoK9A4YGbrorvSvHY4XF8iUBPQww/sUO/0OD/Lfyvg6avAkKe?= =?us-ascii?Q?Q1CnG92dmqdZ2qQLeFQmINxurR/AKlZQtv10khgiHZwY0m5bkym7HiLRAxbY?= =?us-ascii?Q?H57IpfUVj3LmyQ0Na1C5W23YLq9cXwlGTUxmV4oTAuBxF0Ch39VC6Q602655?= =?us-ascii?Q?hmdldMQHxUq3iMb9Zk48d3btZuGK4ZT14YSIGuNgFmzndhiJ2x7rUYtYVS6s?= =?us-ascii?Q?9jwKnCLdGpuu9NzSNRKwqtmdVUFYiOqEANQaisNMrKokmQ3Llytw5G+8Rsx2?= =?us-ascii?Q?E8eMYjgLavTnce8Jbh+5d/gY?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6351 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 91aef20d-3447-404e-9607-08d9641a607d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iREYjLHyiu6ig5HinHpxu28ww5hWQG431XRVV7M2qSPjmtbs+nYEqI9QV4lVLs+Awkx9+lM+RfxbaCJUBichdHQs2co4nGT0oQPCRC4b1VWbaSUSVwzmRufCn02z3ELMCDFjh2TYy8N4OfoIlr1wAOZqWAyUgUho7aII6AbEidwXJzBNfRPpV92H3psOXPIr8291JetmsL1p1L43Sx1FauBMXKgU6rO1mvzERh7TvvcYdavWq2KwM3sov07mdPQqC8KOHdTsxQXDDLC0oagqbZEh13fIR9Rasmt/fsse75DCMfXMRYDjWpkkfT/pgwta13JwD0NmQiERKGHJquPdD3Pdolu/ufd9yv/165GK+H77BfYe498v/u2xmFIoCIPhhIuJrSJAu2ntspiYhgrKf7P+jdISpjcdca2uddTJKUhIhd7kMpBKQCoEWNbeC56rxgQLzUWNpaND1qv0AoaczpWetnXkGenKSJggzf5ehnVKKzycG0InwVkyQI1rTfMFvP/WyXQj0i0c1Cx4YiIRAc9Y1iv2Mo1mRDqT5kmnOrneokytNEcS+XPD80j80lDg4w4GzxO+V0pt+yT7HiNvC+2O0K4ORyuUJ56p5fR6IXw1s1ngqnHUysLIEeDkobjtEovy7v27MzjiFWrM1hNXEd3K/1ZDAG/uKh8xOjmQEuDk06NCoHGtpH7IdOyTUAjp4K1gT4acnnPpk9G1ex4Amw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(376002)(396003)(346002)(136003)(46966006)(36840700001)(186003)(8676002)(81166007)(55016002)(336012)(316002)(9686003)(70206006)(4326008)(356005)(82740400003)(33656002)(19627235002)(82310400003)(47076005)(83380400001)(70586007)(2906002)(110136005)(36860700001)(54906003)(478600001)(52536014)(8936002)(7696005)(6506007)(26005)(53546011)(86362001)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2021 20:38:04.3221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7ab11b9-d37c-4a7f-c667-08d9641a6909 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2521 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: Jeremy Linton > Sent: Friday, August 20, 2021 12:16 AM > To: devel@edk2.groups.io > Cc: pete@akeo.ie; ardb+tianocore@kernel.org; Andrei Warkentin > (awarkentin@vmware.com) ; Sunny Wang > ; Samer El-Haj-Mahmoud Mahmoud@arm.com>; Jeremy Linton > Subject: [PATCH v3 6/7] Platform/RaspberryPi: Enable NVMe boot on CM4 > > The CM4 has a number of carrier boards with PCIe > slots. With the PCIe changes in place its quite > possible to utilize a NVMe root device. Lets allow > people to boot from it. > > Reviewed-by: Andrei Warkentin > Signed-off-by: Jeremy Linton > --- > Platform/RaspberryPi/RPi4/RPi4.dsc | 5 +++++ > Platform/RaspberryPi/RPi4/RPi4.fdf | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc > b/Platform/RaspberryPi/RPi4/RPi4.dsc > index babcbb2f41..25c29a0fbf 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -754,6 +754,11 @@ > } > > # > + # NVMe boot devices > + # > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > + # > # UEFI application (Shell Embedded Boot Loader) > # > ShellPkg/Application/Shell/Shell.inf { > diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf > b/Platform/RaspberryPi/RPi4/RPi4.fdf > index 3534cd3dc3..0c782d2f35 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.fdf > +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf > @@ -283,6 +283,11 @@ READ_LOCK_STATUS =3D TRUE > INF > EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.i > nf > > # > + # NVMe boot devices > + # > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > + # > # SCSI Bus and Disk Driver > # > INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > -- > 2.13.7 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.