Re: [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

[-- Attachment #1: Type: text/plain, Size: 5728 bytes --]

Yes this depends on https://edk2.groups.io/g/devel/message/77787

Which is still under review

________________________________
From: Ard Biesheuvel <ardb@kernel.org>
Sent: Friday, July 16, 2021 1:31:04 PM
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Grzegorz Bernacki <gjb@semihalf.com>; devel@edk2.groups.io <devel@edk2.groups.io>; leif@nuviainc.com <leif@nuviainc.com>; ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>; Sunny Wang <Sunny.Wang@arm.com>; mw@semihalf.com <mw@semihalf.com>; upstream@semihalf.com <upstream@semihalf.com>; pete@akeo.ie <pete@akeo.ie>; jian.j.wang@intel.com <jian.j.wang@intel.com>; hao.a.wu@intel.com <hao.a.wu@intel.com>; dandan.bi@intel.com <dandan.bi@intel.com>; eric.dong@intel.com <eric.dong@intel.com>
Subject: Re: [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib

On Fri, 16 Jul 2021 at 13:50, Samer El-Haj-Mahmoud
<Samer.El-Haj-Mahmoud@arm.com> wrote:
>
> Series Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>

Does this series depend on core EDK2 changes, and if so, have they
been merged already?


> > -----Original Message-----
> > From: Grzegorz Bernacki <gjb@semihalf.com>
> > Sent: Wednesday, July 14, 2021 9:21 AM
> > To: devel@edk2.groups.io
> > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>;
> > mw@semihalf.com; upstream@semihalf.com; pete@akeo.ie;
> > jian.j.wang@intel.com; hao.a.wu@intel.com; dandan.bi@intel.com;
> > eric.dong@intel.com; Grzegorz Bernacki <gjb@semihalf.com>
> > Subject: [edk2-platforms PATCH v3 0/2] Add BootDiscoveryPolicyUiLib
> >
> > This patchset extends Boot Maintenance Menu and allows to select
> > Boot Discovery Policy. Raspberry Pi platforms uses the variable to
> > connect specified class of devices on boot. This patchset also
> > removes efdc159e which has similar functionality.
> >
> > Discussion on design can be found at:
> > https://edk2.groups.io/g/rfc/topic/rfc_boot_discovery_policy/82450628
> >
> > Changes since v1:
> > - make 'Connect All' (0x2) default value for PcdBootDiscoveryPolicy
> > - initialize BootDiscoveryPolicy variable in platform code, if not found
> >
> > Changes since v2:
> > - add missing local variable initialization
> >
> > Grzegorz Bernacki (3):
> > edk2:
> >   MdeModulePkg: Add BootDiscoveryPolicyUiLib.
> > edk2-platform:
> >   Platform/RaspberryPi: Enable Boot Discovery Policy.
> >   Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"
> >
> >  Platform/RaspberryPi/RaspberryPi.dec                                           |   2 -
> >  Platform/RaspberryPi/RPi3/RPi3.dsc                                             |   9 +-
> >  Platform/RaspberryPi/RPi4/RPi4.dsc                                             |  12 +--
> >  Platform/RaspberryPi/RPi4/RPi4.fdf                                             |   1 +
> >  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf                           |   3 +-
> >
> > Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManager
> > Lib.inf |   6 +-
> >  Platform/RaspberryPi/Include/ConfigVars.h                                      |  12 +--
> >  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr                        |  16 +--
> >  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c                             |  11 +--
> >  Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c               |
> > 102 +++++++++++++++++---
> >  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni                        |  10 +-
> >  MdeModulePkg/MdeModulePkg.dec                                                     |   6 +
> >  MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf
> > |  52 +++++++
> >  MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h                                   |  22
> > +++
> >  MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c
> > | 160 ++++++++++++++++++++
> >
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni
> > |  18 +++
> >
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStri
> > ngs.uni |  29 ++++
> >
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.
> > Vfr     |  44 ++++++
> >  18 files changed, 438 insertions(+), 77 deletions(-)
> >  create mode 100644
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf
> >  create mode 100644 MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h
> >  create mode 100644
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.c
> >  create mode 100644
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.uni
> >  create mode 100644
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibStri
> > ngs.uni
> >  create mode 100644
> > MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLibVfr.
> > Vfr
> > --
> > 2.25.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[-- Attachment #2: Type: text/html, Size: 10095 bytes --]