From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: "Andrei Warkentin (awarkentin@vmware.com)"
<awarkentin@vmware.com>, Jeremy Linton <Jeremy.Linton@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
"leif@nuviainc.com" <leif@nuviainc.com>,
"pete@akeo.ie" <pete@akeo.ie>
Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components
Date: Mon, 10 May 2021 16:42:06 +0000 [thread overview]
Message-ID: <PAXPR08MB6987A0C4885445102CF8ED6D90549@PAXPR08MB6987.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <SN7PR05MB758201AD0F00E5F9255510CFB9749@SN7PR05MB7582.namprd05.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 5638 bytes --]
+ Ard's new e-mail address
From: Andrei Warkentin <awarkentin@vmware.com>
Sent: Thursday, April 8, 2021 10:17 AM
To: Jeremy Linton <Jeremy.Linton@arm.com>; devel@edk2.groups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com; pete@akeo.ie; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com<mailto:awarkentin@vmware.com>>
________________________________
From: Jeremy Linton <jeremy.linton@arm.com<mailto:jeremy.linton@arm.com>>
Sent: Thursday, April 8, 2021 12:58 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>
Cc: ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com> <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; leif@nuviainc.com<mailto:leif@nuviainc.com> <leif@nuviainc.com<mailto:leif@nuviainc.com>>; pete@akeo.ie<mailto:pete@akeo.ie> <pete@akeo.ie<mailto:pete@akeo.ie>>; samer.el-haj-mahmoud@arm.com<mailto:samer.el-haj-mahmoud@arm.com> <samer.el-haj-mahmoud@arm.com<mailto:samer.el-haj-mahmoud@arm.com>>; Andrei Warkentin <awarkentin@vmware.com<mailto:awarkentin@vmware.com>>; Jeremy Linton <jeremy.linton@arm.com<mailto:jeremy.linton@arm.com>>
Subject: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components
Add some additional IORT nodes for the USB & EMMC devices, realistically
we probably only need to have a single node with the lowest AddressSizeLimit
but this is conceptually "cleaner" should anyone actually try and use these
values rather than the _DMA provided ones.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com<mailto:jeremy.linton@arm.com>>
---
Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/RaspberryPi/AcpiTables/Iort.aslc
index 00720194bb..810307ae37 100644
--- a/Platform/RaspberryPi/AcpiTables/Iort.aslc
+++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc
@@ -20,6 +20,8 @@ typedef struct {
typedef struct {
EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort;
RPI4_NC_NODE NamedCompNode;
+ RPI4_NC_NODE NamedCompNode2;
+ RPI4_NC_NODE NamedCompNode3;
} RPI4_IO_REMAPPING_STRUCTURE;
STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
@@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
RPI4_IO_REMAPPING_STRUCTURE,
EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
- 1, // NumNodes
+ 3, // NumNodes
sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset
0 // Reserved
}, {
@@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
}, {
"\\_SB_.SCB0.XHC0<file://_SB_.SCB0.XHC0>" // ObjectName
}
+ }, {
+ // gpu/dwc usb named component node
+ {
+ {
+ EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type
+ sizeof (RPI4_NC_NODE), // Length
+ 0x0, // Revision
+ 0x0, // Reserved
+ 0x0, // NumIdMappings
+ 0x0, // IdReference
+ },
+ 0x0, // Flags
+ 0x0, // CacheCoherent
+ 0x0, // AllocationHints
+ 0x0, // Reserved
+ 0x0, // MemoryAccessFlags
+ 30, // AddressSizeLimit
+ }, {
+ "\\_SB_.GDV0.USB0<file://_SB_.GDV0.USB0>" // ObjectName
+ }
+ }, {
+ // emmc2 named component node
+ {
+ {
+ EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type
+ sizeof (RPI4_NC_NODE), // Length
+ 0x0, // Revision
+ 0x0, // Reserved
+ 0x0, // NumIdMappings
+ 0x0, // IdReference
+ },
+ 0x0, // Flags
+ 0x0, // CacheCoherent
+ 0x0, // AllocationHints
+ 0x0, // Reserved
+ 0x0, // MemoryAccessFlags
+ 30, // AddressSizeLimit
+ }, {
+ "\\_SB_.GDV1.SDC3<file://_SB_.GDV1.SDC3>" // ObjectName
+ }
}
};
--
2.13.7
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 16950 bytes --]
next prev parent reply other threads:[~2021-05-10 16:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 5:58 [PATCH 0/3] SD+USB perf/DMA fixes Jeremy Linton
2021-04-08 5:58 ` [PATCH 1/3] Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode Jeremy Linton
2021-04-08 9:48 ` Pete Batard
2021-04-08 14:17 ` Andrei Warkentin
2021-05-10 16:41 ` Samer El-Haj-Mahmoud
2021-05-10 16:41 ` Samer El-Haj-Mahmoud
2021-05-10 16:41 ` Samer El-Haj-Mahmoud
2021-04-08 5:58 ` [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Jeremy Linton
2021-04-08 9:48 ` Pete Batard
2021-05-10 16:41 ` Samer El-Haj-Mahmoud
2021-04-08 14:17 ` Andrei Warkentin
2021-05-10 16:42 ` Samer El-Haj-Mahmoud [this message]
2021-05-10 16:41 ` Samer El-Haj-Mahmoud
2021-04-08 5:58 ` [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Jeremy Linton
2021-04-08 9:48 ` Pete Batard
2021-05-10 16:43 ` Samer El-Haj-Mahmoud
2021-04-08 14:23 ` Andrei Warkentin
2021-04-13 16:44 ` Samer El-Haj-Mahmoud
[not found] ` <167578A6C978A75F.9301@groups.io>
2021-04-29 14:02 ` [edk2-devel] " Samer El-Haj-Mahmoud
[not found] ` <167A591C4A42BD1B.6294@groups.io>
2021-04-30 18:05 ` Samer El-Haj-Mahmoud
2021-05-10 16:42 ` Samer El-Haj-Mahmoud
2021-05-10 16:43 ` Samer El-Haj-Mahmoud
2021-04-08 14:24 ` [PATCH 0/3] SD+USB perf/DMA fixes Andrei Warkentin
2021-04-30 18:28 ` Samer El-Haj-Mahmoud
[not found] ` <167AB62D787B8F90.7155@groups.io>
2021-05-10 16:40 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-04-30 20:30 ` Andrei Warkentin
2021-05-10 16:39 ` [edk2-devel] " Samer El-Haj-Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR08MB6987A0C4885445102CF8ED6D90549@PAXPR08MB6987.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox