From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.47]) by mx.groups.io with SMTP id smtpd.web09.34556.1620664952160676226 for ; Mon, 10 May 2021 09:42:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=jZvHmw+Q; spf=pass (domain: arm.com, ip: 40.107.14.47, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RbT0RZj2x0yrN9riuxOVO4CplE9Q/IfdbN3NxiXULtA=; b=jZvHmw+QSmQsL42YiGu8almxgNxayhio2f9eZLb4tUlmlhnpupBk8zxI6lWZ7Vwis+xpMeGBhBxXMlpAOUZMLDw1f5O5NcuyXlS/b/ZRYFF3P1T/S+pLamACtsEhdd2jjF5msVRUrs7/6HcMpchB1N3Ss2q+I7XyA9toX48/TUE= Received: from DU2PR04CA0183.eurprd04.prod.outlook.com (2603:10a6:10:28d::8) by VE1PR08MB4894.eurprd08.prod.outlook.com (2603:10a6:802:a8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.27; Mon, 10 May 2021 16:42:23 +0000 Received: from DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::53) by DU2PR04CA0183.outlook.office365.com (2603:10a6:10:28d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:42:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT053.mail.protection.outlook.com (10.152.21.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:42:22 +0000 Received: ("Tessian outbound aff50003470c:v91"); Mon, 10 May 2021 16:42:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 41044f3d13cb6e39 X-CR-MTA-TID: 64aa7808 Received: from 027b55699b66.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AEEBED2E-5509-4516-9F84-8D434D9C96BF.1; Mon, 10 May 2021 16:42:16 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 027b55699b66.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 10 May 2021 16:42:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xv+L95IOofyICXodj8Z9LvnratloLoj22esvM1VNPTAN/8OR51pXNku314NbBFS2sO4XeKGTYkFthZ0XfgXdUILeCMO/W8SryQmlSBxYNptAiGe3OlU3k2bKoHpLtgfCBjCM9rI7dLk4mzht1Y2lPZQfd48yrbRzozs/dgwAgqF7XtQWOctTqbKdj3RpOp4J1MzC9CUp9dxCFpE77reE0j6yF57G5vejrJwvtyShdIbZ6mcx1158vIJWwdmK5AdhYbPP773+TwDAdl7aodeF/t3gx5JqrJDil8/Rux/JooYFSKmFpYXdmEidFVFyLniVehKLbiEV8XodMyh/kSZ4+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RbT0RZj2x0yrN9riuxOVO4CplE9Q/IfdbN3NxiXULtA=; b=UIKT4xxXNpt0YvFXS7bW/xx3zMVwmht6UeRgNnfWc7ZIOAuDgc9iM4a8WSzh8rofIsCwDzOr50pi12mLzCJbft7GXGtKQNOALdiw9gdFffHVhvBeKmAWGsdrZXJaBK8mdW0wM7MoodBQrGurKVkkfNwgrpmTnckZjQ6vzuxJl+Hs4A9c+hPpSvRPA6L7/wzyPGraNjnj+BcYLqjDv+HcJHIkFtub3I5G68DZ2UT0vvvtKiNDUzdU09rir5uckPbppcfkqlcLdoPde+KgdcRDXbq3PUQe4tQfXdBa6gUY00MSgShzCXUKiv6LYvWAkbV0TVcbs2sZEsRBxm6hTnzubw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RbT0RZj2x0yrN9riuxOVO4CplE9Q/IfdbN3NxiXULtA=; b=jZvHmw+QSmQsL42YiGu8almxgNxayhio2f9eZLb4tUlmlhnpupBk8zxI6lWZ7Vwis+xpMeGBhBxXMlpAOUZMLDw1f5O5NcuyXlS/b/ZRYFF3P1T/S+pLamACtsEhdd2jjF5msVRUrs7/6HcMpchB1N3Ss2q+I7XyA9toX48/TUE= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PA4PR08MB6192.eurprd08.prod.outlook.com (2603:10a6:102:ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 16:42:06 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad%7]) with mapi id 15.20.4108.031; Mon, 10 May 2021 16:42:06 +0000 From: "Samer El-Haj-Mahmoud" To: "Andrei Warkentin (awarkentin@vmware.com)" , Jeremy Linton , "devel@edk2.groups.io" CC: Ard Biesheuvel , "leif@nuviainc.com" , "pete@akeo.ie" Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Thread-Topic: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Thread-Index: AQHXLDxM/kt8HQGBLEeo9k1B33/A2qqqq0KAgDJzEKA= Date: Mon, 10 May 2021 16:42:06 +0000 Message-ID: References: <20210408055843.2883563-1-jeremy.linton@arm.com>,<20210408055843.2883563-3-jeremy.linton@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: vmware.com; dkim=none (message not signed) header.d=none;vmware.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 16efa163-3915-46c6-40d1-08d913d295f7 x-ms-traffictypediagnostic: PA4PR08MB6192:|VE1PR08MB4894: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3276;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GfSrgYaSHCrGIg0OHro8V5O+BJ/iVwP+SC8Fm2/7e9HxK0DKqiTdCCXMLPPDecvlJ30eN928r1TFWTDQtOdzXdrJ3yq6ur8VZ5fXGm/2/OTP2TttUjuNO6ifQvFp8E7eH2uD0UjaeQf22c5XmTMX/gL4dgPH1TTig9UlP25Kj2NsXa9khbNQyRxax8U/R43YaW8QRdGkE+Xa/0EsqY+HFZ51J/VJlYpcxla+Q/e+ZrOxVY1g5CHnwNTxxvb6IVLGGSONdHAsguw4p3+f6TyQwwJS/iE572bdcIfEWAOX23pXiMbduEGPRSU3GYfq/qYTnoKUan2ONz9XVwWJldXCsoTVlamL0zjayhVS4arAV5n2pjhOlnGu7ltaJtlPSx6Qo+Nsyro9ii9TPE6j5YQSNl0pnlTLFHT1i7RsoaLGvn8BDuBXDbH7nl02c+PjwWQp2EA/Vuyl+n34DREFCvVV4c1DJaPiUBjxkE/0abrvGnAPuzHavfC2jGma4yOkDrwk/iDneDftjL/K3uaAw0UYbDNo4RpgFz6b154LoqCCsY2UuhidGcvST+gSE9wP9aWk3TM/gGLP3XhEVc6mzA3DjuOEgR5d1g/V/X3787Be6Tc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(53546011)(6506007)(2906002)(66476007)(66446008)(66556008)(71200400001)(8936002)(83380400001)(7696005)(186003)(38100700002)(5660300002)(122000001)(86362001)(26005)(64756008)(66946007)(76116006)(110136005)(9686003)(478600001)(54906003)(33656002)(4326008)(52536014)(55016002)(8676002)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?PK2pONat7Xfs5g1Ftxjeiwqmpeucn8i0QYKaTqFESZ2GHdA/ivH4e2xI2uUZ?= =?us-ascii?Q?arvDDiDyPX1BtqzFln/XNqgvAGeLhaFPnatzOKGL/XkM05a4Y7xRq0BLK5U5?= =?us-ascii?Q?vWmNbncX9kaPkJg9OEvVgty5WinicKqcydtiCtc7Y7dkQiSekCnPOpErBFHi?= =?us-ascii?Q?EPTFfb9bIXfGH7ozFVmGTYcuWP12PvX6K+n7rmtUHs5mU7KMyXoMhbbewrXG?= =?us-ascii?Q?SwMlotWxdjKxhM3m3KTI7nCceE7EHt7K0cjr/rqtI4ZnESI2pJTKnay2f/8w?= =?us-ascii?Q?Lxdr9DQyz2u6QMHnBN15M/kh3PQjp1otcy3wlFHyPSFW40V7dVlmJnkTrE90?= =?us-ascii?Q?rzNdE4krzEE745XTxA3j57S337RqZkxmU2UyP659h7LXtIKkI6K2elmhLDG7?= =?us-ascii?Q?fqEFYOC4UCGxW1hFS4Y3HMaLrENyB9muXa/vv8Xoub8aL3oU3UMjRi77BA4v?= =?us-ascii?Q?jg9s0TeFlh+ebWxEYxvsCplbzI/cmimBvIN73S8K5RPLsJDQx2fpw2HqZaob?= =?us-ascii?Q?VCA4JQY0z2n4fB+Mo0Mx/B3QPdoH1Y8L3XNAIFN6RiHLYGaTbrTHIr7pRYs9?= =?us-ascii?Q?e/r9M+SAwweUvXNEbHIxOEWteZg5xHVl+3JYa/ZyzVXJK7CTWicCVYLdIpdW?= =?us-ascii?Q?sEJxUbONfaZ2C2eKx0DyDptUGA5qBP50zHYrV21YIubBLhmkguTH1lbnFJCF?= =?us-ascii?Q?hII4nsmzIOgfwJm0MYjIu8/l/CMFKHdy9tAkEaUqPyGknbZlbyMoq+FZ/57V?= =?us-ascii?Q?Mgu8T4bYNEq0o6KSg/BgkLRD1WHLkHBpMyFAEn9/iXu1u1SrMipIDwwv1+gN?= =?us-ascii?Q?OurGBCZRAcL0ZgS15nI29RB+EDzJxyZMAXlomzqnwCqGqauk0+p7f7tVgEqR?= =?us-ascii?Q?vtixjU9i0Wu+yQlfxAfN3rqG9Y7QvFOh0TTjSRPi9omv3/ssAjCSgq0mg2yQ?= =?us-ascii?Q?LMXIaCURtLzmOmsGtk3VhjMpRiLXECuLtjDM6sfzCD+otYC8i1j2khJCSoXj?= =?us-ascii?Q?3V7MQAId3sGDlrBlvjxRhCTQmI3pWSgXzI9i7KjZbcukaV2jXUZ8Cf1c4c0C?= =?us-ascii?Q?5hVQhirCPBNHkguKqUC2SA2sWVAdgTCQx4CJ8GIGsParhfFHFTIXwxQeF9N1?= =?us-ascii?Q?2j78FQ5dKReZLuCB1FyaH7nDmOGxDQsk0QSMHxR8i49tNudjgxK9JooDXhGx?= =?us-ascii?Q?g0rIWr6FoZaNaPO+aGEkA08HLUbSME7csJBYDb3OOHi6oYoAOF8yCY4xMQN8?= =?us-ascii?Q?A31xIXkTYQc8qoH7XmLsDMKVZsjOLn7fLQDtckVGP1lJXZZBZIHjczDU02hr?= =?us-ascii?Q?DZud+GcrjGnIT2nq/ZA7eTp1?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6192 Original-Authentication-Results: vmware.com; dkim=none (message not signed) header.d=none;vmware.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 50931939-ca34-49a1-b4cd-08d913d28c36 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6oiTDXAuem0G+12G6UtT1Ff2HRCU4fb+3T0ZaH3NvyPUp16GbIYlkuwu/8fHyWY1LyVcFil3riRcOlDFmOd7Z1Qm0douZUcTo++7TvbM4W9SJQPcf2j6cmSI3qasHiLJfInNpKJE2wLjeHD1MfRqmRIUdv4MesvuG4XWnEHG6x6FIz6TpZt5bVLD4K0DuhrYZHKdzrRITUDtm/xjbtRR6ArZwGXS4dbxIV1kg+lKikEkqpm5Bvf0puccDFoGDIerJel34eaK/5jWAxwO+tWY2MSdQsQ441wck6lFwWEQLwogxOOv7nRYgzLwfQQKojui6MNsEQfYHGD+9RqZ4p2/Ef7rQc1FMgNhu9gnAQ7sTlUfbawgQYttHrEyUgW7VTOSkog2TzxEP4VBpliaDp5sMKFFJUcKkZp7ORzSr/EPBRaEo8H2yPUfJFRKaXXl6L/KlI2nWD7XgH9+0Iq5StD8RvLEwUOhJCrdRajSXPYlo4IiQ7Vwd/5BzE6khJr1whoE0hPjfh0Niqyob6TKasYMuEWakF6yVW1rgg860YmG+tVqhOWeI9FouP9L4y6nIdVdLoNHycqP0VCf+M/Z0i9GLZzgzOe/AROcmfTilkYa0GhO7Ew413kCnbdV/dAXfBSyfvhdaUd03KLoEg3j4sMDVVukM9kexDGKXniB+lZq+7U= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(136003)(346002)(396003)(46966006)(36840700001)(70586007)(53546011)(47076005)(86362001)(82310400003)(70206006)(5660300002)(336012)(478600001)(186003)(52536014)(33656002)(6506007)(7696005)(55016002)(2906002)(82740400003)(107886003)(8936002)(81166007)(316002)(54906003)(83380400001)(26005)(110136005)(9686003)(356005)(8676002)(36860700001)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:42:22.9624 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16efa163-3915-46c6-40d1-08d913d295f7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4894 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PAXPR08MB6987A0C4885445102CF8ED6D90549PAXPR08MB6987eurp_" --_000_PAXPR08MB6987A0C4885445102CF8ED6D90549PAXPR08MB6987eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + Ard's new e-mail address From: Andrei Warkentin Sent: Thursday, April 8, 2021 10:17 AM To: Jeremy Linton ; devel@edk2.groups.io Cc: Ard Biesheuvel ; leif@nuviainc.com; pete@akeo.i= e; Samer El-Haj-Mahmoud Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named= components Reviewed-by: Andrei Warkentin > ________________________________ From: Jeremy Linton > Sent: Thursday, April 8, 2021 12:58 AM To: devel@edk2.groups.io > Cc: ard.biesheuvel@arm.com >; leif@nuviainc.com >; pete@akeo.ie >; samer.el-haj-mahmoud@ar= m.com >; Andrei Warkentin >; Jeremy Linton > Subject: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named com= ponents Add some additional IORT nodes for the USB & EMMC devices, realistically we probably only need to have a single node with the lowest AddressSizeLimi= t but this is conceptually "cleaner" should anyone actually try and use these values rather than the _DMA provided ones. Signed-off-by: Jeremy Linton > --- Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 +++++++++++++++++++++++++++= +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/Raspberry= Pi/AcpiTables/Iort.aslc index 00720194bb..810307ae37 100644 --- a/Platform/RaspberryPi/AcpiTables/Iort.aslc +++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc @@ -20,6 +20,8 @@ typedef struct { typedef struct { EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort; RPI4_NC_NODE NamedCompNode; + RPI4_NC_NODE NamedCompNode2; + RPI4_NC_NODE NamedCompNode3; } RPI4_IO_REMAPPING_STRUCTURE; STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { @@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE, RPI4_IO_REMAPPING_STRUCTURE, EFI_ACPI_IO_REMAPPING_TABLE_REVISION), - 1, // NumNodes + 3, // NumNodes sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset 0 // Reserved }, { @@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D { }, { "\\_SB_.SCB0.XHC0" = // ObjectName } + }, { + // gpu/dwc usb named component node + { + { + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type + sizeof (RPI4_NC_NODE), // Length + 0x0, // Revision + 0x0, // Reserved + 0x0, // NumIdMappings + 0x0, // IdReference + }, + 0x0, // Flags + 0x0, // CacheCoherent + 0x0, // AllocationHints + 0x0, // Reserved + 0x0, // MemoryAccessFlags + 30, // AddressSizeLimit + }, { + "\\_SB_.GDV0.USB0" = // ObjectName + } + }, { + // emmc2 named component node + { + { + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type + sizeof (RPI4_NC_NODE), // Length + 0x0, // Revision + 0x0, // Reserved + 0x0, // NumIdMappings + 0x0, // IdReference + }, + 0x0, // Flags + 0x0, // CacheCoherent + 0x0, // AllocationHints + 0x0, // Reserved + 0x0, // MemoryAccessFlags + 30, // AddressSizeLimit + }, { + "\\_SB_.GDV1.SDC3" = // ObjectName + } } }; -- 2.13.7 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. --_000_PAXPR08MB6987A0C4885445102CF8ED6D90549PAXPR08MB6987eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

+ Ard’s new e-mail address

 

 

From: Andrei Warkentin <awarkentin@vmware.= com>
Sent: Thursday, April 8, 2021 10:17 AM
To: Jeremy Linton <Jeremy.Linton@arm.com>; devel@edk2.groups.i= o
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com= ; pete@akeo.ie; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add furthe= r named components

 

Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>

From: Jeremy Linton <jeremy.linton@arm.com>
Sent: Thursday, April 8, 2021 12:58 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: ard.biesheuvel@arm.com= <ard.biesheuvel@arm.com>; leif@nuviainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; samer.el-haj-mahmoud@arm.co= m <samer.el-haj-mahm= oud@arm.com>; Andrei Warkentin <awarkentin@vmware.com>; Jeremy Linton <jeremy.linton@arm.com>=
Subject: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further na= med components

 

Add some additional I= ORT nodes for the USB & EMMC devices, realistically
we probably only need to have a single node with the lowest AddressSizeLimi= t
but this is conceptually "cleaner" should anyone actually try and= use these
values rather than the _DMA provided ones.

Signed-off-by: Jeremy Linton <j= eremy.linton@arm.com>
---
 Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++= ++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/Raspberry= Pi/AcpiTables/Iort.aslc
index 00720194bb..810307ae37 100644
--- a/Platform/RaspberryPi/AcpiTables/Iort.aslc
+++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc
@@ -20,6 +20,8 @@ typedef struct {
 typedef struct {

   EFI_ACPI_6_0_IO_REMAPPING_TABLE      = Iort;

   RPI4_NC_NODE        &n= bsp;            = ;    NamedCompNode;

+  RPI4_NC_NODE         &= nbsp;           &nbs= p;   NamedCompNode2;

+  RPI4_NC_NODE         &= nbsp;           &nbs= p;   NamedCompNode3;

 } RPI4_IO_REMAPPING_STRUCTURE;

 

 STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D {

@@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D {
     ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNA= TURE,

            &nb= sp;     RPI4_IO_REMAPPING_STRUCTURE,

            &nb= sp;     EFI_ACPI_IO_REMAPPING_TABLE_REVISION),

-    1,         = ;            &n= bsp;            = ;            // NumN= odes

+    3,         = ;            &n= bsp;            = ;            // NumN= odes

     sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), &nb= sp;     // NodeOffset

     0        &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p; // Reserved

   }, {

@@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort =3D {
     }, {

       "\\_SB_.SCB0.XHC0"        = ;            &n= bsp;       // ObjectName

     }

+  }, {

+    // gpu/dwc usb named component node

+    {

+      {

+        EFI_ACPI_IORT_TYPE_NAMED_COMP,&= nbsp;           &nbs= p; // Type

+        sizeof (RPI4_NC_NODE), &nb= sp;            =         // Length

+        0x0,    &nb= sp;            =             &nb= sp;          // Revision

+        0x0,    &nb= sp;            =             &nb= sp;          // Reserved

+        0x0,    &nb= sp;            =             &nb= sp;          // NumIdMappings<= br>
+        0x0,    &nb= sp;            =             &nb= sp;          // IdReference
+      },

+      0x0,      &nb= sp;            =             &nb= sp;          // Flags

+      0x0,      &nb= sp;            =             &nb= sp;          // CacheCoherent<= br>
+      0x0,      &nb= sp;            =             &nb= sp;          // AllocationHint= s

+      0x0,      &nb= sp;            =             &nb= sp;          // Reserved

+      0x0,      &nb= sp;            =             &nb= sp;          // MemoryAccessFl= ags

+      30,      &nbs= p;            &= nbsp;           &nbs= p;           // AddressSi= zeLimit

+    }, {

+      "\\_= SB_.GDV0.USB0"        &nbs= p;            &= nbsp;      // ObjectName

+    }

+  }, {

+    // emmc2 named component node

+    {

+      {

+        EFI_ACPI_IORT_TYPE_NAMED_COMP,&= nbsp;           &nbs= p; // Type

+        sizeof (RPI4_NC_NODE), &nb= sp;            =         // Length

+        0x0,    &nb= sp;            =             &nb= sp;          // Revision

+        0x0,    &nb= sp;            =             &nb= sp;          // Reserved

+        0x0,    &nb= sp;            =             &nb= sp;          // NumIdMappings<= br>
+        0x0,    &nb= sp;            =             &nb= sp;          // IdReference
+      },

+      0x0,      &nb= sp;            =             &nb= sp;          // Flags

+      0x0,      &nb= sp;            =             &nb= sp;          // CacheCoherent<= br>
+      0x0,      &nb= sp;            =             &nb= sp;          // AllocationHint= s

+      0x0,      &nb= sp;            =             &nb= sp;          // Reserved

+      0x0,      &nb= sp;            =             &nb= sp;          // MemoryAccessFl= ags

+      30,      &nbs= p;            &= nbsp;           &nbs= p;           // AddressSi= zeLimit

+    }, {

+      "\\_= SB_.GDV1.SDC3"        &nbs= p;            &= nbsp;      // ObjectName

+    }

   }

 };

 

--
2.13.7

IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_PAXPR08MB6987A0C4885445102CF8ED6D90549PAXPR08MB6987eurp_--