From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.72]) by mx.groups.io with SMTP id smtpd.web11.44.1620665189174941157 for ; Mon, 10 May 2021 09:46:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=M8IqkDTE; spf=pass (domain: arm.com, ip: 40.107.6.72, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iF32GxAxH741RWhHTRjhBYFxbnwQhToVOpzBrvIARg8=; b=M8IqkDTEOhvBUAu4EwmGF8K1SbbQaIhP/+eFi5bjkVKUU7V37OKhkh/IM+cBZfhlLGs8ZwViGfVeFd3QmJzPpwD8FpH2Dndu7wHR0wd4xCYTIDnr9w3hsYbS7Xdf5V3bxpvZFYvyRQicBlhSrpxguvfOx6FPMyijXTONqI/1big= Received: from AM0PR06CA0093.eurprd06.prod.outlook.com (2603:10a6:208:fa::34) by PA4PR08MB6032.eurprd08.prod.outlook.com (2603:10a6:102:e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 16:46:26 +0000 Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:fa:cafe::62) by AM0PR06CA0093.outlook.office365.com (2603:10a6:208:fa::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:46:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:46:26 +0000 Received: ("Tessian outbound e566ed09e411:v91"); Mon, 10 May 2021 16:46:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e52c6f82e8be3982 X-CR-MTA-TID: 64aa7808 Received: from 1339450cad58.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5662A7B-4A66-4746-BEF2-EA8A7A2CA463.1; Mon, 10 May 2021 16:46:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1339450cad58.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 10 May 2021 16:46:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LXsm74Dhkcm+pigcxQuiagFl7L4RQmLdSHKJ999ylZ874Y4/MeSGvFXtm2nWMGrJMmt4Zadv9t7Kab6Bzl8y+MEWhJLKfYRGgcHiMbD6MlTRFdB/NLaVTAvGG3hCprhgHL42qXj83WjfZRkITmtuVG9DyD7Vt5i75nxeK3+rhoiHDVowUB7TukTfITLjFR8Ll/+iD2EztOfB/KpXvmS35lBTfitcztxXK0jZ/dofypGhCdresM5EunoHQFEJSu0BmJ33GcYZ52c9A04h4arJZbBHomjjHtNdfnmM5b6OAnp4UPQZPzBeti5XaqboWcWz1vG7FVp2GhDlUJgymPiSNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iF32GxAxH741RWhHTRjhBYFxbnwQhToVOpzBrvIARg8=; b=as3NL+9TOPUljxK+V3BvL1yeL+EJ+na2X0H8blhpp+l5LRfsr74Qvy1YFavc/FD+2nyEWHv7Nda4304G2KRbqq2vEnb440/sl+S8WxSOw1sTCWDPFNKXGlGcvPY/E/cAEtuamqJMZSeucprSIXnkCwCvcJG+K4s4988jqq3dwtMUkqKVgIMOqZzd3OejBrk0Ta9rcsE42IPbdTq9b7jwBSe5g4UMv4z+FLxnSwGqDjqKXa9i56Av1kvLwqCVSLlgyMO+3oFsrho0vkeaAsfU70vT5O5G0J0YCRTn/+BYFCtGNLBd6r1f4oGQrmGfaXktiLhdEvv4fQTD/idkNjN7Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iF32GxAxH741RWhHTRjhBYFxbnwQhToVOpzBrvIARg8=; b=M8IqkDTEOhvBUAu4EwmGF8K1SbbQaIhP/+eFi5bjkVKUU7V37OKhkh/IM+cBZfhlLGs8ZwViGfVeFd3QmJzPpwD8FpH2Dndu7wHR0wd4xCYTIDnr9w3hsYbS7Xdf5V3bxpvZFYvyRQicBlhSrpxguvfOx6FPMyijXTONqI/1big= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PAXPR08MB6861.eurprd08.prod.outlook.com (2603:10a6:102:138::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 16:46:19 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad%7]) with mapi id 15.20.4108.031; Mon, 10 May 2021 16:46:19 +0000 From: "Samer El-Haj-Mahmoud" To: Jared McNeill CC: Jeremy Linton , "devel@edk2.groups.io" , Ard Biesheuvel , "leif@nuviainc.com" , "pete@akeo.ie" , "Andrei Warkentin (awarkentin@vmware.com)" Subject: Re: [PATCH 2/2] Platform/RaspberryPi: Increase genet dma window Thread-Topic: [PATCH 2/2] Platform/RaspberryPi: Increase genet dma window Thread-Index: AQHXMiyr6pUKUbDV80mD1m5NWq2IgarNdQtAgABzWgCADysVgA== Date: Mon, 10 May 2021 16:46:19 +0000 Message-ID: References: <20210415192207.3257790-1-jeremy.linton@arm.com> <20210415192207.3257790-3-jeremy.linton@arm.com> <6FD17261-5675-4148-BD06-650AB2177609@invisible.ca> In-Reply-To: <6FD17261-5675-4148-BD06-650AB2177609@invisible.ca> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: invisible.ca; dkim=none (message not signed) header.d=none;invisible.ca; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 1a3dff29-0268-4e9e-f772-08d913d32728 x-ms-traffictypediagnostic: PAXPR08MB6861:|PA4PR08MB6032: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ODoYrnt87D3h7Ow7C9l62T2n2pUK73XnhMH/QfB+neF9r1Da9pz9Ni+Lmu0QYLg3MDgHFqQgAjE09ks4FoPIJKByuvj2PFLfgRojnYJAT2YF7y7d/P0imnof44LE3lJCnrOdsX/NZfIfAVnBbnekFCXj28zcnf0R05TgXk0LzuT9cqTbSDz8WsHkcAEd3b4fKzLg65jRF09uMlrqyOFSwz6QGXtWBygppVzp/mbXRn5aDbtASGzqm/xbvbD3V5CCyjoIsnpANHQVA7+wRRXj5GmqhN/1oFSNwgIUMs6Oc9YHBSI2UJlBw/9HUSsrHDw6GeIBJLkrEjFwBw9fGUAFe8zM+QBf8pEC/MJZ6n0Sn1jcCKamsfdnHG0BbYyUvB1Uu6OnH5PU/wgNb0LUCAFRCThmeTbwEnWzl9XMxeEdefQovqGBwp5oHQaKX6Enp6Bq904O5mAzRQ639Ha3H86v+saOzhbz6adgJURPkxllSi6V5Rk2pDQH9Lzd6FBN/aXXzoVW+acQfWkrJmUBf5XWwbahqobMu3b/7UFgttvpln0e5vEPyAEnU1wERtYB4t04Rwfxt2HPyxHSGbse2k2p8SzQ5pJ6hgKzNEaj0VutQBI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(54906003)(4326008)(8936002)(52536014)(66556008)(64756008)(478600001)(66476007)(66446008)(66946007)(26005)(8676002)(186003)(76116006)(55016002)(7696005)(71200400001)(122000001)(38100700002)(6916009)(86362001)(316002)(19627235002)(2906002)(53546011)(9686003)(5660300002)(83380400001)(6506007)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kG8ZTDQnLSty0DxVrH9zumfQgPSphutW5GRUWsH7UbnqXEWCZ5079Jr/uAqX?= =?us-ascii?Q?SDtE2w3irQSNe7T86AmNPnua+zu2qd4jcMIiSYsUu/6+u7668nNNwlh+hEAE?= =?us-ascii?Q?EcpbH7EOOVfutnlY68oUOD8f2CMuNuFRaUdj7vvJoQWgnWPAjG5yhkWRaHB0?= =?us-ascii?Q?LdZPuyoLj9zoDrJfF14/EDleyjfl2rC/zXU7ox7i80NntnmPgT4g+uHUcDR2?= =?us-ascii?Q?2fingx8Oo7gDmpJIlUNezaOU3QrtD6mXHGbFyy5LhTHAyhMdm1oFe/KUrYc1?= =?us-ascii?Q?/bLRKa6iFaGCJpHiIzscRfSJVg2IsDnuN4wGzPD7IY7tlH9cYhX3929iv2ig?= =?us-ascii?Q?vDEQiZb26ibufgKAwv/jP6PqFm0NKx7my+10oB11ji2b+9AHEyMN9SAg6B1j?= =?us-ascii?Q?G4sdx+6s+E43MlJS3p0ZD9B5bm6xKic6dlyh5VYCmBwYjLZVg82w85K+wuwK?= =?us-ascii?Q?1h5vmk2tWdFVVNiaW4AWeRpRnpv89+SpS+jr7vMmHhPW+/4GrjsGBtf3j/nG?= =?us-ascii?Q?G+rWBDPQMfkPBmQidRXUnE7k2Qt7FAV2wSKCbxqsbityianW/Voh7/T4ruyh?= =?us-ascii?Q?Gjp3N9tIoPEajcTVjsnImZRfWFzJQ+6ko/y7BhxhQpjMLvCq1GMgYT9Ve5aB?= =?us-ascii?Q?NaZUcxIaDB/oaaUq/c9lfzozFJzlM1+zpM8a2A7cpsOV8uMJWK+r9T3gkmCu?= =?us-ascii?Q?Zv3eomqgJnORR60Nckpe6HiUFwNn2T1hrqi404peZhYzHvsbByRCa9+i4aUY?= =?us-ascii?Q?EGY+zdsWfSEDNLlbUX/IS4Rs7p70aroeWgR4fSQHwxtr8vC5fiWAdtK3LCk6?= =?us-ascii?Q?aCgyrZdAb5vTiCOP5GpA1dKPxIBRBqaAEYZIO/P+TP1cQMft7X+QNcIG69zR?= =?us-ascii?Q?Jj4kxmztlV6GhsBE86h0YtvlOmUvOiLLQd1O7BvrCN1950IxRw4y1IxOF3ut?= =?us-ascii?Q?unt9XYdSYL7P4ZmqIqVCCQNr6xcZKzNuB3OxKHbeR5gMhDiO5JIvmOXdjWfJ?= =?us-ascii?Q?/9m/NZne27Vm33JCLCck2G9AU4uDJI+g+v86KfRAHO7JLTAymUAv/HYXLKGf?= =?us-ascii?Q?sjPsBvUf3PzoEco+xX3KNRFxEtvOqCipVbbIYTsZIkSGiD+PfURORJC+Vlzp?= =?us-ascii?Q?cgWANgBOSI5mEWHU9qIMzrxAZOr0oYrhH4lRsinZqlNFv0mV9u8QLr9NXM9+?= =?us-ascii?Q?ZO16G9yRQoVr6qNUBLQ3xhaAHCL1N1I7Ae3eMGRipOZs5VBBj4l+F4H239Le?= =?us-ascii?Q?Kk8E1BGiVlHXZYmldHddqOUsULL1MLDbWKNygSYpgBnshVkk4MMwQvhoFosp?= =?us-ascii?Q?r4hPD1RQGu4VFC/Qh3/w3mou?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6861 Original-Authentication-Results: invisible.ca; dkim=none (message not signed) header.d=none;invisible.ca; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 319f9754-e565-4bc3-07a1-08d913d322b6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1HV2HCnjk8hXBA3exVXhl+qc27mjVqZNAtMB2B2BqXqt5hhQCMAFDbMFxnHGO/nsfpdwbL3pghOSrUJdTnP3zTZ3qavG8+45hu6nllq5v+agBQrlROBNNNip8fFJjVUSlxQKLVKtb6zwyBjfcUm9eoDVGbgMmzLhI6edD4Bi4Y1namRQwEx7zkElFlwox4m7kEKGjukU2KPMaxUJqN4BB3C/sZO9bWUNqsgYe7q/MVYKpBHTmMoDU+RagF6HKF7gTBNgBHRrKFDhUmbPRoqmg4rtQ36uqmDIAHYHJMAP2lyrBOV6Zmua1LYGp+qsH9Z2C5X5N6V+AE7kJ69Cbk7o9KdN2K/7ekFlwqe7sIWBHewN/nnZhMf5gI5KsPy8fCPn02K2w+dGm19YgY77hxrvuIxGbwhiJWxxKI4AUbGz3p9zTlaNxTQwqrFn+kvgckw5L4mlVodgllpWdsfJXyIkkpNVfuw6QuhTXCSt2Ct7NHeLKu7bKu0CIY5Daqs4WY7KMlK/bHk2PEiU+TuB61opLq5a8NKbmo3ZxXNfBvQI8X3NwnMBHAjzHKkfW7pUuALhgWxxPQfIrLC6E+B8tfn9Nxxyw85jkgAV2dNT2UnJONY1E8ELnsTOEjs/CqLfZVPohchgxURgS9sMxU08GCvoStBCpZIipQGasSPIwOnv/do= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(36840700001)(46966006)(107886003)(53546011)(6506007)(70206006)(2906002)(8936002)(47076005)(83380400001)(6862004)(7696005)(186003)(5660300002)(86362001)(336012)(26005)(82740400003)(70586007)(356005)(81166007)(82310400003)(9686003)(54906003)(33656002)(478600001)(52536014)(4326008)(55016002)(316002)(8676002)(19627235002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:46:26.5139 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a3dff29-0268-4e9e-f772-08d913d32728 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6032 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable +Ard's new e-mail address Jared, I assume your response can be taken as a "Reviewed-By", correct? > -----Original Message----- > From: Jared McNeill > Sent: Friday, April 30, 2021 9:08 PM > To: Samer El-Haj-Mahmoud > Cc: Jeremy Linton ; devel@edk2.groups.io; Ard > Biesheuvel ; leif@nuviainc.com; pete@akeo.ie; > Andrei Warkentin (awarkentin@vmware.com) > Subject: Re: [PATCH 2/2] Platform/RaspberryPi: Increase genet dma window > > LGTM! > > Take care, > Jared > > > > On Apr 30, 2021, at 3:15 PM, Samer El-Haj-Mahmoud Mahmoud@arm.com> wrote: > > > > +Jared > > > > Reviewed-By: Samer El-Haj-Mahmoud Mahmoud@arm.com> > > > >> -----Original Message----- > >> From: Jeremy Linton > >> Sent: Thursday, April 15, 2021 3:22 PM > >> To: devel@edk2.groups.io > >> Cc: Ard Biesheuvel ; leif@nuviainc.com; > >> pete@akeo.ie; Samer El-Haj-Mahmoud Mahmoud@arm.com>; > >> Andrei Warkentin (awarkentin@vmware.com) > ; > >> Jeremy Linton > >> Subject: [PATCH 2/2] Platform/RaspberryPi: Increase genet dma window > >> > >> The genet is capable of addressing the entire memory space on the RPI4= . > >> Lets allow it to dma into those regions. > >> This solves intermittent issues with grub/etc being able to > >> communicate when the 3G limit is lifted on 8G boards. > >> > >> Signed-off-by: Jeremy Linton > >> --- > >> Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc > >> b/Platform/RaspberryPi/RPi4/RPi4.dsc > >> index ddf4dd6a41..facf34f034 100644 > >> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > >> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > >> @@ -698,7 +698,7 @@ > >> Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf { > >> > >> gEmbeddedTokenSpaceGuid.PcdDmaDeviceOffset|0x00000000 > >> - gEmbeddedTokenSpaceGuid.PcdDmaDeviceLimit|0xffffffff > >> + gEmbeddedTokenSpaceGuid.PcdDmaDeviceLimit|0xffffffffff > >> } > >> > >> # > >> -- > >> 2.13.7 > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended reci= pient, > please notify the sender immediately and do not disclose the contents to = any > other person, use it for any purpose, or store or copy the information in= any > medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.