From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from FRA01-PR2-obe.outbound.protection.outlook.com (FRA01-PR2-obe.outbound.protection.outlook.com [40.107.12.43]) by mx.groups.io with SMTP id smtpd.web10.601.1630520374827463452 for ; Wed, 01 Sep 2021 11:19:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=BufQ+VQr; spf=pass (domain: arm.com, ip: 40.107.12.43, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Awp+/a6Mw2rfEDGy0N8ZnMPoZKxq3qVJ9ER6ue3XQds=; b=BufQ+VQr0K2ce6j2pmGnI+qDjbmGLOmEwrOzllrXj4AlPonx5vGPr7kFkvx60zw2deIFUrkyy9+r9BhRKfg68yDduHeFrzz1wOLA8ltAtGBROGjGamDNT+XJSnEw1xqiFhpb6phRSL+3aXVgZk7J6XbgiYbnHEzI6Ugz0H2xLJI= Received: from DB6PR0802CA0045.eurprd08.prod.outlook.com (2603:10a6:4:a3::31) by PR2PR08MB4747.eurprd08.prod.outlook.com (2603:10a6:101:28::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 18:19:26 +0000 Received: from DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::8a) by DB6PR0802CA0045.outlook.office365.com (2603:10a6:4:a3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 18:19:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT036.mail.protection.outlook.com (10.152.20.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 18:19:26 +0000 Received: ("Tessian outbound 5918cb94a4b5:v103"); Wed, 01 Sep 2021 18:19:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 007b4b092baf2869 X-CR-MTA-TID: 64aa7808 Received: from 82fc15fe3c57.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 75C7EC0B-7F42-403E-B5EF-1405BBD82C71.1; Wed, 01 Sep 2021 18:19:20 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 82fc15fe3c57.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Sep 2021 18:19:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YEDrJv7qfE64Palh8Q6sgHPkGKwWBXDKwzliQySe9hMwDW/TULSdg/KV/HXGejyl7zNvgnnG9oCcyZ3KY6fmXXusN9eejep+sGReUFTyFzpzs7JThfmNG10cBXFj3Pd2z1c/Y5Qk36r/LtsV2AxN7nK6xVIjHF5aXs+UwnVTgy89q1xzLz5gNZXyeGxvbcTkC1cpeJx7lo9HWGS0dhakxPzJKqUgD7OI7M9c/3Lo2bUk4X/JEcvvAyo2Kya3QhUAmqdJurlCGOW6ShpzB2LGSVEoADUgC9aRwZMiR67KCvVaeBF6wFpgotZObRm4AZQ8/+avFhg20axo6NnbvIv6wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Awp+/a6Mw2rfEDGy0N8ZnMPoZKxq3qVJ9ER6ue3XQds=; b=BrKzEOxmrYqguAcXKJwUqBQNIBeh2a3FTBuEXWW1lvv8Pc+LWds3chECkEX3bxqjc3nbFMOW0nOxQ4D/nJPrihJrFm3cZ0JqxAtgJj/QDdvS+BAquhvPm6leesQg6nwAGxDj/FRfG5Ocm25N5tYjepPp00MLBljBD6jBFBaBNMmRhvH0Ozo/btfO5zkpUIRNAxo9SyLUyGYwzqSjfEbjEryWr30KCqjXOl/Kh0WCAYt9bQ8+7FcRXFmqsO8DceFfvRzQ7zHP0czVriGcJHmoikonzg9RJF2vpivKty301pFajXqLv+yONvOQvQkjy994YyuTja2g0wZMfMw8ewU4aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Awp+/a6Mw2rfEDGy0N8ZnMPoZKxq3qVJ9ER6ue3XQds=; b=BufQ+VQr0K2ce6j2pmGnI+qDjbmGLOmEwrOzllrXj4AlPonx5vGPr7kFkvx60zw2deIFUrkyy9+r9BhRKfg68yDduHeFrzz1wOLA8ltAtGBROGjGamDNT+XJSnEw1xqiFhpb6phRSL+3aXVgZk7J6XbgiYbnHEzI6Ugz0H2xLJI= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PA4PR08MB6190.eurprd08.prod.outlook.com (2603:10a6:102:e6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 18:19:17 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::64e8:1f66:7a78:c5a1]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::64e8:1f66:7a78:c5a1%6]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 18:19:17 +0000 From: "Samer El-Haj-Mahmoud" To: Pete Batard , "devel@edk2.groups.io" CC: "ardb+tianocore@kernel.org" , "leif@nuviainc.com" , Samer El-Haj-Mahmoud Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi/RPi4: Add _DSM ACPI method for 32-bit MMIO xHCI access Thread-Topic: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi/RPi4: Add _DSM ACPI method for 32-bit MMIO xHCI access Thread-Index: AQHXn1DuFzGsVh5rbUCTFkxSSOhiD6uPe2Zg Date: Wed, 1 Sep 2021 18:19:17 +0000 Message-ID: References: <20210901164610.1047-1-pete@akeo.ie> In-Reply-To: <20210901164610.1047-1-pete@akeo.ie> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: akeo.ie; dkim=none (message not signed) header.d=none;akeo.ie; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 0ef36472-651f-47bc-f2aa-08d96d75083b x-ms-traffictypediagnostic: PA4PR08MB6190:|PR2PR08MB4747: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vUx4K00TfQ5PMIVgOYH2k09Xe+yiOojIF1D/5Fe6YL4hKKwfrCRD2vp/6j2S/wbFS6HnXbLE0wa2yKAZCfW73COSzReSb4Xh8gpoUxEiaU+5YAX5MDFbehmN3EwDyH86D6Gkw6gmkdKY9I0P1BAtBj+UtNNCWPPSaoCuOphn2EW7CxtCQfvGq1gQzP7MyAlouw9LM1ZN4d+IjCojWb2WrjyPzxPSwESapB39d2HNiosfLyg/0YY3mn4FTSzfBVw0UL74Cu9Jzli6jiNVH+QHzABZcuBaBv1PUcBOUY11I76qpom0jd8JNswnH+DTa6KeXygKJgM/5VR9LXWReRdxLsastrpOhQPZ80ThMjUEw7ZSjTkYkElzd4zGKOUpY6CRcYLrRYjq6IbfZJab83KxwCW8IvLAJx4IXX+kmbEBp5RnX+ReCSQylyeSJSXfP6ZNVYXZhKDVzeliT9WSj9gXtkQD4BVS/YlWvzq97v4hOQ2EKTvp3w+co5jPu93nYH/HTqza4AJzkLyuIvbFJCI+LosQ2WnwQVVVZfbf542S3W3akLV4Gmw3lx6JEeyhHyfnae1e5BXMCakKmN+KorWevy4fM7KLEcUPxsLwDcXaFZZGiXKxvlIkopMkXpfHsenszPxADbzZD3BLc0MjhHVHze5oM1q11MqAQVAnv3LW4hBETdQdLAcigcO1WV4NvkH3RJHIk+MVM8UXlsCQ3dvS6g/zpZ5CKJW7NhbZteBqm0hWvD+N/VYbEDwBV1+YpsCGWx0Zwpif8XZhh7aOReNIb/eOOuYim1DgZXFCSVNFSk08wMAncNGgWQTkgVAztf1/m6nmE94mH67QPTzFaE1SZg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(136003)(366004)(396003)(8936002)(38070700005)(110136005)(53546011)(54906003)(26005)(7696005)(316002)(2906002)(8676002)(4326008)(6506007)(45080400002)(478600001)(66946007)(186003)(55016002)(86362001)(966005)(38100700002)(52536014)(122000001)(66446008)(5660300002)(66476007)(71200400001)(33656002)(76116006)(66556008)(9686003)(83380400001)(64756008);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6190 Original-Authentication-Results: akeo.ie; dkim=none (message not signed) header.d=none;akeo.ie; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b887a732-57c1-4a05-8b52-08d96d7502c6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QKCvUTjaa8/zdN+nIv6VEOEwnYdF49BfwpBnSm8LtgGxVhMAGBinXC9V374mmrDaknqDxHM1XstpNJndfXPraR4po0PY0Ue3EvumUVG3zB+TQknxbP4sFMthYJbFvGwXRIdOMPfXVHmduLghoZDsHkbJpb7/ysL15JbSDFMMi/ulazmoluXieFlCisjSzlu73eiZvI9L50J5NCppqpm38SMnkMCN7Dboz8+j28du9MiJ4/NJj8Y6smQQFsyUBnp71pzidyGbB7luzOpUPZE6QEJB36vtTx3Gvg/14q+TCki1Vall6/jGQt+Xk7ERroIHmjjGVkuIONo9hSJjOUbXJKq0sGrhTqAY3h+3x77sfRKA9IBUi6ojl/o9vunSZ3D+kaL8EYXGniRjka8KMsgYbStTcw4PJ8JafLhG9klP/sA755DQBhm9p20o8PGxLVy75uqp9EGsmiiUioOAHou1QIZxznPGCBLo8XclksCTjp5Ft716cSAQgydq5Y/WfefimPXY4cQX6Hl22dThIgu1v7lL9E5hVVXb3M0TWJa7qB7edNS3AfuRuyn/ycOW3g5C8jAJr2/h5jo5eYfdzilfL8jKyVyu5yoIbV+IQL0hdt9rlvrsPsHrsNXrx5HXKzlk3lmekCdk9Z7b303GoEKvAUNm15dbWVhK/tWd4m5BmjBmxncc7LVC/UGCN5SDPKXzVz28pfDO6OyvSqEW2YAka11ST4M3gGxyFVCuMjVyRQMe1PCN2krVyPMET/L5I+AR8WQpkG70418pDQ8tGDlaw/EbzTjXWOKqyVzwjVDyysM3WRDHxl5Wo6ooDWb1/vXLHF6/g4KP79C+Yv0K5wQpDQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(36840700001)(46966006)(83380400001)(47076005)(36860700001)(8936002)(70586007)(186003)(33656002)(82310400003)(70206006)(26005)(110136005)(7696005)(53546011)(6506007)(316002)(336012)(5660300002)(478600001)(2906002)(966005)(81166007)(45080400002)(4326008)(82740400003)(86362001)(52536014)(9686003)(55016002)(356005)(54906003)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 18:19:26.6313 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ef36472-651f-47bc-f2aa-08d96d75083b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4747 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Wonderful! Thank you Pete!! > -----Original Message----- > From: Pete Batard > Sent: Wednesday, September 1, 2021 12:46 PM > To: devel@edk2.groups.io > Cc: ardb+tianocore@kernel.org; leif@nuviainc.com; Samer El-Haj-Mahmoud > > Subject: [edk2-platforms][PATCH 1/1] Platform/RaspberryPi/RPi4: Add _DSM > ACPI method for 32-bit MMIO xHCI access > > With the upcoming release of Windows 11, Microsoft has introduced a new > USB > Device-Specific Method (_DSM) function to enforce 64-bit xHCI registers t= o > be accessed through two sequential 32-bit requests. The new function > (Query > controller register access type - Function 6) is documented at: > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/usb- > device-specific-method---dsm- > > Support for this feature is required on the raspberry Pi 4 where there is > a bug/limitation in the xHCI stack that prevents full range 64-bit access > from working correctly. It should be noted that an equivalent for this _D= SM > is not required on Linux, as 64-bit xHCI register access is already broke= n > down into 2x32-bit by the drivers there. > > With this _DSM, and unlike what is the case for Windows 10, Windows 11 ca= n > now be installed on the Raspberry Pi 4 without having to alter any of the > installation files, as we were able to validate using the latest Windows = 11 > Build 22000 Insider image. > > Signed-off-by: Pete Batard > Tested-by: Pete Batard > --- > Platform/RaspberryPi/AcpiTables/Xhci.asl | 21 ++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Platform/RaspberryPi/AcpiTables/Xhci.asl > b/Platform/RaspberryPi/AcpiTables/Xhci.asl > index 9b37277956d9..00b0cd29c69c 100644 > --- a/Platform/RaspberryPi/AcpiTables/Xhci.asl > +++ b/Platform/RaspberryPi/AcpiTables/Xhci.asl > @@ -138,6 +138,27 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", > "RPI4XHCI", 2) > Debug =3D "xHCI enable" > > Store (0x6, CMND) > > } > > + > > + /* > > + * Microsoft's USB Device-Specific Methods. See: > > + * https://docs.microsoft.com/en-us/windows- > hardware/drivers/bringup/usb-device-specific-method---dsm- > > + */ > > + Name (DSMU, ToUUID ("ce2ee385-00e6-48cb-9f05-2edb927c4899")) > > + > > + Method (_DSM, 4, Serialized) { > > + If (LEqual (Arg0, DSMU)) { // USB capabilities = UUID > > + Switch (ToInteger (Arg2)) { > > + Case (0) { // Function 0: List = of supported functions > > + Return (Buffer () { 0x41 }) // 0x41 - Functions = 0 and 6 supported > > + } > > + Case (6) { // Function 6: Regis= terAccessType > > + Return (Buffer () { 0x01 }) // 0x01 - Must use 3= 2bit register > access > > + } > > + Default { } // Unsupported > > + } > > + } > > + return (Buffer () { 0x00 }) // Return 0x00 for a= nything > unsupported > > + } > > } // end XHC0 > > } //end SCB0 > > } //end scope sb > > -- > 2.30.2.windows.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.