From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.87]) by mx.groups.io with SMTP id smtpd.web11.21734.1621854538217423265 for ; Mon, 24 May 2021 04:08:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=JAgxb0j6; spf=pass (domain: arm.com, ip: 40.107.21.87, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SekyJL2aC8fuFtugUIS2vKA40M2GUMmr3v9tNrVb8i8=; b=JAgxb0j6weXYNCs/KN/d9XrvJ3iIPnQRD3+qArHP62tmRhWFqp4v1tUbK7nbvlhYNrEqpdT1WG9e972nefA8jafZZBWt1SYOgSlaPzLDfIYijq2dRyD5Uvl3nMV+Xt/2y/wdD1ND4yAl+NH+ApPltapfdzFMXzDT4w0Y8h92t40= Received: from DB6PR07CA0024.eurprd07.prod.outlook.com (2603:10a6:6:2d::34) by HE1PR08MB2793.eurprd08.prod.outlook.com (2603:10a6:7:34::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Mon, 24 May 2021 11:08:52 +0000 Received: from DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::21) by DB6PR07CA0024.outlook.office365.com (2603:10a6:6:2d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.12 via Frontend Transport; Mon, 24 May 2021 11:08:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT064.mail.protection.outlook.com (10.152.21.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 24 May 2021 11:08:51 +0000 Received: ("Tessian outbound 3050e7a5b95d:v92"); Mon, 24 May 2021 11:08:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 856c12f1f468b703 X-CR-MTA-TID: 64aa7808 Received: from e4056e7aa332.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 93ED3B98-CCFF-4F51-B9AE-B5FA69928738.1; Mon, 24 May 2021 11:08:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4056e7aa332.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 May 2021 11:08:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eu75Nq1qeiv53O+vJ3LF1P260zNRo8C+7OQMGqxIg5XUNc4QA6vVGXSXWkVk2fTKrF5Lt41JkspF/fnsaDiRy4dy5+W2N1+ydwc18dzeUPSf6jWXdpQK5UfSPla9GoJVJVNCP1W/sxyqOmxV30s2CIdK2a1gls+DqTfWeivSZQkz3YucNo9AaLsQ5YIVLNRkwX1HR9ayc9Wc9TwRwARrbEkWkwegMk8IqjS4t3I9pHULZc1z4lw0OBtx+cJxs8Ay651bsp9zVDocVQUnaTy28u37XAujRqU8OMz2uIdTezIjVUbQZjOoKvQhl81zgDf2M6Kfub8qYgbt0pjKekYwNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SekyJL2aC8fuFtugUIS2vKA40M2GUMmr3v9tNrVb8i8=; b=Flz5XH0K9+koMorsUi+5LfHPZDqF/P74LdX69yGA8IAPaSIpzfH218AnEBy/N/ng9VCGj8SppIAWfBcYg3rKerlLvMPNUZu+pD9w99cWon1SGy23VyztlhRNMBDMQx8l8xxzxoW+KT1ZBXPOqto9aQO581O2A/mSTXCvlhEId7NS/j8ImdT1Lo27CX9J3IgC6huqpwQPJOnXrmXeDF5oy4gJhIAsTc/OShADKRetEGVrglxIGnAz/86W+p9sF7PgRPEYbNpf8o/tKx0K7slbRpjRkK3wHv3nLnI6rbAEUIgI94IRwNdWJRMYlh0LXqsrHxxa1whA3YD6ifgWTzeaUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SekyJL2aC8fuFtugUIS2vKA40M2GUMmr3v9tNrVb8i8=; b=JAgxb0j6weXYNCs/KN/d9XrvJ3iIPnQRD3+qArHP62tmRhWFqp4v1tUbK7nbvlhYNrEqpdT1WG9e972nefA8jafZZBWt1SYOgSlaPzLDfIYijq2dRyD5Uvl3nMV+Xt/2y/wdD1ND4yAl+NH+ApPltapfdzFMXzDT4w0Y8h92t40= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PR3PR08MB5577.eurprd08.prod.outlook.com (2603:10a6:102:81::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Mon, 24 May 2021 11:08:44 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 11:08:44 +0000 From: "Samer El-Haj-Mahmoud" To: Marcin Wojtas , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Sunny Wang , "gjb@semihalf.com" , "upstream@semihalf.com" , Samer El-Haj-Mahmoud Subject: Re: [edk2-platforms PATCH 5/6] Marvell: RealTimeClockLib: Fix daylight and timezone handling Thread-Topic: [edk2-platforms PATCH 5/6] Marvell: RealTimeClockLib: Fix daylight and timezone handling Thread-Index: AQHXUF3R9gVeBNzJDkSYUCiDYwDyrKryeYdA Date: Mon, 24 May 2021 11:08:44 +0000 Message-ID: References: <20210524052919.2496579-1-mw@semihalf.com> <20210524052919.2496579-6-mw@semihalf.com> In-Reply-To: <20210524052919.2496579-6-mw@semihalf.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 2d7059fe-c24d-4292-c951-08d91ea45036 x-ms-traffictypediagnostic: PR3PR08MB5577:|HE1PR08MB2793: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:2449;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nDrBEtE2UiQQ72OZ6yal/Zej7TI3r5FzbFqz5LUHvF5mZakoqNBqzi2dXtLi9YV4u2lyeuZ3FUiWgPNxSXkAk7VXNrNyhL3drJlCCy6AMklV8x4JNr903WsRBmrOnr8zr0wlQnQVfJKTNDCe4FjRGn+PkVQkOMYIQMAaxNmf7caJzErgzE4qtFOdjh/f2xlaImEKoxXpNnUDjPufQOq9evDUU+4ffmrehluJ9uWcmM6HAoglVhUmswDQNufXeYRd0iSIbZJyEUpfA38BQJWtYb5Q43RbsIqPoYYa0e+80XPNqY+2krLeTQI42KnEFuo2LW48ip0Au/7lARd3NtnWxGfLMioXKpazqtHqORqKslrlbXjI701ldE+NDnobYLv/WylG3xgzE/NJnz7faflMu2E3zxLCw1s7bSf8ZH9/xtdsvokF+tBgBdEfomQN3FZKvKprPHX25mTFmKQSKJHLbVv3yZhqWMnFQOQNs4ahcGuM71BmTJxWzQ4iGZN0QVTez7JAzz9qYTqYhfFOAc67AXfvXPh7qEQx0EC7DAvNxwSaDjbK7EkhXzJnceAZuIAAFCQFYcyhHAPlk/SG3pzaTSZuiBLJb7NhJTZoKsk0uSQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(9686003)(38100700002)(122000001)(2906002)(54906003)(8936002)(110136005)(66946007)(86362001)(71200400001)(83380400001)(6506007)(53546011)(186003)(4326008)(66476007)(76116006)(55016002)(5660300002)(64756008)(66446008)(52536014)(478600001)(316002)(8676002)(26005)(33656002)(66556008)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Vceb2bpgbg5HqD7j0oNbBULFJjibj3WsxAcqFpqmzqF3oXoqoDUq+/HKwjBI?= =?us-ascii?Q?fPxa0/R0apOm4hWKM9rXFagz/2uvJFVomJNdaV612jIPcejySgDyKFoc3+yB?= =?us-ascii?Q?ZTLwn1sN7jdnKuB41TMGCqKa5gDmI1PUjGkf8wyFLKtScEKAsSL1VWaYQ2Nq?= =?us-ascii?Q?NPnikK59qju5w2BM7bFpTRIANFnaVGLXuFEu6Idc/gwCOs6EHpKdr6wrtWmj?= =?us-ascii?Q?AnFfdT/mNZwcrpeEZmCJSsEI7Gl9iBmlyxbQpAtUj0lIl9mj6VFANVFzl8Mn?= =?us-ascii?Q?l7GgiTZ495Ivv2qvwvQfpOvf/wzqfW9aZvR4ga9H+nu4v8HAfKoL95Yh9bw9?= =?us-ascii?Q?tZLPh/5mHc/G9QU0lAoVGEOAxAFnX0xMW0livBk4iSJT9ddjp60utzFuNmsu?= =?us-ascii?Q?7jPV4Qs+hTNuS8e4wO31O7Q8qdkWJ+HlS0qP97GZ1sm3JpzXT+dYV6WlWYHH?= =?us-ascii?Q?INxSIYe1gAWxZZHjS9sYLHVPglZV9gjLZ7JUjq3j2tF5K5Yi5tcGwHnL5OfR?= =?us-ascii?Q?wdhiXm4cnuZuWylFurrdlNHLRCE1m3SH2eJ3m8unoZdtuZqf6Y/fQFizNPFS?= =?us-ascii?Q?oVMSkn83yAdextgKUzTXOSHpVsvyWM2Tqo2+TZlzN/nkam9wtT+PM20MIMsL?= =?us-ascii?Q?Sei/SpG5yw6/XA8R66zQtLZ3258ZnoUsfF+w51V3m9CZvUA98LgIn3pZxUy6?= =?us-ascii?Q?u3+IX4RmiZwEAHK7y6iJBmFnSnB9yTiNVKx/2l8RynJ/4gseglJdmjxQPPb4?= =?us-ascii?Q?/YycJZ2gepUizBV8j3aWWmpqCfl+cwgIZbv4FKkj/3S8a3q8JMiJFZvtob7C?= =?us-ascii?Q?2L18IfT5QsacdDJzystY+roSdz9zzNIx+h5TexBethoywvbOOaCv5qQX0Zl0?= =?us-ascii?Q?9B2qOw8fnLT/fht8j1Cp6iIjBLfeoKhE00zUOWxbhSqi4w/LCZG+yy/GLt5s?= =?us-ascii?Q?wKFrqjPIPhzyKJOsK+BuJ9kWrfhW0LCwKuQTba0+XM3olqfITrS7CKT1cPLW?= =?us-ascii?Q?wC8V3ajzbAkGNPyI4BE4fhxDVPvQYJIRyrjKcOC9LhwJ/FBk8MzBwWaQxXXV?= =?us-ascii?Q?ltn9yjqoYPFcgiBvsJMOlOpnoMrqdCavgYpnn11gFaHP/2GyI+TVULTXHu1G?= =?us-ascii?Q?O6X0B0pXoieJk4Txx8OUirw/qo3ztPkuTk+AlRn/cPPy3DRRjZLGPbnI4ym7?= =?us-ascii?Q?p+Y0QJabxDCWr//ilfzeHA1xKZGGR8m/e1ioab2RKr6NwESRyPSrn/FJZXoZ?= =?us-ascii?Q?0ctfiY5qnjLwU+x8sT17Ul08E2WG1gqndPbLgTxDlTsNpl9PqOMTaTJOFt3q?= =?us-ascii?Q?64yB1aA3GuyGeZXr6rODLI1x?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5577 Original-Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 31c17d0c-943a-4ba2-8969-08d91ea44b9a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GYlDe0kcWz7VxxZmO8I5jEE013uEHmrnu1DqxvOrlWF65oKh/P0hRue6Zn0srUCqCz9b6WDdkhQxjzSS3i+9fptY+H1E7imdyE1ChERevLewFkquZy/4Nnho87wm1SEQfM+3VeI6CU5fRRptsnZo1XQelADGVM1PJzQskY9oi2SO65JSnYpdNp0gZmp0NE0871BnMHitxFrF6m0uBlvGXwjIPc61McVjjUKQT9bz9D0JV9E/IzCSkQRj6cTVDyhTdF6JUmq/8kjRBtwvUmtw4oTe0BaUhmsjfjaGIyNBPm6VnaTZiHMoAZNEVsOeZuB/f+NJU6/fS9+QP0qOJ45gdiW5I1luKTzc7jw6htORD5iVbETAIcl94qez2GxHfVgLUpSwqdrxxWiEaHtIHwlw25J8sAWUssQZel7P+GVCFGr86VakujPTcCkdBlwUlrGG3pHc5/3dNqG3Ny/prx7YBXWaRAXUNSeLe3k7qgz20RtSMREJDlDyXUqzo3Jg4OWX7eU1Gux70PmeHcQ0Mh07o7Iu9LA4tTnmXTRo0HyfTcFNiHI4a2ltRhjxGR2s5NULsMzBQ/FPiymWiU9PMDPe1gXcESFfdbtbH6fJBIyXV7uJ8VLa24MaQDmFGEzfXb6FLTRLUTope77xqIlXMhqFlnerO3Z3gZLDx8sl2ONDXa8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(46966006)(36840700001)(33656002)(86362001)(2906002)(36860700001)(4326008)(478600001)(9686003)(70586007)(5660300002)(70206006)(52536014)(186003)(8676002)(8936002)(81166007)(356005)(54906003)(82310400003)(83380400001)(7696005)(6506007)(53546011)(336012)(316002)(110136005)(82740400003)(47076005)(55016002)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 11:08:51.8793 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d7059fe-c24d-4292-c951-08d91ea45036 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2793 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Samer El-Haj-Mahmoud > -----Original Message----- > From: Marcin Wojtas > Sent: Monday, May 24, 2021 1:29 AM > To: devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang > ; gjb@semihalf.com; upstream@semihalf.com; > Marcin Wojtas > Subject: [edk2-platforms PATCH 5/6] Marvell: RealTimeClockLib: Fix daylig= ht > and timezone handling > > The Marvell implementation of the RealTimeClockLib was unnecessarily > overriding the daylight and timezone values, which are handled > by non-volatile variables in the generic code. Fix that. > > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | > 3 --- > 1 file changed, 3 deletions(-) > > diff --git > a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c > b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c > index 40ab01ed41..a48d44ed83 100644 > --- > a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c > +++ > b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c > @@ -79,9 +79,6 @@ LibGetTime ( > // Convert from internal 32-bit time to UEFI time > > EpochToEfiTime (RegVal, Time); > > > > - Time->TimeZone =3D EFI_UNSPECIFIED_TIMEZONE; > > - Time->Daylight =3D 0; > > - > > return Status; > > } > > > > -- > 2.29.0 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.