From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.78]) by mx.groups.io with SMTP id smtpd.web12.21398.1621854041361928790 for ; Mon, 24 May 2021 04:00:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Ts+PNDQp; spf=pass (domain: arm.com, ip: 40.107.15.78, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LElPTED5xFCheRw70FlHGoy9AGI7J1HVcLVWlb7hpc=; b=Ts+PNDQpaYOZs7r99sdic2UnDRhvRRRFpPHPAOzUDJ96UYTmHYyBuwUU169ciAKdwaOoZ0r4mxlRaI0xKEjgPB0I4ukyp4uXE4uNoo02JVYfpEgi7LCOqfW7/zX8weKA3sIQk9feVRv4VUrPzDdjH1fYcdC0MBK6+OfA8lx46TE= Received: from MR2P264CA0045.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::33) by AM9PR08MB7069.eurprd08.prod.outlook.com (2603:10a6:20b:413::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Mon, 24 May 2021 11:00:39 +0000 Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:0:cafe::1e) by MR2P264CA0045.outlook.office365.com (2603:10a6:500::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 11:00:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 24 May 2021 11:00:39 +0000 Received: ("Tessian outbound 6c8a2be3c2e7:v92"); Mon, 24 May 2021 11:00:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a7e972d5680528de X-CR-MTA-TID: 64aa7808 Received: from 445c9181c4ad.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B236952C-AEC1-4926-9E45-EE7431364C67.1; Mon, 24 May 2021 11:00:19 +0000 Received: from FRA01-PR2-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 445c9181c4ad.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 May 2021 11:00:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kfc1hYh8Jnyuo4STIgqy35B+qYsYc6mn0w0RQaHPQa56eGUYVEMY3yJVtcGg2n2vKJaXnZfz9vTV+nVbYlftvPNs/gtgnH9B9QRFZnTHzYAI02ZTg/i15Zco95k6c8DTv13CJOblKnrIXfmLvVcfWnIPJqqmEhkFblYUUF74LCrEwP9Lxltdjgu6ekzortTeleA/iiKja+0qxm+KMtmhC0qSDA2438V+tGcFaYGSt+jaKPrHMWr+GC/rixZnzywciRjXp1c7PVsv5Z9UZILaeYi4/InVNiRzmAz4Gc5EA9EdLP16l/Lbq2QFEkie0SoP/Vyx/GpdzFlUZXFH9JsEaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LElPTED5xFCheRw70FlHGoy9AGI7J1HVcLVWlb7hpc=; b=e281sJ/dpYoHzwljCI4ZH5I7gA56XPIiH17vAiE8kR73BzNbaAPoXSXHHQItkBJkXGWWqjI+5omkVA3iOGSvpopGJZZaIqlAPwyhnnFJIcgbZ8R2nfB3wqorQ7McUQDYcCc3LSVNIADGtFn/08aPObnfk50TAkVq91E1LWE7Ew8mIO5pOT7EduNRKjjwTHEIjAL878RYZJ09sV8I7REayozcuxwkWfWyXbBuj/RN9s4PZ60FLofBVRhS3gjvDOMquvPkduzahZcyvP8JVZyOAL2BQIsPX+L8m8adTbdw1BSgetpZl1nsqMNWc8LvTHQrhW/Y6va6IymuaffU9sCSeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LElPTED5xFCheRw70FlHGoy9AGI7J1HVcLVWlb7hpc=; b=Ts+PNDQpaYOZs7r99sdic2UnDRhvRRRFpPHPAOzUDJ96UYTmHYyBuwUU169ciAKdwaOoZ0r4mxlRaI0xKEjgPB0I4ukyp4uXE4uNoo02JVYfpEgi7LCOqfW7/zX8weKA3sIQk9feVRv4VUrPzDdjH1fYcdC0MBK6+OfA8lx46TE= Received: from PAXPR08MB6987.eurprd08.prod.outlook.com (2603:10a6:102:1df::15) by PR2PR08MB4858.eurprd08.prod.outlook.com (2603:10a6:101:1f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Mon, 24 May 2021 11:00:17 +0000 Received: from PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad]) by PAXPR08MB6987.eurprd08.prod.outlook.com ([fe80::7c65:78c4:8d03:62ad%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 11:00:17 +0000 From: "Samer El-Haj-Mahmoud" To: Marcin Wojtas , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Sunny Wang , "gjb@semihalf.com" , "upstream@semihalf.com" , Samer El-Haj-Mahmoud Subject: Re: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use unique UID's Thread-Topic: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use unique UID's Thread-Index: AQHXUF3RKqTr6dwe3k2YIR7GQcQBsarydyrg Date: Mon, 24 May 2021 11:00:17 +0000 Message-ID: References: <20210524052919.2496579-1-mw@semihalf.com> <20210524052919.2496579-5-mw@semihalf.com> In-Reply-To: <20210524052919.2496579-5-mw@semihalf.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 009c0c4c-da1a-4717-f529-08d91ea32a84 x-ms-traffictypediagnostic: PR2PR08MB4858:|AM9PR08MB7069: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1060;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UjMNXnwaYEisgBboAcOODptLmZTOh1TqiTEW3ZCvkVbEA6sLFVsTzG+SKdc81jO7t7M2Epb+d6N2sADGAko0c8r9kh/U5MIS/EBbScV2E4JV2EcEb9jWTBEArCR8Z/rmbcUHF/1NzSEKxagR6fslWLQNtrsZUd7Y+0g2SP0EpFpFE25mbht3e2FkdpTi0Ec2sP10Pq57aRkIkYO90AnmmNmRilhdwvQousWjydwvt2uJgME7L6JT4Y+MGqT2bgVDZWElEOslbRZFALhQSDjfmmhFKi0PhzYz2mfP7PUtZuVMeHd6M3S7u7BtXqOCXUOidNDVX/m7FYdhR8aQY5sxLOSbmIrcDzlrTCtYMr5V5/Yt1vlw+0EjSXZhEuE3AllVHenNd1uBsMP/iQeHADDOWkHqzRv4/NhF2GPG96w8m3NzjM4xvadZoY5JIKbcMMMWRbcMdjwPhaoAONCFl7490ZMvU4atTo4gMSHY/UaunJzgb8dmBU8WU2czU2gdJPJEkjTAh4BHXEFSeDfnn9MTBwk9ZHirdP45y5ercHzgIIEMOpguads98rhHFi7BzwqQeBHlzeLSuDlp/a1/PeEdDgDZ0KDYd36GszVX57tlQAU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6987.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(376002)(136003)(346002)(366004)(396003)(39830400003)(83380400001)(66946007)(53546011)(186003)(8936002)(26005)(4326008)(7696005)(66476007)(33656002)(2906002)(9686003)(66556008)(6506007)(66446008)(86362001)(76116006)(478600001)(64756008)(54906003)(316002)(38100700002)(55016002)(71200400001)(122000001)(110136005)(52536014)(8676002)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SILT0ZoP2jRoI+UY13Ff46nJcWW+fnAFGtNSuxXEWHNac3qXlFUr7prT1/0G?= =?us-ascii?Q?zdTVDvIB1r3ekshWMZm0Jbm/aV3WNO/GG2rjRX4pB+KNNj3O0M1ElkGJ98hV?= =?us-ascii?Q?jkvhD8/bwbX/4st6GIzEc7MKYDri/e0jXhXJmYDAO51zRK2om4941fAKu13d?= =?us-ascii?Q?eK3fOut4g4bLTDYXtOZDo4I5ohqleiD+TOcbpjL/9WOccykrufc8XCWOeiLA?= =?us-ascii?Q?azRWQGCo5vfvQz5DfjCxorOsJYBhadc0M1FhW5bJxQANbkqfGj0OlEpPy6q3?= =?us-ascii?Q?Lx7SPBkKLdiYesIR/hqVNG/wEWTEWNdB1OwW1mroJq4cxhbIiXxvJ3dVQ1/a?= =?us-ascii?Q?+IHirNM2UhvdcheNvtK1BHRcl8InMomGmSn6E9FAh4ZOLQ6iHQE2YHUrslHa?= =?us-ascii?Q?9o/y/5vUc+07Tv3eEM7OTbP2KDv8DLqXUv/zUpKJ1wK5JhthDrQPQc33K1jW?= =?us-ascii?Q?9CcHTw2To904cfqrr3p3WIANg6HfgcPhSVuPnMzBUxjbCftsa0c2Ru7fDfxZ?= =?us-ascii?Q?OiqwlZx/StSL6qDQBiLZyRaJ35bzB7TBouzLQ55dEJHfetpwFSVjSFIp8QhM?= =?us-ascii?Q?n4OkiXceq70Gvsl1sFKF/mSTsAYbABus2gSUNDY8jcU7eQiMtQgH/82WI75Z?= =?us-ascii?Q?zPGzJihkzJ3q13+q/BHLwMS6zyzDCPv10D7aNctaL9jnTIn9r1975gmooOxU?= =?us-ascii?Q?txu2kjkPDUQx+uJ9a1Si6TuWdqn3XtwiqSj7uP/zjfFn5NVdzHllfjlP6JRQ?= =?us-ascii?Q?hjhsDxc9duTLSIzmx/LX7NNy/9WluFAszugQFaX4vUx43TzpV/giz3d+I5eY?= =?us-ascii?Q?Sn7jSxL0Gbdnhg7P+LVnNS2Bo2dE6nJy9q0nFj/XK4yIEBA/aSWcRWVzJ2f3?= =?us-ascii?Q?eBvc+2w37ym0EWgb5BW7md5F6hWb14wmo+5L5+WXLNse699SFk/IhEsHRxsr?= =?us-ascii?Q?LqRbmuCwO02PlSzYSBepVcIjkUWJwQAmqXcm53wha8YBDYWLuAbBIPhHru0Q?= =?us-ascii?Q?3U1SK4guw0Cht0ts8rHbox23EYTAdRekn8QJejYRgetqx0gf1+/HCePxfnRo?= =?us-ascii?Q?APmTj/b3Rt2KF0lgkUikx1Nvl/P6/JKfUPnbU0YveyEJfoInWu4G1+ajEWbx?= =?us-ascii?Q?xn1zUbJVenS21onrd3TgZszYjSJkqrWvQxdZfVbHEKokInAJmR1IYKHOrwHU?= =?us-ascii?Q?Zioy7dnPFtuCbyQvaNKALBLXuhRc4GJCS6nuNPVwtjo6OeTrarZHevKFlfmK?= =?us-ascii?Q?bCwFKu150gdL1MBTyYKZ+/V6jPfidg1g/k/PhSbiEXgxx6hHPKcktZXes1+R?= =?us-ascii?Q?SZer7v6sZWB7qAsToTR47ngK?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4858 Original-Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b19464f6-eb14-4f09-8132-08d91ea31dde X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 72elMCEbMNbNYadx+VCtTJpNi8Qh3sF5iJn/sKDCjdpQqxF13IqnQ8YR7CGkUHFbokohdoys0Di88eh4tmu/4LBw0knvjprO+uJFTw0NQkjHQkWMge97T/iboejZJyK6d+KwC9gkuVvj54MYiFJEkOrl/r7EzdTwGBtZsvdlu9BSxCkTZRX0v2L2NbSALTRARjXxFr4hRdgWpBOzV+LWyuU+jhrqM+966dxwdZ5FqM27rnQWr7LhOI5CvoJKuIZkoY4y3bPLkhB3rTytbX1IuVjuDQ4bsR0LLCz+jGm1JZD3mFUpcWdKT+r7rmQeCLTYQFMw+x+rMyidFiy0fAejfnC3ptJA4W5P51Z+DqI4Lx76rKAXezLnZq1wfwB7UArvp8LvSAhRrIZWt7U0PDGoQdjG7CyOPITV5uF6HOwR3CVLkOcFooNMwpWYpyKSeSFqttCr7G4h5gmIjhFqaxXvnY116sCD/HiILknXprEqUW20WvDL990T6c+vqo45xTCVjoUHIYk9A5v+Exo7cnEQKfBCBXMN6+89AWy41fimkDE6+zYYwVTzesEMvlVI0aXucMY/Il232+unbLY6E+Q+pcPAk1u/bwiW8baiDYraGVcrcSISAZsKxoetSjaVPCjL1H7yh38Yy4DCQJL90nLm5hDkRGZ+xRoWn7jGlqQsjXY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(396003)(376002)(346002)(136003)(39860400002)(36840700001)(46966006)(82740400003)(9686003)(8676002)(53546011)(478600001)(336012)(7696005)(83380400001)(82310400003)(33656002)(70586007)(5660300002)(8936002)(316002)(55016002)(186003)(47076005)(54906003)(6506007)(81166007)(2906002)(36860700001)(52536014)(110136005)(356005)(86362001)(26005)(70206006)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 11:00:39.0235 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 009c0c4c-da1a-4717-f529-08d91ea32a84 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7069 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: Marcin Wojtas > Sent: Monday, May 24, 2021 1:29 AM > To: devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang > ; gjb@semihalf.com; upstream@semihalf.com; > Marcin Wojtas > Subject: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use > unique UID's > > The CN9131 variant's SSDT comprised UID's, whose values > overlapped the ones used in the main DSDT file. Fix that. > > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > index dc32fe836a..691a709c18 100644 > --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > @@ -18,7 +18,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2, > "MVEBU ", "CN9131", 3) > Device (AHC1) > > { > > Name (_HID, "LNRO001E") // _HID: Hardware ID > > - Name (_UID, 0x00) // _UID: Unique ID > > + Name (_UID, 0x01) // _UID: Unique ID > > Name (_CCA, 0x01) // _CCA: Cache Coherency Attribu= te > > Name (_CLS, Package (0x03) // _CLS: Class Code > > { > > @@ -43,7 +43,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2, > "MVEBU ", "CN9131", 3) > Device (XHC2) > > { > > Name (_HID, "PNP0D10") // _HID: Hardware ID > > - Name (_UID, 0x01) // _UID: Unique ID > > + Name (_UID, 0x02) // _UID: Unique ID > > Name (_CCA, 0x01) // _CCA: Cache Coherency Attribu= te > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource S= ettings > > @@ -62,7 +62,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2, > "MVEBU ", "CN9131", 3) > { > > Name (_HID, "MRVL0110") // _HID:= Hardware ID > > Name (_CCA, 0x01) // Cache= -coherent controller > > - Name (_UID, 0x00) // _UID:= Unique ID > > + Name (_UID, 0x01) // _UID:= Unique ID > > Name (_CRS, ResourceTemplate () > > { > > Memory32Fixed (ReadWrite, 0xf4000000 , 0x100000) > > -- > 2.29.0 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.