From: "Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>
To: "Rebecca Cran OS" <rebecca@os.amperecomputing.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
Chuong Tran OS <chuong@os.amperecomputing.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table
Date: Thu, 15 Aug 2024 07:05:07 +0000 [thread overview]
Message-ID: <PH0PR01MB7287A3C3E6800988A4E05FD196802@PH0PR01MB7287.prod.exchangelabs.com> (raw)
In-Reply-To: <2dbe2059-0b8d-4729-807a-0b1a141df618@os.amperecomputing.com>
[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]
Thanks Rebecca. I fixed in the next version.
Regards,
Nhi
________________________________
From: Rebecca Cran OS <rebecca@os.amperecomputing.com>
Sent: Wednesday, August 14, 2024 8:53 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Nhi Pham OS <nhi@os.amperecomputing.com>
Cc: quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Chuong Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table
On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote:
This could be a static function.
> +EFI_STATUS
> +EFIAPI
> +AcpiInstallSpmiTable (
> + VOID
> + );
> +
> #endif /* ACPI_PLATFORM_H_ */
> diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c
> index 28c422dff166..a82a93d23fa2 100644
> --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c
> +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c
I believe the project now prefers the use of the C keyword "static".
> + // BCD Format
> + SpmiTable->SpecificationRevision = DeviceId.SpecificationVersion & 0xF0;
> + SpmiTable->SpecificationRevision |= (DeviceId.SpecificationVersion & 0x0F) << 8;
It took a second to understand this. Maybe combine it into a single
line, or change the '0x0F' to just '0xF'?
--
Rebecca
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120346): https://edk2.groups.io/g/devel/message/120346
Mute This Topic: https://groups.io/mt/107889268/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 3645 bytes --]
prev parent reply other threads:[~2024-08-15 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 3:33 [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table Nhi Pham via groups.io
2024-08-14 13:53 ` Rebecca Cran via groups.io
2024-08-15 7:05 ` Nhi Pham via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR01MB7287A3C3E6800988A4E05FD196802@PH0PR01MB7287.prod.exchangelabs.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox