From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C6D00941252 for ; Thu, 15 Aug 2024 07:05:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=E2K22Ugm48CGXnewK/jLTtK9IT6WKBF2StTmCOpnjnc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1723705513; v=1; b=K/FNWqCa6i1g8Ngz2bjVxbYPzE9vLkKR7AxPE3KkzminsJxumHiTcKidH7/ZfvwExPwrIos5 fyNLzIiSuOzsmO1OHUsD8MQnpZ+PlZfFjeS8KQcL323LA8vsYAYS5+phCP5+fdZgSPAa9Sb/U1i losfnG9Kmn3GZHekU0BpUFHMg7h7vtGJtVuXr9+DZKj6QFoxJs2QEYgRl2Tfgat6TlQCbqVNQN6 ddVH3OSsofXyemywI+Y+I3mGL8uNxj75v4HmVnhNGc9mJY5aXUkm47xUEvbGkcePirZQxYJMlFt 1bm0AxcKllwk5iiijUC3a9tgqaz6XYVicYZg8qqo7+vbA== X-Received: by 127.0.0.2 with SMTP id IAw6YY7687511xoJvpjAvkOj; Thu, 15 Aug 2024 00:05:12 -0700 X-Received: from SJ2PR03CU001.outbound.protection.outlook.com (SJ2PR03CU001.outbound.protection.outlook.com [52.101.43.93]) by mx.groups.io with SMTP id smtpd.web10.117637.1723705511597863703 for ; Thu, 15 Aug 2024 00:05:11 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB6344.prod.exchangelabs.com (2603:10b6:510:18::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.17; Thu, 15 Aug 2024 07:05:07 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%3]) with mapi id 15.20.7875.018; Thu, 15 Aug 2024 07:05:07 +0000 From: "Nhi Pham via groups.io" To: "Rebecca Cran OS" , "devel@edk2.groups.io" CC: "quic_llindhol@quicinc.com" , Chuong Tran OS Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table Thread-Index: AQHa7fr3JXvdOBF5uka4W+67OkJONbImxqAAgAEcqGM= Date: Thu, 15 Aug 2024 07:05:07 +0000 Message-ID: References: <20240814033333.2360719-1-nhi@os.amperecomputing.com> <2dbe2059-0b8d-4729-807a-0b1a141df618@os.amperecomputing.com> In-Reply-To: <2dbe2059-0b8d-4729-807a-0b1a141df618@os.amperecomputing.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Enabled=True;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SiteId=3bc2b170-fd94-476d-b0ce-4229bdc904a7;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SetDate=2024-08-15T07:05:05.832Z;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Name=Confidential;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ContentBits=0;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Method=Standard; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR01MB7287:EE_|PH0PR01MB6344:EE_ x-ms-office365-filtering-correlation-id: 603d01c3-f14f-4537-5c7e-08dcbcf89870 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?4eRtHyafSgWRzOUOlJUR1HIHzn+auVMlGa1zONqeQ/AAW842mjwEqPcO2cqf?= =?us-ascii?Q?SQAfEOdX5QA8keUtnJQekp81/Sqw5GnA/V1t+0nCQTSw7XWFR4YkBflSeI2n?= =?us-ascii?Q?+QSBPrvIAWAKLcuetbopJ5VGorlZQiUviieMKSQqqfkvsnQPG9wnYXTVGerl?= =?us-ascii?Q?jGScPqC1wrJaoM2/7qN7Ov46k2rZ/A2s4NpoueKOgDaM71eQkR6BpRIc8On9?= =?us-ascii?Q?J0UBytv8seoibxrk5VqTJZt50xoHzYT0tUNwB6EsvO70r1itYSwVz6hD7Kl3?= =?us-ascii?Q?NguJuUhsSseMJYNabmv2PjkDCvwMKW8/Y6cgjua5rHFVB2oaeQih+l7F23IL?= =?us-ascii?Q?h8uCQgTPoKw7Kuwn647D41WMIWA5zGguXAAidKha+c/tl4JuvNA089izBMvu?= =?us-ascii?Q?3sT2Vy30r31mAr0OTylEM+opf5vNOA94DRVRMuXP9Egia2AY8Dh7oelESeUC?= =?us-ascii?Q?ZYmePeRp8ugF7zayLUyK8MJBOstlgDwagfQ58otBhXeoAAgFJHUJryH9ks43?= =?us-ascii?Q?ozsm88fjljDaBqBDNMFgExv2Dw7FZVz4wuCn8vgYO868xbXyHFq9zxqS9r+R?= =?us-ascii?Q?xTdpUOylZ+riS9xlwiHoYRqNkbJcgIpypcWOfmhrojgVLaX7UQhEyxqqlOsw?= =?us-ascii?Q?3Ta6Ofsp80tX6LJ7gNyjh+7uZnz4GeFULbrK+uVBtv13Wl8U05NymIxxEGHL?= =?us-ascii?Q?vjXvVaSL7WAU+4SZJ3DQWJbIiN0yxUW9TPZM59Qqwvi7m14VmPv8ZZKT9uhz?= =?us-ascii?Q?LZDpF+/pYE6XFE0AthOBltKeQHmHvEsRaRUNXctsC53ftC2800OtJha1HGSI?= =?us-ascii?Q?Nr+dv+kcDVTQp0yFBDTOj8JWNQGxljvrf7lViP2Y7IFHGWIt7MjbN8oHW0oO?= =?us-ascii?Q?5n8QjqJSePI0cOiCkItqoHfhKVgspl2awziFhqFE3VgesfvQIglJW80Dtmgi?= =?us-ascii?Q?6k4R2/Aeo9WTxmXTCeiilprukNQ83kqQUNQtNWnmla+wWzABjYdVb0KQtzOn?= =?us-ascii?Q?fK1B3AZjGc25T/P4yuRhWD93XIrX0T3Gw76wzbn8wvKbm7zQ0OjTAWU0Ux0N?= =?us-ascii?Q?gRVcBnU2axa+JQS/U7eTIJS6LjIMvhNfzSmUHAdlmMZQU4sYYs8yGxsvbgxA?= =?us-ascii?Q?ZcqADRW9xFsS5gFwTBRw+xiobrOuT3u4phXE3DpNi+QKuLclDnUyTfoYc7LB?= =?us-ascii?Q?pKdoBgK/lNZ39pDCGiTbiqFrGSKcmtwVX9BO5hlbuX9QZFmycxMtMiyIhRaJ?= =?us-ascii?Q?c505AKoUN3/py+fYvoaPITCiN6j1I7JOgjoMFH1ODDcpYB56m9Ws50EA7uWy?= =?us-ascii?Q?TAtK/o/b92MCCvMs3eyy93zG0bfQ3B4Z+RUv9S31edRyszldTu+/kLQcSjeh?= =?us-ascii?Q?PBjN51tonkl2uFThLy2kuPo1wlZdmJnyk2Y4uesK3HEs7zWpYQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?56O7lPczpxEJPeyE2DYKMSWbix+P6/mmKV0h8UtgJjpwG3r4KcE8yJ8A+EDK?= =?us-ascii?Q?syJA7wTPxeOqsOzrw+syGnCZzbnZRaFbmMVgjHLSFAcpjLW4J8/2K9XNa9Cc?= =?us-ascii?Q?7EqwslnAxe8leGQrtEyvLHaDK+zA6Y4oY8WPDPV3YVMrbtjL6NnE5ALt+7z0?= =?us-ascii?Q?3IHhvMOzWLVO991WSEV312Hny6Qmglpgxn6J7QSFdtPeusnU8GzSG/dWkwYn?= =?us-ascii?Q?h28z3rG3DAX23dktQa4s94vZ3+1Z6pzcqMCqkwvA07kFv1/Se2uv3Lq+2z8Y?= =?us-ascii?Q?rdUHHQ/xaJoBvMLfn/uNSyuW8OahnB7gj6Qb3m3+uP9ptqOVJ6js2mLHGAdw?= =?us-ascii?Q?770xFgvez6z4SQUodews+nyGU1IGZ8DY7EFn6+Rc1RZR+Ayboga5254hD+uJ?= =?us-ascii?Q?jTyT8IcB4sGCLOj8vJLVhqnR26tg/nNfrGWEvZFWqQWqC7glCSzVwMZrNzvD?= =?us-ascii?Q?cdw9yDKdSFHxCOv4b2nQ4HUVDW3IlKQNd9k93CHsFAgeIfTuca8wxeaPhIhh?= =?us-ascii?Q?SqZwf01XJ3CHB/a6FvXN85mnBDueIMeiV4U8BXMVegFvN9oKzesMrZXmgYOH?= =?us-ascii?Q?zycxI93Xu+SPR9hG1KJMmqgiEu7WioTQa2fap3RLMhFGn6haGlXqmZ+hHZKr?= =?us-ascii?Q?HA64Qd6w8q0TliG4Vy3y2CmW6Uce7N2yBYHKFiVUGBJnLqBhjaeAPBonzk6s?= =?us-ascii?Q?scDwFnUgoMveQYWM+AIe3Fa9ijCdjiLW9R3rR3l+FCWCgBiaic5GNsEoj7L5?= =?us-ascii?Q?0d62Eata84E6082OL8t99pGgiLXVokmw4F+bewl2V6bCqyp8efDnOLKsQAlO?= =?us-ascii?Q?d2CYYxyhKuqcoOc2JN706iOIGv7YmWk0qINvKKUui6wyyCy/MuwSlRu1yGdg?= =?us-ascii?Q?V8SNB+lV3US8d5bTVEJJ57l+dX1POgNrz7KtlK4MLUzabhaaeR9qE43795Jj?= =?us-ascii?Q?11vULPswHJpaHJbb2UGWVJYfgHe5vhxcZww03RPh77k4Fl5B6LBD0m/qgUnC?= =?us-ascii?Q?BRIyiJivpuPJTkQadpc9tGjeW7PoA+HG8AVjmhGbg6VcdHIxE27auxf1eAWv?= =?us-ascii?Q?T3wuSMtEAWnfT7ZES0/p29HguuXz1ivKbQaZEB70W0GdTuCZz3ldUjJUJxTh?= =?us-ascii?Q?Nz3fyQmuyhgWt9omcBp2LxlKep4FjQPz+gMXCKW9xRLYnW78E3CtdB/C855r?= =?us-ascii?Q?KYpyuiC8nTBWByvvRwZR90EJGlBL8GYtBwo1OnbvFQ9ev/LCP24FG5SG5qLO?= =?us-ascii?Q?shP5oiJDGwmBTfyrqSTyWFWVhIEyVkiKrfs7QOVAZNQIQd8HfdijBOzwl4od?= =?us-ascii?Q?aZkIq+zq4tv54f/o3RSMJf2rJTO13H9cmg+sSfStSlcBZ1602gQDm9++FOso?= =?us-ascii?Q?mPSdZ/N1T5VFiaYwpVkjAEsat9U9wVmM/UGPM41fN+GlLmZGE7ngTc1tWcsa?= =?us-ascii?Q?Cj0P4yp5DhF/v4mWSMeta6WBhBYLStJPvPJG1tpxyIc6rtAVoN90s52SodUe?= =?us-ascii?Q?qU7o5mbOqE15/ZyHp6PBBWQn6cEOpuqOfJaszJ1t41ft06eXtBLxODg+GqfK?= =?us-ascii?Q?64A1rtyGW1UKUly64M2nYYhn2AAwe2mAQQIIz+IivU+8KJD797P3fQFSkTei?= =?us-ascii?Q?YQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 603d01c3-f14f-4537-5c7e-08dcbcf89870 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2024 07:05:07.4569 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: thpNZdGzBV2X3PvPWPtEV7kv62Ldidv14cyKpzItz51lKRuH1E/jFq1Fn7qLmAh3YphVVOwABH49FlnaTvKh28Va6ePN3a/cwvMIAdAlxBA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6344 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 15 Aug 2024 00:05:11 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JjeEKTlWISdVtEti81uQ4rDox7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR01MB7287A3C3E6800988A4E05FD196802PH0PR01MB7287prod_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="K/FNWqCa"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_PH0PR01MB7287A3C3E6800988A4E05FD196802PH0PR01MB7287prod_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Rebecca. I fixed in the next version. Regards, Nhi ________________________________ From: Rebecca Cran OS Sent: Wednesday, August 14, 2024 8:53 PM To: devel@edk2.groups.io ; Nhi Pham OS Cc: quic_llindhol@quicinc.com ; Chuong Tran OS <= chuong@os.amperecomputing.com>; Rebecca Cran OS Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPM= I table On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote: This could be a static function. > +EFI_STATUS > +EFIAPI > +AcpiInstallSpmiTable ( > + VOID > + ); > + > #endif /* ACPI_PLATFORM_H_ */ > diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatform= Dxe.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c > index 28c422dff166..a82a93d23fa2 100644 > --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c > +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c I believe the project now prefers the use of the C keyword "static". > + // BCD Format > + SpmiTable->SpecificationRevision =3D DeviceId.SpecificationVersion = & 0xF0; > + SpmiTable->SpecificationRevision |=3D (DeviceId.SpecificationVersion= & 0x0F) << 8; It took a second to understand this. Maybe combine it into a single line, or change the '0x0F' to just '0xF'? -- Rebecca -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120346): https://edk2.groups.io/g/devel/message/120346 Mute This Topic: https://groups.io/mt/107889268/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_PH0PR01MB7287A3C3E6800988A4E05FD196802PH0PR01MB7287prod_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thanks Rebecca. I fixed in the next version.

Regards,
Nhi
From: Rebecca Cran OS <r= ebecca@os.amperecomputing.com>
Sent: Wednesday, August 14, 2024 8:53 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Nhi Pham OS &= lt;nhi@os.amperecomputing.com>
Cc: quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Chu= ong Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS <rebe= cca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add A= CPI SPMI table
 
On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote= :
This could be a static function.
> +EFI_STATUS
> +EFIAPI
> +AcpiInstallSpmiTable (
> +  VOID
> +  );
> +
>   #endif /* ACPI_PLATFORM_H_ */
> diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatf= ormDxe.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.= c
> index 28c422dff166..a82a93d23fa2 100644
> --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.= c
> +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.= c

I believe the project now prefers the use of the C keyword "static&quo= t;.

> +    // BCD Format
> +    SpmiTable->SpecificationRevision  =3D Devi= ceId.SpecificationVersion & 0xF0;
> +    SpmiTable->SpecificationRevision |=3D (DeviceId= .SpecificationVersion & 0x0F) << 8;

It took a second to understand this. Maybe combine it into a single
line, or change the '0x0F' to just '0xF'?

--

Rebecca

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120346) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_PH0PR01MB7287A3C3E6800988A4E05FD196802PH0PR01MB7287prod_--