From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 868C4D81112 for ; Fri, 6 Sep 2024 17:38:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xlpvBVL4vpsngyunh28I07ASEVE74bUxzagt4ak27Ro=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240830; t=1725644306; v=1; x=1725903505; b=kEpkMPTJLUPGG/VUSAcmmy09D0HaINv75e3PDIKo4OC1cTtPfeQD5Zof6vKnxpK8mGaU+pDQ osf7OKRwYd1HCW/8e4frymipZvLrvHQBhTd4pD0j5KtX9RTho0VhStQpaeuT/ezcfIMSJd7ig7e vTjNRuJgpwaxpPzHotfSs4JCh7N4YMLGDNLreLfw2ZntFeekIrOjvvuTWh1sMRD3A63gD9WN4hy G/IsWpKw6zXLxBFh1YQlcmnYrlSp6mIZq1p3qQ79s/Fhz7sZPpzEsRwnfuRcivyruqqMMq7n4eD rlj0iollQV58IYE2o47aXC+mWZ9OkrVNfD7g7KJIvjDxQ== X-Received: by 127.0.0.2 with SMTP id SdbrYY7687511xkwHCzWnM15; Fri, 06 Sep 2024 10:38:25 -0700 X-Received: from SJ2PR03CU001.outbound.protection.outlook.com (SJ2PR03CU001.outbound.protection.outlook.com [52.101.43.77]) by mx.groups.io with SMTP id smtpd.web10.4961.1725644304291920079 for ; Fri, 06 Sep 2024 10:38:24 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SA1PR01MB7344.prod.exchangelabs.com (2603:10b6:806:1f7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.17; Fri, 6 Sep 2024 17:38:17 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%4]) with mapi id 15.20.7918.024; Fri, 6 Sep 2024 17:38:17 +0000 From: "Nhi Pham via groups.io" To: "devel@edk2.groups.io" , "sam.kaynor@arm.com" , "rebecca@bsdio.com" CC: Leif Lindholm , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Thread-Topic: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Thread-Index: AQHY9E2Iwe0U+irsOEiJIAhWJYq+nLJPHdyt Date: Fri, 6 Sep 2024 17:38:17 +0000 Message-ID: References: <20221109151036.2164337-1-sam.kaynor@arm.com> In-Reply-To: <20221109151036.2164337-1-sam.kaynor@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Enabled=True;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SiteId=3bc2b170-fd94-476d-b0ce-4229bdc904a7;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SetDate=2024-09-06T17:38:14.704Z;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Name=Confidential;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ContentBits=0;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Method=Standard; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR01MB7287:EE_|SA1PR01MB7344:EE_ x-ms-office365-filtering-correlation-id: 98a7107a-4795-4887-9296-08dcce9ab16b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?kDRkBBZRREPI+xFFzoRvrsvUBLCtIygc8BKDaS9qxJS4t1AIUapVm5eRCGYB?= =?us-ascii?Q?xy12gs1BG7s1HUQcUM6NLwF6ncr8FT5Guok+38Q+J7i6L3qMB0ZTcja9zFPg?= =?us-ascii?Q?0hXN8FigXrhDclsBIMbHJEx/TiKotc1GFDp2KGxt43TYRUSZYRx/O9za1YkC?= =?us-ascii?Q?w5Vd+ySDofTwdsRf8UsK9FyQE/0ws5JoT25zEDmKqB4xMrSh53AKRGOPifK5?= =?us-ascii?Q?iAZnpXEWzAowulJwpujcbgB7Jfrj7sQR9pGHYSYFQ5WVoeUfm7g90YgEMlg5?= =?us-ascii?Q?bzevE1URCR9OBTYu7VlpGbnUc/gLSYiSpxb8G77lL/TkPFX8rkSxvKUN0jc8?= =?us-ascii?Q?x+mUooqAxUXsFxGs1e1/hmkGsjcuR0a8auhDQ8UspPA5dK+d1qdPGAv8Ohwi?= =?us-ascii?Q?TurmQC+wRputOq2MY0Tvr7ag03mMxgYN9t67fCP+NLtNUyjPoDSm/OPdxThP?= =?us-ascii?Q?nrhycvH3bnF37X2rqY9Uy6zQJ69vvwn/Rk2RukIGrIsWdsFTm2QL9dLYUGtK?= =?us-ascii?Q?BcRS3ZGCs965bH5cEcqKt6TPTCahClVLwUYTalIvISaOza/QKkUv4KIvYZgi?= =?us-ascii?Q?db8FaLqFZVBPGekgtn3CO4X6Ym3JfKI6lq7ZTbbmiPt+wwP2cVjaboG7ilv9?= =?us-ascii?Q?t7hQT//Si723zV5SM/yFfXBlxr6YpfFRdbzgzKlupv1Ofzg8iw148mmLwCHQ?= =?us-ascii?Q?6pA2Wue2SLSW4FJAKrvjcXDPgvA1kQPq0m4sUfIWi8RvlDrB1pc5NW6479SL?= =?us-ascii?Q?NL5jhsIEpbndhMF6UAKQsJCVN6+EsqmeKKfGLyerRevV/jRlisA6jHKYmEIr?= =?us-ascii?Q?5vXOUfR213tLSz7zXucv6d1/KLJ0tUr2mbKtsFSC3jfcZRq72mO7CDT+Tdqc?= =?us-ascii?Q?0dZoEgChp3/1g0+yTexn9ovBPFRYZUr6adJAScIN+pVY+eaB5y1F53mIT+Hy?= =?us-ascii?Q?rU6hRMmiWlDAFSsmut7UEuktz43Nna0AGuXoQpYNr94hYuaibLnGbwIc+Fqc?= =?us-ascii?Q?S5LQxv6VpTwY1bVuWvSyXwHItx9HxVyWtoB0wTVlsPiXrkO0JCX7ZjtnwQz5?= =?us-ascii?Q?xJ2TP7u+g3RewRTRfAIo9nK4G6CvDJ+xpbN9D/SyQlTUhuHTGFRgHuewx8AQ?= =?us-ascii?Q?splZsxImprTo/PVphsxs/pTM0ytf7GDlFkDIvVQI/HoAC6YNqlE4LdYNTv3d?= =?us-ascii?Q?hVbP3WubP6swqRhZfZ01PY5xTp8Mw966YhzULnF3dK3siIl9yrThV66k1U8i?= =?us-ascii?Q?SNnw0MOWT3PuHg/v6yJaIlaJkh31Z6sqBgq3xurgP0byTxfoq0E9TZ2oDcYx?= =?us-ascii?Q?QP/9CZwWa5Yylx8I7qsj8Xz82pQG3gTsFq1C0ue6PhI5Im2oWG2gjvtJDXOA?= =?us-ascii?Q?oCT9wf4=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RhA158jqx5PGWYX197nLQq2MPE+tRtrBH3e4eVesPup8gzoOI/UPys9GoeSI?= =?us-ascii?Q?ADTJVTgYOXIIDnttPqbHBwvcIeD/fyAA8j3mS5hZPxHU3wmyoY3+W2EWgWA+?= =?us-ascii?Q?pQXqhyRtBOv29Zt2D2NlNTXDU3L5w7pHBhMBl10fDyCjS1heC1pKlXzmv4GR?= =?us-ascii?Q?b48nLp1886JFCTvJEc0KbzEGeWUrsOrX3akM8bVfT47VaQOeH2bxBUx+De1e?= =?us-ascii?Q?fRkYgob+kMbP/1u8wklO0RVmwNY5dk3Z3cLUP9nn5BRIE8gP+qb6k7xBjZYt?= =?us-ascii?Q?pHPsORufyvevNK5JpERtQiCmR7uv5e6GEu7pzJ07mfBzY52KOIYbvkShLtec?= =?us-ascii?Q?xaZuLRZPCQ13ZGmv603NsAKtUFI+ypH29atMQ9qS5mZQ/3gn8RN8G/n7w+PK?= =?us-ascii?Q?HkzD9XraJLa0U+DGeFAfo21fp84EE9PJtik1RoekW+4rE7oIhQFC8Xwb32xp?= =?us-ascii?Q?n6IZNLs2RlNnmlx/bqnl6RDEqYYYHExkHERwNGdNcQZ7suN7hCmrdLDRoQjP?= =?us-ascii?Q?0TSJYIoAxQ9w/WdpuzwQBEOxb6AzzCrWxjuFyznibf95ApVEXKpG2TAd0x8T?= =?us-ascii?Q?pRQR24PhA9HIx8Vi+3ZvX/+WzxrNLdQsN+UgYLnQfqGw5Pz4WVvZTnXV7um+?= =?us-ascii?Q?0cQrILHP2NDF+B/b+ebp70q2zwi0amUX0ngpeGD1e0VXs6iLfQcPPn8AD8Dh?= =?us-ascii?Q?3xTn03nZ1o/IHDE7cMOqW/wzRL7eeRn01MbWcBjxXmr/oyOs8JxC9pTsqlrl?= =?us-ascii?Q?CjaobZcVkH9kCnAhqTjqRqAGHC4V6c0qiNuS2N1kfM/17bZNOnwg/o/nOUNd?= =?us-ascii?Q?fKlBKY6uqcBX7wTdsAFzqC8Iz9DqqxDl6RDHET3+ARJENmjb4XoSy1lORehI?= =?us-ascii?Q?4NQFjfSCwSu3/Vk92QyJ9I2VPTDP/4LyKYjgBbq+kjreML40+bQJcDd6LsIs?= =?us-ascii?Q?igCohlk/cj7FY7gWUatTenxfaKFCkOFW5Ywj7Bsj+QaCzknay7U5rnDzOVS9?= =?us-ascii?Q?J0d1YO8NwadB4o8wR3TvONlL0u01Ssp0m0mwBaVb1wfokmnf7eBZb7rRqHCg?= =?us-ascii?Q?RTr0hN8N7PRyObHRRcaP2w9mv2LiqjTy1muE5BDkZ+0XIs3tUPcZ+rJiM+Od?= =?us-ascii?Q?XBs7Fv1FFSJo/Qlc0qtOywvRE+dsSMthLcai1gdAYpuIfmiQEw9TNlq7VSLk?= =?us-ascii?Q?IRC9/Mf6iQJkxzDcQroFfK8inFe6gr6PYnWIXDf3j2It+8QoOQA+Y1Pg0V8J?= =?us-ascii?Q?dn1ItXk8r1lzLXvhZst4cS+LfHSte/CyCHEKOTUbZoEnnwjTSjAdfZxBv14H?= =?us-ascii?Q?5iJy6Mq0T9J5U5xk/lqClzdEs0eK7CC52fq1xZ3hZlWzcx/KPz/zVxEl7m60?= =?us-ascii?Q?om9qYTG7pCpR+nP8H/xFdZzV/SNKOm1DyHzaXCZiq0ZPIjrSnqW57+rQ4Tdp?= =?us-ascii?Q?0Psa0jI2k+RP1qWwIHI7x01IKMSY1VPdRybuSgXxsNGwM7+ZlDetlWwWTA8e?= =?us-ascii?Q?K3fvwsoFE2CTLq1on0xBgw/j+jiB8AsvaDaAwbn3u4X3PuDJMH4SNkBPdWpS?= =?us-ascii?Q?wW8dn5jD8aM/EJ0Vsky24ft2SkiWrBQmZGBzJpQe5IBHa5+7XAAem5HCAyn6?= =?us-ascii?Q?WQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98a7107a-4795-4887-9296-08dcce9ab16b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2024 17:38:17.6075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QBR/ha+ZHxekxwWJD2FvNchCCs9I5mKd8eCsTbVc8tp2UEooF1uxflItOy2EZUHHw20C5AzP019DlK/4vnL4V6SJleEdJWPxjJsOuDCwqtQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR01MB7344 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 06 Sep 2024 10:38:24 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NMbZGCb4somN2NyEEWHij5Oux7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR01MB7287C896343A3018AA619AA9969E2PH0PR01MB7287prod_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=kEpkMPTJ; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io --_000_PH0PR01MB7287C896343A3018AA619AA9969E2PH0PR01MB7287prod_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, It seems that this patch has been left unattended. The empty string "" may be ambiguous, as it could imply that the string is = valid but contains no characters, or it has not been filled. On Ampere plat= forms, I utilize "Not Set" to avoid this confusion, which is effective for = FWTS. Regards, Nhi ________________________________ From: devel@edk2.groups.io on behalf of Sam Kaynor v= ia groups.io Sent: Wednesday, November 9, 2022 10:10 PM To: devel@edk2.groups.io Cc: Sam Kaynor ; Leif Lindholm ; Ard Biesheuvel ; Sami Mujawar Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni va= lues to "" Current default values in uni files are set to "Not Specified". This value causes errors in DMI tables when running FWTS tests. To avoid these errors and align more closely with the SMBIOS spec, the default value is changed from "Not Specified" to empty string "". REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4066 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Sam Kaynor Sam Kaynor (1): ArmPkg: Smbios: UNI file default values ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni = | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni = | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni = | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni= | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni = | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133 Mute This Topic: https://groups.io/mt/94914657/5228573 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nhi@os.amperecomputing.c= om] -=3D-=3D-=3D-=3D-=3D-=3D -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120525): https://edk2.groups.io/g/devel/message/120525 Mute This Topic: https://groups.io/mt/94914657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_PH0PR01MB7287C896343A3018AA619AA9969E2PH0PR01MB7287prod_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi,

It seems that this patch has been left unattended.

The empty string "" may be ambiguous, as it could imply that the = string is valid but contains no characters, or it has not been filled. On A= mpere platforms, I utilize "Not Set" to avoid this confusion, whi= ch is effective for FWTS.

Regards,
Nhi

From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Sam Kaynor via groups.io <sam.= kaynor=3Darm.com@groups.io>
Sent: Wednesday, November 9, 2022 10:10 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sam Kaynor <sam.kaynor@arm.com>; Leif Lindholm <quic_ll= indhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; S= ami Mujawar <sami.mujawar@arm.com>
Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default= uni values to ""
 
Current default values in uni files are set to &qu= ot;Not Specified". This
value causes errors in DMI tables when running FWTS tests. To avoid
these errors and align more closely with the SMBIOS spec, the default
value is changed from "Not Specified" to empty string ""= ;.

REF: http= s://bugzilla.tianocore.org/show_bug.cgi?id=3D4066

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Sam Kaynor <sam.kaynor@arm.com>

Sam Kaynor (1):
  ArmPkg: Smbios: UNI file default values

 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings= .uni  | 12 ++++++------
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni =            |  8 ++++= ----
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.u= ni    | 12 ++++++------
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= r.uni | 14 +++++++-------
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.= uni   | 10 +++++-----
 5 files changed, 28 insertions(+), 28 deletions(-)

--
2.34.1



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133
Mute This Topic: https://= groups.io/mt/94914657/5228573
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.= groups.io/g/devel/unsub [nhi@os.amperecomputing.com]
-=3D-=3D-=3D-=3D-=3D-=3D


_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120525) | =20 | Mute = This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_PH0PR01MB7287C896343A3018AA619AA9969E2PH0PR01MB7287prod_--