* [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" @ 2022-11-09 15:10 Sam Kaynor 2022-11-09 15:10 ` [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Sam Kaynor 2024-09-06 17:38 ` [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Nhi Pham via groups.io 0 siblings, 2 replies; 7+ messages in thread From: Sam Kaynor @ 2022-11-09 15:10 UTC (permalink / raw) To: devel; +Cc: Sam Kaynor, Leif Lindholm, Ard Biesheuvel, Sami Mujawar Current default values in uni files are set to "Not Specified". This value causes errors in DMI tables when running FWTS tests. To avoid these errors and align more closely with the SMBIOS spec, the default value is changed from "Not Specified" to empty string "". REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4066 Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> Sam Kaynor (1): ArmPkg: Smbios: UNI file default values ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values 2022-11-09 15:10 [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Sam Kaynor @ 2022-11-09 15:10 ` Sam Kaynor 2023-01-05 16:28 ` [edk2-devel] " Sunny Wang 2023-01-30 12:10 ` Rebecca Cran 2024-09-06 17:38 ` [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Nhi Pham via groups.io 1 sibling, 2 replies; 7+ messages in thread From: Sam Kaynor @ 2022-11-09 15:10 UTC (permalink / raw) To: devel; +Cc: Sam Kaynor, Leif Lindholm, Ard Biesheuvel, Sami Mujawar Current default value for DMI tables in uni files is "Not Specified". This causes an error when running FWTS tests. To avoid these errors, and align more accurately with the SMBIOS spec, this value should be changed to "". Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni index 22b3c64d9fe2..a86695ea3e29 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni @@ -15,10 +15,10 @@ // // Processor Information // -#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "Not Specified" -#string STR_PROCESSOR_MANUFACTURE #language en-US "Not Specified" -#string STR_PROCESSOR_VERSION #language en-US "Not Specified" -#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_PROCESSOR_ASSET_TAG #language en-US "Not Specified" -#string STR_PROCESSOR_PART_NUMBER #language en-US "Not Specified" +#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "" +#string STR_PROCESSOR_MANUFACTURE #language en-US "" +#string STR_PROCESSOR_VERSION #language en-US "" +#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "" +#string STR_PROCESSOR_ASSET_TAG #language en-US "" +#string STR_PROCESSOR_PART_NUMBER #language en-US "" #string STR_PROCESSOR_UNKNOWN #language en-US "Unknown" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni index a3f068cdcca2..6f1c360c0aaf 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni @@ -11,8 +11,8 @@ /=# -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" -#string STR_MISC_BIOS_VERSION #language en-US "Not Specified" -#string STR_MISC_BIOS_RELEASE_DATE #language en-US "Not Specified" -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" +#string STR_MISC_BIOS_VENDOR #language en-US "" +#string STR_MISC_BIOS_VERSION #language en-US "" +#string STR_MISC_BIOS_RELEASE_DATE #language en-US "" +#string STR_MISC_BIOS_VENDOR #language en-US "" #string STR_MISC_BIOS_RELEASE_DATE #language en-US "12/02/2020" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni index 2b3b19cab2ea..d8f73a3ffc74 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni @@ -11,9 +11,9 @@ /=# -#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" -#string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified" -#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_FAMILY #language en-US "Not Specified" +#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "" +#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "" +#string STR_MISC_SYSTEM_VERSION #language en-US "" +#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "" +#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "" +#string STR_MISC_SYSTEM_FAMILY #language en-US "" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni index 0f0fb1f93bbb..9f36e5ff1998 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni @@ -11,10 +11,10 @@ /=# -#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_VERSION #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "Not Specified" +#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "" +#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "" +#string STR_MISC_BASE_BOARD_VERSION #language en-US "" +#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "" +#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "" +#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "" +#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni index 9512b354fe9a..77cbe27d8f7a 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni @@ -11,8 +11,8 @@ /=# -#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_CHASSIS_VERSION #language en-US "Not Specified" -#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "Not Specified" -#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "Not Specified" +#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "" +#string STR_MISC_CHASSIS_VERSION #language en-US "" +#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "" +#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "" +#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "" -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values 2022-11-09 15:10 ` [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Sam Kaynor @ 2023-01-05 16:28 ` Sunny Wang 2023-01-30 12:10 ` Rebecca Cran 1 sibling, 0 replies; 7+ messages in thread From: Sunny Wang @ 2023-01-05 16:28 UTC (permalink / raw) To: devel@edk2.groups.io, Sam Kaynor Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar, Sunny Wang Looks good to me. Thanks, Sam. Just for others' reference. I also had an offline discussion with Samer and got some clarifications below: 1. The default strings (SMBIOS PCDs) in ArmPkg\ArmPkg.dec are L"", so the UNI files should be changed to match the PCD values. 2. As for the case where system vendors want to use FWTS to catch the SMBIOS string issues (check if the data in FRU is updated properly) in the factory, they should change their default value rather than counting on these wrong default values in UNI files. Reviewed-by: Sunny Wang <sunny.wang@arm.com> -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sam Kaynor via groups.io Sent: 09 November 2022 15:11 To: devel@edk2.groups.io Cc: Sam Kaynor <Sam.Kaynor@arm.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <Sami.Mujawar@arm.com> Subject: [edk2-devel] [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Current default value for DMI tables in uni files is "Not Specified". This causes an error when running FWTS tests. To avoid these errors, and align more accurately with the SMBIOS spec, this value should be changed to "". Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni index 22b3c64d9fe2..a86695ea3e29 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni @@ -15,10 +15,10 @@ // // Processor Information // -#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "Not Specified" -#string STR_PROCESSOR_MANUFACTURE #language en-US "Not Specified" -#string STR_PROCESSOR_VERSION #language en-US "Not Specified" -#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_PROCESSOR_ASSET_TAG #language en-US "Not Specified" -#string STR_PROCESSOR_PART_NUMBER #language en-US "Not Specified" +#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "" +#string STR_PROCESSOR_MANUFACTURE #language en-US "" +#string STR_PROCESSOR_VERSION #language en-US "" +#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "" +#string STR_PROCESSOR_ASSET_TAG #language en-US "" +#string STR_PROCESSOR_PART_NUMBER #language en-US "" #string STR_PROCESSOR_UNKNOWN #language en-US "Unknown" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni index a3f068cdcca2..6f1c360c0aaf 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni @@ -11,8 +11,8 @@ /=# -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" -#string STR_MISC_BIOS_VERSION #language en-US "Not Specified" -#string STR_MISC_BIOS_RELEASE_DATE #language en-US "Not Specified" -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" +#string STR_MISC_BIOS_VENDOR #language en-US "" +#string STR_MISC_BIOS_VERSION #language en-US "" +#string STR_MISC_BIOS_RELEASE_DATE #language en-US "" +#string STR_MISC_BIOS_VENDOR #language en-US "" #string STR_MISC_BIOS_RELEASE_DATE #language en-US "12/02/2020" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni index 2b3b19cab2ea..d8f73a3ffc74 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni @@ -11,9 +11,9 @@ /=# -#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" -#string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified" -#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified" -#string STR_MISC_SYSTEM_FAMILY #language en-US "Not Specified" +#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "" +#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "" +#string STR_MISC_SYSTEM_VERSION #language en-US "" +#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "" +#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "" +#string STR_MISC_SYSTEM_FAMILY #language en-US "" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni index 0f0fb1f93bbb..9f36e5ff1998 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni @@ -11,10 +11,10 @@ /=# -#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_VERSION #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "Not Specified" -#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "Not Specified" +#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "" +#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "" +#string STR_MISC_BASE_BOARD_VERSION #language en-US "" +#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "" +#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "" +#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "" +#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "" diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni index 9512b354fe9a..77cbe27d8f7a 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni @@ -11,8 +11,8 @@ /=# -#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "Not Specified" -#string STR_MISC_CHASSIS_VERSION #language en-US "Not Specified" -#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "Not Specified" -#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "Not Specified" -#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "Not Specified" +#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "" +#string STR_MISC_CHASSIS_VERSION #language en-US "" +#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "" +#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "" +#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "" -- 2.34.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96134): https://edk2.groups.io/g/devel/message/96134 Mute This Topic: https://groups.io/mt/94914659/5985097 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -=-=-=-=-=-= IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values 2022-11-09 15:10 ` [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Sam Kaynor 2023-01-05 16:28 ` [edk2-devel] " Sunny Wang @ 2023-01-30 12:10 ` Rebecca Cran 1 sibling, 0 replies; 7+ messages in thread From: Rebecca Cran @ 2023-01-30 12:10 UTC (permalink / raw) To: devel, sam.kaynor; +Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar [-- Attachment #1: Type: text/plain, Size: 7197 bytes --] Reviewed-by: Rebecca Cran<rebecca@bsdio.com> On 11/9/22 08:10, Sam Kaynor wrote: > Current default value for DMI tables in uni files is "Not Specified". > This causes an error when running FWTS tests. To avoid these errors, > and align more accurately with the SMBIOS spec, this value should > be changed to "". > > Cc: Leif Lindholm<quic_llindhol@quicinc.com> > Cc: Ard Biesheuvel<ardb+tianocore@kernel.org> > Cc: Sami Mujawar<sami.mujawar@arm.com> > Signed-off-by: Sam Kaynor<sam.kaynor@arm.com> > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- > 5 files changed, 28 insertions(+), 28 deletions(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni > index 22b3c64d9fe2..a86695ea3e29 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni > @@ -15,10 +15,10 @@ > // > // Processor Information > // > -#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "Not Specified" > -#string STR_PROCESSOR_MANUFACTURE #language en-US "Not Specified" > -#string STR_PROCESSOR_VERSION #language en-US "Not Specified" > -#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "Not Specified" > -#string STR_PROCESSOR_ASSET_TAG #language en-US "Not Specified" > -#string STR_PROCESSOR_PART_NUMBER #language en-US "Not Specified" > +#string STR_PROCESSOR_SOCKET_DESIGNATION #language en-US "" > +#string STR_PROCESSOR_MANUFACTURE #language en-US "" > +#string STR_PROCESSOR_VERSION #language en-US "" > +#string STR_PROCESSOR_SERIAL_NUMBER #language en-US "" > +#string STR_PROCESSOR_ASSET_TAG #language en-US "" > +#string STR_PROCESSOR_PART_NUMBER #language en-US "" > #string STR_PROCESSOR_UNKNOWN #language en-US "Unknown" > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni > index a3f068cdcca2..6f1c360c0aaf 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni > @@ -11,8 +11,8 @@ > > /=# > > -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" > -#string STR_MISC_BIOS_VERSION #language en-US "Not Specified" > -#string STR_MISC_BIOS_RELEASE_DATE #language en-US "Not Specified" > -#string STR_MISC_BIOS_VENDOR #language en-US "Not Specified" > +#string STR_MISC_BIOS_VENDOR #language en-US "" > +#string STR_MISC_BIOS_VERSION #language en-US "" > +#string STR_MISC_BIOS_RELEASE_DATE #language en-US "" > +#string STR_MISC_BIOS_VENDOR #language en-US "" > #string STR_MISC_BIOS_RELEASE_DATE #language en-US "12/02/2020" > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > index 2b3b19cab2ea..d8f73a3ffc74 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > @@ -11,9 +11,9 @@ > > /=# > > -#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "Not Specified" > -#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "Not Specified" > -#string STR_MISC_SYSTEM_VERSION #language en-US "Not Specified" > -#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "Not Specified" > -#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "Not Specified" > -#string STR_MISC_SYSTEM_FAMILY #language en-US "Not Specified" > +#string STR_MISC_SYSTEM_MANUFACTURER #language en-US "" > +#string STR_MISC_SYSTEM_PRODUCT_NAME #language en-US "" > +#string STR_MISC_SYSTEM_VERSION #language en-US "" > +#string STR_MISC_SYSTEM_SERIAL_NUMBER #language en-US "" > +#string STR_MISC_SYSTEM_SKU_NUMBER #language en-US "" > +#string STR_MISC_SYSTEM_FAMILY #language en-US "" > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni > index 0f0fb1f93bbb..9f36e5ff1998 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni > @@ -11,10 +11,10 @@ > > /=# > > -#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "Not Specified" > -#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "Not Specified" > -#string STR_MISC_BASE_BOARD_VERSION #language en-US "Not Specified" > -#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "Not Specified" > -#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "Not Specified" > -#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "Not Specified" > -#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "Not Specified" > +#string STR_MISC_BASE_BOARD_MANUFACTURER #language en-US "" > +#string STR_MISC_BASE_BOARD_PRODUCT_NAME #language en-US "" > +#string STR_MISC_BASE_BOARD_VERSION #language en-US "" > +#string STR_MISC_BASE_BOARD_SERIAL_NUMBER #language en-US "" > +#string STR_MISC_BASE_BOARD_ASSET_TAG #language en-US "" > +#string STR_MISC_BASE_BOARD_CHASSIS_LOCATION #language en-US "" > +#string STR_MISC_BASE_BOARD_SKU_NUMBER #language en-US "" > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni > index 9512b354fe9a..77cbe27d8f7a 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni > @@ -11,8 +11,8 @@ > > /=# > > -#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "Not Specified" > -#string STR_MISC_CHASSIS_VERSION #language en-US "Not Specified" > -#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "Not Specified" > -#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "Not Specified" > -#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "Not Specified" > +#string STR_MISC_CHASSIS_MANUFACTURER #language en-US "" > +#string STR_MISC_CHASSIS_VERSION #language en-US "" > +#string STR_MISC_CHASSIS_SERIAL_NUMBER #language en-US "" > +#string STR_MISC_CHASSIS_ASSET_TAG #language en-US "" > +#string STR_MISC_CHASSIS_SKU_NUMBER #language en-US "" [-- Attachment #2: Type: text/html, Size: 7691 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" 2022-11-09 15:10 [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Sam Kaynor 2022-11-09 15:10 ` [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Sam Kaynor @ 2024-09-06 17:38 ` Nhi Pham via groups.io 2024-09-09 8:00 ` Sami Mujawar 1 sibling, 1 reply; 7+ messages in thread From: Nhi Pham via groups.io @ 2024-09-06 17:38 UTC (permalink / raw) To: devel@edk2.groups.io, sam.kaynor@arm.com, rebecca@bsdio.com Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar [-- Attachment #1: Type: text/plain, Size: 2643 bytes --] Hi, It seems that this patch has been left unattended. The empty string "" may be ambiguous, as it could imply that the string is valid but contains no characters, or it has not been filled. On Ampere platforms, I utilize "Not Set" to avoid this confusion, which is effective for FWTS. Regards, Nhi ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sam Kaynor via groups.io <sam.kaynor=arm.com@groups.io> Sent: Wednesday, November 9, 2022 10:10 PM To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: Sam Kaynor <sam.kaynor@arm.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com> Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Current default values in uni files are set to "Not Specified". This value causes errors in DMI tables when running FWTS tests. To avoid these errors and align more closely with the SMBIOS spec, the default value is changed from "Not Specified" to empty string "". REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4066 Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> Sam Kaynor (1): ArmPkg: Smbios: UNI file default values ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) -- 2.34.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133 Mute This Topic: https://groups.io/mt/94914657/5228573 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nhi@os.amperecomputing.com] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120525): https://edk2.groups.io/g/devel/message/120525 Mute This Topic: https://groups.io/mt/94914657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 5446 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" 2024-09-06 17:38 ` [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Nhi Pham via groups.io @ 2024-09-09 8:00 ` Sami Mujawar 2024-09-10 0:08 ` Nhi Pham via groups.io 0 siblings, 1 reply; 7+ messages in thread From: Sami Mujawar @ 2024-09-09 8:00 UTC (permalink / raw) To: Nhi Pham OS, devel@edk2.groups.io, Sam Kaynor, rebecca@bsdio.com Cc: Leif Lindholm, Ard Biesheuvel, nd [-- Attachment #1: Type: text/plain, Size: 3234 bytes --] Hi Nhi, Sam, Apologies, this slipped off the radar. The changes look good to me. Is it possible to submit a pull request, please? Regards, Sami Mujawar From: Nhi Pham OS <nhi@os.amperecomputing.com> Date: Friday 6 September 2024 at 18:38 To: "devel@edk2.groups.io" <devel@edk2.groups.io>, Sam Kaynor <Sam.Kaynor@arm.com>, "rebecca@bsdio.com" <rebecca@bsdio.com> Cc: Leif Lindholm <quic_llindhol@quicinc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, Sami Mujawar <Sami.Mujawar@arm.com> Subject: Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Hi, It seems that this patch has been left unattended. The empty string "" may be ambiguous, as it could imply that the string is valid but contains no characters, or it has not been filled. On Ampere platforms, I utilize "Not Set" to avoid this confusion, which is effective for FWTS. Regards, Nhi ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sam Kaynor via groups.io <sam.kaynor=arm.com@groups.io> Sent: Wednesday, November 9, 2022 10:10 PM To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: Sam Kaynor <sam.kaynor@arm.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com> Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Current default values in uni files are set to "Not Specified". This value causes errors in DMI tables when running FWTS tests. To avoid these errors and align more closely with the SMBIOS spec, the default value is changed from "Not Specified" to empty string "". REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4066 Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> Sam Kaynor (1): ArmPkg: Smbios: UNI file default values ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- 5 files changed, 28 insertions(+), 28 deletions(-) -- 2.34.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133 Mute This Topic: https://groups.io/mt/94914657/5228573 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [nhi@os.amperecomputing.com] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120528): https://edk2.groups.io/g/devel/message/120528 Mute This Topic: https://groups.io/mt/94914657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 9509 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" 2024-09-09 8:00 ` Sami Mujawar @ 2024-09-10 0:08 ` Nhi Pham via groups.io 0 siblings, 0 replies; 7+ messages in thread From: Nhi Pham via groups.io @ 2024-09-10 0:08 UTC (permalink / raw) To: devel, sami.mujawar, Sam Kaynor, rebecca@bsdio.com Cc: Leif Lindholm, Ard Biesheuvel, nd Hi Sami, On 9/9/2024 3:00 PM, Sami Mujawar via groups.io wrote: > Hi Nhi, Sam, > > Apologies, this slipped off the radar. > > The changes look good to me. > Is it possible to submit a pull request, please? I've integrated Sam's patch and changed the default uni values to "Not Set". https://github.com/tianocore/edk2/pull/6181 Regards, Nhi > > Regards, > > Sami Mujawar > > From: Nhi Pham OS <nhi@os.amperecomputing.com> > Date: Friday 6 September 2024 at 18:38 > To: "devel@edk2.groups.io" <devel@edk2.groups.io>, Sam Kaynor <Sam.Kaynor@arm.com>, "rebecca@bsdio.com" <rebecca@bsdio.com> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, Sami Mujawar <Sami.Mujawar@arm.com> > Subject: Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" > > Hi, > > It seems that this patch has been left unattended. > > The empty string "" may be ambiguous, as it could imply that the string is valid but contains no characters, or it has not been filled. On Ampere platforms, I utilize "Not Set" to avoid this confusion, which is effective for FWTS. > > Regards, > Nhi > > ________________________________ > From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sam Kaynor via groups.io <sam.kaynor=arm.com@groups.io> > Sent: Wednesday, November 9, 2022 10:10 PM > To: devel@edk2.groups.io <devel@edk2.groups.io> > Cc: Sam Kaynor <sam.kaynor@arm.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com> > Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" > > Current default values in uni files are set to "Not Specified". This > value causes errors in DMI tables when running FWTS tests. To avoid > these errors and align more closely with the SMBIOS spec, the default > value is changed from "Not Specified" to empty string "". > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4066 > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Sami Mujawar <sami.mujawar@arm.com> > Signed-off-by: Sam Kaynor <sam.kaynor@arm.com> > > Sam Kaynor (1): > ArmPkg: Smbios: UNI file default values > > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 12 ++++++------ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 8 ++++---- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 12 ++++++------ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++------- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 10 +++++----- > 5 files changed, 28 insertions(+), 28 deletions(-) > > -- > 2.34.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133 > Mute This Topic: https://groups.io/mt/94914657/5228573 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [nhi@os.amperecomputing.com] > -=-=-=-=-=-= > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120536): https://edk2.groups.io/g/devel/message/120536 Mute This Topic: https://groups.io/mt/94914657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-09-10 0:08 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-11-09 15:10 [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Sam Kaynor 2022-11-09 15:10 ` [PATCH v1 1/1] ArmPkg: Smbios: UNI file default values Sam Kaynor 2023-01-05 16:28 ` [edk2-devel] " Sunny Wang 2023-01-30 12:10 ` Rebecca Cran 2024-09-06 17:38 ` [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" Nhi Pham via groups.io 2024-09-09 8:00 ` Sami Mujawar 2024-09-10 0:08 ` Nhi Pham via groups.io
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox