[edk2-devel] Retire EmbeddedPkg/Library/FdtLib

[edk2-devel] Retire EmbeddedPkg/Library/FdtLib

[Nhi Pham via groups.io]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

Hi,

It appears that the EmbeddedPkg/Library/FdtLib could be replaced by MdePkg/Library/BaseFdtLib. Should we remove the old one in EmbeddedPkg and transition to the new one?

The type declaration in EmbeddedPkg/Include/libfdt_env.h cause some compilation errors in certain cases.

Regards,
Nhi


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120571): https://edk2.groups.io/g/devel/message/120571
Mute This Topic: https://groups.io/mt/108536731/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2350 bytes --]

Re: [edk2-devel] Retire EmbeddedPkg/Library/FdtLib

[Leif Lindholm]

On 2024-09-19 10:57, Nhi Pham via groups.io wrote:
> Hi,
> 
> It appears that the EmbeddedPkg/Library/FdtLib could be replaced by 
> MdePkg/Library/BaseFdtLib. Should we remove the old one in EmbeddedPkg 
> and transition to the new one?

Yes, but the new one does not (yet) implement all the functionality 
exposed by the old one, and some platforms use those additional interfaces.

And I'm sad to see additional users have been added more than a year 
after BaseFdtLib was added.

I've started that work, but have had a shortage of time to complete it.

Migrating away from the legacy one is absolutely the right thing to do.

/
     Leif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120580): https://edk2.groups.io/g/devel/message/120580
Mute This Topic: https://groups.io/mt/108536731/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Retire EmbeddedPkg/Library/FdtLib

[Nhi Pham via groups.io]

Thanks Leif for sharing that.

Regards,
Nhi

On 9/24/2024 5:43 PM, Leif Lindholm via groups.io wrote:
> On 2024-09-19 10:57, Nhi Pham via groups.io wrote:
>> Hi,
>>
>> It appears that the EmbeddedPkg/Library/FdtLib could be replaced by
>> MdePkg/Library/BaseFdtLib. Should we remove the old one in EmbeddedPkg
>> and transition to the new one?
> 
> Yes, but the new one does not (yet) implement all the functionality
> exposed by the old one, and some platforms use those additional interfaces.
> 
> And I'm sad to see additional users have been added more than a year
> after BaseFdtLib was added.
> 
> I've started that work, but have had a shortage of time to complete it.
> 
> Migrating away from the legacy one is absolutely the right thing to do.
> 
> /
>     Leif
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120581): https://edk2.groups.io/g/devel/message/120581
Mute This Topic: https://groups.io/mt/108536731/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-