From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.5874.1633137276429753774 for ; Fri, 01 Oct 2021 18:14:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=OaU1AKbw; spf=pass (domain: vmware.com, ip: 40.107.236.40, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nTwodT9qk3uMIff5yxRu7aneSaJSCnNI/cqknlbEwtodfnvLUarXZg4XBh6t1fPpbML8e2uQxGubC7M421pw0YyVA+1LxcxX2Iwd3D/RCDUYoFfaURWX6XPh+E+CeFelzlaT4HQX/C6/jNbr5Y92BdwLWYzxMrdiR34VyJkcLSu4tpaG071+nhb/wPsVwtoJcs45ePTEnchnNzEIEsek6nj3IbFSxUcMUXmKlVFVynYakebQD9nRmNFPD92iJQFXAFcXYJ3IMUypxyV2F/z9pX3JzJ2gXC3k+jssol9TxpoLQt+/KR2Z6SWHluZ7JOrTlLG0P+c2fVMxsTtZIEpUrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zlmjbffskQRy4zCol57ACaUYkf4qaJesbfDgN5tS1/w=; b=Wr54zo22CZoEdgIq0/5k6trumH8R0HwqYLHeFMVPVTQV239AJNlJ+lymD62K+nnFZX5b2QhdUUFwjDCqC09kUTH2UXgyEvGw7rNweKBDMYbzhYs8sLhUyFj0JUXeS5kD9RAU3EYg8aO/KykGDvqK2z7wKZwt5vgPOisG4nhdO959lgdRaN8GGwPDPQDYB7ywlhlWLseOe3F73BpoNcSHIg8/hE5kWzPMHknl5Ny8Y8A3R9AgRTvXX4b9iUqxdZb/LgMMgkUNftG0zxpYH4n71nRdBG1uvRN8btjsrLoDyMLTEhV/A53CGG6fYYaxELyX2QvXOQr42CLAxq1YgGmzwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zlmjbffskQRy4zCol57ACaUYkf4qaJesbfDgN5tS1/w=; b=OaU1AKbwkkLPJA1Vi8S0v0MNlF0+0M0H8tpUM9bq5xFE4UUFCCzJeP3VzndJax8QrvYIHTcflQjCfiHb9+6336l2/6VwRiQj1Ntz1jmR6EGr8UFrQRYQ9KcEriyfPNv1QoUG8PsZe5jVh2mNT3xiBAYmvde2pEgLOeT4yhb5+cY= Received: from PH0PR05MB8702.namprd05.prod.outlook.com (2603:10b6:510:b2::21) by PH0PR05MB8800.namprd05.prod.outlook.com (2603:10b6:510:bb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.7; Sat, 2 Oct 2021 01:14:34 +0000 Received: from PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94]) by PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94%7]) with mapi id 15.20.4587.009; Sat, 2 Oct 2021 01:14:34 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "pete@akeo.ie" , "ardb+tianocore@kernel.org" , "leif@nuviainc.com" , "Sunny.Wang@arm.com" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [PATCH 4/5] Platform/RaspberryPi: Normal memory should not be marked as uncached Thread-Topic: [PATCH 4/5] Platform/RaspberryPi: Normal memory should not be marked as uncached Thread-Index: AQHXtyfUZIypl25H4U6HoFl0lx6q5Ku+5zRZ Date: Sat, 2 Oct 2021 01:14:34 +0000 Message-ID: References: <20211002005238.40280-1-jeremy.linton@arm.com> <20211002005238.40280-5-jeremy.linton@arm.com> In-Reply-To: <20211002005238.40280-5-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: d09fdaeb-5699-82ba-a842-7d5e3175e6b5 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 565b73a4-9554-432b-d7bc-08d98541fee1 x-ms-traffictypediagnostic: PH0PR05MB8800: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0TgLRXW9Sx1b/WO1q3iKezt7uZtJtFYXJBkyj/guKJ2axPqYMAmMLcS210E7V1DdN28ZuPtoftiVWfl+6wkXhJqDphi4Q0tUl2uEJbrMJlbxhaqDaWMsQypk9aKFDjfTl4U9G/yemlBOiIhQHv/w9AV67lC60dMGnnFG3oo6qVJ19Or1BrfCznDb750N9VWVX4qtCWQYzI7XFwI/IXNsA6uq2UTKboC4FJpttmAz3xXXBbdMCl2TXgoGsAixKrcA+ZpWBRvn/TAD9wDbAabbmjNGQ1EUZJuczoMfCvBvgy7zPonfkQdTP2ajUQRO/eGXsBmA9qM6UztYQ7ssmvyOiuZ4P0E20w8ENpbWVVpxED5ns7gucLXk0kAKBE3xRBoOvYI/xGrtb3oiAo1MCo3H5LuWTLH0y5CammHZZKCzCC4DG8VYNO9sWIuK/aJTJFTyap2B/X3Be4vGJylYzoReZgtKF7YUAHICWnjWhzYjwbs8HR/796Wv0hnbHUXdVfM+YTCXYnoT6AeGWBxwp2+qotXqvRMClKSAYN7EYJ58hJBxHaDy7MCN9hbn93VGa41pkI+7bDOLkcE9HwS4mk6J30V71jg5/Ifj5morjiIg3Arxt1bAxrgvTzleR7KVNpXLNN7ZTKZ4ogRWAd3spmT2CuuTDV4iNWW4uZ6DRSVsx8SSfxkdoavMaTrh0MCmW/qI2KjxIq514mz8lYTOqydCOw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR05MB8702.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(55016002)(26005)(5660300002)(71200400001)(122000001)(52536014)(7696005)(9686003)(8936002)(6506007)(66446008)(83380400001)(33656002)(508600001)(8676002)(66556008)(66946007)(91956017)(2906002)(38070700005)(66476007)(64756008)(186003)(38100700002)(316002)(76116006)(4326008)(19627235002)(110136005)(19627405001)(86362001)(54906003)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z3DBSs8MUm2c1k0osk2v+z+Ux3hx0HTSO6DMGoPuKBVfvHJcLta5cs4s6o25?= =?us-ascii?Q?43AyEk5dj0zO5m3ySki203AgXud9e3h6p+iWTCbzg57j8QZJBARq4cNA5+ak?= =?us-ascii?Q?0CZZQ6V+tvsJFDx4tdaWAZxHsAGdys2lkT+R4M9jbiTdQWnMoKtM2drktrz/?= =?us-ascii?Q?4frGc3aZNyjkN/7Ucbx/Z3XoRPBXMa3TdFFE21QK/tyYrRmOBgoKJOdWeUpo?= =?us-ascii?Q?x0j4DzgZoDU05yrW9nz6A4PQ4MiFRyxMznILPMafsQ9jqCQtdgBKirN/lp95?= =?us-ascii?Q?Md3d6v5Z6V9xz66kIAVXozkH9O/rG2sbRqdDXKLGvU11UzvJiz6aMwz6VVGN?= =?us-ascii?Q?VCF7cS/SR4nUjmLCIrVqfhGqc/v2MTksYNF/Nttz4QN667HmlRT7qQ0hpSU1?= =?us-ascii?Q?/Am3C7DSSYjRX2T0vDhEey+XgCUnUE9DaouM+grCkWLyu81RKGMA8A6Chi+p?= =?us-ascii?Q?k4y8Hdo4NwMKKxdbPT2LnKx98zb28dhkcCMa55zKYziRPFexPOEFzfwAiWsZ?= =?us-ascii?Q?ihBA9dyCrrX3qqyzAUNLsRdJqWjAwoDpDRs+Q8TPGpHOvl7YTXW6CQxEAt+l?= =?us-ascii?Q?YcizvAQbeOGPLVpKRHE59A4Ik7zUzHVKouIPs7lJiNJP5Af4FUxH61BCjNvB?= =?us-ascii?Q?llsTN7p037fPTrlkf1ZRUwGLgYntMlZZ1utWGg3jOKelHUf2p/iItLEmTuvb?= =?us-ascii?Q?Q2Ibf2NFk2QsoSZgR+93Yp1ZBsAt10Yk8dy1NFz/K+dFPDO3G/En7J9nyOXU?= =?us-ascii?Q?tZYEdFvIfB9wLfkOD9nFOAjfTHM62Xfkvhgw9riPeXeZR6v+r798VSmbVdZg?= =?us-ascii?Q?nK0DczkHjnHNUYXzMAqYWcOrE98QhRsU6O5vE6gIWALn3t7EnGoUA/c1pC/B?= =?us-ascii?Q?bTTiLMlfOiis+6VV/pY9AL3Y6yS5cchB08wU9E398SqRNftpeMOU/Jk6cziz?= =?us-ascii?Q?aovIR4KmGfpv4OulZq6tfmP2r1l7VS/SGGGUrKWVZrOg0RjbKXrYwRZEYYz6?= =?us-ascii?Q?+pomPr/kYAmCKMmd8t19HkX7Yl0/aBMWg2yK0BjxUVN0vBZRpwvrYvQ3+F5Z?= =?us-ascii?Q?g19a7dGzcXNGIKyWhDg38cCi57QSyD+6rxDhlVlFGFndHJfroeSBJ3bHpq2O?= =?us-ascii?Q?RVwDI3TkG8+RWncC5BVGThGXqGNFqO9GOyz8viJgm74gUaQ5Ft3Gb8g6CDWO?= =?us-ascii?Q?dIbhsM/dG7mAxBI0uxfEQttBw4lfAK+3GdsSdPiwk+5cL42km/Kt8QeFqSRW?= =?us-ascii?Q?Gbiqnza7Vek3ZZABTcRsQhAF7MYm6AR64qElyxUVNoepy3HJ+Ib7viKX6G9T?= =?us-ascii?Q?zOw=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8702.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 565b73a4-9554-432b-d7bc-08d98541fee1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2021 01:14:34.4302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8b32hWFiFbNBgVcfwEOC+bCzfZfMuKpYmgd7XbKpsoNFlqseA3izyTGjLwAqWTbSK8h3c5YapH4O5tG1vc9HOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR05MB8800 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR05MB8702377CAE923E825DFFEEAEB9AC9PH0PR05MB8702namp_" --_000_PH0PR05MB8702377CAE923E825DFFEEAEB9AC9PH0PR05MB8702namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I may have misunderstood the flags as being valid ways of mapping the added= range. Should we also then take out WC and WT? ________________________________ From: Jeremy Linton Sent: Friday, October 1, 2021 7:52 PM To: devel@edk2.groups.io Cc: pete@akeo.ie ; ardb+tianocore@kernel.org ; leif@nuviainc.com ; Andrei Warkentin ; Sunny.Wang@arm.com ; samer.el-haj-ma= hmoud@arm.com ; Jeremy Linton Subject: [PATCH 4/5] Platform/RaspberryPi: Normal memory should not be mark= ed as uncached The efi spec seems to indicate that the efi uncacheable attribute should be mapped to device memory rather than normal-nc. This means that the uefi mem attribute for the >3G ram doesn't match the remainder of the RAM in the machine. So, lets remove the uncacheable attribute to make it more consistent. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 2ef7da67bd..415d99fadb 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c @@ -499,7 +499,7 @@ ApplyVariables ( Status =3D gDS->AddMemorySpace (EfiGcdMemoryTypeSystemMemory, 3UL * BA= SE_1GB, SystemMemorySizeBelow4GB - (3UL * SIZE_1GB), - EFI_MEMORY_UC | EFI_MEMORY_WC | EFI_MEMORY_WT | EFI_ME= MORY_WB); + EFI_MEMORY_WC | EFI_MEMORY_WT | EFI_MEMORY_WB); ASSERT_EFI_ERROR (Status); Status =3D gDS->SetMemorySpaceAttributes (3UL * BASE_1GB, SystemMemorySizeBelow4GB - (3UL * SIZE_1GB), EFI_MEMOR= Y_WB); @@ -511,7 +511,7 @@ ApplyVariables ( // Status =3D gDS->AddMemorySpace (EfiGcdMemoryTypeSystemMemory, 4UL * = BASE_1GB, SystemMemorySize - (4UL * SIZE_1GB), - EFI_MEMORY_UC | EFI_MEMORY_WC | EFI_MEMORY_WT | EFI_= MEMORY_WB); + EFI_MEMORY_WC | EFI_MEMORY_WT | EFI_MEMORY_WB); ASSERT_EFI_ERROR (Status); Status =3D gDS->SetMemorySpaceAttributes (4UL * BASE_1GB, SystemMemorySize - (4UL * SIZE_1GB), EFI_MEMORY_WB); -- 2.13.7 --_000_PH0PR05MB8702377CAE923E825DFFEEAEB9AC9PH0PR05MB8702namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
I may have misunderstood the flags as being valid ways of mapping the added= range. Should we also then take out WC and WT?
From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; ardb+tianocore@kernel.org <= ;ardb+tianocore@kernel.org>; leif@nuviainc.com <leif@nuviainc.com>= ; Andrei Warkentin <awarkentin@vmware.com>; Sunny.Wang@arm.com <Su= nny.Wang@arm.com>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud= @arm.com>; Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH 4/5] Platform/RaspberryPi: Normal memory should not = be marked as uncached
 
The efi spec seems to indicate that the efi uncach= eable attribute
should be mapped to device memory rather than normal-nc. This means
that the uefi mem attribute for the >3G ram doesn't match the remainder<= br> of the RAM in the machine.

So, lets remove the uncacheable attribute to make it more consistent.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
index 2ef7da67bd..415d99fadb 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
@@ -499,7 +499,7 @@ ApplyVariables (
 
     Status =3D gDS->AddMemorySpace (EfiGcdMemoryTyp= eSystemMemory, 3UL * BASE_1GB,
            &nb= sp;        SystemMemorySizeBelow4GB - (3= UL * SIZE_1GB),
-            &n= bsp;       EFI_MEMORY_UC | EFI_MEMORY_WC | EF= I_MEMORY_WT | EFI_MEMORY_WB);
+            &n= bsp;       EFI_MEMORY_WC | EFI_MEMORY_WT | EF= I_MEMORY_WB);
     ASSERT_EFI_ERROR (Status);
     Status =3D gDS->SetMemorySpaceAttributes (3UL *= BASE_1GB,
            &nb= sp;        SystemMemorySizeBelow4GB - (3= UL * SIZE_1GB), EFI_MEMORY_WB);
@@ -511,7 +511,7 @@ ApplyVariables (
       //
       Status =3D gDS->AddMemorySpace (Efi= GcdMemoryTypeSystemMemory, 4UL * BASE_1GB,
            &nb= sp;          SystemMemorySize = - (4UL * SIZE_1GB),
-            &n= bsp;         EFI_MEMORY_UC | EFI_ME= MORY_WC | EFI_MEMORY_WT | EFI_MEMORY_WB);
+            &n= bsp;         EFI_MEMORY_WC | EFI_ME= MORY_WT | EFI_MEMORY_WB);
       ASSERT_EFI_ERROR (Status);
       Status =3D gDS->SetMemorySpaceAttri= butes (4UL * BASE_1GB,
            &nb= sp;          SystemMemorySize = - (4UL * SIZE_1GB), EFI_MEMORY_WB);
--
2.13.7

--_000_PH0PR05MB8702377CAE923E825DFFEEAEB9AC9PH0PR05MB8702namp_--