From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.41]) by mx.groups.io with SMTP id smtpd.web12.3044.1629490547352032421 for ; Fri, 20 Aug 2021 13:15:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=nWExIgXT; spf=pass (domain: vmware.com, ip: 40.107.244.41, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d6NWuVW2Ec2lSc5hKeFlOMpa5g13LA09LmTo5PUeMlT6bvTCm4srgxC6+tP2RcDcmqzozRYx5e6rfz/lA4quY8kBBgSSHL4+vFFbUGM1RO1wAjR6NEJWjMNU+4/exv27l1Id3rm9CKNZV8KN9sZ1GociKuKpO728fsfRrejLZ6mmV+hhVse7SES1Tav4YV/akyKbDE88D6jC/mZSb9bUtQxqXjECv0q7ROa4xx119h+uxJ5CKnYCzVkPKj0p7lJJIHkaUcyS6f0eEqCg+7Dwh3+geLKM9cqBn/EqwPmuJVCitkMDB4WDskbWfsQJ5d6SCptGo8M5P/LqpmCrKqS8eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=13P/w9IGlz24CEN9UTsFpHtmvIBTmdsA3PqfDnSzCBA=; b=l0uQ2KJiwC+H1sNy+QAwq+RobJIUka3CsC6DiaetDTsgIt6Q//wOz0tfrcxwLRqjeer0aam1Y96H6gSXeIiOMK0iUWNrjB+FCpLsbrITqd0wJoGrkae5tp73WttZEtDmyWt4LRtN98EXsuyXzQKZLLqkeRDcASqMS0keE6wqFGUM81FvldjWo0PTR9+ZjnfsoAD3K3p6Azi+bncKRJ+Ah0nbiHnqoinQAGQapURgnH8w58zDyHRpx4L2OpBVDHfSSc9HfVEh1pXHdQC14416+0JwrUGzagvmHMPMYHEGzra9LKPgQXitrA7Vd5sXKULygSuQul8Ehkari43Gyg/JUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=13P/w9IGlz24CEN9UTsFpHtmvIBTmdsA3PqfDnSzCBA=; b=nWExIgXTyi8ppTsgchTFXkc73jifTF+gN8TtGMOzQmuI1MDEY5H9qkxIz9Xe9Ce6I8w2Spbd9zEpMIEXdBqhAQL7dlFWi00Yl0ZEDhXjCJXhDq08N/3QY7qzfmwffHIXMHY1UtR3QLVOW1C7tRw/Fm10YyNCRctERCqCnACJAUQ= Received: from PH0PR05MB8702.namprd05.prod.outlook.com (2603:10b6:510:b2::21) by PH0PR05MB8749.namprd05.prod.outlook.com (2603:10b6:510:b7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.5; Fri, 20 Aug 2021 20:15:43 +0000 Received: from PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94]) by PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94%6]) with mapi id 15.20.4457.005; Fri, 20 Aug 2021 20:15:43 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "pete@akeo.ie" , "ardb+tianocore@kernel.org" , "Sunny.Wang@arm.com" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [PATCH v3 7/7] Platform/RaspberryPi: Add Linux quirk support Thread-Topic: [PATCH v3 7/7] Platform/RaspberryPi: Add Linux quirk support Thread-Index: AQHXlXonmoMkhlneIk2yV4U4EFRx36t81Vex Date: Fri, 20 Aug 2021 20:15:43 +0000 Message-ID: References: <20210820041619.87248-1-jeremy.linton@arm.com> <20210820041619.87248-8-jeremy.linton@arm.com> In-Reply-To: <20210820041619.87248-8-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb3ab8a3-eed6-4a8d-935a-08d964174a08 x-ms-traffictypediagnostic: PH0PR05MB8749: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0ybMRLzX4/z5wmViVhivbh20xChE3f6O9dJ6m3aqSKZlqtkuKg7jjVHkokO6rmtc7iJ24utjOZcki9A5jp+IJ/ans4T3Nx4sPv9JrCYV7tFC7m6cOC2qaihwiXJ5shcW/0BX/RvpWFn2Pi6y7T4p5YWf8nLtIivv9EBIoC6hS0xk/s73Y+24iwBXRBJeHWxNiPGpC1xeLYrZBa/M30wB7g5yQwburg62iNbEx+ZPyr3/1vqXE1pzeTsbwnKgyH9PIRm2+mAwDUvg0RXdvq0jXyqxvmoOsVdxoqY/1iFqFhiayanBaHttEHJqN7da6GJ0nZr1XAlCXMPmPHCPBjX9bE6ZMKEMAoCeDvFCzDJAqgVKWy/Wwop+cw2ADS29h/E/xGHnxbd+aa1Ij66siowHurbolHjuQCK97PH+xQkLiGlpnX4V+zx6fa/8SRPqHkjKEguhmCQEq22wcla4HQ9O+7SL4JddrVZ2e5cj4APJwOPemWXEqsjCdUSpaWYozvyPJSIEKJCvNgfBWRoBQ43Je9nSipVD8Ku9w2y/xZIy3uzT5b8B7zZ5wL8OO51aAXUzOkSVc6Yo0BPfbwrA2EyzyaTgzwSVXNQ9hw+kY5w+rWqayCXrMxUQW+ugLkiZKwWhFR0gFDqpd4A6HWxO8r9Q4/kqQO5StvUoLzeN0g9gPlPZPxzlkuy8V8uj+kk1iLk3x5sck/A1Igknv7DlEBypwQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR05MB8702.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(55016002)(91956017)(66556008)(8676002)(4326008)(83380400001)(38070700005)(38100700002)(76116006)(64756008)(66476007)(86362001)(66446008)(19627405001)(33656002)(7696005)(122000001)(6506007)(52536014)(53546011)(186003)(71200400001)(26005)(8936002)(110136005)(5660300002)(54906003)(9686003)(66946007)(478600001)(316002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0oUM8Xdj+a7Sjc3dHh6jUwbZBYlUtE+X2/Z9VOjM/i/jhrNnBH8nvDrSbJXe?= =?us-ascii?Q?TMF/1pfIusAZLnOMxGV1RKucKjfvf7SpvgQ0Y+gaftSlQjjB2NrBntDHpwXc?= =?us-ascii?Q?+FXs5hIcObQviKBOs2A9IwJgs8wgmNJc1JnFDIXeGkzWbqA4pvfghksB9qkX?= =?us-ascii?Q?pBQkY2XaZfhJurap7h2syvI7rPzESBnAdSlBbHIgyekpH+y7ZQ2/RJ0PhEdw?= =?us-ascii?Q?rIbYs6oNRHbi6pMPIIm+tS/9NAhov34UPX52dssI/HLoo0fY38M2rbTz3qei?= =?us-ascii?Q?DptKNjthYPAuV81YD8bfHBMeiaOW+aBYx4NPvQt6l8LJj550RQ2k+FpIK7WP?= =?us-ascii?Q?8/DITqTcu1R2AGldRYUy0giUnt8o6nyNEqaFX4oeUt14SqjCFtGghVK9B/R/?= =?us-ascii?Q?wIW3OfxuweCcM5s1mYHOXcP3wlcdcErhVpZ05xbe7BlCx6yrC9CoCP/dbrHF?= =?us-ascii?Q?tVzcFeDGNpVa/XnlBuVySkS/qd1lWsQZljf8fvXA2CTvDWKJS+mJHtoSo3Ao?= =?us-ascii?Q?+JIdiJefWU+imwOsRos89r1MRg5ale4n4KEjMUZeY3Llirvda2Fuq1iuxnvZ?= =?us-ascii?Q?1FRpk0wHK9/ldQWUiz+9pB3+R41VOA0pzXpbWyrF45Ci496azgRAdBYizW03?= =?us-ascii?Q?Gp7VZHOfKmROLLXrzdxXO2flpwu1s2onnezE3lh4CJPTY8lQzoRzazFPINKs?= =?us-ascii?Q?Xqa0HLyumCFEiw5HulsIVNbD5N7SqIT6mW22zcV68n/u12c7qon4krEE8oYK?= =?us-ascii?Q?/dJ/kgprnnWhIjTpChRP4XQyA8bBm57lYrwgPtvZKFO/lcwaAHQh5RuGnQL/?= =?us-ascii?Q?uu+28nxp+sM9A/CKAQzpzxhBrIqe8RauA05k58koJpr5/0OypwRResKqWczn?= =?us-ascii?Q?ebYlWqpm/7kg0t6EVgKgPjgMs4yPdjcyb2fCMgyEj2pvP1bb3hQe+IpdSi/Q?= =?us-ascii?Q?HQcxdOVIR1cyQxmoWaRek7p8ualpJ6Sc6oXvPv+jIFVa6SOOLqaWkMWchi+c?= =?us-ascii?Q?XyvTNraOPpwgxAQ2gWLYf7WDNy2pFmQFEFttX858oCDw0dZR97N4wtGYOtSg?= =?us-ascii?Q?iQ3kefvyeqpCuDO904Q1Rq7FK4rrJPAWcXWaiBJcfwx3i0uANAN1o67XmRWg?= =?us-ascii?Q?s+bOgNB/2lut3e2zznjpLQm0DwlrdY/rE6lSwFz4mARQxh82gzAhSzNyGOTo?= =?us-ascii?Q?cWBDiLN8VI92LL2Z8S9WAdkNopbu2rnfVKdeRDF0bvXVIyvth/IXoaqNGwlO?= =?us-ascii?Q?VdwtCcu2XzCf8uibabsPDYQTq21mV+AzrK3zHh70vvjL+7u21a6RCMy8GsWF?= =?us-ascii?Q?wd8UR8Pdjzi8hvRfUgwNQh4u?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8702.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb3ab8a3-eed6-4a8d-935a-08d964174a08 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2021 20:15:43.7512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ClaW0GvH1TZ9oZAr1ny6+dTezxELH0pMazqgIgq9rwZ6x5EdInpcDkIvC8OdVjIo8WpEUNwsK7iRKPGtSQeglg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR05MB8749 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR05MB87027963CF837DB8A3A44BDBB9C19PH0PR05MB8702namp_" --_000_PH0PR05MB87027963CF837DB8A3A44BDBB9C19PH0PR05MB8702namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Jeremy Linton Sent: Thursday, August 19, 2021 11:16 PM To: devel@edk2.groups.io Cc: pete@akeo.ie ; ardb+tianocore@kernel.org ; Andrei Warkentin ; Sunny.Wang@arm.com <= Sunny.Wang@arm.com>; samer.el-haj-mahmoud@arm.com ; Jeremy Linton Subject: [PATCH v3 7/7] Platform/RaspberryPi: Add Linux quirk support Linux, for the time being has refused to support the Arm standard SMCCC for PCIe configuration. Instead they want to continue to maintain per device "quirks". As the RPI isn't really ECAM this is a bit more involved because the MCFG can't really describe the root port+config registers situation. Further platforms which support the SMCCC shouldn't have a MCFG, so we need an additional way to tell linux what it needs to know about this platform. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/AcpiTables/Pci.asl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi= /AcpiTables/Pci.asl index dc2bd7bc9e..50fe2cbdf2 100644 --- a/Platform/RaspberryPi/AcpiTables/Pci.asl +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl @@ -62,6 +62,13 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCI= E", 2) Package (4) { 0x0000FFFF, 3, zero, 178 } }) + Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () { "linux-ecam-quirk-id", "bcm2711" }, + } + }) + // Root complex resources Method (_CRS, 0, Serialized) { Name (RBUF, ResourceTemplate () { -- 2.13.7 --_000_PH0PR05MB87027963CF837DB8A3A44BDBB9C19PH0PR05MB8702namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Thursday, August 19, 2021 11:16 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; ardb+tianocore@kernel.org <= ;ardb+tianocore@kernel.org>; Andrei Warkentin <awarkentin@vmware.com&= gt;; Sunny.Wang@arm.com <Sunny.Wang@arm.com>; samer.el-haj-mahmoud@ar= m.com <samer.el-haj-mahmoud@arm.com>; Jeremy Linton <jeremy.linton= @arm.com>
Subject: [PATCH v3 7/7] Platform/RaspberryPi: Add Linux quirk suppor= t
 
Linux, for the time being has refused to support t= he Arm
standard SMCCC for PCIe configuration. Instead they
want to continue to maintain per device "quirks".

As the RPI isn't really ECAM this is a bit more
involved because the MCFG can't really describe
the root port+config registers situation. Further
platforms which support the SMCCC shouldn't have
a MCFG, so we need an additional way to tell linux
what it needs to know about this platform.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/AcpiTables/Pci.asl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi= /AcpiTables/Pci.asl
index dc2bd7bc9e..50fe2cbdf2 100644
--- a/Platform/RaspberryPi/AcpiTables/Pci.asl
+++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
@@ -62,6 +62,13 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RP= IFDN", "RPI4PCIE", 2)
         Package (4) { 0x0000FFFF, = 3, zero, 178 }
       })
 
+      Name (_DSD, Package () {
+        ToUUID("daffd814-6eba-4d8c= -8a91-bc9bbf4aa301"),
+          Package () {
+            Package= () { "linux-ecam-quirk-id", "bcm2711" },
+          }
+      })
+
       // Root complex resources
       Method (_CRS, 0, Serialized) {
         Name (RBUF, ResourceTempla= te () {
--
2.13.7

--_000_PH0PR05MB87027963CF837DB8A3A44BDBB9C19PH0PR05MB8702namp_--