From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.59]) by mx.groups.io with SMTP id smtpd.web08.5810.1633137162790141550 for ; Fri, 01 Oct 2021 18:12:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=gLFs5PZh; spf=pass (domain: vmware.com, ip: 40.107.236.59, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iHRraP4yK8CHc3ApfrNQ1wWX6qgph78Mvlz29WLH6lDE0ls2n9VE6BL1N7fm5jeD83EpzNzyNXLsgPRR4GH0/Ngp4iaNOwhN43TS27c79nOi6cxhgU663KrjovCDnNb7SX8PJGsFXE3zCDi6uu/KdPQN8pCBiCcaXKiJhhyFjm82RKl1BlTQ3cE7nzS+1YkdWMwjTQHxbMOOlISJhGk+qemb+aokjETsWP+BxBIQmp4GhpGs/qV9OTSY+htZrOLJbPyMsSrJ3lYfEpVij1NPVUl6VNmmQ57taiVwydwL3imZD1OCpVDakJuvLaOmE44Oj1f7ghBLQZJNg8/XZKArmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aEaSjCqD+Sqgi+9enJAeFVMDbhrd7oVNYJFmXA094cw=; b=UZXGbPsidpehzSnkh+oxkH2PImbvJP5dIYX1HiMZ69Cu5twRSYvq8ni66fgDXdZErv2LNBcQRhgJgCItLr9l9/owwQVP/j0smiQuL/dWiMSgSj7z74D6bEh2qzuYqsU58bkEOsZFjK2TxYRY3l5wgIJPbg51L4I9/WrGgnB4/a7FUJduHY88/pyecpjYyxwgWZ60nIaW85Z9HzWrKU5OWKwQvgAV3dol8Uj/e5zK0EkME+Qod/DDX0qstE/P0bJFf9DYYdRiXVOUYiNdcGWO7MnLf3qpRhV5RFXQ4nv1CYy0zWUiHxbXkcZIdWj2W481LQzrzv7LZjwB5bUlabrHYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEaSjCqD+Sqgi+9enJAeFVMDbhrd7oVNYJFmXA094cw=; b=gLFs5PZhT0TmFjK6qxoc6opGO2Y1T8JXQXrdv8kW/dQeX+4jSVXtAzFKNsxTFCiwXtUpGD3x0dBy4f9jj694oagYb/QuZCNWAsmQZnzYoTxE19VkH9Vc5vTNX45EhdSs5/X1tTb0bFT7yXfvsWsd6I62wPQgFZLeWaFv2xhq74g= Received: from PH0PR05MB8702.namprd05.prod.outlook.com (2603:10b6:510:b2::21) by PH0PR05MB8800.namprd05.prod.outlook.com (2603:10b6:510:bb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.7; Sat, 2 Oct 2021 01:12:40 +0000 Received: from PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94]) by PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94%7]) with mapi id 15.20.4587.009; Sat, 2 Oct 2021 01:12:40 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "pete@akeo.ie" , "ardb+tianocore@kernel.org" , "leif@nuviainc.com" , "Sunny.Wang@arm.com" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [PATCH 1/5] Platform/RaspberryPi: Fix vfr warning caused by two defaults Thread-Topic: [PATCH 1/5] Platform/RaspberryPi: Fix vfr warning caused by two defaults Thread-Index: AQHXtyfRRxSNmQ8FmEGgV4/L1DHOP6u+5tHx Date: Sat, 2 Oct 2021 01:12:40 +0000 Message-ID: References: <20211002005238.40280-1-jeremy.linton@arm.com> <20211002005238.40280-2-jeremy.linton@arm.com> In-Reply-To: <20211002005238.40280-2-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 39d796ba-e9c1-0437-dab1-54caebd504a7 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b778d11-2324-466d-1602-08d98541bb11 x-ms-traffictypediagnostic: PH0PR05MB8800: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sHT6AKkm0gBcfFqkpl1H1Cqxd3e++FspQC18U/WOK0js1vitWE9+H9BBk6VsRLet0kscWUdxBF7ErZq4/QulLm5R328rxyYk7tFub9SCgy0a60nkq/bB2zpafSK9Vurt5wdCXZSs0YEMj0XelLiYgmUPvUj6WXbFbDp/BXqWW56P0j5NOdPgI/7/alAcBl9ITx48aNW1EMhG4Xk+2pWaUnQPO91pOiQ51Yn6V9ztJ5tpG7A+ndvD10YAqyf+KTGLJEXNBNERihyOeuKYbOk6Yez86i4yf56Dud15fGa9kcMBixFI23ywc4K2QBwshPBWQ1dbWNfJQkNtz63GvA0ipV6xGiayl/2F4NXUJScxYJP8Q3wRGkKqfW6GFG3EkYFy8bNYXeYfS2alSUZmDjUfVXLxv18cpaNhJVXAToZbVnKDghCPleHM5t71tPfRHxDEBxB/s3aIkV7Ihbpuj/s+zaRBu5rZNDDmgllxCfgNX5T7SeNnVB2t/3TSIyBLRotJF8wYthocNAdS29Z+WxnrUdjCugmJs4K+31u9Wm5r7JHht6YeOGNYd+AyC7bh3plxoqZmIa/eoH0E7vAGScPzT+KObd8YEeLjDfdvl5L6suOdSSrZLNlTJxX3yOkmiF6lbcQ1aCOIVckpuj9H2v+Fl1nWzMD51G7Sv0qXltQc+lCZGVaDdmm+Cxo4meXV/VsU4UyPYzZKDJg0vYEP3fVkXA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR05MB8702.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(55016002)(26005)(5660300002)(71200400001)(122000001)(52536014)(7696005)(9686003)(8936002)(6506007)(66446008)(83380400001)(33656002)(508600001)(8676002)(66556008)(66946007)(91956017)(2906002)(38070700005)(66476007)(64756008)(186003)(38100700002)(316002)(76116006)(4326008)(110136005)(19627405001)(86362001)(54906003)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?twSot5/A2hBsAMDkdOey6ShXv5wlebNolI/qb2hquX8NVR8OuhuLys79bc8M?= =?us-ascii?Q?oj2Hn0eqheNNLv1y83sAvSZIxrfzMKSlrqvjyNKGWYRN8c7enFnAbJlWvNFI?= =?us-ascii?Q?ric59AvNpvuTolzwJ81quGKpURLDoXhumts4zLAcxaOgehTjVG/dLyLOHJ/y?= =?us-ascii?Q?SF9ZPf19l4jBFqXJkxewxGYwSdMHiEgfnQPdsgYJ1+zfL/wM17pjGJQ4MV5T?= =?us-ascii?Q?z7AcLu4wQ0fThCKmBqNZMMqkfEWU87HHSjd2MpjwRoV7SDcCNjSghxWGjgDD?= =?us-ascii?Q?2GULUOJISdaB6zCBQGCwD39vdir8J2FY8K4Qb3NbYhVumtXOui0ZfekblpRq?= =?us-ascii?Q?iWmwZ5XyUqVUrhktaWxD0l2STcfo+OuStt1U1ahfLD67+SItVqHGDLRKpTD2?= =?us-ascii?Q?Nq+NiT6Go6mA1uViBvlaWMnQNyqNDkEnKIsK+KR+zK0Jsc6AzzTxAthkYKDc?= =?us-ascii?Q?ckdIF4kJkY6MkXPQsOGvsqZJwLWvlPyogPAGj651Er5o8QKjyu+e9xNBLehj?= =?us-ascii?Q?b6djwLWq0tO5vBWceGruuVLGZMUbBp1bZbe0JSRIzV4gLIGyZdmI4wkuuoPA?= =?us-ascii?Q?cymo4MWlSt46NSwoPBqvHo8lzL2CxJs+LownOjTMGvjrYg8oENdiBQmhHRxS?= =?us-ascii?Q?eKRUvZi0KL9Boo2Fq1Yl+W9fCHoDphryy6y667hSfrmvIoQGbvc1m6NKISyI?= =?us-ascii?Q?INxE2ncsrGzzu32wNQwnIe+RfpCVXLrBlcddvcFcEwp8k+iXOAoKotC6FNob?= =?us-ascii?Q?SfxROJSzCc2B4RE61w3r6pRpFK/GMYzCW6pcEdrEOHNZp28wB7Hu2wlki2sA?= =?us-ascii?Q?K1WxZnR7jFQ+QaUYG+OxMdzbe2aUBdEoSi/aXROJuLLo3nzVgTTWom6d7Blr?= =?us-ascii?Q?GykYYzgCgNBfUsNsGPZs0fLCgm4/knPEv+nI+CIwXjn/RyyiWVV0IB7Ly8iK?= =?us-ascii?Q?SlSUq5slYlAQ6cyHn05RsZqWpw2KLnB4IkPjKMIs80/BY2wC9n1v7g9cHFKA?= =?us-ascii?Q?FrAbMwt0K7ddYJfcZZ7aqymjEAN8qBdWgzwt/4wc6f31EoXrR2ZAuifGvTLe?= =?us-ascii?Q?2AddO59RNFK8fem/U3kyMkBjG+XoEkGtsEE1FR2xymYvKX+3F30ZYSPS12B0?= =?us-ascii?Q?zu2nhUZOzWTGUnUwxoUVDQCgg4o0dEp9H2mYZOO09i5DT5dHDr62PjD9MRpi?= =?us-ascii?Q?kS8Mko//Ev6khGalxgt134LqJRgEC0wLJDCMvJI+Q3XpK4ToGpEgtthrW+5x?= =?us-ascii?Q?ApBf8MWd7ADF3D3LKsH7TfSeV8SoLr67Xz6XK08lZmiov41w4KoyO0u6LLjj?= =?us-ascii?Q?xNM=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8702.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b778d11-2324-466d-1602-08d98541bb11 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2021 01:12:40.6607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jq4C5hvqQBFihphjmoozJsoWwCnxU2w0xenXEX9BTV0migV+/EvuucnVjjXvhA+4byU/uIAN7QAIUkdasK+vKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR05MB8800 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR05MB8702DEEF67ED376EF6B9D1FBB9AC9PH0PR05MB8702namp_" --_000_PH0PR05MB8702DEEF67ED376EF6B9D1FBB9AC9PH0PR05MB8702namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Jeremy Linton Sent: Friday, October 1, 2021 7:52 PM To: devel@edk2.groups.io Cc: pete@akeo.ie ; ardb+tianocore@kernel.org ; leif@nuviainc.com ; Andrei Warkentin ; Sunny.Wang@arm.com ; samer.el-haj-ma= hmoud@arm.com ; Jeremy Linton Subject: [PATCH 1/5] Platform/RaspberryPi: Fix vfr warning caused by two de= faults The build has been tossing a warning about having two defaults for a while now, lets fix it. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr b/Plat= form/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr index 18b3ec726e..e8bf16312d 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr @@ -192,7 +192,7 @@ formset flags =3D NUMERIC_SIZE_4 | INTERACTIVE | RESET_REQUIRED, option text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_ACPI), value = =3D SYSTEM_TABLE_MODE_ACPI, flags =3D 0; option text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_BOTH), value = =3D SYSTEM_TABLE_MODE_BOTH, flags =3D DEFAULT; - option text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_DT), value = =3D SYSTEM_TABLE_MODE_DT, flags =3D DEFAULT; + option text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_DT), value = =3D SYSTEM_TABLE_MODE_DT, flags =3D0; endoneof; #if (RPI_MODEL =3D=3D 4) -- 2.13.7 --_000_PH0PR05MB8702DEEF67ED376EF6B9D1FBB9AC9PH0PR05MB8702namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; ardb+tianocore@kernel.org <= ;ardb+tianocore@kernel.org>; leif@nuviainc.com <leif@nuviainc.com>= ; Andrei Warkentin <awarkentin@vmware.com>; Sunny.Wang@arm.com <Su= nny.Wang@arm.com>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud= @arm.com>; Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH 1/5] Platform/RaspberryPi: Fix vfr warning caused by= two defaults
 
The build has been tossing a warning about having = two defaults
for a while now, lets fix it.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr b/Plat= form/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
index 18b3ec726e..e8bf16312d 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr
@@ -192,7 +192,7 @@ formset
             fl= ags       =3D NUMERIC_SIZE_4 | INTERACTIVE | = RESET_REQUIRED,
             op= tion text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_ACPI), value =3D SYSTEM_TABL= E_MODE_ACPI, flags =3D 0;
             op= tion text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_BOTH), value =3D SYSTEM_TABL= E_MODE_BOTH, flags =3D DEFAULT;
-            option = text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_DT), value =3D SYSTEM_TABLE_MODE_= DT, flags =3D DEFAULT;
+            option = text =3D STRING_TOKEN(STR_ADVANCED_SYSTAB_DT), value =3D SYSTEM_TABLE_MODE_= DT, flags =3D0;
         endoneof;
 
 #if (RPI_MODEL =3D=3D 4)
--
2.13.7

--_000_PH0PR05MB8702DEEF67ED376EF6B9D1FBB9AC9PH0PR05MB8702namp_--