From: "Andrei Warkentin" <awarkentin@vmware.com>
To: Jeremy Linton <jeremy.linton@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "pete@akeo.ie" <pete@akeo.ie>,
"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
"leif@nuviainc.com" <leif@nuviainc.com>,
"Sunny.Wang@arm.com" <Sunny.Wang@arm.com>,
"samer.el-haj-mahmoud@arm.com" <samer.el-haj-mahmoud@arm.com>
Subject: Re: [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name
Date: Sat, 2 Oct 2021 01:13:19 +0000 [thread overview]
Message-ID: <PH0PR05MB8702DFE1303E9B83D383A793B9AC9@PH0PR05MB8702.namprd05.prod.outlook.com> (raw)
In-Reply-To: <20211002005238.40280-4-jeremy.linton@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
________________________________
From: Jeremy Linton <jeremy.linton@arm.com>
Sent: Friday, October 1, 2021 7:52 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>; leif@nuviainc.com <leif@nuviainc.com>; Andrei Warkentin <awarkentin@vmware.com>; Sunny.Wang@arm.com <Sunny.Wang@arm.com>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@arm.com>; Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name
During review/merge of the linux ecam quirk, some logic
was added to require the quirk name to be exactly 6
characters, matching the MADT field its overriding.
As such, the rpi quirk here needed to be shorted by
a character to avoid confusion.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
index ee37b7a21e..e5fe755923 100644
--- a/Platform/RaspberryPi/AcpiTables/Pci.asl
+++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
@@ -65,7 +65,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
Name (_DSD, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
- Package () { "linux-ecam-quirk-id", "bcm2711" },
+ Package () { "linux-ecam-quirk-id", "bc2711" },
}
})
--
2.13.7
[-- Attachment #2: Type: text/html, Size: 2887 bytes --]
next prev parent reply other threads:[~2021-10-02 1:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 0:52 [PATCH 0/5] Platform/Rpi: Various cleanups Jeremy Linton
2021-10-02 0:52 ` [PATCH 1/5] Platform/RaspberryPi: Fix vfr warning caused by two defaults Jeremy Linton
2021-10-02 1:12 ` Andrei Warkentin
2021-10-02 0:52 ` [PATCH 2/5] Platform/RaspberryPi: Expand locking to cover return data Jeremy Linton
2021-10-02 1:17 ` Andrei Warkentin
2021-10-05 10:12 ` Ard Biesheuvel
2021-10-05 21:19 ` Jeremy Linton
2021-10-06 15:31 ` Ard Biesheuvel
2021-10-02 0:52 ` [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name Jeremy Linton
2021-10-02 1:13 ` Andrei Warkentin [this message]
2021-10-14 21:22 ` Jeremy Linton
2021-10-02 0:52 ` [PATCH 4/5] Platform/RaspberryPi: Normal memory should not be marked as uncached Jeremy Linton
2021-10-02 1:14 ` Andrei Warkentin
2021-10-05 10:05 ` Ard Biesheuvel
2021-10-02 0:52 ` [PATCH 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot Jeremy Linton
2021-10-02 1:16 ` Andrei Warkentin
2021-10-05 10:11 ` Ard Biesheuvel
2021-10-05 21:24 ` Jeremy Linton
2021-10-05 21:35 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR05MB8702DFE1303E9B83D383A793B9AC9@PH0PR05MB8702.namprd05.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox