From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.82]) by mx.groups.io with SMTP id smtpd.web11.3072.1629490562523523226 for ; Fri, 20 Aug 2021 13:16:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=1iTv3VLK; spf=pass (domain: vmware.com, ip: 40.107.92.82, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CBFtKfjFJH1GgHGJsK5R7oDwPdhLMUsLAX4wFCL4hyGLE1zOEeCIs2K1g8ImWLXtii5B9PjDocM75VfD84RY+fKH6BLO7xTlDW8+Y5/R5HpVWFEpaU963l7oP4ENkVx++PQqoF5hs61e1z/lznw71qpmDR9/DXyGGL+rofqv/buIdT0OTEYI5Ct+Y7RwZlLCLWqz/Uj502XzqTg7q5uyCjmK/I2agFAmB8utmXr2jvUgcNZMllELI7zTedBcsqXisVdYQ75bxY6aTjB+XpWDsOv4ozer5dpzrbo8ePCvoVzi3xA3q66/5k1wcMjzxcgHfRKqA+GWOK1BC9GZhAfyXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QTEqioWdpfuuVqoUv/+NKFgwLTsPsgkA1nRfu4pPNLc=; b=avO2anhsVL5cGiOeHOc1pJmLbASllokbLJr02z8ivJfiiQ77W7q6nFcAImwWKlUv0RL3ef6cp8h6CVmFoLgoaDJnkQe2Q8S8Xvt8t67PCLgLzBQ1i1Tag9p7Kh1w9TFi6Cz48PVnB9Z2o7MhJaj20k6IxBJioBbXIEBTGYCiUuj37Mk1MhBMpcp1JDFwHQAfwmVjL7MJVUs5ZwBFEC/bqSLp2Haki3CLI6KR+Ge6dj9ofkLt9wIT4m8A7P6VOFf7C5OdktuqQjUdJR27uA2fHJU84+k1ZpHo1ozTdeLp6H3j2FzWucDV+5WIlcX9wbNNeUQ6KwX91wlC/7oxGo+PJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QTEqioWdpfuuVqoUv/+NKFgwLTsPsgkA1nRfu4pPNLc=; b=1iTv3VLKINZQhDNcGeUDNSFmQBYjjGKOEfU9wqfOM/lzoQ8S1b9PNTmu0lzlEQMDdcZ6vNedsmxru5TDMFFDMFaENDIECzr4Kfax3LKucTU+wbRNBuexCMN0H35qI1YOP6VAEyV1ITsnITd/14PhrdKp0RiEstqXxGhxjsJs/h8= Received: from PH0PR05MB8702.namprd05.prod.outlook.com (2603:10b6:510:b2::21) by PH0PR05MB8749.namprd05.prod.outlook.com (2603:10b6:510:b7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.5; Fri, 20 Aug 2021 20:16:00 +0000 Received: from PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94]) by PH0PR05MB8702.namprd05.prod.outlook.com ([fe80::c88e:73c1:db37:5b94%6]) with mapi id 15.20.4457.005; Fri, 20 Aug 2021 20:16:00 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "pete@akeo.ie" , "ardb+tianocore@kernel.org" , "Sunny.Wang@arm.com" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [PATCH v3 6/7] Platform/RaspberryPi: Enable NVMe boot on CM4 Thread-Topic: [PATCH v3 6/7] Platform/RaspberryPi: Enable NVMe boot on CM4 Thread-Index: AQHXlXomwdabLU5Qg0aFODTnYD20Yqt81WwK Date: Fri, 20 Aug 2021 20:16:00 +0000 Message-ID: References: <20210820041619.87248-1-jeremy.linton@arm.com> <20210820041619.87248-7-jeremy.linton@arm.com> In-Reply-To: <20210820041619.87248-7-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5c5ae6c-2f0f-4916-5738-08d964175436 x-ms-traffictypediagnostic: PH0PR05MB8749: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6tjcL4wu9Z/RgEqgBIA9XxTK9nF7wdd1DTbmhqD8GjnI9ZLCpQevePWxR83JesxEW29+eFPjAgsygkhzuq3SiyZxrgaMpu7kPVphtH+rVDiDeIYTIwtAjLmRWK0i7rJ8KAkvuCY1odL0LKzgM++/0+B706QlhJKyJfLNDAYqpFH07eAIZZCSsE6Czryao60FyJOcZl7kzRN+BrWER/AXB+MaNbXryuYm4Cr0pC2q1t2wZ3NzJ//ggpKLufkXj7Ss87GgSYfolnSTf87XBsfJj7AijxaQK8HfvaHvr7nly928+iloXEPFm53OGky+RmH/ePLLapnh4NBjVJawX1fNAH3f4QECvT/xM8q/pAclKQpMYVKf8k137ackKlup46dJyMZUcTDoXiiRf6TPuRV0QunLnZOBBm1eHdwf0wyE9vdsuvvKlwsppg5686OXXZtdqSK1TJPzAMCUwLwyOT9qeQfDZ1B2M7UjZbdMx5Xo/o8YH2JZzddDC5pHPCiZ0hacBRFNOAxNnCcp7Qs7MUM3OwF5WLJ+pXPsEJ9dqfSr7CWrDo0G0ynOEjSxDbXBqfXn+ru4a866vtb1qvGUtzzLS2iJXJ500fOUIfMhmCk1um1DbVOOIwYt4tNDeE8jQBQuyTN2rrzBCLkV8ODqaSL2L1BFfOxPVTDy/GaJ2AEsRlssnLXrmek+i351w1p1EY4ZfPSdQAo3YJ7iwcJE5C0rWA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR05MB8702.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(55016002)(91956017)(66556008)(8676002)(4326008)(83380400001)(38070700005)(38100700002)(76116006)(64756008)(66476007)(86362001)(66446008)(19627405001)(33656002)(7696005)(122000001)(6506007)(52536014)(53546011)(186003)(71200400001)(26005)(8936002)(110136005)(5660300002)(54906003)(9686003)(19627235002)(66946007)(478600001)(316002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?psh9/G8UsEPx2VoVdmISKSJX6pjNngcrv6GhA8JetFdQ9wNyaJfvfHR6eOKg?= =?us-ascii?Q?qIgdOU/lODwSp0MrWOCSwJxcct+cie7DmJAFwQOhYuvjHznjkW+9l3+fTQue?= =?us-ascii?Q?FEoVUjEDSkub/oNgENM3XlQPQn25iGGe3oAgqm8nc2c8xr5PvdXQqYvUmUnM?= =?us-ascii?Q?MIfpdroywdZNVp5zWXtSFPVbBKchq3Z8pvR+0c7XNzKjisxYSBKXL5kdjbNe?= =?us-ascii?Q?qCoq2hVs9imB3UEAtDkqikJQGFoYYbzcL1Pi4lVRHdQsGsx3o7BeTbPwdjUG?= =?us-ascii?Q?HE2QgqeUAHAe1L2b+xk42chQvzF9RMZjI5Oyowqfdn3hGvPTgke/tAJuC+gR?= =?us-ascii?Q?rx78hO7rMs3YSy91jlYkVF0myLC2mGUAQl315oBUA2kN2jmB03XeZLe7vch2?= =?us-ascii?Q?UWUHL5igQG7i81eLyU6jRLY2HR3nTGrqhLSX+kCGkMZQP8pjQTFJWM2q65uy?= =?us-ascii?Q?EObtf6T/pReEZi2Ag8tjVLkO9XDz8fHqF17JLi0tpz+Ro8BXCOhCDWZhICJc?= =?us-ascii?Q?PhNNMQUAlAFKS4/cdkSWNQbXh7bxIpRZSOM82hhYo4xC90dzeb9UAqQYesfd?= =?us-ascii?Q?oq2vuvYT9LYLEy0vDoyOuxPmePenoi9cfsf8/NtQzZs1EIYKRjOY7S1xcbYc?= =?us-ascii?Q?iv/kke8UHsQQlk62kf1u4ihd+Zoay39RCvzAgp6NQEzxhypoenkq1ZB2bnmO?= =?us-ascii?Q?Upka85XINUCEP8N1XFUJSlbZ2prVZ4hqB+DgfaAja2h4axvOsBcLscoU2I3v?= =?us-ascii?Q?1mw0Kc6kFPlsFkOAtmP70XairyJ7NTpcp/v3w3skJ/3IXFv4ucx1uGxwV3D1?= =?us-ascii?Q?aJKC0yNPbIOv+3w7bfbAr8U+TeEpQ9ICDaFBK77NbqIZBd43WB/7i67z0/gw?= =?us-ascii?Q?yBMkmorZWq9PY435S/Xt8RqR00RyaJAGBwrUTbmvPmFD0zhkuFqj7/NmRwwY?= =?us-ascii?Q?RDYv8uYesXOW7LD2Rc8jre6uuz2gQNtbbSTKtP+SjUP1Rpget3VtlzZkFIEK?= =?us-ascii?Q?RYe4H27G7S0buGXi8Ckamz50qPpsR0No9RK3NGuVjL0bRAIPLW+h36XZzDsM?= =?us-ascii?Q?0b1DQXLaT1xs4X+X5JuEZ+WUk3ur471UF0bfHRNKdn3sJkY05HFaBt0IbVuA?= =?us-ascii?Q?FC2tYDy9zjFNWQy2RzYdxsmft854TPX+9lIZ4fSCrzTRKENURR8fI2ehoJnP?= =?us-ascii?Q?i1OKWWgDme8zZXEPOCMPiLNl+vUKZ2RISYPr+Gk5f2F9ndtWm5xwlZ58MkMS?= =?us-ascii?Q?4+9Rwk/TKXxJZ+v4SC3d4nqAhvN68kQ7c8Ea+bvS23C9GB+irlDXqdpkaizw?= =?us-ascii?Q?adip48ZX7GMU0sY+YJiPnt1X?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8702.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5c5ae6c-2f0f-4916-5738-08d964175436 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2021 20:16:00.8612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tjWYJsPlS493w7HwVx1YySdLVQh1sYnUmsmWnu9vLt8GvhdM96xSr0r1lUJ96AIUFORw2cftT47poO/OF3vF0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR05MB8749 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR05MB8702E8EEC7B1E53DFD0EB5D0B9C19PH0PR05MB8702namp_" --_000_PH0PR05MB8702E8EEC7B1E53DFD0EB5D0B9C19PH0PR05MB8702namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Jeremy Linton Sent: Thursday, August 19, 2021 11:16 PM To: devel@edk2.groups.io Cc: pete@akeo.ie ; ardb+tianocore@kernel.org ; Andrei Warkentin ; Sunny.Wang@arm.com <= Sunny.Wang@arm.com>; samer.el-haj-mahmoud@arm.com ; Jeremy Linton Subject: [PATCH v3 6/7] Platform/RaspberryPi: Enable NVMe boot on CM4 The CM4 has a number of carrier boards with PCIe slots. With the PCIe changes in place its quite possible to utilize a NVMe root device. Lets allow people to boot from it. Reviewed-by: Andrei Warkentin Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/RPi4/RPi4.dsc | 5 +++++ Platform/RaspberryPi/RPi4/RPi4.fdf | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc index babcbb2f41..25c29a0fbf 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -754,6 +754,11 @@ } # + # NVMe boot devices + # + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf + + # # UEFI application (Shell Embedded Boot Loader) # ShellPkg/Application/Shell/Shell.inf { diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4= /RPi4.fdf index 3534cd3dc3..0c782d2f35 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.fdf +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf @@ -283,6 +283,11 @@ READ_LOCK_STATUS =3D TRUE INF EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.inf # + # NVMe boot devices + # + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf + + # # SCSI Bus and Disk Driver # INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf -- 2.13.7 --_000_PH0PR05MB8702E8EEC7B1E53DFD0EB5D0B9C19PH0PR05MB8702namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Thursday, August 19, 2021 11:16 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; ardb+tianocore@kernel.org <= ;ardb+tianocore@kernel.org>; Andrei Warkentin <awarkentin@vmware.com&= gt;; Sunny.Wang@arm.com <Sunny.Wang@arm.com>; samer.el-haj-mahmoud@ar= m.com <samer.el-haj-mahmoud@arm.com>; Jeremy Linton <jeremy.linton= @arm.com>
Subject: [PATCH v3 6/7] Platform/RaspberryPi: Enable NVMe boot on CM= 4
 
The CM4 has a number of carrier boards with PCIe slots. With the PCIe changes in place its quite
possible to utilize a NVMe root device. Lets allow
people to boot from it.

Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/RPi4/RPi4.dsc | 5 +++++
 Platform/RaspberryPi/RPi4/RPi4.fdf | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc
index babcbb2f41..25c29a0fbf 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -754,6 +754,11 @@
   }
 
   #
+  # NVMe boot devices
+  #
+  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
+
+  #
   # UEFI application (Shell Embedded Boot Loader)
   #
   ShellPkg/Application/Shell/Shell.inf {
diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4= /RPi4.fdf
index 3534cd3dc3..0c782d2f35 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.fdf
+++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
@@ -283,6 +283,11 @@ READ_LOCK_STATUS   =3D TRUE
   INF EmbeddedPkg/Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDx= e.inf
 
   #
+  # NVMe boot devices
+  #
+  INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
+
+  #
   # SCSI Bus and Disk Driver
   #
   INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
--
2.13.7

--_000_PH0PR05MB8702E8EEC7B1E53DFD0EB5D0B9C19PH0PR05MB8702namp_--