From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.42]) by mx.groups.io with SMTP id smtpd.web09.3651.1623381269979714810 for ; Thu, 10 Jun 2021 20:14:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=kKMkr1D8; spf=pass (domain: ami.com, ip: 40.107.236.42, mailfrom: manickavasakamk@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZj/iSyBTMiSToRGtDOQDRUhDkPFAPYAj61BE1mq+4Kh6ugXggPKksvUnp9fTJHh/33w1gJ5QpmGcaKcqiMQdNXqVgM2/hmkaICt7DffOCEkILndItnRLKPHFIrhJDEIYlWQaRcIE3/KItWAb2c9QB2awDK5yLB3VGz9welyK/tp7i8zW8WgiCzEk0+cDV9oAu8wroashGN9wSHTylSWKOEuO5NBAVGViDqZS5D7u6GNlE2loja+z/2oBUgroNOvXsEvVU/VyiGjjRQdst/5Zm9OWHGNhEGFr9lS32OAnx5It82qCzm4iSP2bf0KK1EiWov8yrlA4JQ3ms74UwJjsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g8cvpk41oMMvhkPac8PrqQvkkqpz5UPg0uby/le/OW8=; b=cn71p1VprMymlPbT1UjCNKc8z0BCxQy//nAdBrfrUDL2GrnDfOBV/YVAr/WVRbZDiDiGcCEwJxmPMlbA0IvmjOTkUkcAB3TLEiSOOocNoJSoWBZVEG+MdM6XcusJiJEftuZ9TWqAdPeE948A8lHShfW54T24E4iD7MHArUIX7eHY9/wgHC3rTQhshVdqJUvlSbnOtcRtqx7+HvLJmSe8mPAoAR/i18zzgOLWTT2LeI0E+W7OeU1wMKTSnvUJzjlB16MJzczBIDkwKn6aryOWqWJxFIG717Vi21ujPuIw+bYsvdeoE5dTGF1IL2njlCkGENlwnGrXa65Ibp0h7PJBaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g8cvpk41oMMvhkPac8PrqQvkkqpz5UPg0uby/le/OW8=; b=kKMkr1D8vl6aG+avlzmsFr/PbwO8v2+Y3CBTXUTRn9kfFe+uVnH9uG0GL+8VL0mb/JBisq5L5GCzIXTTNcAnoKzXxOHH/0KaqpOcrQ4Ab9xsTxykdQsstcZTbbdbXcGxlaNhNH73/r2e6h7SENSx2929xXE9UKCTESKGaH6gBOE= Received: from PH0PR10MB4408.namprd10.prod.outlook.com (2603:10b6:510:39::16) by PH0PR10MB4647.namprd10.prod.outlook.com (2603:10b6:510:43::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 03:14:27 +0000 Received: from PH0PR10MB4408.namprd10.prod.outlook.com ([fe80::c578:856e:c894:d2b0]) by PH0PR10MB4408.namprd10.prod.outlook.com ([fe80::c578:856e:c894:d2b0%9]) with mapi id 15.20.4219.021; Fri, 11 Jun 2021 03:14:27 +0000 From: Manickavasakam Karpagavinayagam To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Felix Polyudov , Harikrishna Doppalapudi , Manish Jha , Zachary Bobroff Subject: Re: [EXTERNAL] RE: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Thread-Topic: [EXTERNAL] RE: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Thread-Index: AQHXXlIsW/Dyi2lE6UucfpwHjQUZ7qsN7IqggAA0n5A= Date: Fri, 11 Jun 2021 03:14:27 +0000 Message-ID: References: <20210610234121.7409-1-manickavasakamk@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=ami.com; x-originating-ip: [63.147.10.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 175c306e-caff-4690-f2ed-08d92c87059a x-ms-traffictypediagnostic: PH0PR10MB4647: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yoigNcGy00rWB7kvuXraerlJYQcgSnzTXeseijYq+LR3g1k0ZHNUnPF7m9dWTCwFOlkwNLJpptDFY/HZnzmrovAmuJ1Dxq3qEtAuLTcnyRr+L/DUojuFjUJLkXei7FfILZrPCynATXZD4tsf6rE4LsfcNb4lEeSKPbp6E4Zko0i7e7zLdWBRclzBH0g09zant/2KlFdtMNUMaLlro4mBSU0L3jAV6/KqiFqQBPNOznfE+r0CxydcTCrQyH4bJ4XlfYwCXKjNs0bv6aucZq18+ePaRQ0oSWdNj8Rl9we8IdKP7XmD4QhWU3f7GANuGkMX/jd9N4ndME0UTUi3k5B7bAtWxLm/OkDWyf03fpwVkUL7xkK34Np0DcvvBRWPsM14cA8XyNQuzbCo5wNap3vPFXnn9afw4vcNoF0riuuA9hiykVMeFVXNTnvkve5SwLG/foqTfvc/h9QFe5lBmCyWUpsCtugXUlOp6XEf+7AlXTMSbdcxBYV6sb6dV3eUqRTg/DGP+/jYJvkFmY4MNMjC9cKSmsHlyTCyR9fEzmvRZs3VgLxGW1TyaMUIZXldJq1Ma5aAfzxBjwgaSs0x6oZI0GjHC9WrZsmCpvLtCYMdejI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4408.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(39840400004)(136003)(376002)(366004)(66476007)(66946007)(110136005)(54906003)(64756008)(66556008)(316002)(71200400001)(55016002)(66446008)(76116006)(9686003)(83380400001)(8936002)(478600001)(6506007)(186003)(53546011)(86362001)(8676002)(7696005)(38100700002)(122000001)(4326008)(2906002)(33656002)(52536014)(26005)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dgUa3HS6J6Olh/fc3ZXese9xdXDFnhSzKJteY9fMxQXWowjuNYVNb1fORFkM?= =?us-ascii?Q?nur93+LzYwpgpzp1GwXNn9DU2EwDmWK8fiiaMkGnQfXmena1mqI/StBtol3i?= =?us-ascii?Q?QwVoPoatM5EWri1gEq18bdOUy+3v3bzI6YnkSwC45rV3FFG3YRzinf094E/d?= =?us-ascii?Q?rF2t//UKHNE1J6MG0Nh0uHydUweAFV2lkejJVWu5yWrR1kpUUoTYe+Ward+i?= =?us-ascii?Q?Oq++ZrCTbqUSPA0pTEnDGO2F3vrd4y0D0aXlXKGRj+myMME+/bPuC5D2G3Jp?= =?us-ascii?Q?ugySpQAQBg+OwM0xbynvhdOvKdHu3B20Un67qAKH6lQGKz5wMgkxL7dN7gdq?= =?us-ascii?Q?m5roHHYcHpCNwvUn3AEMN9NFrvhr6JL7iyK2MSCVYXDXUi5K517XIsFVhB/K?= =?us-ascii?Q?oXxhY5aU81arhOVvYZlRsqcLSIN0S1tRl5eDIMJ64ncqcW8xXzJ3ntgNg+Iz?= =?us-ascii?Q?S3+hgQIxexv3NWQdBQOYvw3LNvbmQ3Y/wTXoZSzELYiQ9gHANUXc/DEncnWf?= =?us-ascii?Q?DwoBwxbESGVbmUX5vMrZKVSu/TMleiUbIorBUvrR4oT/Awp/xpT8/m1iA9Tc?= =?us-ascii?Q?RgVDJSQ6hMCvSARbchWzOUo9al60+7re9/zbFSbsiGMyNYziM1bVpfuRS8D/?= =?us-ascii?Q?uwtJPjL9boIsoS91QN9Bjkz265uEH6UvVWu7bgXBXqNCdYB9cHTWbWiumwnz?= =?us-ascii?Q?d+AflPd9LGw/6vZRmdmvQoaoZA7lwkENrQCfMT+gHuBN6N9qwGPjVkXKZzG4?= =?us-ascii?Q?UX7Q/NKBd2nJlIgToOh2uViM5U8x/yQkQA1UjDctNjoyOSN2I5VmUo+aMBJs?= =?us-ascii?Q?ofCFjFdK14JCVHmf0TdWUHmctC3+fneK7PgJ7v2/OCBerCielmkNpRkdA/NQ?= =?us-ascii?Q?rZSild41gtn24bsIsToQ9QxsmmXveJEG/L/jB1HGjmRFKcoiZM5KteVwDpUx?= =?us-ascii?Q?lyZ+Y2usa4ofuaHb1ePHyzaZm6ybai5P/ojjRbP3BK7+rfk+/3OUFGzBxyaw?= =?us-ascii?Q?haIuYM6hRMgIhhzLp0OnuxYXQp0yuOVulm7Kmqc/G2plQh+m8GlN6HWSFOHe?= =?us-ascii?Q?T0Q9DXz5UTYkOL81g63hxrQAJSuj/G9H3hiF1HBE+9zGWnCoh9Ah+gLNdwQ9?= =?us-ascii?Q?gZ4JjxZB8lPY007ZCnHvCWj5I2dwD+7ysl0/nHXvp1nf+k6tCDJfHKzsOL80?= =?us-ascii?Q?Q+xz2c4zt9qt5ICksTDQTRK4j/svDQzAGRKB8xU030sv3/QeuojSGmEbXqpr?= =?us-ascii?Q?PZaV5el8faISJ9CBievP5v7rG28xE9Q04qNTD3siBxZcLJPAWKaZpuezM9WK?= =?us-ascii?Q?ZBs=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4408.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 175c306e-caff-4690-f2ed-08d92c87059a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 03:14:27.3195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zYe8d0n/kJ9AUTZ1FM7hdPL1pUjRpxpbazJTYpZY+Y6PT3SIlPQrQftcADjkw56OpD9rPOv8FFtHJlL/hy3frA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4647 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Issac : We defined the macros as these macros are already used in edk2-platforms\Fe= atures\Intel\OutOfBandManagement\IpmiFeaturePkg\GenericIpmi\Dxe\IpmiInit.c = GetDeviceId() Please let us know who needs to correct the edk2-platforms\Features\Intel\O= utOfBandManagement\IpmiFeaturePkg\GenericIpmi\Dxe\IpmiInit.c GetDeviceId() Thank you -Manic -----Original Message----- From: Oram, Isaac W Sent: Thursday, June 10, 2021 8:13 PM To: Manickavasakam Karpagavinayagam ; devel@edk2.g= roups.io Cc: Desimone, Nathaniel L ; Felix Polyudov = ; Harikrishna Doppalapudi ; Manish Jh= a ; Zachary Bobroff Subject: [EXTERNAL] RE: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure= Defintions to resolve the IPMI build error **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Please comment the following commenting per normal style /*-------------------------------------------------------------------------= --------------- Definitions for Get BMC Execution Context ------------------------------= ----------------------------------------------------------*/ Which would correctly be: // // Definitions for Get BMC Execution Context // Please don't use EFI_ or Efi prefix for items that are not part of UEFI own= ed specifications. Please correct: EFI_IPMI_MSG_GET_BMC_EXEC_RSP EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT EFI_FIRMWARE_BMC_IN_FULL_RUNTIME EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE and any uses. Thanks, Isaac -----Original Message----- From: manickavasakam karpagavinayagam Sent: Thursday, June 10, 2021 4:41 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to = resolve the IPMI build error Build error reported for missing structures IPMI_SET_BOOT_OPTIONS_RESPONSE,= EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros EFI_FIRMWARE_GET_BMC_EXECUTION_CO= NTEXT EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE when using edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg --- MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++++ MdePkg/Incl= ude/IndustryStandard/IpmiNetFnFirmware.h | 19 +++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h b/MdePkg/In= clude/IndustryStandard/IpmiNetFnChassis.h index 79db55523d..d7cdd3a865 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h @@ -186,6 +186,10 @@ typedef struct { UINT8 ParameterData[0]; } IPMI_SET_BOOT_OPTIONS_REQUEST; +typedef struct { + UINT8 CompletionCode:8; +} IPMI_SET_BOOT_OPTIONS_RESPONSE; + // // Definitions for Get System Boot options command // diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h b/MdePkg/I= nclude/IndustryStandard/IpmiNetFnFirmware.h index 2d892dbd5a..1c692cc792 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h @@ -17,4 +17,23 @@ // All Firmware commands and their structure definitions to follow here // +/*--------------------------------------------------------------------- +------------------- + Definitions for Get BMC Execution Context +----------------------------------------------------------------------- +-----------------*/ +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 + +// +// Constants and Structure definitions for "Get Device ID" command to +follow here +// +typedef struct { + UINT8 CurrentExecutionContext; + UINT8 PartitionPointer; +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; + +// +// Current Execution Context responses +// +#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME 0x10 +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 + #endif -- 2.25.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .