public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "manickavasakam karpagavinayagam" <manickavasakamk@ami.com>
To: Ramkumar Krishnamoorthi <ramkumark@ami.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Selvaraj V <selvarajv@ami.com>,
	Harikrishna Doppalapudi <Harikrishnad@ami.com>,
	Sureshkumar Ponnusamy <sureshkumarp@ami.com>,
	"isaac.w.oram@intel.com" <isaac.w.oram@intel.com>,
	"nathaniel.l.desimone@intel.com" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82
Date: Mon, 3 Apr 2023 14:40:56 +0000	[thread overview]
Message-ID: <PH0PR10MB44085D92C450CC866D782BA1BB929@PH0PR10MB4408.namprd10.prod.outlook.com> (raw)
In-Reply-To: <20230327110351.1371-1-ramkumark@ami.com>

Isaac/Nate :

Please let us know whether you received this patch email from Ram. If so, please review the changes and push it to repo.

Thank you

-Manic

-----Original Message-----
From: Ramkumar Krishnamoorthi <ramkumark@ami.com>
Sent: Monday, March 27, 2023 7:04 AM
To: devel@edk2.groups.io
Cc: Selvaraj V <selvarajv@ami.com>; Harikrishna Doppalapudi <Harikrishnad@ami.com>; Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>; Sureshkumar Ponnusamy <sureshkumarp@ami.com>; Ramkumar Krishnamoorthi <ramkumark@ami.com>; isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com
Subject: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82

Subject: [edk2-platfoms][PATCH V2] Update PcdBoardID  of JunctionCity and Aowanda platform to 0x81 and 0x82

Fix to resolve the boot error - Change the enum constants values TypeBoardPortTemplate, TypeJunctionCity and TypeAowanda in PlatformInfoTypes.h.
Changed PcdBoardId as 0x81 and 0x82 for Junction and Aowanda on respective PlatformPkg.dsc.

Cc: Harikrishna Doppalapudi <harikrishnad@ami.com>
Cc: Sureshkumar Ponnusamy <sureshkumarp@ami.com>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Cc: Selvaraj V <selvarajv@ami.com>
Cc: Ramkumar K <ramkumark@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Ramkumar K <ramkumark@ami.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc      | 2 +-
 Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc | 2 +-
 Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc
index 8761f8b56a..fa4cfc09db 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.dsc
@@ -49,7 +49,7 @@
   gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047      # Built in messages:  Error, MTRR, info, load, warn, init
   gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2     # This is set to INT3 (0x2) for Simics source level debugging
 !endif
-  gPlatformTokenSpaceGuid.PcdBoardId|0x26
+  gPlatformTokenSpaceGuid.PcdBoardId|0x82

 [PcdsFixedAtBuild.X64]
   gPcAtChipsetPkgTokenSpaceGuid.PcdMinimalValidYear|1900
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc
index 8e226c1552..f934a456dd 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.dsc
@@ -49,7 +49,7 @@
   gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0x80200047      # Built in messages:  Error, MTRR, info, load, warn, init
   gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2     # This is set to INT3 (0x2) for Simics source level debugging
 !endif
-  gPlatformTokenSpaceGuid.PcdBoardId|0x25
+  gPlatformTokenSpaceGuid.PcdBoardId|0x81

 [PcdsFixedAtBuild.X64]
   gPcAtChipsetPkgTokenSpaceGuid.PcdMinimalValidYear|1900
diff --git a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h b/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h
index 0c14a2409f..ca96ab3304 100644
--- a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h
+++ b/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h
@@ -69,7 +69,7 @@ typedef enum {
   //
   // Vendor board range currently starts at 0x80
   //
-  TypeBoardPortTemplate,               // 0x80
+  TypeBoardPortTemplate = 0x80,               // 0x80
   TypeJunctionCity,
   TypeAowanda,
   EndOfVendorPlatformTypeEnum
--
2.37.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

  reply	other threads:[~2023-04-03 14:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 11:04 [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82 Ramkumar Krishnamoorthi
2023-04-03 14:40 ` manickavasakam karpagavinayagam [this message]
2023-04-03 15:56 ` Isaac Oram
     [not found] ` <175277D8CF5EBC01.3578@groups.io>
2023-04-03 15:57   ` [edk2-devel] " Isaac Oram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR10MB44085D92C450CC866D782BA1BB929@PH0PR10MB4408.namprd10.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox