Re: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

["Sheng Wei" <w.sheng@intel.com>]

The change is good to me.
Reviewed-by: Sheng Wei <w.sheng@intel.com>


> -----Original Message-----
> From: Kuo, Ted <ted.kuo@intel.com>
> Sent: 2022年2月15日 14:47
> To: devel@edk2.groups.io
> Cc: Sheng, W <w.sheng@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty,
> Rangasai V <rangasai.v.chaganty@intel.com>; Huang, Jenny
> <jenny.huang@intel.com>; Kowalewski, Robert
> <robert.kowalewski@intel.com>
> Subject: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in
> 64bit
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3836
> Changed VtdIndex defined in PROCESS_DRHD_CALLBACK_FUNC from
> UINT32 to UINTN to avoid type incompatible error when enable PEI in 64bit.
> 
> Cc: Sheng Wei <w.sheng@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Jenny Huang <jenny.huang@intel.com>
> Cc: Robert Kowalewski <robert.kowalewski@intel.com>
> Signed-off-by: Ted Kuo <ted.kuo@intel.com>
> ---
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c     | 4
> ++--
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h     | 2
> +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> index f97d627eca..2844f366bb 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTd
> +++ DmarPei.c
> @@ -434,7 +434,7 @@ GetVTdInfoHob (
>  VOID
>  ProcessDhrdPreMemory (
>    IN OUT VOID                       *Context,
> -  IN     UINT32                     VTdIndex,
> +  IN     UINTN                      VTdIndex,
>    IN     EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>    )
>  {
> @@ -454,7 +454,7 @@ ProcessDhrdPreMemory (  VOID
> ProcessDrhdPostMemory (
>    IN OUT VOID                       *Context,
> -  IN     UINT32                     VTdIndex,
> +  IN     UINTN                      VTdIndex,
>    IN     EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>    )
>  {
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> index 351a7810d8..7bed0a5363 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTd
> +++ DmarPei.h
> @@ -49,7 +49,7 @@ typedef
>  VOID
>  (*PROCESS_DRHD_CALLBACK_FUNC) (
>    IN OUT VOID                       *Context,
> -  IN     UINT32                     VTdIndex,
> +  IN     UINTN                      VTdIndex,
>    IN     EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>    );
> 
> --
> 2.16.2.windows.1