From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7E0B37803E4 for ; Thu, 7 Dec 2023 09:02:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=My3PtZ1jEi1OhWw5AvWb/NWwy7jWsVHCJD7Wh3oDPn8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701939719; v=1; b=C2knnReQIz3FaXZFE66DcLkEKKdryr/cGp8W9So0agV2a4uo784rBXZWvxIU+RMtAdXoLU+2 FWUh2l7oE45kACJSA5nCqJoLy9cAg0gfMAfO2nOwCXX5OVHAsdjeHtvCnIkv7WTbcgiFwQOfQOJ wOw1ZRRoFprxZsVlUTTDTYNU= X-Received: by 127.0.0.2 with SMTP id uwp8YY7687511x6jONY2tGZe; Thu, 07 Dec 2023 01:01:59 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.79894.1701939718371086756 for ; Thu, 07 Dec 2023 01:01:58 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="480391325" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="480391325" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 01:01:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="805945041" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="805945041" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Dec 2023 01:01:57 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 01:01:57 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 7 Dec 2023 01:01:57 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 7 Dec 2023 01:01:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V26RuLLuTb/4IBxiGu7Oy1b2SeemzGIAX7yHccoaPgCuDQP4bsoW7Iq6qzFYn/HquV3D8COYPS6gYFMzZ66npUmu2f99e36Hd1ZBFBVBQrDvA4+gTjy8h/ABt4ff1Vuiy8g5/IJI9yAQKoliW+fz2oZJZlTr80781+VPS49VNViSt9yGfVGQSJk73i1uxeHcAV3PQs41iZvTZfgoNuBM6AM/VLiMy641oFV99RxoJ3kF3FSHzUwWIfGB87LGYwyj92Ktpkf+glZXBZaAL+o2kFB7atF7EAohWXF0P63YhJymZjA8/It68MMOzwybw4+SbC8fPiRXcqAjMyc9Di2uTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dtSmn32L6eIY8w5bXrJABAjYVHl6R+mhh2Q6eYrIDxA=; b=Qljzk47ye2SxRHwZkMTEC/QB3VJ1IXZQixXPnkKVCMmlF7zsR7LvDyjxdChTret3yG3eXXBxoguO3vapUdgFyxZlS5SWQ9B0i12sfvcBYHlQINygrY4rqs6Zv7v7oL3iGuAU6raJAdzw96lNNR5ZvR/7uoHzc9NIpVbdJFgd76J/18+qtIH5CnLv4/a70JHaIkP+GmfuOMHm948aGJJ/7+QKj5dUeuGwiYe8GuAdDDoeK2MQtGq2AYLuN5YBDKLT4xb9gG4rn6KbBMVVC03kiwbqKjD0JolJ75jNwrniVFi1K9ykp2FYnRKr/7qT/Mt95K/pkFTFyVD2eCaM+qzwAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH0PR11MB4870.namprd11.prod.outlook.com (2603:10b6:510:34::16) by PH8PR11MB6927.namprd11.prod.outlook.com (2603:10b6:510:225::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Thu, 7 Dec 2023 09:01:49 +0000 X-Received: from PH0PR11MB4870.namprd11.prod.outlook.com ([fe80::1190:ca15:b4c5:9862]) by PH0PR11MB4870.namprd11.prod.outlook.com ([fe80::1190:ca15:b4c5:9862%7]) with mapi id 15.20.7068.027; Thu, 7 Dec 2023 09:01:49 +0000 From: "Sheng Wei" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Wu, Jiaxin" , "Tan, Dun" Subject: Re: [edk2-devel] [PATCH v7 1/5] UefiCpuPkg: Add macro definitions for CET feature for NASM files. Thread-Topic: [PATCH v7 1/5] UefiCpuPkg: Add macro definitions for CET feature for NASM files. Thread-Index: AQHaKByRGpfty1Llvk6DK8As4Ig1vbCdga8ggAAEF+A= Date: Thu, 7 Dec 2023 09:01:49 +0000 Message-ID: References: <20231206081624.1370-1-w.sheng@intel.com> <20231206081624.1370-2-w.sheng@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB4870:EE_|PH8PR11MB6927:EE_ x-ms-office365-filtering-correlation-id: fbe477d3-3e9d-4400-bf7d-08dbf70325c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: hkxgAfrf8m1EBjXYI5Ayuf0wIUOLkkL3IDQZKzdTA6UqcqbzveCQ4BjcnaY2HYgMqVjKsp2dK12yeBoRcNH0Wu2fXwhsxPDApXym7MxICG36vVKpLo5g2DuVhcm+Y9Q9tNdoMWE20ZJxxhDd5T2f9dfoYnEldgtJd4GWVMBR3UGIeW0M9zktZXGv4kC8yl8zQ6hWNEOgVHy7Go8oA/R3zYRUXwNReEyCvn1dt4q8tiQCFvcTKAOLYFCwh6UxaiTtsdlxfif5LmIdeSfBm9uVYjv+a4s0XL/XyfjC3TMoxPZrJ9JjOcypFNIFrHNMUVlQit8E6PW5xQRLMZ/JoY4XOY/EixstkrH0d0QWSRgXm39jLSJZQOqYEbeT4lmtlF66kdAk0IscjmX594G9jzhlYHoA7nCfpfkISFHP1vGWoBbcRTiSwDqOgi2Skz2MCNEL1mxxIyKxiS0+zcxluTH5vZYjtLpjpOWRnsBPW4rhXVM9SDrmbQyQhUaO6dbJHrFHyxKc/GJ10muID6DmkdhX35AFhco0QMIxT+LEfmxtX8TcCp3WXLa3lhttQej62u/1k+m+pvfW1D37dmVODlb1/cizmybTzi2xwIcMCJFgV8s= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wMpeMmEf7d/PqXrme0HCUF86ml3HRRcvVbqE8f7HSRKVoTvPvSh/RbLuWJDR?= =?us-ascii?Q?b+IRKn58RV1xKF83H/o6kc/G4AQG/E2BNd8MwrFmBS8okQetmVc8NXZG/9eu?= =?us-ascii?Q?ApcnzPkcap+PvLXutA0YuJgkh31TiqQ9dKVkP3/pN3kCI490Lcipe7bfVOO/?= =?us-ascii?Q?jkyNOCBjCxI2gKawduhE9139FOodz/NUmMJLsVc/CT77XlEXPYryTi6emesi?= =?us-ascii?Q?H/qGmM62Mc5jVKdi5UH50fmgg9hgPw0bSQiUdJWcnecwyZ0W7eimRDltVmZl?= =?us-ascii?Q?BeCtjb/hDVkpBIXoVxEuBdnnkjSRYL5QeMqSmWaBnt0TP64ZG5iYh9/L3NBd?= =?us-ascii?Q?blkzG7BUOSJpYbuort/hnfSlawIMZ+PBDh9SvProtxngIQ4fOa+90cFg8biV?= =?us-ascii?Q?TMX5gvi3pf8mJaAdLfqZYotNNd9p324CjF3QVR28c3ZCzNF7ETTJR2koAidF?= =?us-ascii?Q?/LYHvNO/VOsP8J0HMGq1+iDik89FfIX0QDa+XbJjt+zCShk6H+t61H3puMWV?= =?us-ascii?Q?QKRN0/Qq2wfsf1vOm+UmjMYiOgDCNFWe5xWHpcK6KhDV/e5/cXVFK1yhvSmg?= =?us-ascii?Q?r3BrXJzHXoXbY+Lpo6BGgVMv44jZh9HC3K6OyL6W45ZmoWQX/lVPQbBQWiBC?= =?us-ascii?Q?ntePb3KoKwEJmMgJJt1uzhn9s9REq0pgyMr09w3n54QmkZ32xdCnN1o1OsRZ?= =?us-ascii?Q?QBirkypYt2I6natEglCEXOmylT/ENrfRI0SOL9YMMdJ39lVvW8Ul86iaSCWA?= =?us-ascii?Q?suXuqZ+CHawGK2j+P5NdFHfYNNHIAzOTARIjGzDLWRg3t709gimQBuicDVdB?= =?us-ascii?Q?Mp89T/gPxJ7O1bQ5W1E7ikA/Me7P+6hZiD1cJOWFutZN9W7dAsaTpzRJJDOe?= =?us-ascii?Q?fMDDKyCYCTHe1mGQoPC1cPjhoivHHKuQ/7HfaNHa1gwSccguGRWN//35Uucj?= =?us-ascii?Q?BzQQzOvZ0IM4a1ZU2BDIpSvjNGlMx8UYnqk62HUvW1baEnurmU0Z5ymk/YT9?= =?us-ascii?Q?69OcrVFHDw+9Lm4THtA8Ceu1GRpiDFNISsoP8frqtY/j411LlR3nlSXBYNkh?= =?us-ascii?Q?8X9Ot1bbigIVNRVvK/7P6oIsYhpvfLVv8GOZtURjhPQhC4JS4KhHn66deiUX?= =?us-ascii?Q?1Oq2RwJnk/vyDoFhc0Kag6pif7/chJNalGI3GhYl0RlthtI+1WV4Wbys48bt?= =?us-ascii?Q?QRYrbjjiYjiniUMOoI9odIgC9KwE/WZH/zdsbK/MiYawng6ssHTXSc9m7LoA?= =?us-ascii?Q?jhPErBncg0ImS+LkcRT93xInibmTYl1VWULAY3D5ptXItVPYm7FKmGtjQx9N?= =?us-ascii?Q?wJUYlEGOlDOsGtOnOxCDVqTy39HF3y2+MJYLSASeBBnkLK+8WXsMxoyTGlZa?= =?us-ascii?Q?TfNkRV7l2vpDPQxYcZyhfmLwOYDqBkq13L2af7W5796VMO6/spGLV2tQis4A?= =?us-ascii?Q?1MWrJAtp8/NHMcUUHaJmEHGPJu5pdiWW6+R1DXU88sNez1jMcJaOBISw8dzo?= =?us-ascii?Q?6aMqfEwgQUZ6oOYn/iR4XDvwEhVS2D9rMSBXp5MHmsVjZC2xJMyfnrjj9zJm?= =?us-ascii?Q?1nu0FJxhDWFDAACRK54=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4870.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbe477d3-3e9d-4400-bf7d-08dbf70325c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 09:01:49.3478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rsi9lFEHXSNih5ITjjxOQna29F7LUsSyqT/Vdfl8pSO4brRhG+k9FM3wwccU42ZdACqPDPhCQJzIbwfHBUf56w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6927 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,w.sheng@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LDGpWAquNv9pKrGRbagNvriVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=C2knnReQ; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ray, I update the copyright year and add your review-by for the 5 patches. And here is the PR https://github.com/tianocore/edk2/pull/5109 Thank you. BR Sheng Wei > -----Original Message----- > From: Ni, Ray > Sent: Thursday, December 7, 2023 4:41 PM > To: Sheng, W ; devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; W= u, > Jiaxin ; Tan, Dun > Subject: RE: [PATCH v7 1/5] UefiCpuPkg: Add macro definitions for CET > feature for NASM files. >=20 > For all the series (5 patches), Reviewed-by: Ray Ni >=20 > Can you kindly create PR and update the copyright year in file header in = the > final PR? >=20 > Thanks, > Ray > > -----Original Message----- > > From: Sheng, W > > Sent: Wednesday, December 6, 2023 4:16 PM > > To: devel@edk2.groups.io > > Cc: Dong, Eric ; Ni, Ray ; > > Laszlo Ersek ; Wu, Jiaxin ; > > Tan, Dun > > Subject: [PATCH v7 1/5] UefiCpuPkg: Add macro definitions for CET > > feature for NASM files. > > > > Signed-off-by: Sheng Wei > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Laszlo Ersek > > Cc: Wu Jiaxin > > Cc: Tan Dun > > --- > > UefiCpuPkg/PiSmmCpuDxeSmm/Cet.inc | 26 > > ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Cet.inc > > > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/Cet.inc > > b/UefiCpuPkg/PiSmmCpuDxeSmm/Cet.inc > > new file mode 100644 > > index 0000000000..41c99988c9 > > --- /dev/null > > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Cet.inc > > @@ -0,0 +1,26 @@ > > +;-------------------------------------------------------------------- > > +---------- > > > > +; > > > > +; Copyright (c) 2023, Intel Corporation. All rights reserved.
> > > > +; SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +; > > > > +; Abstract: > > > > +; > > > > +; This file provides macro definitions for CET feature for NASM file= s. > > > > +; > > > > +;-------------------------------------------------------------------- > > +---------- > > > > + > > > > +%define MSR_IA32_U_CET 0x6A0 > > > > +%define MSR_IA32_S_CET 0x6A2 > > > > +%define MSR_IA32_CET_SH_STK_EN (1<<0) > > > > +%define MSR_IA32_CET_WR_SHSTK_EN (1<<1) > > > > +%define MSR_IA32_CET_ENDBR_EN (1<<2) > > > > +%define MSR_IA32_CET_LEG_IW_EN (1<<3) > > > > +%define MSR_IA32_CET_NO_TRACK_EN (1<<4) > > > > +%define MSR_IA32_CET_SUPPRESS_DIS (1<<5) > > > > +%define MSR_IA32_CET_SUPPRESS (1<<10) > > > > +%define MSR_IA32_CET_TRACKER (1<<11) > > > > +%define MSR_IA32_PL0_SSP 0x6A4 > > > > +%define MSR_IA32_INTERRUPT_SSP_TABLE_ADDR 0x6A8 > > > > + > > > > +%define CR4_CET_BIT 23 > > > > +%define CR4_CET (1< > > > -- > > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112171): https://edk2.groups.io/g/devel/message/112171 Mute This Topic: https://groups.io/mt/103009377/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-