From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.5059.1634270253077469476 for ; Thu, 14 Oct 2021 20:57:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QlXekEjx; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="214780442" X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="214780442" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 20:57:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="461435218" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 14 Oct 2021 20:57:31 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 20:57:31 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 20:57:30 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 20:57:30 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 20:57:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUE4wD89rXmDxGaOtLtXW+stTsewpD1GaAmTI9V0TlIpnf9fwDR4DBDCW9u4uhyufhFQftU+A5+zflIkVAS3a5CJeTp6WeGf9Ehxy30mWsBqErTCByWSS1SbwPuYkk8B552FmxOAJU4wRoXHvdGB8NeXw36A9Jb6WbH1Xm64dOJo5wzSkfNB77FJEWBtmO7Fm/9233S30MJersDvcpZ4tvd21z/Hcvu8Vdhm5+1JFMveucAy/DvOsH+Vf+/cigUN/GtfG9fRyP+1zeetcj0NRZu5moVFq47ntPO/l9o875EazCx4qLH6e+JYtPvvJbmmIkYNYDKPc3E9eSvzXPZKQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gd8VDoz0XnFHmiwGFwekFH/UF8y7HsGppBKjKAs6C/Q=; b=kFVZg1dq5KBJVrlqMEq9oAwK/oXpvAymZi7IPA3S6bPmB59Cf2TMdnBGpJC/gF3TInypBOd7uMbhL4Yi+krZtqIyPTTeUsIKkyj5/phApAJJ26y3xcZE/TtA68oagIUDd3sEHyJmOeGGbytOx8Oe30z+mh4VXCk52XQBbrjcIDGlwG4Q8BYhAMS+/G41pvGany7Zn2QotjCWH3CVltfV/uq44MffXVCMJYbo4j4HQoei2hQh595oucJZLysdIZotwL3g1IjUwWgjo8z7mbR0gc/eLWrfZF2RhiLtle+GUhb/OI624JlEOL+h9+0Hq1hybYSNlEIct9Ra1fv+NPD8CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gd8VDoz0XnFHmiwGFwekFH/UF8y7HsGppBKjKAs6C/Q=; b=QlXekEjx1lglnN9B8Q2YIntR8LhOMNN5ZATSbaVZqy3EpYEG4UYrFDyftQGUGX1h4f4Oj3yTTD+8VXM0SMsjNX+0UvOLyVQ4BWINd7Fpg9T/u37GN0xVxbbA/UdFj8chWtRyYQHhj9Y+dnHPM0rz/99HPD6oXqvUJMhxrAsHjNY= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB5158.namprd11.prod.outlook.com (2603:10b6:510:3b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct 2021 03:57:28 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80%6]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 03:57:28 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Ard Biesheuvel , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support Thread-Topic: [edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support Thread-Index: AQHXwRCpmxYI7+TMfkm8aued8BxAQKvTbu2Q Date: Fri, 15 Oct 2021 03:57:28 +0000 Message-ID: References: <20211014153024.2318942-1-kraxel@redhat.com> <20211014153024.2318942-5-kraxel@redhat.com> In-Reply-To: <20211014153024.2318942-5-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa3ec6de-b78c-446b-eff0-08d98f8fe7fc x-ms-traffictypediagnostic: PH0PR11MB5158: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tVoKHZF3DAsaIBavnirI6InyK17fLDWEXgkputJM07Lx5vKxIF0WuzSVu5Yh8QEGFQgS3OLhOPOErxps82EQCdEv78n2lyvnjYURul8Xrqx8Z7fob8xdWpKRlOtKLkEQ7OSvUwomEb6AgiiD6z6VzVbOUYQz765iS3hOwqLk7qIrkdPKyv1RvU0jSXxbRnxItvWv5DdlRc4Csk8ELLFyZgm7xW3Pp2s33pKjcmdpeVen2v/TIAKkhAqY6azDakZKxg8OWY1NxRYgRY4ZXio4N3EOMpi2OcfNxTyNB7/X7uHM/OXUcNT8BIdAmnkJuQRoMgAjXJDBGydZ0gFTjHV3BN+krp8zoDLVFKS3FvvZ29Ouc45n53T/BDfyGgVQG8J8oNlBrHhg+QwAdJWbSeyGVGnl+tJOffjoN8p//7c2ta94/rEy24EdREAPLT0+S1fpPPWIZdI6Tf5TiSVpKPXMaPQedQk6ryzw5HUf+AYoG29O1UzkAl6iVUyvJpKJzl4ZXLSBkmbSDuNpCSYDhvJamc1DM0D/7Rmy+LOI7R2ffoYz7nrAj0CInoZEfyDrHvi6WWVUZevy4cl+tR/MrovVZ3dbDTibw04mGIv/VsjG25GJF1Zqh8qFh3FNNCtaLXwMiayG0USkbfvcR1P7Mp3K188PUtnEqz2si83EuBe0nP3qB1/1dVIgFRicMyaX/UK0vnsRvA6usQ3lf3K0F9iYM03sYkRrwwKFhLhcKFTsTfAJ7R8AeGQJf1Syq0VIFJHjL5wp7iFnhxSMrsvKWWqIGNJGz7Vv9SoL99YRbWZWEpC0Tamar8msVS2DlplzBwlJ/q7QqglLljWUAeBvpv66ew== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(4326008)(71200400001)(8936002)(19627235002)(186003)(82960400001)(9686003)(52536014)(66556008)(508600001)(7696005)(38070700005)(2906002)(966005)(76116006)(26005)(5660300002)(316002)(8676002)(83380400001)(54906003)(110136005)(38100700002)(86362001)(33656002)(6506007)(66946007)(55016002)(66476007)(64756008)(53546011)(107886003)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WNU8fX+9bFAos6RC4kn73J0sdol5ze8ffg3H7U8HuD9cd5qHVPwAURuVwj8O?= =?us-ascii?Q?u40s/AtB18PhLBnJiXEacv0XJ4jvDBy43ojb6sGwwZGs2ss7/0lUod9RYKxy?= =?us-ascii?Q?M9MTa3LzPhKTqoBoazkEsjdyBujiQkviql7nDSqmaMbQDbMOjZeTwDJR3wIK?= =?us-ascii?Q?JB7qWp3KlzkjBP8lN8dgQevs66tjQ2KyLL/9KFaN5p06vr82J+r5YEy55kIj?= =?us-ascii?Q?6fQ5AuO4PZo261PPHUd98guHqbqskkvCDRodySNOLDzArMV6EgiFhSD+9kw9?= =?us-ascii?Q?UEBQB1vKKXBEK39ifXY60ALN9qHFEw5x6K+nHYRIONPIJ6bX2jQrWKQyDq81?= =?us-ascii?Q?WFrLhWoRUVwt01/9gHitBewxWu50F0siJtRfdP/9sNcj/IJfJH7qUeuFNUXU?= =?us-ascii?Q?OcNqbdecCbK/f4LR1lhwOnedzs+ZK0JQYm12l84ZBPomaHnqgx10qFKCprIK?= =?us-ascii?Q?JMBjAp301nWx+uqXGkTcSBozels8hIJ1+YzpM9eGO4R+bEaV9uiSUNbLPgf3?= =?us-ascii?Q?Uml63Su/t0cte4wmXyoGAQXwdz/x3oTDWe9FIwTx3BizK+6URvvtUpY3hvt+?= =?us-ascii?Q?M/6iACfmylmPgjgjGZOmXBfd0N53NQ++76xgk4LZVkp3aIXSk+a0vruHqzNu?= =?us-ascii?Q?Bg6WYKPzictJSwbz9k6UNYgqV8O/4raTndZGleP10eZvPYAtfbomuT+e51rv?= =?us-ascii?Q?U3UGyTFVlDNfU6Nol2LE+lk3/cFBqSJ4RWzP26oxqoH/G1Gd4OulaqD1Lg9F?= =?us-ascii?Q?V/B7pgqOwkoeV2YkysveLGzyCtMUsptldMRFQmiovXJNMbvfOJfl7wceHj1F?= =?us-ascii?Q?qVWd/H4tX5Bh7vqPvNWweax3LQUex18F8I6aJooVBEXNwwqDFynp9ZIzTLP3?= =?us-ascii?Q?CeI1HEGH/9KZnA4ntuuYMwQ8baSHGm9gd6fuJoSqCtdLIzENkCU9S2L0tAMV?= =?us-ascii?Q?xOH3dLzpdM/l0z4HcAjF39cwfEAyZ5OXstLrbfGNi0TnJFTlq+ADcBLpCumL?= =?us-ascii?Q?viESMPrRUT8a/75qR+3EXbngvZSninrtYz8bNt5yUu2nIIqL+J6QQM7fiQHS?= =?us-ascii?Q?ySn2D6zvhFUEBLYLZGLLll4Yu1nUlj9yy/Aw2hsdICTcCPKY1gi4jWz20MoK?= =?us-ascii?Q?lkvJJdEsNXXetVD2F84Kt8W939MpVlCN/6WE4yA+HGsOGYzwIsPFidtcVJFV?= =?us-ascii?Q?e7tWkxcDVRnikCCoqVaXghJ0yqJUntVISIl8UC73wonmQUX/3mGYpYNlxW+h?= =?us-ascii?Q?HvZMl68Buqfd4QwnkUQTMmpunhDhhWmjMqmd6IluXnmRN2NArWnMqETEP9yV?= =?us-ascii?Q?sgW0oxOd5kJFvUy13rTsmUAw?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa3ec6de-b78c-446b-eff0-08d98f8fe7fc X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 03:57:28.3639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J4zHHjBqRN2ejFaZDXg6h06rrp22WEaPAObLQXDJhkQelQ+dd2D6eAKMDVkppkiaN4owaYtFYHEYqrWrX/+1yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5158 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Would you please help me understand what the relationship is between Virtio= Mmio and VirtioFdt ? The Bugzilla just states "add support for virtio-mmio devices". How VirtioF= dt comes into this case? Thank you Yao Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, October 14, 2021 11:30 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Justen, Jordan L > ; Yao, Jiewen ; Gerd > Hoffmann > Subject: [edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio > support >=20 > Add virtio-mmio support (VirtioMmioDeviceLib and VirtioFdtDxe). >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3689 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Microvm/MicrovmX64.dsc | 2 ++ > OvmfPkg/Microvm/MicrovmX64.fdf | 1 + > 2 files changed, 3 insertions(+) >=20 > diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc > b/OvmfPkg/Microvm/MicrovmX64.dsc > index 27d2024266c2..85afdca9beba 100644 > --- a/OvmfPkg/Microvm/MicrovmX64.dsc > +++ b/OvmfPkg/Microvm/MicrovmX64.dsc > @@ -233,6 +233,7 @@ [LibraryClasses.common] >=20 > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortL= ib > 16550.inf >=20 > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatfo > rmHookLibNull.inf > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > + > VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice > Lib.inf >=20 > [LibraryClasses.common.SEC] > QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf > @@ -743,6 +744,7 @@ [Components] > # device tree > # > EmbeddedPkg/Drivers/FdtClientDxe/FdtClientDxe.inf > + OvmfPkg/Fdt/VirtioFdtDxe/VirtioFdtDxe.inf >=20 > # > # SMBIOS Support > diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf > b/OvmfPkg/Microvm/MicrovmX64.fdf > index cc8892a459ee..0bf20a702764 100644 > --- a/OvmfPkg/Microvm/MicrovmX64.fdf > +++ b/OvmfPkg/Microvm/MicrovmX64.fdf > @@ -278,6 +278,7 @@ [FV.DXEFV] > INF OvmfPkg/VirtioFsDxe/VirtioFsDxe.inf >=20 > INF EmbeddedPkg/Drivers/FdtClientDxe/FdtClientDxe.inf > +INF OvmfPkg/Fdt/VirtioFdtDxe/VirtioFdtDxe.inf >=20 > !if $(TOOL_CHAIN_TAG) !=3D "XCODE5" > INF > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > -- > 2.31.1 >=20 >=20 >=20 >=20 >=20