From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.12314.1636035122458277480 for ; Thu, 04 Nov 2021 07:12:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=i1gsW3tq; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="292543966" X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208,217";a="292543966" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 07:05:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,209,1631602800"; d="scan'208,217";a="468472973" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 04 Nov 2021 07:05:39 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 07:05:39 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 07:05:39 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 07:05:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TRDi1sYlKmlnqIq/OoZWmXoRWBe12tZFkCMF+xQugn3Vl6MecUcCOBQ96Nyoq62OTX0hpRCMD7k4SfV19JfKptsGK4LNZhnRlp5VpVNw4Y2oSszZK5dTFuMnMK5H44xbxr1zODYS6k6yA+WL9f3ft6iHNAd2MfRI4y4Ja0OfRcfKdjgi+iDlVV8+90IpAmVm9DIqIQQbqasRZgSLgWTe4yJukqs41LB+FcAgzUQLmnAmubgklYaAn0JERhAb2mY39c4jqiZH8ZVUouRFd/I0fONF5ZZGC8m+1oSra2lZpteS9M5krRCQNcz6G8W0Iq6CYYSe2jTLiBJM2SyvQ3a2Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6+MmuNfMLsNbr9H15+BwzXbk0QBAOvaXeMBOZ97Qnxc=; b=M0DWStC/h+9bT9ykpQX3hOv2zYLwE3ybemfoRVHOQVHmh1cr4N+BRxb10eiZLujtlL/2HzCHNH10BroBhNDtmb69GaE+iZWG+qlRgiByaMpVj4xD0uJ/NLGNSCZ/ESZGD+O5tSMiLdMlmV1zfU5bwLmHPKm52FJs0VV46zKUqngmEOuLr8PYDPCkUdSlB88die+OJ/b6lslU0R8WvGOW+05HRnaZcxyQoiOWdolxAq4vCqp8Qvfg0w8jI4qAzmp//6ILQJQxbay+WxoGmp4jBYRmgFnO2GMg3TeVBL1R0KXZKU6TfPKWtYwr7Hh9pbQAJYiSUV0bmONKhB7Uz25pqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+MmuNfMLsNbr9H15+BwzXbk0QBAOvaXeMBOZ97Qnxc=; b=i1gsW3tqiYXooTRBXeKGNvW0ffW1PYmACTNWwxgBsWMOyoq0rZeIdlJJ81sYucWLRhbwem59nL/yIEgt3plJ3WL52uRIRgnfvIcdBtQwUW7+8sVjy02MBLbniK1F55NE+x/fGuXBznJScqFzcbHF590vZnkfNRe7/RifuPnnHGc= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4792.namprd11.prod.outlook.com (2603:10b6:510:32::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 14:05:37 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80%5]) with mapi id 15.20.4649.019; Thu, 4 Nov 2021 14:05:37 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Gonzalez Del Cueto, Rodrigo" CC: "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion. Thread-Topic: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion. Thread-Index: AQHXeogrYsCxTB3/+kyyE/JN9B8psatqhlIAgAHp8FCAh52rIIAABvHQ Date: Thu, 4 Nov 2021 14:05:37 +0000 Message-ID: References: <20210716211817.263-1-rodrigo.gonzalez.del.cueto@intel.com>, <16B45B96D9D719E5.17679@groups.io> In-Reply-To: <16B45B96D9D719E5.17679@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 479055b6-a0bc-43db-509b-08d99f9c2d8d x-ms-traffictypediagnostic: PH0PR11MB4792: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d7sjhX12G/efu6LtR55AxuOVTWkcDwIYZOgspbRuRDD8nB5Su/Ghw3ohExcsmW09EaQvNgDpcA6XOg73pilxcc7FJg43yj/IJoPQQHklWZ4sHrllqiekGwL2KHkZHaDF58XO0jWzeXQze6AQctnoyMLdfOVWT5tSwIqmCc4gYLJ2xOpiB0t3ednA4YEjDLlyP8Cr7+vKHzUX+tWREz3AgFGLKzYIdTA5ElvSktySBlr5zgdNnnMb2YGmdg/hn9xjxGyG0qwMaRTZ9wgLkFEVmtEXRVwCbXRXhOi4KZ7wWzjBeiy9NjUxYXmsAXTAfPMJ4Ty3A6BjyoWFBrdl4Y0jyLI3VPSeCXbeuVYqZojaRGLMSJQtmwavwR72OvDfzqFil+TZl1A7cAA2RGFDtzMqRWL/T1tzfQ92C3MIQdcMjnc+pya++nOFHEv7FosbpMUvgBn5iW8XfiLjll9PGmXmczucOnPNKCniw9mH0SUTeWvMphtlVMWOwoCteCPlhWFcI5CEqtdN0G1Qs8ru32gdbKHcVn12xwYuyxi63Kn+M2i82vSMmE1o5Ade4/Qib+RiwjHruIy5HfxZgXg3BPXtkG2y6eX/TFjcDhTekjyxO0briHZzibyutq7Fqnaus5x+/8fQsDMyvs0e8GH3ypSEzuNNo99iDinN1dqm7t7XWCWx3sL2IytJblE0gdU7k1iA3bf4OcxmgvaXDZq8R04rzoff1Q0lSHxjrl6hVmeXF4nn6CmzClRm0ZA9/tf5nHdy5fSnuy9Mahw4KWsmtY4GKAHLmzlUq8w59g2Usl/vLZAja8bV2YKGXwGcaAvQ9cbFemmoXxFhWqiiI24O89Ml/A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7696005)(186003)(6506007)(15650500001)(966005)(76236003)(52536014)(33656002)(64756008)(55016002)(8936002)(83380400001)(8676002)(2906002)(53546011)(86362001)(316002)(166002)(66446008)(9686003)(76116006)(19627235002)(82960400001)(38070700005)(6636002)(5660300002)(66556008)(4326008)(508600001)(122000001)(66476007)(38100700002)(66946007)(107886003)(71200400001)(26005)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9YperbasfOxFHaebNV2nQptNlZr6hp5H2sK0XN9P7tFFvhuUM2GzjUjHUG9S?= =?us-ascii?Q?KxqqNJWhe/fLWOYwcQUnla9FcSWM72eCjCP1BQBewtn1zKfHmcyjlpB9CfKH?= =?us-ascii?Q?w1TEQublzIT71xoiNDV1P59PWsh9sg95OCUuwtzRpJY0upaacqAWYxNYrNKH?= =?us-ascii?Q?YAlWqNgAjd/zxHI9n0ScE5F9ViTgYdEZs6nKZC99Pyh5Ck4x7/3UQBgn5JyC?= =?us-ascii?Q?vCK3mIrpvpy4SCaYZk0w1dvyHT8UuArs59GbJkBJpb7NP33aAx4H0If8vQvo?= =?us-ascii?Q?qwq9xFt6IRlOi2ijy5zNiXlPhwBdO0YHsFL+8uwWDfMD4Nz5Kl5CO0qrP9lj?= =?us-ascii?Q?ueqYaVTYbkH01R/hXeCrNFuDLU5iud9MydSadhgwSIvzgkn32FqaXGy8ZXo6?= =?us-ascii?Q?uC2wAARQjRs8InmjN92lPdbLECRql9FPvriE4pap888QSsD3YBttTaYK9VEE?= =?us-ascii?Q?Q63UVynwZpzPPWVQPb4opMfMeD6SpHnDbpQxPk4PqBJFcFdwrKuH144xHCHX?= =?us-ascii?Q?IXB7UYSOIPDaSWgKh1qBZc7p01mp7oCgC63zBUerDv/gzmQlNgVeTP/0rGlS?= =?us-ascii?Q?R0co74forK+Cpf3iZx3rxf08P+IaA/+EQTA6RszjEvXkwsKZPl/NGpafqvOu?= =?us-ascii?Q?QQtvmVibVzm8tPrzfV/ZoJWAfQoPAuKbaqqoOBJbDODs6hTU5j949D07JylY?= =?us-ascii?Q?CrPJj9wzGH1uaH1qXqMxCxDalETRjmjdOplarAoQqZ8tU56iPd8memJvWU/1?= =?us-ascii?Q?1lgX7NWIea7pmq8Q0PLdLv55VifV2yVIOcOB1Z7l+pXi/xMKAS+px6DVWm0A?= =?us-ascii?Q?uOUG9M4uMfLpWxyT/IPorb9t9OtjzT3OnurELgEilfREfBuFQqTFJur+CkGJ?= =?us-ascii?Q?JhOiiHETtxJ6Oc39aVczXXMXkR0LCpf3Jcb+duCJxIeqX7j14vF6FyHp12KF?= =?us-ascii?Q?OVZb1v0NZYAkkidhqEs8AA6FXm1cW/L3rU3WXqYOzeQC2AIGWEwYRakQlYNQ?= =?us-ascii?Q?B4q5jWo+Zg2aTN3m0RIljfaoCFNe3CpbTrP+hAEcE9yAdlzuSJCVgmWomIjp?= =?us-ascii?Q?8yj9Bfkb7o5sDjzpJkx+0TEifIZvnf9Q38VYYIBtoCo1zPKB5FhnVcr1CVKu?= =?us-ascii?Q?IrkdHtqGRHnaJDZLhNJnjB30kLyGIJtDuo2Q+lkrAZmZQCxZyuPvZps9TtCl?= =?us-ascii?Q?L67ZTUwx74zWrB8zLfL4djZ2u+6DPPMYw/AngHB+UjK5pfkqlz2CiBZVxccg?= =?us-ascii?Q?0VWi7vHLuJBBYJfL6nmCSvETZS+aAfnCu/62WhGk6uUlHQBQmC2B1U9vknKR?= =?us-ascii?Q?C+3NWY1Sf+I3KkzqPcSnAGnLooaCPQBiRnYQFZjfnc/U/VSKWHCtjxgwQJOM?= =?us-ascii?Q?QSsoG4lzSdvmf1Nzy/OVCHat/5m8nydxTvWc92cW/J+XyNTdf7MaDbTA3m7K?= =?us-ascii?Q?ELM6ZJ+bwjkgccPtUc9aRc4pgkF4Rm9Mas7b2zvpa73hI/m6JPgmZWs/X7Hl?= =?us-ascii?Q?CUI4fBYVu0JMm2FMyIvckhQR5+PVjr+YD/CFinJAZAsrnVQgisTM5jBSGZou?= =?us-ascii?Q?I4eyzf9IqolXIPk0gLLpNhS4WoHqLdDCwbmgNI3V7yumVHse12yOfosRVS3+?= =?us-ascii?Q?bxUpm/pQ78kfBdOllBVuT4U=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 479055b6-a0bc-43db-509b-08d99f9c2d8d X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 14:05:37.6620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: opO03lFztPeYdG3dStDY3kE9xbfaOdj4f2CmggrA/6pOFbLEnZbaajlPinM8cfflj/GjcFg3gEWWGCcxQlLInA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4792 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR11MB488507CA32BAE65977D4D6948C8D9PH0PR11MB4885namp_" --_000_PH0PR11MB488507CA32BAE65977D4D6948C8D9PH0PR11MB4885namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable CI failed: https://github.com/tianocore/edk2/pull/2173 Would you please try CI by yourself? From: devel@edk2.groups.io On Behalf Of Yao, Jiewen Sent: Thursday, November 4, 2021 9:40 PM To: Gonzalez Del Cueto, Rodrigo ; dev= el@edk2.groups.io Cc: Wang, Jian J Subject: Re: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on= CRB command completion. Reviewed-by: Jiewen Yao > From: Gonzalez Del Cueto, Rodrigo > Sent: Saturday, October 30, 2021 5:34 AM To: Yao, Jiewen >; devel@= edk2.groups.io Cc: Wang, Jian J > Subject: Re: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command = completion. Hi Jiewen, I have tested the proposed CRB protocol fix with three different TPM config= urations I have available which support the CRB interface: Intel PTT, STMic= ro and Nuvoton. Under these CRB configurations I didn't observe any issues = arising from the proposed change aligning with the TCG CRB protocol definit= ion. I verified the BIOS flows were unaffected and completed without errors and = that the OS was still able to interact with the TPM. Regards, -Rodrigo ________________________________ From: Yao, Jiewen > Sent: Sunday, August 8, 2021 6:27 PM To: Gonzalez Del Cueto, Rodrigo >; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command = completion. Would you please tell us how many TPM2 chip you have tested? I think we need consider the compatibility of exiting TPM2 chips, to make s= ure the code still work. Thank you Yao Jiewen > -----Original Message----- > From: Gonzalez Del Cueto, Rodrigo > > Sent: Saturday, July 17, 2021 5:18 AM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo >; > Wang, Jian J >; Yao, = Jiewen > > Subject: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command > completion. > > To follow the TCG CRB protocol specification, on every CRB TPM command > completion the TPM should return to Idle state, regardless of the > CRB Idle Bypass capability reported by the TPM device. > > See: TCG PC Client Device Driver Design Principles for TPM 2.0, > Version 1.0, Rev 0.27 > > Signed-off-by: Rodrigo Gonzalez del Cueto > > > Cc: Jian J Wang > > Cc: Jiewen Yao > > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > index f1f8091683..34e3874a5b 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > @@ -310,7 +310,7 @@ PtpCrbTpmCommand ( > // Command completed, but buffer is not enough > // > Status =3D EFI_BUFFER_TOO_SMALL; > - goto GoReady_Exit; > + goto GoIdle_Exit; > } > *SizeOut =3D TpmOutSize; > // > @@ -328,16 +328,6 @@ PtpCrbTpmCommand ( > DEBUG ((EFI_D_VERBOSE, "\n")); > ); > > -GoReady_Exit: > - // > - // Goto Ready State if command is completed successfully and TPM suppo= rt > IdleBypass > - // If not supported. flow down to GoIdle > - // > - if (GetCachedIdleByPass () =3D=3D 1) { > - MmioWrite32((UINTN)&CrbReg->CrbControlRequest, > PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY); > - return Status; > - } > - > // > // Do not wait for state transition for TIMEOUT_C > // This function will try to wait 2 TIMEOUT_C at the beginning in next= call. > -- > 2.31.1.windows.1 --_000_PH0PR11MB488507CA32BAE65977D4D6948C8D9PH0PR11MB4885namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

CI failed: https://github.com/tianocore/edk2/pull/2173

 

Would you please try CI by yourself?

 

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Yao, Jiewen
Sent: Thursday, November 4, 2021 9:40 PM
To: Gonzalez Del Cueto, Rodrigo <rodrigo.gonzalez.del.cueto@intel= .com>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle s= tate on CRB command completion.

 

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

 

From: Gonzalez Del Cueto, Rodrigo <rodrigo.gonzalez.del.cueto= @intel.com>
Sent: Saturday, October 30, 2021 5:34 AM
To: Yao, Jiewen <jiewen.y= ao@intel.com>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j= .wang@intel.com>
Subject: Re: [PATCH] SecurityPkg: TPM must go to Idle state on CRB c= ommand completion.

 

Hi Jiewen,

 

I have tested the proposed CRB protocol fix with three = different TPM configurations I have available which support the CRB interfa= ce: Intel PTT, STMicro and Nuvoton. Under these CRB configurations I didn't observe any issues arising from the prop= osed change aligning with the TCG CRB protocol definition.

 

I verified the BIOS flows were unaffected and completed= without errors and that the OS was still able to interact with the TPM.

 

Regards,

-Rodrigo

From: Yao, Jiewen <jiewen.yao@intel.com>
Sent: Sunday, August 8, 2021 6:27 PM
To: Gonzalez Del Cueto, Rodrigo <rodrigo.gonzalez.del.cueto@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Wang, Jian J <jian.j= .wang@intel.com>
Subject: RE: [PATCH] SecurityPkg: TPM must go to Idle state on CRB c= ommand completion.

 

Would you please tell= us how many TPM2 chip you have tested?

I think we need consider the compatibility of exiting TPM2 chips, to make s= ure the code still work.


Thank you
Yao Jiewen

> -----Original Message-----
> From: Gonzalez Del Cueto, Rodrigo <rodrigo.gonzalez.del.cueto@intel.com>
> Sent: Saturday, July 17, 2021 5:18 AM
> To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo <rodrigo.gonzalez.del.cueto@intel.com>;
> Wang, Jian J <jian.j.wang@= intel.com>; Yao, Jiewen <= jiewen.yao@intel.com>
> Subject: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command=
> completion.
>
> To follow the TCG CRB protocol specification, on every CRB TPM command=
> completion the TPM should return to Idle state, regardless of the
> CRB Idle Bypass capability reported by the TPM device.
>
> See: TCG PC Client Device Driver Design Principles for TPM 2.0,
> Version 1.0, Rev 0.27
>
> Signed-off-by: Rodrigo Gonzalez del Cueto
> <rodrigo.go= nzalez.del.cueto@intel.com>
> Cc: Jian J Wang <jian.j.wa= ng@intel.com>
> Cc: Jiewen Yao <jiewen.yao@= intel.com>
> ---
>  SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 12 +----------= -
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> index f1f8091683..34e3874a5b 100644
> --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c
> @@ -310,7 +310,7 @@ PtpCrbTpmCommand (
>      // Command completed, but buffer is not = enough
>      //
>      Status =3D EFI_BUFFER_TOO_SMALL;
> -    goto GoReady_Exit;
> +    goto GoIdle_Exit;
>    }
>    *SizeOut =3D TpmOutSize;
>    //
> @@ -328,16 +328,6 @@ PtpCrbTpmCommand (
>      DEBUG ((EFI_D_VERBOSE, "\n"));=
>    );
>
> -GoReady_Exit:
> -  //
> -  // Goto Ready State if command is completed successfully and T= PM support
> IdleBypass
> -  // If not supported. flow down to GoIdle
> -  //
> -  if (GetCachedIdleByPass () =3D=3D 1) {
> -    MmioWrite32((UINTN)&CrbReg->CrbControlReque= st,
> PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY);
> -    return Status;
> -  }
> -
>    //
>    // Do not wait for state transition for TIMEOUT_C >    // This function will try to wait 2 TIMEOUT_C at the= beginning in next call.
> --
> 2.31.1.windows.1

--_000_PH0PR11MB488507CA32BAE65977D4D6948C8D9PH0PR11MB4885namp_--