Re: [edk2-devel] [PATCH 0/3] Move the SEV specific changes in ResetVector in separate file

["Yao, Jiewen" <jiewen.yao@intel.com>]

Thank you Brijesh. That is exactly what I want.

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Sorry, I obviously overlooked the SNP series.

If you don't mind, I would like to merge this at first as soon as possible, then we can build up more stuff on top it.

Thank you
Yao Jiewen





> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Brijesh
> Singh via groups.io
> Sent: Tuesday, July 27, 2021 7:17 PM
> To: devel@edk2.groups.io
> Cc: Brijesh Singh <brijesh.singh@amd.com>; James Bottomley
> <jejb@linux.ibm.com>; Xu, Min M <min.m.xu@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Tom Lendacky <thomas.lendacky@amd.com>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Laszlo Ersek <lersek@redhat.com>; Erdem Aktas
> <erdemaktas@google.com>
> Subject: [edk2-devel] [PATCH 0/3] Move the SEV specific changes in ResetVector
> in separate file
> 
> The PageTable64.asm was created to build the initial page table,
> but over the time it grew to include bunch of the SEV specific code
> which does not directly manipulates the pagetable. Before adding more
> to it, let's move all the SEV-specific routines into a separate file.
> 
> The series is taken from SNP RFCv4. And there is no functionality change
> intended. Its just moving the code from one place to another.
> 
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> 
> The full branch is available at:
> https://github.com/AMDESE/ovmf/pull/new/refactor-reset-vector
> 
> Brijesh Singh (3):
>   OvmfPkg/ResetVector: move SEV specific code in a separate file
>   OvmfPkg/ResetVector: add the macro to invoke MSR protocol based
>     VMGEXIT
>   OvmfPkg/ResetVector: add the macro to request guest termination
> 
>  .../Ia32/{PageTables64.asm => AmdSev.asm}     | 292 ++++---------
>  OvmfPkg/ResetVector/Ia32/PageTables64.asm     | 391 ------------------
>  OvmfPkg/ResetVector/ResetVector.nasmb         |   1 +
>  3 files changed, 90 insertions(+), 594 deletions(-)
>  copy OvmfPkg/ResetVector/Ia32/{PageTables64.asm => AmdSev.asm} (67%)
> 
> --
> 2.17.1
> 
> 
> 
> 
>