public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0
Date: Fri, 27 Aug 2021 10:35:29 +0000	[thread overview]
Message-ID: <PH0PR11MB48851EF82F2EF7C320BC71E28CC89@PH0PR11MB4885.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210819072517.1565797-1-kraxel@redhat.com>

Hi Gerd
I create a PR but it fails. I am not able to merge.

https://github.com/tianocore/edk2/pull/1917

Would you please take a look, fix it and resubmit V5?


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> Hoffmann
> Sent: Thursday, August 19, 2021 3:25 PM
> To: devel@edk2.groups.io
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Subject: [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0
> 
> This little series adds virtio 1.0 support for the virtio-mmio
> transport.  For the mmio transport the difference between 0.9.5 and 1.0
> is rather small (when compared to the pci transport), it is just a bunch
> of new registers for the changed virtio queue initialization.  So the
> patch series is small too ...
> 
> v2 changes:
>  - Added review tags for patches #1 + #2.
>  - Add a patch to make sure we have a valid QueueNum.
>  - Add a patch to support all 64 virtio 1.0 feature bits.
> v3 changes:
>  - Add #defines for virtio-mmio version field.
> v4 changes:
>  - split patches into smaller ones.
>  - enable virtio 1.0 at the end when everything is in place.
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (7):
>   OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
>   OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize.
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum
>   OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling
>   OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0
> 
>  OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 ++++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  5 ++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++--
>  .../VirtioMmioDeviceFunctions.c               | 71 ++++++++++++++++---
>  4 files changed, 92 insertions(+), 13 deletions(-)
> 
> --
> 2.31.1
> 
> 
> 
> 
> 


  parent reply	other threads:[~2021-08-27 10:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19  7:25 [PATCH v4 0/7] add support for virtio-mmio 1.0 Gerd Hoffmann
2021-08-19  7:25 ` [PATCH v4 1/7] OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines Gerd Hoffmann
2021-08-19  7:25 ` [PATCH v4 2/7] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 detection Gerd Hoffmann
2021-08-19  7:25 ` [PATCH v4 3/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetPageSize Gerd Hoffmann
2021-08-19  7:25 ` [PATCH v4 4/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAddress Gerd Hoffmann
2021-08-19  7:25 ` [PATCH v4 5/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Add default QueueNum Gerd Hoffmann
2021-08-19  7:25 ` [PATCH v4 6/7] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Adapt feature bit handling Gerd Hoffmann
2021-08-19  7:25 ` [PATCH v4 7/7] OvmfPkg/VirtioMmioDeviceLib: enable virtio 1.0 Gerd Hoffmann
2021-08-19  9:26 ` [edk2-devel] [PATCH v4 0/7] add support for virtio-mmio 1.0 Philippe Mathieu-Daudé
2021-08-20  7:20   ` Yao, Jiewen
2021-08-27 10:35 ` Yao, Jiewen [this message]
     [not found] ` <169F236B4CC08BB7.32747@groups.io>
2021-08-27 11:35   ` Yao, Jiewen
2021-08-27 13:42     ` Gerd Hoffmann
2021-08-27 13:45       ` Yao, Jiewen
2021-08-27 13:46       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB48851EF82F2EF7C320BC71E28CC89@PH0PR11MB4885.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox